Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215803/?format=api
{ "id": 2215803, "url": "http://patchwork.ozlabs.org/api/patches/2215803/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/acPAP4Ct-7zm7iTw@tucnak/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<acPAP4Ct-7zm7iTw@tucnak>", "list_archive_url": null, "date": "2026-03-25T11:00:15", "name": "c++: Fix up reflect_constant_{array, string}2.C for installed testing [PR124621]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6ad9d5d7ab96f26791ecd095d660e99899ec67b7", "submitter": { "id": 671, "url": "http://patchwork.ozlabs.org/api/people/671/?format=api", "name": "Jakub Jelinek", "email": "jakub@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/acPAP4Ct-7zm7iTw@tucnak/mbox/", "series": [ { "id": 497419, "url": "http://patchwork.ozlabs.org/api/series/497419/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=497419", "date": "2026-03-25T11:00:15", "name": "c++: Fix up reflect_constant_{array, string}2.C for installed testing [PR124621]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497419/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215803/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215803/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EhNn0Sgy;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EhNn0Sgy", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgkVS4gGmz1y1K\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 22:01:19 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 718B24BB593D\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 11:01:17 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 3D7BE4BB3BFC\n for <gcc-patches@gcc.gnu.org>; Wed, 25 Mar 2026 11:00:23 +0000 (GMT)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-pEuQi_XZN3CqPTQ4yqOTxw-1; Wed,\n 25 Mar 2026 07:00:21 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 6A4E41800359\n for <gcc-patches@gcc.gnu.org>; Wed, 25 Mar 2026 11:00:20 +0000 (UTC)", "from tucnak.zalov.cz (unknown [10.45.225.193])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id B2F99180035F; Wed, 25 Mar 2026 11:00:19 +0000 (UTC)", "from tucnak.zalov.cz (localhost [127.0.0.1])\n by tucnak.zalov.cz (8.18.1/8.18.1) with ESMTPS id 62PB0Fpj3774518\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);\n Wed, 25 Mar 2026 12:00:16 +0100", "(from jakub@localhost)\n by tucnak.zalov.cz (8.18.1/8.18.1/Submit) id 62PB0Fp33774517;\n Wed, 25 Mar 2026 12:00:15 +0100" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 718B24BB593D", "OpenDKIM Filter v2.11.0 sourceware.org 3D7BE4BB3BFC" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 3D7BE4BB3BFC", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 3D7BE4BB3BFC", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774436423; cv=none;\n b=Vw20tCDpA3fCJAPwLbbkRFHwXTSRz12k6r3orZCjJzXgO1HTbhLeqPPQaIZAs3zfTxQJOkfKDP+syfSI9Jl8orA/twVRrmZqbWx2Ourkxqbqrb/zPwpeP1e4JOPbV95MwZJw9ndp9wEvKyY3AoA7vhVZMicf63+04nYlH/xLQcI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774436423; c=relaxed/simple;\n bh=FI4cIBPiiyWUyPD0BOeszhZukkadh2vOLNWoDqqY+EM=;\n h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version;\n b=Xsx5a5JbuzCQcfwf/SL+sKegW5Ben1LN9HWxEu6OPvtpvvvyPmMdVG2zmpGZ+nLu4KWzo53uiU0YY1zCpdTlH6Vx0BBrLrFLQ1bbcDKTDfJWyTgEvWrfH+e1NinlqaqxL6xqSkiMGoKBN8G0HJmSm9fytb1asMxUfOUld9yE77M=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774436422;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=aABFnAGnN9Nc17z+omgNWcw3Zriyt+VaJh5Tjm7DknQ=;\n b=EhNn0SgynGb7BodDewh6moNQ+eci1mPx3ngyYCvM7/U9Kio8s/vVb9xhkPCkt4f2EJEpG2\n Gm6Cp8osgt5dtb6lkVYxAMAn8euWZrokZaIt0b+EBvPcWN0FO6XqdUI1uLTgrAcej4FZuE\n mqHBp1xTo1Pep5NB7OqPYgaX9yTdHNw=", "X-MC-Unique": "pEuQi_XZN3CqPTQ4yqOTxw-1", "X-Mimecast-MFC-AGG-ID": "pEuQi_XZN3CqPTQ4yqOTxw_1774436420", "Date": "Wed, 25 Mar 2026 12:00:15 +0100", "From": "Jakub Jelinek <jakub@redhat.com>", "To": "Jason Merrill <jason@redhat.com>, Marek Polacek <polacek@redhat.com>", "Cc": "gcc-patches@gcc.gnu.org", "Subject": "[PATCH] c++: Fix up reflect_constant_{array, string}2.C for installed\n testing [PR124621]", "Message-ID": "<acPAP4Ct-7zm7iTw@tucnak>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "yG_k1Uz_pAuaEQmWDMBxs2HVpC6VHok6SHgz0TIhU9c_1774436420", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "Jakub Jelinek <jakub@redhat.com>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Hi!\n\nThese two tests behave differently when using in-tree testing vs.\nout-of-tree testing.\nIn the former case, libstdc++-v3/scripts/testsuite_flags uses\n-nostdinc++ -I.../libstdc++-v3/include/x86_64-pc-linux-gnu etc.,\nso the libstdc++ headers aren't considered system headers, while\nwith out-of-tree testing they are.\nAnd the aka printing uses user_facing_original_type_p which depends on\n /* Look through any typedef in \"user\" code. */\n if (!DECL_IN_SYSTEM_HEADER (decl) && !DECL_IS_UNDECLARED_BUILTIN (decl))\n return true;\nand so behaves differently (and arguably in this case the non-system headers\noutput is nicer).\n\nAnyway, the following patch adjusts the tests so that they accept both\nforms.\n\nTested on x86_64-linux in-tree and Torbjorn has tested it in arm-none-eabi\nout-of-tree testing. Ok for trunk?\n\n2026-03-25 Jakub Jelinek <jakub@redhat.com>\n\n\tPR testsuite/124621\n\t* g++.dg/reflect/reflect_constant_array2.C: Allow different aka\n\targument in diagnostics for in-tree vs. out-of-tree testing.\n\t* g++.dg/reflect/reflect_constant_string2.C: Likewise.\n\n\n\tJakub", "diff": "--- gcc/testsuite/g++.dg/reflect/reflect_constant_array2.C.jj\t2026-01-15 16:33:47.014097840 +0100\n+++ gcc/testsuite/g++.dg/reflect/reflect_constant_array2.C\t2026-03-25 11:27:34.568796335 +0100\n@@ -10,8 +10,8 @@ using namespace std::meta;\n \n struct A { int a, b; mutable int c; };\n constexpr auto a = reflect_constant_array (std::vector <A> { A { 1, 2, 3 } });\n-// { dg-error \"'reflect_constant_array' argument with 'std::ranges::range_value_t<std::vector<A> >' \\\\\\{aka 'A'\\\\\\} which is not a structural type\" \"\" { target *-*-* } .-1 }\n+// { dg-error \"'reflect_constant_array' argument with 'std::ranges::range_value_t<std::vector<A> >' \\\\\\{aka '(A|std::iter_value_t<__gnu_cxx::__normal_iterator<A\\\\\\*, std::vector<A> > >)'\\\\\\} which is not a structural type\" \"\" { target *-*-* } .-1 }\n struct B { constexpr B (int x, int y) : a (x), b (y) {} constexpr ~B () {} B (const B &) = delete; int a, b; };\n constexpr B b[2] = { { 1, 2 }, { 2, 3 } };\n constexpr auto c = reflect_constant_array (b);\n-// { dg-error \"'reflect_constant_array' argument with 'std::ranges::range_value_t<const B \\\\\\[2\\\\\\]>' \\\\\\{aka 'B'\\\\\\} which is not copy constructible\" \"\" { target *-*-* } .-1 }\n+// { dg-error \"'reflect_constant_array' argument with 'std::ranges::range_value_t<const B \\\\\\[2\\\\\\]>' \\\\\\{aka '(B|std::iter_value_t<const B\\\\\\*>)'\\\\\\} which is not copy constructible\" \"\" { target *-*-* } .-1 }\n--- gcc/testsuite/g++.dg/reflect/reflect_constant_string2.C.jj\t2026-01-15 16:33:47.015097823 +0100\n+++ gcc/testsuite/g++.dg/reflect/reflect_constant_string2.C\t2026-03-25 11:28:21.181009946 +0100\n@@ -11,4 +11,4 @@ using namespace std::meta;\n struct V { int a, b, c; };\n constexpr auto a = reflect_constant_string (std::vector <int> { 42, 43, 44 });\t// { dg-error \"'reflect_constant_string' called with 'std::ranges::range_value_t<std::vector<int> >' \\\\\\{aka 'int'\\\\\\} rather than 'char', 'wchar_t', 'char8_t', 'char16_t' or 'char32_t'\" }\n constexpr auto b = reflect_constant_string (std::vector <float> {});\t\t// { dg-error \"'reflect_constant_string' called with 'std::ranges::range_value_t<std::vector<float> >' \\\\\\{aka 'float'\\\\\\} rather than 'char', 'wchar_t', 'char8_t', 'char16_t' or 'char32_t'\" }\n-constexpr auto c = reflect_constant_string (std::vector <V> { V { 1, 2, 3 } });\t// { dg-error \"'reflect_constant_string' called with 'std::ranges::range_value_t<std::vector<V> >' \\\\\\{aka 'V'\\\\\\} rather than 'char', 'wchar_t', 'char8_t', 'char16_t' or 'char32_t'\" }\n+constexpr auto c = reflect_constant_string (std::vector <V> { V { 1, 2, 3 } });\t// { dg-error \"'reflect_constant_string' called with 'std::ranges::range_value_t<std::vector<V> >' \\\\\\{aka '(V|std::iter_value_t<__gnu_cxx::__normal_iterator<V\\\\\\*, std::vector<V> > >)'\\\\\\} rather than 'char', 'wchar_t', 'char8_t', 'char16_t' or 'char32_t'\" }\n", "prefixes": [] }