Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215771/?format=api
{ "id": 2215771, "url": "http://patchwork.ozlabs.org/api/patches/2215771/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260325101437.3059693-14-sheetal@nvidia.com/", "project": { "id": 21, "url": "http://patchwork.ozlabs.org/api/projects/21/?format=api", "name": "Linux Tegra Development", "link_name": "linux-tegra", "list_id": "linux-tegra.vger.kernel.org", "list_email": "linux-tegra@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325101437.3059693-14-sheetal@nvidia.com>", "list_archive_url": null, "date": "2026-03-25T10:14:36", "name": "[v3,13/14] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "769096e796476a0809798572bb58f69c0bb7ef2f", "submitter": { "id": 87986, "url": "http://patchwork.ozlabs.org/api/people/87986/?format=api", "name": "Sheetal", "email": "sheetal@nvidia.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260325101437.3059693-14-sheetal@nvidia.com/mbox/", "series": [ { "id": 497410, "url": "http://patchwork.ozlabs.org/api/series/497410/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/list/?series=497410", "date": "2026-03-25T10:14:23", "name": "ASoC: tegra: Add error logging for probe and callback failures", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/497410/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215771/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215771/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-tegra+bounces-13194-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-tegra@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=VHTTQCUh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13194-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"VHTTQCUh\"", "smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.56.14", "smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com", "smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgjXs6Fm1z1y1K\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 21:18:21 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id E0D1330607F3\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 10:15:54 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8E52A3A16A9;\n\tWed, 25 Mar 2026 10:15:54 +0000 (UTC)", "from BN1PR04CU002.outbound.protection.outlook.com\n (mail-eastus2azon11010014.outbound.protection.outlook.com [52.101.56.14])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C0B0E3AE717;\n\tWed, 25 Mar 2026 10:15:50 +0000 (UTC)", "from MN2PR06CA0003.namprd06.prod.outlook.com (2603:10b6:208:23d::8)\n by DM6PR12MB4058.namprd12.prod.outlook.com (2603:10b6:5:21d::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Wed, 25 Mar\n 2026 10:15:44 +0000", "from BL02EPF00021F6E.namprd02.prod.outlook.com\n (2603:10b6:208:23d:cafe::fd) by MN2PR06CA0003.outlook.office365.com\n (2603:10b6:208:23d::8) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.32 via Frontend Transport; Wed,\n 25 Mar 2026 10:15:17 +0000", "from mail.nvidia.com (216.228.118.233) by\n BL02EPF00021F6E.mail.protection.outlook.com (10.167.249.10) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9745.21 via Frontend Transport; Wed, 25 Mar 2026 10:15:44 +0000", "from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com\n (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 25 Mar\n 2026 03:15:27 -0700", "from drhqmail202.nvidia.com (10.126.190.181) by\n drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.20; Wed, 25 Mar 2026 03:15:27 -0700", "from build-sheetal-bionic-20251202.nvidia.com (10.127.8.14) by\n mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.2562.20\n via Frontend Transport; Wed, 25 Mar 2026 03:15:26 -0700" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774433754; cv=fail;\n b=sLBaUW5K8+QgyckhvFRiaEt1crA/3Pjo5zGzyow0dHuJGUcIwW31ovURDtyxEGumVthO0pxHM0m1Yk9jGYSJLLEg0v/DPdrDx5hDSNNhspoN9xzPRRlp3ylcQ9l8HsCR2mzGUKGXoQaW9tdiGaTshZ9/ZRjzENtZPzjHZ6QKclE=", "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=To8D5hktvytPtQdK9tNxb+raqRXZuZf2k8fcZX/35yj2r8fZ4g4LYe3i1iBxEG8norE4ophZDhnRm7ABIV4lAlFkdFrEEdnaX/6Z/GBEtOHzlCu026YuOrLHACo7IxuYRIOgezHPF4pI3THJ4fKoptxMJylRxiOliLb4kXPp5A2vNOKqFvd/YdRn0TZXxRaKRioxa2A2Lj+zpVe+gUAPDwSz1Kmy6zMbiTPxzWjZKbkpnVY0wDtSgMoiVFbmGrQs6Xq+xwWkx0EHKBeUFt8x8wgrI0QEFjuxeq5AN941JpchfSDjkh7+NzexCiw+XTJmkhbPImxZfKlrYNBXTiuXLg==" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774433754; c=relaxed/simple;\n\tbh=3Dnfxik7z4WjPVYqyn3d4hLbRKINIpPjrrjQo5hq9Ds=;\n\th=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=rkpmahJlOijw34pS5RaEg2HdRf2mHF7Fo8tEIXp1QrpRPb5aWxyahkg+lxdNB34zOZ/D9s35JQLZzEXIl76cZWJcRvl6/+o0AjxWV9WvHUWpNXsFLGOvH+LP2CPR0DRuzcxOUH/URDCUM9iDK5j28YJbpcQRHpIFu8b7iipf95o=", "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=dP/mJYA8La5dazSOB0xQ5PYp3mW8PWoOK38ah01BkTI=;\n b=xCWE0RO6wItJPvsrEOy6TnTZIx+xRLN96yUNesvYShnx02s6mSBwFzfZ76gf3HiXyaF014bfB6mxZW0tGtHO3mUgwnh8FrWfVlgXui4KMkeINzCjYq821D46Qm3I9nJhSaUPcKQfBUqrxayl8HIdCB/OVRaWrKe5daYqEPevntUtNaaXRHuC8heyiQQDM6c9FX/640BxlvEWmeENj7dXQxQI9wIe5/hrawGdwqEthnJOs8KhfZ66kDjfiQfQSsTXyzNOCoK23VNSsGu3waRyNhvahyUxnMbHgUr0hrSMrcB8/AghWtwht/F4O9Zp2NkYhdq+177qeeRZqK4ZKXS9vA==" ], "ARC-Authentication-Results": [ "i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=VHTTQCUh; arc=fail smtp.client-ip=52.101.56.14", "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.118.233) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=dP/mJYA8La5dazSOB0xQ5PYp3mW8PWoOK38ah01BkTI=;\n b=VHTTQCUhoKXMJjto5r1EFJtlCcJV6BiLzrlwtUbuLnvTKw0v7tZfbecSE+dO1xBS7mryQjjtcGQseQNHhzq1Yze9hRxPuLYH6ja2B2IWVMqOaYg1kjTHM5gF/1KyN0pG1ajlaWdVZ8yizLlxN0K+4hlJxyomSfkP+WvcT22rsHsl6DgmYptrFwayqL9WdTkVNG4zkED2addPfTsm/FCLagCTBwqB2BQt1dExdRIHbUoQwQpw/6ZLXO9PNJ5J9HW19D4zdGL3o1cMDAAS67ke8KvksVAujUePWtpI9UnO4PdhwWE/J0OHgdPM1AF/RYYZWli4dLlCMPVkdX0PH35WWA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.118.233)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.118.233 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C", "From": "Sheetal <sheetal@nvidia.com>", "To": "Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,\n\tThierry Reding <thierry.reding@kernel.org>, Jonathan Hunter\n\t<jonathanh@nvidia.com>", "CC": "Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, \"Mohan\n Kumar\" <mkumard@nvidia.com>, Kuninori Morimoto\n\t<kuninori.morimoto.gx@renesas.com>, <linux-sound@vger.kernel.org>,\n\t<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Sheetal\n\t<sheetal@nvidia.com>", "Subject": "[PATCH v3 13/14] ASoC: tegra: Use dev_err_probe() in\n tegra_asoc_machine probe", "Date": "Wed, 25 Mar 2026 10:14:36 +0000", "Message-ID": "<20260325101437.3059693-14-sheetal@nvidia.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20260325101437.3059693-1-sheetal@nvidia.com>", "References": "<20260325101437.3059693-1-sheetal@nvidia.com>", "Precedence": "bulk", "X-Mailing-List": "linux-tegra@vger.kernel.org", "List-Id": "<linux-tegra.vger.kernel.org>", "List-Subscribe": "<mailto:linux-tegra+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-tegra+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL02EPF00021F6E:EE_|DM6PR12MB4058:EE_", "X-MS-Office365-Filtering-Correlation-Id": "40ae3a8c-0d30-449d-6b4c-08de8a577a0b", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "\n\tBCL:0;ARA:13230040|1800799024|82310400026|36860700016|376014|56012099003|22082099003|18002099003;", "X-Microsoft-Antispam-Message-Info": "\n\tvqgHPKiO3WSj+tRHUFC3HkMesvYkKbQTciLz/9vqZhqBjcetW+jOZfKJ53me4aiGqEbfga73wBthBHvWv/K4gx2lSsFGCYYf+gz7IIxW+0OPcqWeorjHDzFM9a/bCw/R2zxYsSJWA487qieb4JYA7XKzvXICUYubSKIsEYP1MTUPjBYb3UFt2ATNkFz19Xs+R86C0IsdO29UOGxeOqUEjoghA54ArGrO2xhlSP7qOXCli5CZx1PUHSvKi0mwpeh/OCOXw7Zc6nflw92Nkdz1SBkm0hKRNnPornO1CkrtUQMHH7faKgUqYebHKWH4IEbi9FspiPJv7j/YqyGmeMh4OS6leM1bpdPHCnoLAaKliX/CzX5gE6hnqchxv4UDFLrrErKzbUk4yn3uMiMfTGvtPIql7R0gFLWXjEAl71YMXOSTfozZ8OBD5MjZWUeqqlS+eNCyqkQsmfD4r1LggttHfFTcfkrFcHFiKL7u3ODC30dWDOiT0IAwgpmM2QTXoXjZHBf+kEfkDOZzzO175wXqiUsXcR5fLj3gB5DUMKeCMYWb06ufF7EXLLgf4XU+rte7S77p4pk11t94itM7dWgNPA8u+dYNWK1tnbrQe7MURXu7Id7ySMlrqYTvoecVX1k88BkloRhWqY1TT0Y3Vprv7S5tz/SzNvE5i1LGEdjoL5NmjrnFibTpcheoan5zFTczsP+Mkp9YvIghITl6ugOPB15lhqaf5kcOuJAtRyGZk16kkoDp0nSNk13wK8OFspQBmLEMQHi7SxIFT1t3xub3Ow==", "X-Forefront-Antispam-Report": "\n\tCIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700016)(376014)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n\td4C66G+eXRSaCfKI5zcKPod0eUqKkCPqU7AKSaPpf75UIPnogxwfuhLOTE1Y9SUbg14wmwU8bkCvGtGEquCEUD2GtpPf+QSjuq6wJjeR+EBKU/7Dtk5mtKnsPlto61bt6f3ro6tU5kAP9bTa1yz4LDbaTt4xokrqE1IMHSG70ROa/Rd98yYmLFszLE2IlVOP5CfB8bRb2pSTf+/wztnbEhKxpEia4V7ZSTT42VA6HvUL0Ki7KeFuaCtpxxUiookhaCOSALjqDxbNITvXtGTPGE4ozJSo1qxhnvK6ZqbNEjI00VcvlOydq4M2Itb+Xtn245afwL+vZYxNUjHoPHNN8hmeXXrwI/pnrUBYSZ0xLRIGSHCMaeKmkwdvThiYtIiF7c7faZJkSodlCP7zAwkYkXgqUxT/6Mqv13gS/GGvOkdh3gpYJICeawqvAYnS2wkA", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "25 Mar 2026 10:15:44.5605\n (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 40ae3a8c-0d30-449d-6b4c-08de8a577a0b", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n\tBL02EPF00021F6E.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4058" }, "content": "Log errors in the Tegra ASoC machine driver probe path using\ndev_err_probe().\n\nSigned-off-by: Sheetal <sheetal@nvidia.com>\n---\n sound/soc/tegra/tegra_asoc_machine.c | 70 +++++++++++++++++-----------------\n 1 file changed, 35 insertions(+), 35 deletions(-)", "diff": "diff --git a/sound/soc/tegra/tegra_asoc_machine.c b/sound/soc/tegra/tegra_asoc_machine.c\nindex 10834f9c3422..d7245a10bba1 100644\n--- a/sound/soc/tegra/tegra_asoc_machine.c\n+++ b/sound/soc/tegra/tegra_asoc_machine.c\n@@ -431,8 +431,9 @@ static int tegra_machine_register_codec(struct device *dev, const char *name)\n \t\treturn 0;\n \n \tpdev = platform_device_register_simple(name, -1, NULL, 0);\n \tif (IS_ERR(pdev))\n-\t\treturn PTR_ERR(pdev);\n+\t\treturn dev_err_probe(dev, PTR_ERR(pdev),\n+\t\t\t\t \"failed to register codec %s\\n\", name);\n \n \terr = devm_add_action_or_reset(dev, tegra_machine_unregister_codec,\n \t\t\t\t pdev);\n@@ -468,32 +469,38 @@ int tegra_asoc_machine_probe(struct platform_device *pdev)\n \tgpiod = devm_gpiod_get_optional(dev, \"nvidia,hp-mute\", GPIOD_OUT_HIGH);\n \tmachine->gpiod_hp_mute = gpiod;\n \tif (IS_ERR(gpiod))\n-\t\treturn PTR_ERR(gpiod);\n+\t\treturn dev_err_probe(dev, PTR_ERR(gpiod),\n+\t\t\t\t \"failed to get hp-mute GPIO\\n\");\n \n \tgpiod = devm_gpiod_get_optional(dev, \"nvidia,hp-det\", GPIOD_IN);\n \tmachine->gpiod_hp_det = gpiod;\n \tif (IS_ERR(gpiod))\n-\t\treturn PTR_ERR(gpiod);\n+\t\treturn dev_err_probe(dev, PTR_ERR(gpiod),\n+\t\t\t\t \"failed to get hp-det GPIO\\n\");\n \n \tgpiod = devm_gpiod_get_optional(dev, \"nvidia,mic-det\", GPIOD_IN);\n \tmachine->gpiod_mic_det = gpiod;\n \tif (IS_ERR(gpiod))\n-\t\treturn PTR_ERR(gpiod);\n+\t\treturn dev_err_probe(dev, PTR_ERR(gpiod),\n+\t\t\t\t \"failed to get mic-det GPIO\\n\");\n \n \tgpiod = devm_gpiod_get_optional(dev, \"nvidia,spkr-en\", GPIOD_OUT_LOW);\n \tmachine->gpiod_spkr_en = gpiod;\n \tif (IS_ERR(gpiod))\n-\t\treturn PTR_ERR(gpiod);\n+\t\treturn dev_err_probe(dev, PTR_ERR(gpiod),\n+\t\t\t\t \"failed to get spkr-en GPIO\\n\");\n \n \tgpiod = devm_gpiod_get_optional(dev, \"nvidia,int-mic-en\", GPIOD_OUT_LOW);\n \tmachine->gpiod_int_mic_en = gpiod;\n \tif (IS_ERR(gpiod))\n-\t\treturn PTR_ERR(gpiod);\n+\t\treturn dev_err_probe(dev, PTR_ERR(gpiod),\n+\t\t\t\t \"failed to get int-mic-en GPIO\\n\");\n \n \tgpiod = devm_gpiod_get_optional(dev, \"nvidia,ext-mic-en\", GPIOD_OUT_LOW);\n \tmachine->gpiod_ext_mic_en = gpiod;\n \tif (IS_ERR(gpiod))\n-\t\treturn PTR_ERR(gpiod);\n+\t\treturn dev_err_probe(dev, PTR_ERR(gpiod),\n+\t\t\t\t \"failed to get ext-mic-en GPIO\\n\");\n \n \terr = snd_soc_of_parse_card_name(card, \"nvidia,model\");\n \tif (err)\n@@ -549,22 +556,19 @@ int tegra_asoc_machine_probe(struct platform_device *pdev)\n \t\tcard->driver_name = \"tegra\";\n \n \tmachine->clk_pll_a = devm_clk_get(dev, \"pll_a\");\n-\tif (IS_ERR(machine->clk_pll_a)) {\n-\t\tdev_err(dev, \"Can't retrieve clk pll_a\\n\");\n-\t\treturn PTR_ERR(machine->clk_pll_a);\n-\t}\n+\tif (IS_ERR(machine->clk_pll_a))\n+\t\treturn dev_err_probe(dev, PTR_ERR(machine->clk_pll_a),\n+\t\t\t\t \"can't retrieve clk pll_a\\n\");\n \n \tmachine->clk_pll_a_out0 = devm_clk_get(dev, \"pll_a_out0\");\n-\tif (IS_ERR(machine->clk_pll_a_out0)) {\n-\t\tdev_err(dev, \"Can't retrieve clk pll_a_out0\\n\");\n-\t\treturn PTR_ERR(machine->clk_pll_a_out0);\n-\t}\n+\tif (IS_ERR(machine->clk_pll_a_out0))\n+\t\treturn dev_err_probe(dev, PTR_ERR(machine->clk_pll_a_out0),\n+\t\t\t\t \"can't retrieve clk pll_a_out0\\n\");\n \n \tmachine->clk_cdev1 = devm_clk_get(dev, \"mclk\");\n-\tif (IS_ERR(machine->clk_cdev1)) {\n-\t\tdev_err(dev, \"Can't retrieve clk cdev1\\n\");\n-\t\treturn PTR_ERR(machine->clk_cdev1);\n-\t}\n+\tif (IS_ERR(machine->clk_cdev1))\n+\t\treturn dev_err_probe(dev, PTR_ERR(machine->clk_cdev1),\n+\t\t\t\t \"can't retrieve clk cdev1\\n\");\n \n \t/*\n \t * If clock parents are not set in DT, configure here to use clk_out_1\n@@ -578,26 +582,22 @@ int tegra_asoc_machine_probe(struct platform_device *pdev)\n \t\tdev_warn(dev, \"Please update DT to use assigned-clock-parents\\n\");\n \n \t\tclk_extern1 = devm_clk_get(dev, \"extern1\");\n-\t\tif (IS_ERR(clk_extern1)) {\n-\t\t\tdev_err(dev, \"Can't retrieve clk extern1\\n\");\n-\t\t\treturn PTR_ERR(clk_extern1);\n-\t\t}\n+\t\tif (IS_ERR(clk_extern1))\n+\t\t\treturn dev_err_probe(dev, PTR_ERR(clk_extern1),\n+\t\t\t\t\t \"can't retrieve clk extern1\\n\");\n \n \t\terr = clk_set_parent(clk_extern1, machine->clk_pll_a_out0);\n-\t\tif (err < 0) {\n-\t\t\tdev_err(dev, \"Set parent failed for clk extern1\\n\");\n-\t\t\treturn err;\n-\t\t}\n+\t\tif (err < 0)\n+\t\t\treturn dev_err_probe(dev, err,\n+\t\t\t\t\t \"set parent failed for clk extern1\\n\");\n \n \t\tclk_out_1 = devm_clk_get(dev, \"pmc_clk_out_1\");\n-\t\tif (IS_ERR(clk_out_1)) {\n-\t\t\tdev_err(dev, \"Can't retrieve pmc_clk_out_1\\n\");\n-\t\t\treturn PTR_ERR(clk_out_1);\n-\t\t}\n+\t\tif (IS_ERR(clk_out_1))\n+\t\t\treturn dev_err_probe(dev, PTR_ERR(clk_out_1),\n+\t\t\t\t\t \"can't retrieve pmc_clk_out_1\\n\");\n \n \t\terr = clk_set_parent(clk_out_1, clk_extern1);\n-\t\tif (err < 0) {\n-\t\t\tdev_err(dev, \"Set parent failed for pmc_clk_out_1\\n\");\n-\t\t\treturn err;\n-\t\t}\n+\t\tif (err < 0)\n+\t\t\treturn dev_err_probe(dev, err,\n+\t\t\t\t\t \"set parent failed for pmc_clk_out_1\\n\");\n \n", "prefixes": [ "v3", "13/14" ] }