Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215633/?format=api
{ "id": 2215633, "url": "http://patchwork.ozlabs.org/api/patches/2215633/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20260324-aspeed-v1-1-354181624c00@gmail.com/", "project": { "id": 57, "url": "http://patchwork.ozlabs.org/api/projects/57/?format=api", "name": "Linux ASPEED SoC development", "link_name": "linux-aspeed", "list_id": "linux-aspeed.lists.ozlabs.org", "list_email": "linux-aspeed@lists.ozlabs.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260324-aspeed-v1-1-354181624c00@gmail.com>", "list_archive_url": null, "date": "2026-03-23T17:57:59", "name": "PCI: aspeed: Fix IRQ domain leak on platform_get_irq() failure", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "552689f0dd614678e3bc87bff592f078bf104f90", "submitter": { "id": 92491, "url": "http://patchwork.ozlabs.org/api/people/92491/?format=api", "name": "Felix Gu", "email": "ustc.gu@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20260324-aspeed-v1-1-354181624c00@gmail.com/mbox/", "series": [ { "id": 497357, "url": "http://patchwork.ozlabs.org/api/series/497357/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/list/?series=497357", "date": "2026-03-23T17:57:59", "name": "PCI: aspeed: Fix IRQ domain leak on platform_get_irq() failure", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497357/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215633/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215633/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-aspeed+bounces-3759-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-aspeed@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ra4MmNX3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linux-aspeed+bounces-3759-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::62b\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ra4MmNX3;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::62b; helo=mail-pl1-x62b.google.com;\n envelope-from=ustc.gu@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgQJf6Lpgz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 09:51:46 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fgQJR3b15z2ynn;\n\tWed, 25 Mar 2026 09:51:35 +1100 (AEDT)", "from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com\n [IPv6:2607:f8b0:4864:20::62b])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4ffgrJ55hrz2xs4\n\tfor <linux-aspeed@lists.ozlabs.org>; Tue, 24 Mar 2026 04:58:07 +1100 (AEDT)", "by mail-pl1-x62b.google.com with SMTP id\n d9443c01a7336-2b056b7f783so23064935ad.1\n for <linux-aspeed@lists.ozlabs.org>;\n Mon, 23 Mar 2026 10:58:07 -0700 (PDT)", "from junjungu-PC.localdomain ([223.167.147.240])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b0835551c3sm113415065ad.35.2026.03.23.10.58.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 23 Mar 2026 10:58:04 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774288690;\n\tcv=none;\n b=SvILixPfLLRjvPjrko29rs+56KVd73+gi91JSjtOsGhej7DD7afLK720Kl+bgpMIxY51yKE9icIplHIKhAqebpP+TRtSZ8CtBoeujHLkXrr9OYcnHj5U/vavrynq8V0Cz/YHg1Amiq2i46L3tCBOc8ceQmzIpDx/Z15XT2FOuEoDDAGwu5A+ulYEEEmXjv1YfWwTW+JBl/u635s3Hoc+dAeJUl2sY8QFwrxx8hXM4Wji/VkPTKawd1R3LBmAvrdTRFVeFciJUpQ2fVxyA3nsJIIZEmMmfxRAGFe6kZugUPpZiHd6XQrwoFVXeU4AH2lJNNNHkBKudPsYrJaF+F1cpw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774288690; c=relaxed/relaxed;\n\tbh=DAFVmIYqCpTk7YHQuUKCiaGw6d7SaBhhkzvznBNGhns=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc;\n b=fSZImmjMLG7KmnDDqwGybXU+yzOfdVtKIxpSedq82d3tqTi144TTKJYkis/dmQx4+FJPd0c52nDtIzEr318tCMB6yUq8+hoI1x1oLwlXCrAWkh+fovGXeVjoUYGbWoIYVAa2q/EALTTQKxZzjZHdIEo210QMaM/z0AtldT3MCOMFWoDgEKY1UihM3LAtcY6Zq1wl9XxUtMsEq7EeGwczi6iObVFINpy9MDM9agk0aV5c2p36dApkok4AH9MSb6VneU90i9T3lHAC9xIqb7/dxNisyg/JZu9SpfaSWhce0WQtaEwxrGIOvt9uin61QqOD4lTAxfOriTzyfzgvGnHj3Q==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ra4MmNX3; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::62b; helo=mail-pl1-x62b.google.com;\n envelope-from=ustc.gu@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774288685; x=1774893485;\n darn=lists.ozlabs.org;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=DAFVmIYqCpTk7YHQuUKCiaGw6d7SaBhhkzvznBNGhns=;\n b=ra4MmNX3Y8dbdcacJXQ779O9dOosbNMRXjKO7iGqWbUOVS+8EGIK6Z+Z75lbOBmTHT\n bJD6IGq29PPlgKd7oJpFTPKNuo1w+yOXcpixi9//ZKXifkK+kGJQIbqmbbAyJWhaRlkm\n U48vxfVyvkpppoBKQWxWwXi3MU0OJr89yrieNZsYjgnxFaVGBkSE2Jm7U4wTF+7/c7nb\n aA5I8twP7C2k71xOnOeTb2OHy2wN8YN77gA5B9YbkhPtToj75mDopiGfy5NBbxfWJDLg\n RM9BJoxnFIyiMKuor9PNQCBEFWuZ/JfIuo3hX2Oop+TnB8HRPDw1WHUDZ1fQibdLOScS\n LZUg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774288685; x=1774893485;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=DAFVmIYqCpTk7YHQuUKCiaGw6d7SaBhhkzvznBNGhns=;\n b=R5a1yftftOU6D4UD/+YkvTEh5pcBnrjTxiZHBgvUdVOoCjuA+2Oqmv+lGnXzzZVwLB\n hHqhvgJbd1251kCyY6e77te0Ob7is6MUBT8PW5+6CYmZ6mw99ljMBEXLNOLenJ3Q+Ph2\n BAHzweG++WFs9pmsr+0krljd4ViW1hZWB5cDPtQb2LVfeWaJ+EMC0nHerYTA7f7e7yzQ\n Qz8OSaoGOlj3AyLWu2S6bnY58TJ6/pi62l6xzg5E3ALzUr22hs+2nf0LxfEqGttTWIA2\n KOIrvJfF+ccoI34gueevsPGCYdisB4Fff/PJYZ3sPSxxqm8DwKjBeO1LugPPpceS1Xj4\n 1JvQ==", "X-Gm-Message-State": "AOJu0Yzv7Ch6Dz1y0Zd7CpsQMJBOnctAs3a8cYa7rm7UR9Vnli3kManN\n\tC3178H7GL56iZ39Sdbam96A2cHfwU+N3a8c8vhD6AdhiK7Qlp3eOKRVt", "X-Gm-Gg": "ATEYQzxJ4YTwTBKE3XGr2SjomkUcKqn6kaFplHjxYpKWA35qLe3zgGO/J324SClXLLg\n\tAUw/seurX0PCkaekUReYR20/PBAtxNS4aqSzfopntI8KE5eXP8ZX30FEwXQwk8xzqJdZjj28q2u\n\t7EsgCEKIOj/yj8oDBi68ig3TsFghR2NLL8Jlmuy7ZtZ95Cw6Gd4kW775phAwJrsWMRqV++ycoxi\n\tYETuB86Zn+Qsg8DLVvhq9PRNQncG/jalY4GdDKLVfuT2FZlfYT+weQ+zfz2NcfuAzcJhQcRaMZX\n\tQO1zwqkdibS1ELSwfUSsWfJtJy52kHPPQT41sZbAnyyhlQylts1KUt8xvDeR4Ix0B7RF89ZpBY5\n\tAiPLbGGrpNveiqGDKotcso2yJIJURrWk4Hnijj/1i3d6BaDExGBCXngP9iZctOLCd1bDm2UEBMT\n\tTnvPj0rBXjyuhkH3vv7ps6jgxFE95RTXCr+uuI", "X-Received": "by 2002:a17:903:2acc:b0:2ae:7f85:33d1 with SMTP id\n d9443c01a7336-2b0a4cd49e4mr4562165ad.0.1774288684737;\n Mon, 23 Mar 2026 10:58:04 -0700 (PDT)", "From": "Felix Gu <ustc.gu@gmail.com>", "Date": "Tue, 24 Mar 2026 01:57:59 +0800", "Subject": "[PATCH] PCI: aspeed: Fix IRQ domain leak on platform_get_irq()\n failure", "X-Mailing-List": "linux-aspeed@lists.ozlabs.org", "List-Id": "<linux-aspeed.lists.ozlabs.org>", "List-Help": "<mailto:linux-aspeed+help@lists.ozlabs.org>", "List-Owner": "<mailto:linux-aspeed+owner@lists.ozlabs.org>", "List-Post": "<mailto:linux-aspeed@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linux-aspeed/>,\n <https://lists.ozlabs.org/pipermail/linux-aspeed/>", "List-Subscribe": "<mailto:linux-aspeed+subscribe@lists.ozlabs.org>,\n <mailto:linux-aspeed+subscribe-digest@lists.ozlabs.org>,\n <mailto:linux-aspeed+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linux-aspeed+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260324-aspeed-v1-1-354181624c00@gmail.com>", "X-B4-Tracking": "v=1; b=H4sIACZ/wWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE\n vPSU3UzU4B8JSMDIzMDYyMT3cTigtTUFN0kA1MTUxNLM8MUc1MloOKCotS0zAqwQdGxtbUAgHK\n gQ1gAAAA=", "X-Change-ID": "20260324-aspeed-b05454961d75", "To": "Jacky Chou <jacky_chou@aspeedtech.com>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy?=\n\t=?utf-8?q?=C5=84ski?= <kwilczynski@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>, Rob Herring <robh@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>, Joel Stanley <joel@jms.id.au>,\n Andrew Jeffery <andrew@codeconstruct.com.au>", "Cc": "linux-aspeed@lists.ozlabs.org, linux-pci@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n Felix Gu <ustc.gu@gmail.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1774288681; l=1574;\n i=ustc.gu@gmail.com; h=from:subject:message-id;\n bh=cYrcg8cZ1OOgmV+TAbZ97fcCPC0PWmH/iybgc6SDMxs=;\n b=l+RPKAQMkKB3prPtTq61GiYDOiTZZEVvZpdPRmil5aMf0ygzxdGhIKpTojXIdqk8Guifwxe3Y\n UOj7efLJOKnAPRYwxbJvxbBY6Iz1Z6VcYRmZbAzVLfAw5weD9l6RPeg", "X-Developer-Key": "i=ustc.gu@gmail.com; a=ed25519;\n pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw=", "X-Spam-Status": "No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "The aspeed_pcie_probe() function calls aspeed_pcie_init_irq_domain()\nwhich allocates pcie->intx_domain and initializes MSI. However, if\nplatform_get_irq() fails afterwards, the cleanup action was not yet\nregistered via devm_add_action_or_reset(), causing the IRQ domain\nresources to leak.\n\nFix this by registering the devm cleanup action immediately after\naspeed_pcie_init_irq_domain() succeeds, before calling\nplatform_get_irq(). This ensures proper cleanup on any subsequent\nfailure.\n\nFixes: 9aa0cb68fcc1 (\"PCI: aspeed: Add ASPEED PCIe RC driver\")\nSigned-off-by: Felix Gu <ustc.gu@gmail.com>\n---\n drivers/pci/controller/pcie-aspeed.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\n\n---\nbase-commit: 785f0eb2f85decbe7c1ef9ae922931f0194ffc2e\nchange-id: 20260324-aspeed-b05454961d75\n\nBest regards,", "diff": "diff --git a/drivers/pci/controller/pcie-aspeed.c b/drivers/pci/controller/pcie-aspeed.c\nindex 3e1a39d1e648..6acfae7d026e 100644\n--- a/drivers/pci/controller/pcie-aspeed.c\n+++ b/drivers/pci/controller/pcie-aspeed.c\n@@ -1052,14 +1052,14 @@ static int aspeed_pcie_probe(struct platform_device *pdev)\n \tif (ret)\n \t\treturn ret;\n \n-\tirq = platform_get_irq(pdev, 0);\n-\tif (irq < 0)\n-\t\treturn irq;\n-\n \tret = devm_add_action_or_reset(dev, aspeed_pcie_irq_domain_free, pcie);\n \tif (ret)\n \t\treturn ret;\n \n+\tirq = platform_get_irq(pdev, 0);\n+\tif (irq < 0)\n+\t\treturn irq;\n+\n \tret = devm_request_irq(dev, irq, aspeed_pcie_intr_handler, IRQF_SHARED,\n \t\t\t dev_name(dev), pcie);\n \tif (ret)\n", "prefixes": [] }