Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215502/?format=api
{ "id": 2215502, "url": "http://patchwork.ozlabs.org/api/patches/2215502/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260324-deverr-v1-4-7e591cce33a3@gmail.com/", "project": { "id": 21, "url": "http://patchwork.ozlabs.org/api/projects/21/?format=api", "name": "Linux Tegra Development", "link_name": "linux-tegra", "list_id": "linux-tegra.vger.kernel.org", "list_email": "linux-tegra@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260324-deverr-v1-4-7e591cce33a3@gmail.com>", "list_archive_url": null, "date": "2026-03-24T18:26:52", "name": "[04/10] i2c: stm32f7: Replace dev_err() with dev_err_probe() in probe function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "685dea477ac7f9aa5cae1f31ca087eaf3bc8e330", "submitter": { "id": 92959, "url": "http://patchwork.ozlabs.org/api/people/92959/?format=api", "name": "Atharv Dubey", "email": "atharvd440@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260324-deverr-v1-4-7e591cce33a3@gmail.com/mbox/", "series": [ { "id": 497326, "url": "http://patchwork.ozlabs.org/api/series/497326/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/list/?series=497326", "date": "2026-03-24T18:26:49", "name": "i2c: Replace dev_err() with dev_err_probe()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497326/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215502/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215502/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-tegra+bounces-13130-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-tegra@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=qAkfYh2x;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13130-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"qAkfYh2x\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.215.176", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgJXn6PSPz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 05:31:53 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 47FF3305CAB2\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Mar 2026 18:27:52 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1E4A03A2566;\n\tTue, 24 Mar 2026 18:27:52 +0000 (UTC)", "from mail-pg1-f176.google.com (mail-pg1-f176.google.com\n [209.85.215.176])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9977963B9\n\tfor <linux-tegra@vger.kernel.org>; Tue, 24 Mar 2026 18:27:50 +0000 (UTC)", "by mail-pg1-f176.google.com with SMTP id\n 41be03b00d2f7-c7358a7a8d1so941361a12.3\n for <linux-tegra@vger.kernel.org>;\n Tue, 24 Mar 2026 11:27:50 -0700 (PDT)", "from [127.0.1.1] ([103.216.213.160])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 11:27:49 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774376871; cv=none;\n b=Izl0ZqyfpydNsQ+8EhJ4sL/SK7JTKhI555q4W34nrWIBuMCRcux8B6PhQfSYFJb4OZ3QRwt4/oZfOwgzi35DIys8hiB2aVtJsIaP7XG1ApKBSpZgRUaDNaujs3neaHmW9nhFMeMxvgGm5Ja51ZTsPeotG4IvSIsIlCBW9aZexr8=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774376871; c=relaxed/simple;\n\tbh=INy7r9nqYAh8xRryTtp2F3L3u24eOCBCoOZXV2Ktc3E=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=O04Ufd66178xn3svLWMUgYt07c7V9Uljc/XtsZy3n57I20NzGT/qZ84/1BZDJ4JTwCkZMP0X6yQUclf4dP5agf+lJats+P0pFW33neKOqaLUupoeT9uVkctPxtAGKjcRZKaK6uvSESMj3/vlom01pVQ0ZB8mvyUt1Dqs184TT2c=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=qAkfYh2x; arc=none smtp.client-ip=209.85.215.176", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774376870; x=1774981670;\n darn=vger.kernel.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to;\n bh=YOUVvE5FNmjkaySdFPrc+7+hSpPNsoY2HaGuj8AkFfI=;\n b=qAkfYh2xYQHXiHGQvivSqGXRcMqtWLP3pggJM1DGosW4QJUlcSjbPvSm6kfq2uXYLi\n Ou8tZ65iGdJQ/xmJn+SXVToRlUTmNYFpdCB9UCWhQFG/2sXdWrFD7YHT0HirOt8/aQKM\n Y6pAVVpbtz1BjwZj+b5EzYj9Et0yFcDBVNo/lS+qimPsBuYxQjAGwZRP0+LRFRCGVhoz\n NA0txW/yQdxnUtw47dcAV8cgCFDLi1U0eaphyo7BBXWsF46CmTRIRK1p/rNxvX4PbUSR\n j5rKQwmNGjU9/LoAVe7HlzVvKhnPekeTATFynMs651ziTN9iXQ2/pe+bhBJT22TcqTq3\n ea6A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774376870; x=1774981670;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=YOUVvE5FNmjkaySdFPrc+7+hSpPNsoY2HaGuj8AkFfI=;\n b=bnNhisGDJwIx8t3+aBrbLHTsd+lj9YGYiVH58+BILbSAPG69YWt2w2rwIKKrxuqhhh\n aVZMnY/R1X5DuoPvzBxVqyKkJ1E2PYN3l6Qy3eaGO9A4Iu2yqJ99fuG5DpyMwK+yDQ1c\n gPkEYnHjZAXRdMYB995kyEIo5Tk+aR6rrQYxKmXJoTL8lOBLaVP4+3E4MNEQOpjR8XIp\n IgJyI8VZ87gpsC0UKBpIX2cT3awvTz1H9ZDSZOyLMlWoFuVtr/QeNcKcc47j3OW5Xi5y\n 8Cp3YE0Gp/HxX3aLB+9+dUHQkXWb0vlBZxHk4EgxV18CZ/A0CFAd1xiyshmCIm0GBOuq\n mv9g==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVdnE7I1IOksz9Dm9R3RoAIurxDa4o950VQmpJH1tzAeCyLw7SlJWwqIKevHlH7xXn53/153EBSyJ2lfg==@vger.kernel.org", "X-Gm-Message-State": "AOJu0YzjhXhXjO3SEsQu2LdL7x973YVfrhgdSz16qO8L1hfzilWwKvLb\n\tIu6CJ3UEwSK7ZkpFNHHj/Qc/yIXQImn9CVh6mlQ6809OfJztXePCeK5a", "X-Gm-Gg": "ATEYQzwEt9soJ/h9RNneinCqKGft8EGuxX5N/LR5nlgn5pzJWPgxy8p7zJK46vK+yYE\n\tJoCvKOwKz0e/72EqL4/afEeG58m641Z1K3NFYIRfQ9NGzmKNnQ7m+Iu2az4xctLtErLmOr7UfKD\n\tBhm2Imsuiqj3DSIZaZ1qqaYoRKve7Tp4gOLFdseUqFzCJTAurkpaLBt6JpcttPjtU47U45bM/ff\n\tPs8mzQGiFhHkcv+qXLSuY0I5qu+AW+KXwPmSRHFdkqCpp1FkbiaG3/8a43t9vQ0F2Qz0U5oF8Dy\n\t+11XUeuFMWzVLvJrvzr7lP6Lis2J1+Mb0KBV8HxMp/xPie7y38F4eNusDvCfL363L/qmBYFHD4o\n\t6/llAfhpes4Zg9gKtWSgJiZRU/D4vJKvODt6mrGrJj/LNHvnPq/q9s9kwcp+iY4ICT6Q+4wj0wF\n\tBvdjKfQOMpMk6Gu0CcShwh1iNzpacmDT2exmpv", "X-Received": "by 2002:a17:90b:1dcd:b0:35b:a656:a60a with SMTP id\n 98e67ed59e1d1-35c0dcf48dbmr341601a91.8.1774376869963;\n Tue, 24 Mar 2026 11:27:49 -0700 (PDT)", "From": "Atharv Dubey <atharvd440@gmail.com>", "Date": "Tue, 24 Mar 2026 23:56:52 +0530", "Subject": "[PATCH 04/10] i2c: stm32f7: Replace dev_err() with dev_err_probe()\n in probe function", "Precedence": "bulk", "X-Mailing-List": "linux-tegra@vger.kernel.org", "List-Id": "<linux-tegra.vger.kernel.org>", "List-Subscribe": "<mailto:linux-tegra+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-tegra+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260324-deverr-v1-4-7e591cce33a3@gmail.com>", "References": "<20260324-deverr-v1-0-7e591cce33a3@gmail.com>", "In-Reply-To": "<20260324-deverr-v1-0-7e591cce33a3@gmail.com>", "To": "Till Harbaum <till@harbaum.org>, Andi Shyti <andi.shyti@kernel.org>,\n Laxman Dewangan <ldewangan@nvidia.com>, Dmitry Osipenko <digetx@gmail.com>,\n Thierry Reding <thierry.reding@gmail.com>,\n Jonathan Hunter <jonathanh@nvidia.com>, Chen-Yu Tsai <wens@kernel.org>,\n Jernej Skrabec <jernej.skrabec@gmail.com>,\n Samuel Holland <samuel@sholland.org>,\n Pierre-Yves MORDRET <pierre-yves.mordret@foss.st.com>,\n Alain Volmat <alain.volmat@foss.st.com>,\n Maxime Coquelin <mcoquelin.stm32@gmail.com>,\n Alexandre Torgue <alexandre.torgue@foss.st.com>,\n Patrice Chotard <patrice.chotard@foss.st.com>,\n Orson Zhai <orsonzhai@gmail.com>,\n Baolin Wang <baolin.wang@linux.alibaba.com>,\n Chunyan Zhang <zhang.lyra@gmail.com>, Jean Delvare <jdelvare@suse.com>", "Cc": "linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,\n Enrico Zanda <e.zanda1@gmail.com>, Atharv Dubey <atharvd440@gmail.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1774376818; l=6197;\n i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id;\n bh=s9JDU7GcgsnDDFXsrCxagGOfCSdKXg3wGsXTsgZz2H0=;\n b=ah0pTzAjwcV8FwCOGin97Y4dMl89Nw1GTUGKElGrgDchfwSWIGhdZL4fJM5yOH/LB2Vze2ERu\n 5pFUk9n36AADxerpZp4V7L4H+yM/I6gEVGRW6UOTZNuNCinHlE0yV/c", "X-Developer-Key": "i=atharvd440@gmail.com; a=ed25519;\n pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk=" }, "content": "From: Enrico Zanda <e.zanda1@gmail.com>\n\nThis simplifies the code while improving log.\n\nSigned-off-by: Enrico Zanda <e.zanda1@gmail.com>\nSigned-off-by: Atharv Dubey <atharvd440@gmail.com>\n---\n drivers/i2c/busses/i2c-stm32f7.c | 78 ++++++++++++++++------------------------\n 1 file changed, 30 insertions(+), 48 deletions(-)", "diff": "diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c\nindex 70cb5822bf17..e7cc7f0fb56c 100644\n--- a/drivers/i2c/busses/i2c-stm32f7.c\n+++ b/drivers/i2c/busses/i2c-stm32f7.c\n@@ -481,28 +481,22 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev,\n \tint ret = 0;\n \n \tspecs = stm32f7_get_specs(setup->speed_freq);\n-\tif (specs == ERR_PTR(-EINVAL)) {\n-\t\tdev_err(i2c_dev->dev, \"speed out of bound {%d}\\n\",\n-\t\t\tsetup->speed_freq);\n-\t\treturn -EINVAL;\n-\t}\n+\tif (specs == ERR_PTR(-EINVAL))\n+\t\treturn dev_err_probe(i2c_dev->dev, -EINVAL, \"speed out of bound {%d}\\n\",\n+\t\t\t\t setup->speed_freq);\n \n \tif ((setup->rise_time > specs->rise_max) ||\n-\t (setup->fall_time > specs->fall_max)) {\n-\t\tdev_err(i2c_dev->dev,\n-\t\t\t\"timings out of bound Rise{%d>%d}/Fall{%d>%d}\\n\",\n-\t\t\tsetup->rise_time, specs->rise_max,\n-\t\t\tsetup->fall_time, specs->fall_max);\n-\t\treturn -EINVAL;\n-\t}\n+\t (setup->fall_time > specs->fall_max))\n+\t\treturn dev_err_probe(i2c_dev->dev, -EINVAL,\n+\t\t\t\t \"timings out of bound Rise{%d>%d}/Fall{%d>%d}\\n\",\n+\t\t\t\t setup->rise_time, specs->rise_max,\n+\t\t\t\t setup->fall_time, specs->fall_max);\n \n \ti2c_dev->dnf = DIV_ROUND_CLOSEST(i2c_dev->dnf_dt, i2cclk);\n-\tif (i2c_dev->dnf > STM32F7_I2C_DNF_MAX) {\n-\t\tdev_err(i2c_dev->dev,\n-\t\t\t\"DNF out of bound %d/%d\\n\",\n-\t\t\ti2c_dev->dnf * i2cclk, STM32F7_I2C_DNF_MAX * i2cclk);\n-\t\treturn -EINVAL;\n-\t}\n+\tif (i2c_dev->dnf > STM32F7_I2C_DNF_MAX)\n+\t\treturn dev_err_probe(i2c_dev->dev, -EINVAL,\n+\t\t\t\t \"DNF out of bound %d/%d\\n\", i2c_dev->dnf * i2cclk,\n+\t\t\t\t STM32F7_I2C_DNF_MAX * i2cclk);\n \n \t/* Analog and Digital Filters */\n \taf_delay_min =\n@@ -567,8 +561,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev,\n \t}\n \n \tif (list_empty(&solutions)) {\n-\t\tdev_err(i2c_dev->dev, \"no Prescaler solution\\n\");\n-\t\tret = -EPERM;\n+\t\tret = dev_err_probe(i2c_dev->dev, -EPERM, \"no Prescaler solution\\n\");\n \t\tgoto exit;\n \t}\n \n@@ -624,8 +617,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev,\n \t}\n \n \tif (!s) {\n-\t\tdev_err(i2c_dev->dev, \"no solution at all\\n\");\n-\t\tret = -EPERM;\n+\t\tret = dev_err_probe(i2c_dev->dev, -EPERM, \"no solution at all\\n\");\n \t\tgoto exit;\n \t}\n \n@@ -674,11 +666,9 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev,\n \n \ti2c_parse_fw_timings(i2c_dev->dev, t, false);\n \n-\tif (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) {\n-\t\tdev_err(i2c_dev->dev, \"Invalid bus speed (%i>%i)\\n\",\n-\t\t\tt->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ);\n-\t\treturn -EINVAL;\n-\t}\n+\tif (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ)\n+\t\treturn dev_err_probe(i2c_dev->dev, -EINVAL, \"Invalid bus speed (%i>%i)\\n\",\n+\t\t\t\t t->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ);\n \n \tsetup->speed_freq = t->bus_freq_hz;\n \ti2c_dev->setup.rise_time = t->scl_rise_ns;\n@@ -686,10 +676,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev,\n \ti2c_dev->dnf_dt = t->digital_filter_width_ns;\n \tsetup->clock_src = clk_get_rate(i2c_dev->clk);\n \n-\tif (!setup->clock_src) {\n-\t\tdev_err(i2c_dev->dev, \"clock rate is 0\\n\");\n-\t\treturn -EINVAL;\n-\t}\n+\tif (!setup->clock_src)\n+\t\treturn dev_err_probe(i2c_dev->dev, -EINVAL, \"clock rate is 0\\n\");\n \n \tif (!of_property_read_bool(i2c_dev->dev->of_node, \"i2c-digital-filter\"))\n \t\ti2c_dev->dnf_dt = STM32F7_I2C_DNF_DEFAULT;\n@@ -698,8 +686,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev,\n \t\tret = stm32f7_i2c_compute_timing(i2c_dev, setup,\n \t\t\t\t\t\t &i2c_dev->timing);\n \t\tif (ret) {\n-\t\t\tdev_err(i2c_dev->dev,\n-\t\t\t\t\"failed to compute I2C timings.\\n\");\n+\t\t\tdev_err_probe(i2c_dev->dev, ret,\n+\t\t\t\t \"failed to compute I2C timings.\\n\");\n \t\t\tif (setup->speed_freq <= I2C_MAX_STANDARD_MODE_FREQ)\n \t\t\t\tbreak;\n \t\t\tsetup->speed_freq =\n@@ -710,10 +698,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev,\n \t\t}\n \t} while (ret);\n \n-\tif (ret) {\n-\t\tdev_err(i2c_dev->dev, \"Impossible to compute I2C timings.\\n\");\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\treturn dev_err_probe(i2c_dev->dev, ret, \"Impossible to compute I2C timings.\\n\");\n \n \ti2c_dev->analog_filter = of_property_read_bool(i2c_dev->dev->of_node,\n \t\t\t\t\t\t \"i2c-analog-filter\");\n@@ -2175,10 +2161,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)\n \t\treturn -ENOMEM;\n \n \tsetup = of_device_get_match_data(&pdev->dev);\n-\tif (!setup) {\n-\t\tdev_err(&pdev->dev, \"Can't get device data\\n\");\n-\t\treturn -ENODEV;\n-\t}\n+\tif (!setup)\n+\t\treturn dev_err_probe(&pdev->dev, -ENODEV, \"Can't get device data\\n\");\n \ti2c_dev->setup = *setup;\n \n \ti2c_dev->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);\n@@ -2279,7 +2263,7 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)\n \n \t\tret = dev_pm_set_wake_irq(i2c_dev->dev, irq_event);\n \t\tif (ret) {\n-\t\t\tdev_err(i2c_dev->dev, \"Failed to set wake up irq\\n\");\n+\t\t\tdev_err_probe(i2c_dev->dev, ret, \"Failed to set wake up irq\\n\");\n \t\t\tgoto clr_wakeup_capable;\n \t\t}\n \t}\n@@ -2305,9 +2289,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)\n \tif (i2c_dev->smbus_mode) {\n \t\tret = stm32f7_i2c_enable_smbus_host(i2c_dev);\n \t\tif (ret) {\n-\t\t\tdev_err(i2c_dev->dev,\n-\t\t\t\t\"failed to enable SMBus Host-Notify protocol (%d)\\n\",\n-\t\t\t\tret);\n+\t\t\tdev_err_probe(i2c_dev->dev, ret,\n+\t\t\t\t \"failed to enable SMBus Host-Notify protocol\\n\");\n \t\t\tgoto i2c_adapter_remove;\n \t\t}\n \t}\n@@ -2315,9 +2298,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)\n \tif (of_property_read_bool(pdev->dev.of_node, \"smbus-alert\")) {\n \t\tret = stm32f7_i2c_enable_smbus_alert(i2c_dev);\n \t\tif (ret) {\n-\t\t\tdev_err(i2c_dev->dev,\n-\t\t\t\t\"failed to enable SMBus alert protocol (%d)\\n\",\n-\t\t\t\tret);\n+\t\t\tdev_err_probe(i2c_dev->dev, ret,\n+\t\t\t\t \"failed to enable SMBus alert protocol\\n\");\n \t\t\tgoto i2c_disable_smbus_host;\n \t\t}\n \t}\n", "prefixes": [ "04/10" ] }