Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215456/?format=api
{ "id": 2215456, "url": "http://patchwork.ozlabs.org/api/patches/2215456/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324164007.549397-5-djordje.todorovic@htecgroup.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260324164007.549397-5-djordje.todorovic@htecgroup.com>", "list_archive_url": null, "date": "2026-03-24T16:40:16", "name": "[v5,4/7] hw/riscv: Make boot code endianness-aware at runtime", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ba0ccfb5dd48d0afcbd389d69a86934930c7dc8a", "submitter": { "id": 90738, "url": "http://patchwork.ozlabs.org/api/people/90738/?format=api", "name": "Djordje Todorovic", "email": "Djordje.Todorovic@htecgroup.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324164007.549397-5-djordje.todorovic@htecgroup.com/mbox/", "series": [ { "id": 497314, "url": "http://patchwork.ozlabs.org/api/series/497314/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497314", "date": "2026-03-24T16:40:16", "name": "Add RISC-V big-endian target support", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/497314/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215456/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215456/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=htecgroup.com header.i=@htecgroup.com\n header.a=rsa-sha256 header.s=selector1 header.b=N3LqF6bc;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=htecgroup.com;" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgG5z32Hpz1y1g\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 03:41:59 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w54o6-0003nQ-J9; Tue, 24 Mar 2026 12:40:42 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <Djordje.Todorovic@htecgroup.com>)\n id 1w54o0-0003lM-2E; Tue, 24 Mar 2026 12:40:36 -0400", "from mail-northeuropeazlp170100001.outbound.protection.outlook.com\n ([2a01:111:f403:c200::1] helo=DB3PR0202CU003.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <Djordje.Todorovic@htecgroup.com>)\n id 1w54nx-0005LR-FW; Tue, 24 Mar 2026 12:40:35 -0400", "from GV2PR09MB8755.eurprd09.prod.outlook.com (2603:10a6:150:358::6)\n by DU0PR09MB6145.eurprd09.prod.outlook.com (2603:10a6:10:475::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Tue, 24 Mar\n 2026 16:40:16 +0000", "from GV2PR09MB8755.eurprd09.prod.outlook.com\n ([fe80::939c:95df:4890:ce63]) by GV2PR09MB8755.eurprd09.prod.outlook.com\n ([fe80::939c:95df:4890:ce63%3]) with mapi id 15.20.9723.030; Tue, 24 Mar 2026\n 16:40:16 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=S7uY1Y58vPAR9B7eme46vtCgSc+wpnOGRpH3W6F3eT90T9l5SUbKe4Si2HbyqGlQWb9jV4Xz329Dxe4uqZMeLgd6fR17ib58xmMRm0H7F35YhFKVVl87lSF8fcS08W6an18eLsi8YGeuHBRMoyeRF+cqf9WLwm3EiSlESD2HtRIibE4pay/rSUuUcxt69Fhp2tIWNJD7KflQFAjopYUTiMB/r1oTr1rsS4HQ0Fv0mkaIDpcHlY++lqt9onqbFzsmOBvwjU/2EPupvHH//UKo4eahZwCZ2b7JTxAL47cqbPQlEIfiz4DKBdwfMlYPS0uLznX7Y0+7QL21SWP00Sn7OA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=pbfVXWr9+U6etvsznPf/5+PQydUm4sQ3DPy9B4dJuEk=;\n b=airhLJ/FSH9KeFP3dzAkZFVswL5R5z4GfZpqtVUTsbQrDw/SnbvvggIEbJE7q5QSa85JnTmIoGtnQausKryiEkK58iEHUMHTyfK0ufJ0EENWpEZ3WYOELAPxJliXia338N12LvlW2XHY8ZeLdBWJwwLHjjlp5fQYsdJ8DQLhJqYoXaZI+LW9Yncd++RjwRbxx5Hbdh2mLY1CwAZohoYTtVp0Tg50H5LYXu4eGeEse4HQ3nzvHVEGNnsEzv7ye4ePG0U2I/i9ojIRffK98nunbuiWmAueIRuBlHiq1jG0ueNKDs1Jc/rTAQGgyQ1CJACEgmtww2Qt6AFm2X+QkCxlrg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=htecgroup.com; dmarc=pass action=none\n header.from=htecgroup.com; dkim=pass header.d=htecgroup.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=htecgroup.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pbfVXWr9+U6etvsznPf/5+PQydUm4sQ3DPy9B4dJuEk=;\n b=N3LqF6bcKAXiNmvS8ZXjxORJlyd8e2ipvMowzWlidJ0TlktYP/ONubpgv3N2CRshIK9ihIutCZjyaema0xdHJoPhIkGvdVinAzM8NvdTc/bT043uwJsH4T/66qpyR5/BcRT+yhhqhEkfh+hL7TrBWm6N2x5qnCKeWVqYoSzOdisY2dNC9x4cVcN0WScfF2NZB1ogOQHkl3A37jf2QPzkkWhMZ9hjCjvqETllK8dDSQyD52FFyG7vzHSn8svKSIRChc+EV6TT5RcYssCE7GZhtz3OpIPC/TSsWLnEpWdCkPwSsS0+eg5hSXL5j/zPollBiFAvazYDXasW8hG8prX9KQ==", "From": "Djordje Todorovic <Djordje.Todorovic@htecgroup.com>", "To": "\"qemu-devel@nongnu.org\" <qemu-devel@nongnu.org>", "CC": "\"qemu-riscv@nongnu.org\" <qemu-riscv@nongnu.org>, \"cfu@mips.com\"\n <cfu@mips.com>, \"mst@redhat.com\" <mst@redhat.com>,\n \"marcel.apfelbaum@gmail.com\" <marcel.apfelbaum@gmail.com>,\n \"dbarboza@ventanamicro.com\" <dbarboza@ventanamicro.com>, \"philmd@linaro.org\"\n <philmd@linaro.org>, \"alistair23@gmail.com\" <alistair23@gmail.com>,\n \"thuth@redhat.com\" <thuth@redhat.com>, Djordje Todorovic\n <Djordje.Todorovic@htecgroup.com>", "Subject": "[PATCH v5 4/7] hw/riscv: Make boot code endianness-aware at runtime", "Thread-Topic": "[PATCH v5 4/7] hw/riscv: Make boot code endianness-aware at\n runtime", "Thread-Index": "AQHcu6zkp4dl2F3i9UaTc6hdecuzUQ==", "Date": "Tue, 24 Mar 2026 16:40:16 +0000", "Message-ID": "<20260324164007.549397-5-djordje.todorovic@htecgroup.com>", "References": "<20260324164007.549397-1-djordje.todorovic@htecgroup.com>", "In-Reply-To": "<20260324164007.549397-1-djordje.todorovic@htecgroup.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=htecgroup.com header.i=@htecgroup.com\n header.a=rsa-sha256 header.s=selector1 header.b=N3LqF6bc;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=htecgroup.com;" ], "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "GV2PR09MB8755:EE_|DU0PR09MB6145:EE_", "x-ms-office365-filtering-correlation-id": "7d162eaf-bffe-45e5-5f42-08de89c407a5", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;\n ARA:13230040|376014|366016|1800799024|38070700021|56012099003|18002099003|22082099003;", "x-microsoft-antispam-message-info": "\n 7Qhlh7qN9bTH3QeWv4WtvSeVHS35/KX6yXrg41ZBIrukEwfYvhFLB5GjzPvZgM6QdnS48OfY30bIlNAC5MlmnLpq80I33DQ3+4pgMzcyBcbkHqLM+T4nvY6R+DQbXA43O9C3jmwefydzGcHz1eBM2+NioAIi/O6D0Hi7f2X2nHVkQuNwJie/5/dfkjWBTujsMLmsasZpdyIBHI1yF+98oMQGc+FcWxtDFES+pRwuN+L3f8WK4qBFGfU7j1l+KWXGxbedBYyZl6o/gfC8gyYSWPWT6fX+iC90IpyasCGBwZC4Xt+Un/LVT/zTcLaGyatWuwlnpMxeIa8oZ8fwL7lNvvBazSgPjmWBLKYg4Hp/VIpYcxQxTFpdoQkHmaTSqfSgPYPZeVwoeAyJnZaGZYtd28krfXHOgy5RGZGCFxsWMYmxpTlOIzQ1t8rduAFFCHHITGTDISYTUlHJcOgeoO0dLOHpOsRlKexhTQQ0bSxtnesauz8Y33HRwXMU/7OXMpfdBvVvhj+VC3J0x2g8Ny5CyeOkGTvfySD/ksSLlM/59+Fx/ee3FfFXUx+OwDSmqg9gYQSthK7iRX4WdjPcSZXb5UB/IjhNlJ8D8U4+OlswXNkeokfZNfMkKFEZllt3SBvHTiZycIXil9rwCNJvXNmf+Qf4oNZb9ohmtfGZfrBvvdLWCmKVXiFzgqueedjiyUjW8i3AYiSt2Fu3jdgeSXgyVIbwO/B2kFRFDHYKGt43TGA+j9MK6OkLLi0pPfE4tqTrJQgCWRf56Q+OLlZJMcRvNgLfXVshrVZiEN+17vlA/so=", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:GV2PR09MB8755.eurprd09.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "=?iso-8859-1?q?nBsqJV2C/BI2Umc3qbLaELn?=\n\t=?iso-8859-1?q?r9VdotfN4DKBaVc9Q67IgpOHp+27/NtdXCUzXYl9uHTHsUHWGsWmQO53SgEI?=\n\t=?iso-8859-1?q?Q0frJAoXO+mCnXuP9pBEDzxoVcC1f3daGM2gAbXJKXLL2kl85a7Fu4b6eCuC?=\n\t=?iso-8859-1?q?XkvjZet5qnHntud43S80aD7sgLeoYTQDDx2bGYijKXWIslEw3hu8IHNuUrHF?=\n\t=?iso-8859-1?q?nIteSHyfSMsA3FlbZ5owuTATCP/D5a4ibjL6dOckXhRWRLe8O5jJCWsJdiOG?=\n\t=?iso-8859-1?q?eKDvHaUoG+CsrmBS6swYjtUq9j+hJhoYVM/P4+4m9GOsBFijohVcDcqKwVqz?=\n\t=?iso-8859-1?q?mvCUpie+ou0d9AADbdoZJQ0Ong2jnKjlwKMkQZQ1JJVmQ9P6zlG5xSn0Fk7Z?=\n\t=?iso-8859-1?q?odnudhxXunGEy4KKAM2lc4m8eyrFxTD1g1BtNx+7iP3UQVWWoCrt0bOB6Hjo?=\n\t=?iso-8859-1?q?4cdQfBkAJPNiAHOOi8/pkY68awAbEefMbUkl3lODH5joQTUWGc9jwWL3bUTn?=\n\t=?iso-8859-1?q?5cYMwEFaIj4A1uvUzrBB23U8Zz2Ni8DTTJobd/QZfmYSSyY0AD18wtlNHQTH?=\n\t=?iso-8859-1?q?c3jPDblG/R/pNvJT2brgCIOhmiJdBwlDwrg5mH6DxvRxbDBEZ4cq8uOmtLmC?=\n\t=?iso-8859-1?q?pkMsGNTPrrpNwHozXE7Vgp2Bnxa5nZgw77knrIYLEVNv3KjyFmWlBEQWoawP?=\n\t=?iso-8859-1?q?nykl6abgqf0yWxbPodf5lU5J1Ok1OxoJ7p5ADVh6i774AblnOdoojm1RGugc?=\n\t=?iso-8859-1?q?bSl1M8mcJjfDya5ivyJB5bwbWsammWTN7RIrWwNVUPGljfKYDTAUJ5Ga8t9I?=\n\t=?iso-8859-1?q?5H5L9m77y1bm8xjxwzWvi26D5Mw4ChUdyCQIyBf9FA8PnYGUqPPkD3GqvGDJ?=\n\t=?iso-8859-1?q?mDpSLRwFZNSuBv9EZ+ANKlA7AZxhtDtPfkSVabqSlG79HKYcPfr6AWnkMIsO?=\n\t=?iso-8859-1?q?zMsgw7yETskriL40RJPcfOhs77ilSpoF78UV89G2wPFamz221ZR3fkdxJ1Lg?=\n\t=?iso-8859-1?q?a/gZ7vL2ho+IkGpbXFl+WqNqIQXiOTLNjJ9Ai5DUHRd+fanIsL6pDBA9srTi?=\n\t=?iso-8859-1?q?ub9JxSBXCam4HT7682gb9BFM6RkI/ltwP6Ec4gjGf564ZNVeJvET07/oZXe1?=\n\t=?iso-8859-1?q?QVuP5S97ztvZ/ZmuR6qDAPZq4iG6FHKfuXLvU499fxFtBkzr3YrStLdfGXtJ?=\n\t=?iso-8859-1?q?3FIXBavEGlEzVPLHQ/M9xCrv4V4R+KMnITm4inQ5tJtpr26A9AU89wtXZR5i?=\n\t=?iso-8859-1?q?xvNQQRoztaSOBAS8+Uwld00ZAjGiug+xKlKLnO6NGPkkSzn4EECReuDf67RC?=\n\t=?iso-8859-1?q?6DOHUgjWgyUvHZDgYeC8msrrAftvGufq110tf3XMDWdJbw7EVFwE41u4/zT+?=\n\t=?iso-8859-1?q?H0OP1np1Z9zVnce5uEKQnQNY4h6vSIGoZZDKtpQGbKmJ7U72HndFnr/hyQEQ?=\n\t=?iso-8859-1?q?qZkffMF77XchMQ4Wy7et98YOMCRk5mBnRl+1KQhwatP1a/+Y+KxurCFgoFf9?=\n\t=?iso-8859-1?q?neu/5wfVErO9vewq56rzQCELYroUvFD1+CFEG4Zls7w68Z56nZBIiVFO2udP?=\n\t=?iso-8859-1?q?8Bqadn/LNaYWbxoAEqgOl1awx4x/SQVux9mOev6YGI/Db5IoXr7FnmlkPDao?=\n\t=?iso-8859-1?q?bZlZUxahSxJInJe60BCyoS0XJ730/6IjFkVxYvftWaxLepj+uEegOTpmcIUm?=\n\t=?iso-8859-1?q?RbEct8U2Mbwdghmuhq2YI/ybur+xLbki4DEW2REa9wdkK0CYjAHVwZyflxCp?=\n\t=?iso-8859-1?q?V0Emljl7abrf0vckz9a9WmLIsE6Zmqt+dvUakJx4HUAvbYIxaTgCjUrB7oby?=\n\t=?iso-8859-1?q?c9jDPCJ9rngLLV4evKgLHHL3yzDsp?=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "htecgroup.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "GV2PR09MB8755.eurprd09.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7d162eaf-bffe-45e5-5f42-08de89c407a5", "X-MS-Exchange-CrossTenant-originalarrivaltime": "24 Mar 2026 16:40:16.4489 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "9f85665b-7efd-4776-9dfe-b6bfda2565ee", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n 4902d83BDxSC96jrBLH7kwi/B2WymZv5u7L1asJfMSoQN/iyDPR/O6DXjlBJSnCSZ8CO04yoxcT/dBLUrdeGOK+Hf6m7RDJsVL6nzoGMz2Y=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DU0PR09MB6145", "Received-SPF": "pass client-ip=2a01:111:f403:c200::1;\n envelope-from=Djordje.Todorovic@htecgroup.com;\n helo=DB3PR0202CU003.outbound.protection.outlook.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add riscv_is_big_endian() helper that checks the hart's big-endian CPU\nproperty and use it throughout the boot code:\n\n- ELF loading: pass ELFDATA2MSB or ELFDATA2LSB based on endianness\n- Firmware dynamic info: use cpu_to_be* or cpu_to_le* based on endianness\n- Reset vector: instructions (entries 0-5) remain always little-endian,\n data words (entries 6-9) use target data endianness. For RV64 BE, the\n hi/lo word pairs within each dword are swapped since LD reads as BE.\n\nThis is part of the runtime big-endian support series which avoids\nseparate BE binaries by handling endianness as a CPU property.\n\nSigned-off-by: Djordje Todorovic <djordje.todorovic@htecgroup.com>\n---\n hw/riscv/boot.c | 82 +++++++++++++++++++++++++++++++++++------\n include/hw/riscv/boot.h | 2 +\n 2 files changed, 72 insertions(+), 12 deletions(-)", "diff": "diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c\nindex e5490beda0..c7558b904f 100644\n--- a/hw/riscv/boot.c\n+++ b/hw/riscv/boot.c\n@@ -40,6 +40,28 @@ bool riscv_is_32bit(RISCVHartArrayState *harts)\n return mcc->def->misa_mxl_max == MXL_RV32;\n }\n \n+bool riscv_is_big_endian(RISCVHartArrayState *harts)\n+{\n+ return harts->harts[0].cfg.big_endian;\n+}\n+\n+/*\n+ * Convert a pair of 32-bit words forming a 64-bit dword to target data\n+ * endianness. For big-endian, the hi/lo word order is swapped since LD\n+ * interprets bytes as BE.\n+ */\n+static void riscv_boot_data_dword(uint32_t *data, bool big_endian)\n+{\n+ if (big_endian) {\n+ uint32_t tmp = data[0];\n+ data[0] = cpu_to_be32(data[1]);\n+ data[1] = cpu_to_be32(tmp);\n+ } else {\n+ data[0] = cpu_to_le32(data[0]);\n+ data[1] = cpu_to_le32(data[1]);\n+ }\n+}\n+\n /*\n * Return the per-socket PLIC hart topology configuration string\n * (caller must free with g_free())\n@@ -72,6 +94,7 @@ void riscv_boot_info_init(RISCVBootInfo *info, RISCVHartArrayState *harts)\n info->kernel_size = 0;\n info->initrd_size = 0;\n info->is_32bit = riscv_is_32bit(harts);\n+ info->is_big_endian = riscv_is_big_endian(harts);\n }\n \n vaddr riscv_calc_kernel_start_addr(RISCVBootInfo *info,\n@@ -247,8 +270,9 @@ void riscv_load_kernel(MachineState *machine,\n */\n kernel_size = load_elf_ram_sym(kernel_filename, NULL, NULL, NULL, NULL,\n &info->image_low_addr, &info->image_high_addr,\n- NULL, ELFDATA2LSB, EM_RISCV,\n- 1, 0, NULL, true, sym_cb);\n+ NULL,\n+ ELFDATA2LSB,\n+ EM_RISCV, 1, 0, NULL, true, sym_cb);\n if (kernel_size > 0) {\n info->kernel_size = kernel_size;\n goto out;\n@@ -391,21 +415,32 @@ void riscv_rom_copy_firmware_info(MachineState *machine,\n struct fw_dynamic_info64 dinfo64;\n void *dinfo_ptr = NULL;\n size_t dinfo_len;\n+ bool big_endian = riscv_is_big_endian(harts);\n \n if (riscv_is_32bit(harts)) {\n- dinfo32.magic = cpu_to_le32(FW_DYNAMIC_INFO_MAGIC_VALUE);\n- dinfo32.version = cpu_to_le32(FW_DYNAMIC_INFO_VERSION);\n- dinfo32.next_mode = cpu_to_le32(FW_DYNAMIC_INFO_NEXT_MODE_S);\n- dinfo32.next_addr = cpu_to_le32(kernel_entry);\n+ dinfo32.magic = big_endian ? cpu_to_be32(FW_DYNAMIC_INFO_MAGIC_VALUE)\n+ : cpu_to_le32(FW_DYNAMIC_INFO_MAGIC_VALUE);\n+ dinfo32.version = big_endian ? cpu_to_be32(FW_DYNAMIC_INFO_VERSION)\n+ : cpu_to_le32(FW_DYNAMIC_INFO_VERSION);\n+ dinfo32.next_mode = big_endian\n+ ? cpu_to_be32(FW_DYNAMIC_INFO_NEXT_MODE_S)\n+ : cpu_to_le32(FW_DYNAMIC_INFO_NEXT_MODE_S);\n+ dinfo32.next_addr = big_endian ? cpu_to_be32(kernel_entry)\n+ : cpu_to_le32(kernel_entry);\n dinfo32.options = 0;\n dinfo32.boot_hart = 0;\n dinfo_ptr = &dinfo32;\n dinfo_len = sizeof(dinfo32);\n } else {\n- dinfo64.magic = cpu_to_le64(FW_DYNAMIC_INFO_MAGIC_VALUE);\n- dinfo64.version = cpu_to_le64(FW_DYNAMIC_INFO_VERSION);\n- dinfo64.next_mode = cpu_to_le64(FW_DYNAMIC_INFO_NEXT_MODE_S);\n- dinfo64.next_addr = cpu_to_le64(kernel_entry);\n+ dinfo64.magic = big_endian ? cpu_to_be64(FW_DYNAMIC_INFO_MAGIC_VALUE)\n+ : cpu_to_le64(FW_DYNAMIC_INFO_MAGIC_VALUE);\n+ dinfo64.version = big_endian ? cpu_to_be64(FW_DYNAMIC_INFO_VERSION)\n+ : cpu_to_le64(FW_DYNAMIC_INFO_VERSION);\n+ dinfo64.next_mode = big_endian\n+ ? cpu_to_be64(FW_DYNAMIC_INFO_NEXT_MODE_S)\n+ : cpu_to_le64(FW_DYNAMIC_INFO_NEXT_MODE_S);\n+ dinfo64.next_addr = big_endian ? cpu_to_be64(kernel_entry)\n+ : cpu_to_le64(kernel_entry);\n dinfo64.options = 0;\n dinfo64.boot_hart = 0;\n dinfo_ptr = &dinfo64;\n@@ -474,10 +509,33 @@ void riscv_setup_rom_reset_vec(MachineState *machine, RISCVHartArrayState *harts\n reset_vec[2] = 0x00000013; /* addi x0, x0, 0 */\n }\n \n- /* copy in the reset vector in little_endian byte order */\n- for (i = 0; i < ARRAY_SIZE(reset_vec); i++) {\n+ /* RISC-V instructions are always little-endian */\n+ for (i = 0; i < 6; i++) {\n reset_vec[i] = cpu_to_le32(reset_vec[i]);\n }\n+\n+ /*\n+ * Data words (addresses at entries 6-9) must match the firmware's data\n+ * endianness.\n+ */\n+ if (riscv_is_32bit(harts)) {\n+ for (i = 6; i < ARRAY_SIZE(reset_vec); i++) {\n+ if (riscv_is_big_endian(harts)) {\n+ reset_vec[i] = cpu_to_be32(reset_vec[i]);\n+ } else {\n+ reset_vec[i] = cpu_to_le32(reset_vec[i]);\n+ }\n+ }\n+ } else {\n+ /*\n+ * For RV64, each pair of 32-bit words forms a dword. For big-endian,\n+ * the hi/lo word order within each dword must be swapped since LD\n+ * interprets bytes as BE.\n+ */\n+ for (i = 6; i < ARRAY_SIZE(reset_vec); i += 2) {\n+ riscv_boot_data_dword(reset_vec + i, riscv_is_big_endian(harts));\n+ }\n+ }\n rom_add_blob_fixed_as(\"mrom.reset\", reset_vec, sizeof(reset_vec),\n rom_base, &address_space_memory);\n riscv_rom_copy_firmware_info(machine, harts,\ndiff --git a/include/hw/riscv/boot.h b/include/hw/riscv/boot.h\nindex f00b3ca122..a54c2b397d 100644\n--- a/include/hw/riscv/boot.h\n+++ b/include/hw/riscv/boot.h\n@@ -36,9 +36,11 @@ typedef struct RISCVBootInfo {\n ssize_t initrd_size;\n \n bool is_32bit;\n+ bool is_big_endian;\n } RISCVBootInfo;\n \n bool riscv_is_32bit(RISCVHartArrayState *harts);\n+bool riscv_is_big_endian(RISCVHartArrayState *harts);\n \n char *riscv_plic_hart_config_string(int hart_count);\n \n", "prefixes": [ "v5", "4/7" ] }