Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2214927/?format=api
{ "id": 2214927, "url": "http://patchwork.ozlabs.org/api/patches/2214927/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260323174052.5355-10-larysa.zaremba@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260323174052.5355-10-larysa.zaremba@intel.com>", "list_archive_url": null, "date": "2026-03-23T17:40:40", "name": "[iwl-next,v6,09/14] idpf: make mbx_task queueing and cancelling more consistent", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "c5cc51c78050b74684016bedf82f63bfc2036083", "submitter": { "id": 84900, "url": "http://patchwork.ozlabs.org/api/people/84900/?format=api", "name": "Larysa Zaremba", "email": "larysa.zaremba@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260323174052.5355-10-larysa.zaremba@intel.com/mbox/", "series": [ { "id": 497154, "url": "http://patchwork.ozlabs.org/api/series/497154/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497154", "date": "2026-03-23T17:40:31", "name": "Introduce iXD driver", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/497154/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2214927/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2214927/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=tkGk28ML;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ffgSy1rZzz1xyt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Mar 2026 04:41:22 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E19F740C46;\n\tMon, 23 Mar 2026 17:41:20 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id hnIJ_clzJYh4; Mon, 23 Mar 2026 17:41:19 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id A9D2940C2C;\n\tMon, 23 Mar 2026 17:41:19 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 91E0D353\n for <intel-wired-lan@lists.osuosl.org>; Mon, 23 Mar 2026 17:41:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 841E981DE1\n for <intel-wired-lan@lists.osuosl.org>; Mon, 23 Mar 2026 17:41:17 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id DGsPTZBy4BYN for <intel-wired-lan@lists.osuosl.org>;\n Mon, 23 Mar 2026 17:41:16 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 8005881DEF\n for <intel-wired-lan@lists.osuosl.org>; Mon, 23 Mar 2026 17:41:16 +0000 (UTC)", "from orviesa004.jf.intel.com ([10.64.159.144])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Mar 2026 10:41:16 -0700", "from irvmail002.ir.intel.com ([10.43.11.120])\n by orviesa004.jf.intel.com with ESMTP; 23 Mar 2026 10:41:10 -0700", "from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id C439232C8B;\n Mon, 23 Mar 2026 17:41:08 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org A9D2940C2C", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8005881DEF" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774287679;\n\tbh=nlstaBa/3a7zX1OdBvwrxETx3Ois1nvcsiJg79+uDhk=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=tkGk28MLX8g+oKs3w9wOlA1xIkDxuMkAem0lauPFLnm0k0x1WIlUdZDuN1uaUBjz7\n\t YfffJUuWdQ2HstZEmkbr8Iq10eMgDIOaoPrOnYr0hjDmYGW2VBSTkVikyaDleO4nj1\n\t pIP5nGc0ZWyx0G3ml06WGUfR3OZ/go7EZHmPUS7d/QXronN4s1JSZofqSLybQFbgpu\n\t JL4wZ4ilLR6tRyQmpDYVloVdMh8yv0tybITq5xB6TbUX8rkPRG17RtAV0Up0vUEdEY\n\t xX5uajS4Lpy5IvayfdazzKSYNgNx6q6ToWz6imuR4Kj5tQ013zsekrSGoqOQMtdxpZ\n\t ZC4QJ98xWqx+A==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=larysa.zaremba@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8005881DEF", "X-CSE-ConnectionGUID": [ "4GPKes5GQCydgrbKv5ulQQ==", "CIJkTjB5QFeNcoWr70USNw==" ], "X-CSE-MsgGUID": [ "q5CLrekaTueGUK/E6DQflQ==", "QLxopq2VRKehz9nZzKlulQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11738\"; a=\"75484709\"", "E=Sophos;i=\"6.23,137,1770624000\"; d=\"scan'208\";a=\"75484709\"", "E=Sophos;i=\"6.23,137,1770624000\"; d=\"scan'208\";a=\"228576818\"" ], "X-ExtLoop1": "1", "From": "Larysa Zaremba <larysa.zaremba@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, Tony Nguyen <anthony.l.nguyen@intel.com>", "Cc": "aleksander.lobakin@intel.com, sridhar.samudrala@intel.com,\n \"Singhai, Anjali\" <anjali.singhai@intel.com>,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Larysa Zaremba <larysa.zaremba@intel.com>,\n \"Fijalkowski, Maciej\" <maciej.fijalkowski@intel.com>,\n Emil Tantilov <emil.s.tantilov@intel.com>,\n Madhu Chittim <madhu.chittim@intel.com>, Josh Hay <joshua.a.hay@intel.com>,\n \"Keller, Jacob E\" <jacob.e.keller@intel.com>,\n jayaprakash.shanmugam@intel.com, Jiri Pirko <jiri@resnulli.us>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,\n Jonathan Corbet <corbet@lwn.net>,\n Richard Cochran <richardcochran@gmail.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, netdev@vger.kernel.org,\n linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org", "Date": "Mon, 23 Mar 2026 18:40:40 +0100", "Message-ID": "<20260323174052.5355-10-larysa.zaremba@intel.com>", "X-Mailer": "git-send-email 2.47.0", "In-Reply-To": "<20260323174052.5355-1-larysa.zaremba@intel.com>", "References": "<20260323174052.5355-1-larysa.zaremba@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774287676; x=1805823676;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=wKJFUxzIqQHiF1RVJnXfLddqbbGn9rxtMzrYNBq2ihc=;\n b=QPqZ+74gvIfQGscAyYkGIB0M47W6kYFtlQUJZkBlzvf+WthkQUmVsYFJ\n DEJhel4BgOl3PKXVIB59LmJz5t4XByqvZDDb7ilMduRyYEbLyl90AqawS\n J5rZgMxZD7V36ZI/BX7/+/s3KseY1MCHrFwb0KM+rZAuu05fcs/i0MGtq\n wrwVe3ofJEMG4LYk2chYcFfmaw8iQlO19pGp8LVlQ0jaDeyl9rvvNI2HV\n +YD4jLYf85g2gjYogf5QMJdxoMm8R/DyyiSfd7/eXd5vNVOJG8s60CPyJ\n HZkdJR51j5I71RDIa+JYXL++URjTTyRj/Q7QBsBSkwVVR6bTvKjsQi/T9\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=QPqZ+74g" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v6 09/14] idpf: make mbx_task\n queueing and cancelling more consistent", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "As a consequence of refactoring idpf code to use libeth APIs,\nidpf_vc_xn_shutdown was merged with and replaced by idpf_deinit_dflt_mbx.\nThis does not affect the Tx path, as it checked for a presence of an xn\nmanager anyway. Rx processing is handled by the mbx_task that is not always\ncancelled before calling the new consolidated mailbox deinit function.\nMoreover, in the reset path idpf_intr_rel() reschedules it after the deinit\nis done. This leads to mbx_task referencing the freed mailbox and causing\nKASAN warnings.\n\nTo remedy this, in the init path, do the first queueing of mbx_task in\nidpf_init_dflt_mbx(), in deinit and reset, always cancel the task in\nidpf_deinit_dflt_mbx() and in every flow first call idpf_mb_intr_rel_irq().\n\nReviewed-by: Emil Tantilov <emil.s.tantilov@intel.com>\nReviewed-by: Michal Kubiak <michal.kubiak@intel.com>\nSigned-off-by: Larysa Zaremba <larysa.zaremba@intel.com>\nTested-by: Samuel Salin <Samuel.salin@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/idpf/idpf.h | 1 +\n drivers/net/ethernet/intel/idpf/idpf_lib.c | 9 ++++-----\n drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 6 +++++-\n 3 files changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h\nindex b06640925fb9..9606c0de018f 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf.h\n+++ b/drivers/net/ethernet/intel/idpf/idpf.h\n@@ -984,6 +984,7 @@ void idpf_vc_event_task(struct work_struct *work);\n void idpf_dev_ops_init(struct idpf_adapter *adapter);\n void idpf_vf_dev_ops_init(struct idpf_adapter *adapter);\n int idpf_intr_req(struct idpf_adapter *adapter);\n+void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter);\n void idpf_intr_rel(struct idpf_adapter *adapter);\n u16 idpf_get_max_tx_hdr_size(struct idpf_adapter *adapter);\n int idpf_initiate_soft_reset(struct idpf_vport *vport,\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c\nindex 0d131bf0993e..7988836fbae0 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_lib.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c\n@@ -68,9 +68,11 @@ static void idpf_deinit_vector_stack(struct idpf_adapter *adapter)\n * This will also disable interrupt mode and queue up mailbox task. Mailbox\n * task will reschedule itself if not in interrupt mode.\n */\n-static void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter)\n+void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter)\n {\n-\tclear_bit(IDPF_MB_INTR_MODE, adapter->flags);\n+\tif (!test_and_clear_bit(IDPF_MB_INTR_MODE, adapter->flags))\n+\t\treturn;\n+\n \tkfree(free_irq(adapter->msix_entries[0].vector, adapter));\n \tqueue_delayed_work(adapter->mbx_wq, &adapter->mbx_task, 0);\n }\n@@ -1938,14 +1940,11 @@ static void idpf_init_hard_reset(struct idpf_adapter *adapter)\n \t\tgoto unlock_mutex;\n \t}\n \n-\tqueue_delayed_work(adapter->mbx_wq, &adapter->mbx_task, 0);\n-\n \t/* Initialize the state machine, also allocate memory and request\n \t * resources\n \t */\n \terr = idpf_vc_core_init(adapter);\n \tif (err) {\n-\t\tcancel_delayed_work_sync(&adapter->mbx_task);\n \t\tidpf_deinit_dflt_mbx(adapter);\n \t\tgoto unlock_mutex;\n \t}\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\nindex 6d847aea00e4..38d119147ab6 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n@@ -2974,6 +2974,8 @@ int idpf_init_dflt_mbx(struct idpf_adapter *adapter)\n \tadapter->xnm = params.xnm;\n \tadapter->state = __IDPF_VER_CHECK;\n \n+\tqueue_delayed_work(adapter->mbx_wq, &adapter->mbx_task, 0);\n+\n \treturn 0;\n }\n \n@@ -2983,6 +2985,9 @@ int idpf_init_dflt_mbx(struct idpf_adapter *adapter)\n */\n void idpf_deinit_dflt_mbx(struct idpf_adapter *adapter)\n {\n+\tidpf_mb_intr_rel_irq(adapter);\n+\tcancel_delayed_work_sync(&adapter->mbx_task);\n+\n \tif (adapter->arq && adapter->asq) {\n \t\tidpf_mb_clean(adapter, adapter->asq, true);\n \t\tlibie_ctlq_xn_deinit(adapter->xnm, &adapter->ctlq_ctx);\n@@ -3237,7 +3242,6 @@ void idpf_vc_core_deinit(struct idpf_adapter *adapter)\n \t\tidpf_deinit_dflt_mbx(adapter);\n \n \tcancel_delayed_work_sync(&adapter->serv_task);\n-\tcancel_delayed_work_sync(&adapter->mbx_task);\n \n \tidpf_vport_params_buf_rel(adapter);\n \n", "prefixes": [ "iwl-next", "v6", "09/14" ] }