Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2214644/?format=api
{ "id": 2214644, "url": "http://patchwork.ozlabs.org/api/patches/2214644/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/patch/20260323074814.2930709-1-wakel@google.com/", "project": { "id": 59, "url": "http://patchwork.ozlabs.org/api/projects/59/?format=api", "name": "Linux Test Project development", "link_name": "ltp", "list_id": "ltp.lists.linux.it", "list_email": "ltp@lists.linux.it", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260323074814.2930709-1-wakel@google.com>", "list_archive_url": null, "date": "2026-03-23T07:48:14", "name": "[v2] syscalls/file_attr01: Dynamically expect EOPNOTSUPP on tmpfs without xattr", "commit_ref": null, "pull_url": null, "state": "needs-review-ack", "archived": false, "hash": "a0cc51804b5386772bd6e81973816cd4f63905ca", "submitter": { "id": 92108, "url": "http://patchwork.ozlabs.org/api/people/92108/?format=api", "name": "Wake Liu", "email": "wakel@google.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ltp/patch/20260323074814.2930709-1-wakel@google.com/mbox/", "series": [ { "id": 497058, "url": "http://patchwork.ozlabs.org/api/series/497058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/list/?series=497058", "date": "2026-03-23T07:48:14", "name": "[v2] syscalls/file_attr01: Dynamically expect EOPNOTSUPP on tmpfs without xattr", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497058/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2214644/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2214644/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ltp@lists.linux.it" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ltp@picard.linux.it" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=TnGMsTs+;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=hxDuVnE5;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ffQJr2P8tz1xyt\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 23 Mar 2026 18:48:28 +1100 (AEDT)", "from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 578633E2299\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 23 Mar 2026 08:48:26 +0100 (CET)", "from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 63A903C6147\n for <ltp@lists.linux.it>; Mon, 23 Mar 2026 08:48:21 +0100 (CET)", "from mail-pl1-x649.google.com (mail-pl1-x649.google.com\n [IPv6:2607:f8b0:4864:20::649])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 7D149600AB2\n for <ltp@lists.linux.it>; Mon, 23 Mar 2026 08:48:20 +0100 (CET)", "by mail-pl1-x649.google.com with SMTP id\n d9443c01a7336-2b059511554so54072705ad.0\n for <ltp@lists.linux.it>; Mon, 23 Mar 2026 00:48:20 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1774252106; h=date :\n in-reply-to : mime-version : references : message-id : to : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=3R/qMkCMm9J86hW9Fzoi+iuNdr77HOWVbgst3vLuYhg=;\n b=TnGMsTs+22bg2HH9KymX6qoipdJCWe2aWq+V04QTTifE4YpPSqZcsnsq6fpz6RKl99HkE\n B7uexDdQ54nW9QLGjRUDy9nGWzgByPAS6RenWoBu9x6wEEqdURXEfSSOM8c3JtEmbBxLzHD\n sYYEhraBB4L9apxEnoqVNd6HeHT4rB4=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1774252099; x=1774856899; darn=lists.linux.it;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:from:to:cc:subject:date:message-id:reply-to;\n bh=/x9Ba7YymFzERHWEZslDPbAQsLyj7chTkUVuZ50U0PQ=;\n b=hxDuVnE5dlDiTNFk1qg+i0MzyQVUd3NmSdpLWdHeLns76LQQlXeOIziIHIPvDaSt4N\n bxBGD67+8f/r4mZbnSO2XKES/9DgWOjRnZ7W9koUlCNtKdcqI56j3woikQaefe2S3viy\n QGJC4BWAL+OVHGstCpCuWUceB3vzSiNnNQFOAVMzI3CMIJgGnKKMi+Bm0dcn+EFzr1Zv\n oxidEh6/jAXGAtf6tSAjMG0bt9Yf2zvZx7PfqbLS5GpG2m/uRS8saPFgT91Wu7S4P37P\n +QbI5Rfp/Jjrru2eKEHdNaVmsfA8rp/wD6t5S5hQ74gXpejOutx9RvuMBEG80C3DL2ER\n xJ/g==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774252099; x=1774856899;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=/x9Ba7YymFzERHWEZslDPbAQsLyj7chTkUVuZ50U0PQ=;\n b=KQ8Pvl9nCvoDozV6cCoL6g3hc6d9X3hmAXT7o8uyU8X5YkfbGZn1GOez2eF0AxQPxz\n DH2Y9EvOgwJEGsk/6Lawsdb+CmVrAa+Ib8FpYTXLST23TThem50Mz1RULqElaToWfgeo\n 2qiBDcnO0ifsccxK6hCuiKccriVH4Ctd6gzf1pkyu4IOE6ZHABOvgK+z2bkDdcJzYlqS\n QVm3atVBU8fdmgHubc8QmHCA+f201sKCP8sR158Dk0zkB6Rwrw/EVBRBsn9Y7QkKEzIZ\n 5fDwRs/uNmgQVK5dj+RUvZTCYspHGMhmG7DRgIbm/C2Za7eI6sj4bJSCZAPfTZ8F3uAc\n fejw==", "X-Gm-Message-State": "AOJu0YzQmBbz0gvWa+w0SrEV2H0khvWgNlPiLCXX5ZcNE7rA3EtpOC60\n vxzKthgCIPjiQ9eQeBv/ltbq1hRq4YllbAGgjJz1vRVC1sqk4H8z46rlv9ZXE0XSkOUuPZ9dfCY\n 3WHQnsgf3vlQeI9/rokmdzJvj5ysnYohMdpqSSOT71bfVBsAlUwMW00WdKA7rkSKxrNO0XynwdD\n dXAgJ2eLxaEVcCdXkNabLJhVRseA==", "X-Received": "from plblc4.prod.google.com ([2002:a17:902:fa84:b0:2b0:5c78:84a7])\n (user=wakel job=prod-delivery.src-stubby-dispatcher) by\n 2002:a17:902:f984:b0:2ae:c795:6b4a\n with SMTP id d9443c01a7336-2b0826d73f3mr76070305ad.11.1774252098401; Mon, 23\n Mar 2026 00:48:18 -0700 (PDT)", "Date": "Mon, 23 Mar 2026 07:48:14 +0000", "In-Reply-To": "\n <CAOcRiAF3gkD8QDr2L7g7DXpUwUurYDh7k-vBMmw=um5AdnuNMw@mail.gmail.com>", "Mime-Version": "1.0", "References": "\n <CAOcRiAF3gkD8QDr2L7g7DXpUwUurYDh7k-vBMmw=um5AdnuNMw@mail.gmail.com>", "X-Mailer": "git-send-email 2.53.0.983.g0bb29b3bc5-goog", "Message-ID": "<20260323074814.2930709-1-wakel@google.com>", "To": "ltp@lists.linux.it", "X-Spam-Status": "No, score=-7.4 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL\n shortcircuit=no autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it", "X-Virus-Scanned": "clamav-milter 1.0.9 at in-5.smtp.seeweb.it", "X-Virus-Status": "Clean", "Subject": "[LTP] [PATCH v2] syscalls/file_attr01: Dynamically expect\n EOPNOTSUPP on tmpfs without xattr", "X-BeenThere": "ltp@lists.linux.it", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux Test Project <ltp.lists.linux.it>", "List-Unsubscribe": "<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>", "List-Archive": "<http://lists.linux.it/pipermail/ltp/>", "List-Post": "<mailto:ltp@lists.linux.it>", "List-Help": "<mailto:ltp-request@lists.linux.it?subject=help>", "List-Subscribe": "<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>", "From": "Wake Liu via ltp <ltp@lists.linux.it>", "Reply-To": "Wake Liu <wakel@google.com>", "Cc": "Wake Liu <wakel@google.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it", "Sender": "\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>" }, "content": "The syscalls file_getattr and file_setattr return EOPNOTSUPP instead of\nEFAULT when the ufattr argument is NULL on tmpfs without xattr support\n(CONFIG_TMPFS_XATTR=n). This is because the kernel checks for the\nfilesystem operation support before dereferencing the user pointer.\n\nThis patch adds a runtime check for CONFIG_TMPFS_XATTR when testing\non tmpfs, ensuring the correct errno is expected based on the kernel\nconfiguration. This prevents hiding potential kernel bugs where\nEOPNOTSUPP might be returned even when xattr is supported.\n\nChanges in v2:\n- Replaced the TST_EXP_FAIL_ARR approach with a dynamic check in run().\n- Included tst_kconfig.h and used tst_kconfig_check() to verify\n CONFIG_TMPFS_XATTR status.\n- Expected EOPNOTSUPP only on tmpfs when xattr support is missing,\n otherwise default to EFAULT.\n\nSigned-off-by: Wake Liu <wakel@google.com>\n---\n testcases/kernel/syscalls/file_attr/file_attr01.c | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/testcases/kernel/syscalls/file_attr/file_attr01.c b/testcases/kernel/syscalls/file_attr/file_attr01.c\nindex c9c9288a1..43e0f0503 100644\n--- a/testcases/kernel/syscalls/file_attr/file_attr01.c\n+++ b/testcases/kernel/syscalls/file_attr/file_attr01.c\n@@ -18,6 +18,7 @@\n \n #include <string.h>\n #include \"tst_test.h\"\n+#include \"tst_kconfig.h\"\n #include \"lapi/fs.h\"\n #include \"lapi/fcntl.h\"\n \n@@ -115,20 +116,28 @@ static struct tcase {\n static void run(unsigned int i)\n {\n \tstruct tcase *tc = &tcases[i];\n+\tint exp_errno = tc->exp_errno;\n+\n+\tif (tc->ufattr == (struct file_attr **)(&null_ptr)) {\n+\t\tconst char *const kconfig[] = {\"CONFIG_TMPFS_XATTR=y\", NULL};\n+\n+\t\tif (!strcmp(tst_device->fs_type, \"tmpfs\") && tst_kconfig_check(kconfig))\n+\t\t\texp_errno = EOPNOTSUPP;\n+\t}\n \n \tif (tst_variant) {\n \t\tTST_EXP_FAIL(file_getattr(\n \t\t\t*tc->dfd, *tc->filename,\n \t\t\t*tc->ufattr, *tc->usize,\n \t\t\ttc->at_flags),\n-\t\t\ttc->exp_errno,\n+\t\t\texp_errno,\n \t\t\t\"%s\", tc->msg);\n \t} else {\n \t\tTST_EXP_FAIL(file_setattr(\n \t\t\t*tc->dfd, *tc->filename,\n \t\t\t*tc->ufattr, *tc->usize,\n \t\t\ttc->at_flags),\n-\t\t\ttc->exp_errno,\n+\t\t\texp_errno,\n \t\t\t\"%s\", tc->msg);\n \t}\n }\n", "prefixes": [ "v2" ] }