Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2214293/?format=api
{ "id": 2214293, "url": "http://patchwork.ozlabs.org/api/patches/2214293/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260320212824.264252-1-bvanassche@acm.org/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260320212824.264252-1-bvanassche@acm.org>", "list_archive_url": null, "date": "2026-03-20T21:28:24", "name": "[iwl-net,v4] ice: fix locking in ice_dcb_rebuild()", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "bf595b753a475c1abb47016da600718234a1f98f", "submitter": { "id": 3511, "url": "http://patchwork.ozlabs.org/api/people/3511/?format=api", "name": "Bart Van Assche", "email": "bvanassche@acm.org" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260320212824.264252-1-bvanassche@acm.org/mbox/", "series": [ { "id": 496920, "url": "http://patchwork.ozlabs.org/api/series/496920/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496920", "date": "2026-03-20T21:28:24", "name": "[iwl-net,v4] ice: fix locking in ice_dcb_rebuild()", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/496920/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2214293/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2214293/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=MWj1MInk;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fcwft1jQ2z1xyt\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 21 Mar 2026 08:28:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E679141E77;\n\tFri, 20 Mar 2026 21:28:49 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id agmAZWOm1lxp; Fri, 20 Mar 2026 21:28:48 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 06DF041E6D;\n\tFri, 20 Mar 2026 21:28:48 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id ADF0725C\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 21:28:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 93B9A848D2\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 21:28:46 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZEq5lhUSNE8T for <intel-wired-lan@lists.osuosl.org>;\n Fri, 20 Mar 2026 21:28:45 +0000 (UTC)", "from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 7BD71848CB\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 21:28:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by 013.lax.mailroute.net (Postfix) with ESMTP id 4fcwfh2YFszlfpM6;\n Fri, 20 Mar 2026 21:28:44 +0000 (UTC)", "from 013.lax.mailroute.net ([127.0.0.1])\n by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP\n id X29t86ALwCta; Fri, 20 Mar 2026 21:28:40 +0000 (UTC)", "from bvanassche.mtv.corp.google.com (unknown [104.135.180.219])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n (Authenticated sender: bvanassche@acm.org)\n by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fcwfY6FrrzlfvpL;\n Fri, 20 Mar 2026 21:28:37 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org", "by MailRoute" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 06DF041E6D", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7BD71848CB" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774042128;\n\tbh=E26FYxc8wFxoRO3tK3QNRl4t1EimTsqjdbEJ3zG8sHM=;\n\th=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=MWj1MInkpKJ2Z4VkFHuVMGh6qdCv24p9KVgnOFhwBk6e5Wgc9F7uDkPtg3Qht1WZF\n\t zwH48S2IvQh3vgyu+A4tjggqxUUJBrRqyPUxEMnnRemyWmoxo+gHLh5vyvY8PZp3aw\n\t 8lrNQty02LJ7OaCrWJgkUsIHNFu/N5oG96Tx7XOvIXftesAwpagQAwMPywhSB7qYwe\n\t vM0eUmxbRINOlZzO+r6frLpY9u5W7svY8+iopoKlGRSw5S/jQ4i/E/yk3E2aqfuYE4\n\t fxXYc2KGKA47JrM2BEijRhRPEHW+WshqqqpTOV+DLuNSsjzFQWi6ybtZACYqJECr1e\n\t U90+5sGUM44kw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=199.89.1.16;\n helo=013.lax.mailroute.net; envelope-from=bvanassche@acm.org;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 7BD71848CB", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>", "Cc": "Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n intel-wired-lan@lists.osuosl.org, Bart Van Assche <bvanassche@acm.org>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Fri, 20 Mar 2026 14:28:24 -0700", "Message-ID": "<20260320212824.264252-1-bvanassche@acm.org>", "X-Mailer": "git-send-email 2.53.0.959.g497ff81fa9-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=acm.org; h=\n content-transfer-encoding:mime-version:x-mailer:message-id:date\n :date:subject:subject:from:from:received:received; s=mr01; t=\n 1774042120; x=1776634121; bh=E26FYxc8wFxoRO3tK3QNRl4t1EimTsqjdbE\n J3zG8sHM=; b=YJawdxt4oC9yp8KYDgd73MLR58EVim8aNX2V2S+m6t4aFOEq6Dv\n GkdfqqSnro2ZzmMUelIOfl2VbzOLX+HRTHM10Gn3bOEEEDM+dFBWpbDiAusnstiG\n jRrmeKlqPvllUQXw8/Gi3T5oUgcKDOHuP2po1sxJBeIk1FBmv/YdK/Q1XKglN2ZU\n 8n0oYYzXshDPCRmhK9yH/tqIXjzd/m8RaDqdYHXzeJ/Y4UzApdjAu8/4628OX7xQ\n IlHnP28KAfghKzwKkRgkci/7uKvksYSBK6/lFSV+9xPyABP5dtZ8pGbPFXw+3OIc\n WOCtJ86PFXikdQqDY1r1hA8Mlk+GyWRUMvA==", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=acm.org", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=acm.org header.i=@acm.org header.a=rsa-sha256\n header.s=mr01 header.b=YJawdxt4" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v4] ice: fix locking in\n ice_dcb_rebuild()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "From": "Bart Van Assche via Intel-wired-lan <intel-wired-lan@osuosl.org>", "Reply-To": "Bart Van Assche <bvanassche@acm.org>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Move the mutex_lock() call up to prevent that DCB settings change after\nthe first ice_query_port_ets() call. The second ice_query_port_ets()\ncall in ice_dcb_rebuild() is already protected by pf->tc_mutex.\n\nThis also fixes a bug in an error path, as before taking the first\n\"goto dcb_error\" in the function jumped over mutex_lock() to\nmutex_unlock().\n\nThis bug has been detected by the clang thread-safety analyzer.\n\nCc: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nCc: intel-wired-lan@lists.osuosl.org\nFixes: 242b5e068b25 (\"ice: Fix DCB rebuild after reset\")\nSigned-off-by: Bart Van Assche <bvanassche@acm.org>\n---\n\nv4 (this patch): Changed \"[PATCH] iwl-net:\" into \"[PATCH iwl-net]\".\n\nv3 (2026-03-20): Modified patch description. See also\n https://lore.kernel.org/all/20260223220102.2158611-20-bart.vanassche@linux.dev/#t\n\nv2 (2026-02-23): Combined the two patches into one patch and\n increased the amount of code covered by tc_mutex. See also\n https://lore.kernel.org/all/20260223220102.2158611-20-bart.vanassche@linux.dev/\n\nv1 (2025-02-06): Two patches. See also\n https://lore.kernel.org/all/20250206175114.1974171-16-bvanassche@acm.org/\n\n drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\nindex bd77f1c001ee..78ded6876581 100644\n--- a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n@@ -537,14 +537,14 @@ void ice_dcb_rebuild(struct ice_pf *pf)\n \tstruct ice_dcbx_cfg *err_cfg;\n \tint ret;\n \n+\tmutex_lock(&pf->tc_mutex);\n+\n \tret = ice_query_port_ets(pf->hw.port_info, &buf, sizeof(buf), NULL);\n \tif (ret) {\n \t\tdev_err(dev, \"Query Port ETS failed\\n\");\n \t\tgoto dcb_error;\n \t}\n \n-\tmutex_lock(&pf->tc_mutex);\n-\n \tif (!pf->hw.port_info->qos_cfg.is_sw_lldp)\n \t\tice_cfg_etsrec_defaults(pf->hw.port_info);\n \n", "prefixes": [ "iwl-net", "v4" ] }