Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2213742/?format=api
{ "id": 2213742, "url": "http://patchwork.ozlabs.org/api/patches/2213742/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260320051034.425089-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260320051034.425089-1-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-20T05:10:34", "name": "[net,v1] ice: fix LLDP AQ filter fallback not working on E82x and E830 hardware", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "cd716e492c7fe4ed71070236dfa6ac07174e7e3e", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260320051034.425089-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 496758, "url": "http://patchwork.ozlabs.org/api/series/496758/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496758", "date": "2026-03-20T05:10:34", "name": "[net,v1] ice: fix LLDP AQ filter fallback not working on E82x and E830 hardware", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/496758/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2213742/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2213742/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=XISQl1MX;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fcVyB2HRcz1y0H\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Mar 2026 16:10:42 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B2F6441C64;\n\tFri, 20 Mar 2026 05:10:40 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ORevZZfygCts; Fri, 20 Mar 2026 05:10:40 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E897E41C61;\n\tFri, 20 Mar 2026 05:10:39 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 6E7BF1B6\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 05:10:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 543894062A\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 05:10:38 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Wa1BgMxU6T8c for <intel-wired-lan@lists.osuosl.org>;\n Fri, 20 Mar 2026 05:10:37 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.20])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 5435440176\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 05:10:37 +0000 (UTC)", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Mar 2026 22:10:37 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa008.jf.intel.com with ESMTP; 19 Mar 2026 22:10:36 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org E897E41C61", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5435440176" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773983440;\n\tbh=Q4YZ77oFPtMSn3vu86EQb5yAFgSiVuzgK2al9ZPKO9Q=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=XISQl1MXSZyA/lvLAKcpy/mIJx/T5iw13HHBk2GNLGwPSB2QM6bNPfUmciizo2opY\n\t Zi1ckEA7bmyaMmGKCdliyNu6ObXUHAigxfrNBwDVaFVrytkWEXxr2FVLbnqVDLFUey\n\t FqkZgfEKskA0pSA2dYpVnF3tDv/MErZNjzW38H0zFb6XM9goBqWpk4qtkb7GSy8YgG\n\t iiNS3X+nfQeqrRhkf8zEx6Pk7duSPP27mr+pSyBpDgEsODn+bR7eUzM24PXG7Zxc49\n\t lJ7pdfq0aFBDlYBfAsf6uN0y9dpmdPR2qYUMi8yxsODHCM8MDO63/eloo/+0ly7ckM\n\t U0WzSLUcgR3cg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.20;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 5435440176", "X-CSE-ConnectionGUID": [ "ibq4Rr7XT+W8rZR96D0MZw==", "nCdl/dMvR1iQdNZR947FQw==" ], "X-CSE-MsgGUID": [ "WWLIKOD0QkiIXm1tERw/qw==", "68WIwvocTteh9O2OkhjPIA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11734\"; a=\"74768355\"", "E=Sophos;i=\"6.23,130,1770624000\"; d=\"scan'208\";a=\"74768355\"", "E=Sophos;i=\"6.23,130,1770624000\"; d=\"scan'208\";a=\"223203575\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org", "Date": "Fri, 20 Mar 2026 06:10:34 +0100", "Message-ID": "<20260320051034.425089-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1773983437; x=1805519437;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=mUlw4KKtOe5/k/P2JJKYxdQldfA6ieZg8A8WlRsueFw=;\n b=Q+gHXPIIsP25KNEJ/wAzrMpuaEeKFVM9Fci5ee27XSVFengYUiHGDCwH\n Iby/tripDMNfaU7muLHwXrMSwMoSYs18gDS1GyeXv1WRDMIg/4Rj4XUN4\n Y73ZhUoXJVRSeibB7pToRVSjtn5MpRczaG3a78qa6yIj50q66l/2gDynP\n xmrU77s6UGUizkYL3VIgq6AMBB9/XD+bQmVMeWi+L1sJZ4joU+w1dReZw\n SHdMlbqdgQpFCLV2VleefIFP132d5opycXIqkG3rNi4sUqUjKXuyLyihh\n DNqLO1AwnLt36Pa0EzXBtO/mKQRMWdG2LQzZxSQpE6r+XOf5YhgFro0RT\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=Q+gHXPII" ], "Subject": "[Intel-wired-lan] [PATCH net v1] ice: fix LLDP AQ filter fallback\n not working on E82x and E830 hardware", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Commit 4d5a1c4e6d49 (\"ice: do not add LLDP-specific filter if not\nnecessary\") restructured ice_vsi_cfg_sw_lldp() to first attempt a\ngeneric ethernet Rx filter and, on failure, fall back to the specialized\nLLDP filter control AQ command (0x0A0A) via ice_lldp_fltr_add_remove().\nThis fallback is gated by ice_fw_supports_lldp_fltr_ctrl(), which only\naccepted E810, causing two distinct omissions.\n\nE82x (ICE_MAC_GENERIC, e.g. E822/E823) support the same LLDP filter\ncontrol AQ command with the same minimum firmware API version as E810\n(>= 1.7.1). On E82x systems where the generic ethernet LLDP Rx filter\ncannot be added, the AQ fallback silently returns -EOPNOTSUPP and the\nport is left with no LLDP Rx filter.\n\nE830 has been supported since kernel 6.9 and implements the same AQ\ncommand but requires a higher minimum API version (>= 1.7.11). Starting\nwith NVM 1.2 / FW 7.9.1, the generic ethernet LLDP Rx filter path is\nblocked on E830, making the AQ fallback the only viable option. With\nice_fw_supports_lldp_fltr_ctrl() returning false for E830, no LLDP Rx\nfilter is installed after a firmware-update-triggered reset (e.g. NVM\n1.1->1.2 on an E830-CC in HPE DL380 Gen11), and the interface stays\nlink-down with complete loss of network connectivity.\n\nReplace the single-type if-chain with a switch on hw->mac_type so each\nfamily's version requirement is explicit. E810 and E82x share the 1.7.1\nconstants; E830 gets its own 1.7.11 constants. The default branch returns\nfalse, covering any future MAC type that does not implement the command.\n\nFixes: 4d5a1c4e6d49 (\"ice: do not add LLDP-specific filter if not necessary\")\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_common.c | 23 ++++++++++++++++-----\n drivers/net/ethernet/intel/ice/ice_type.h | 7 ++++++-\n 2 files changed, 24 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\nindex ce11fea..78a075c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.c\n+++ b/drivers/net/ethernet/intel/ice/ice_common.c\n@@ -6372,15 +6372,28 @@ ice_aq_set_lldp_mib(struct ice_hw *hw, u8 mib_type, void *buf, u16 buf_size,\n /**\n * ice_fw_supports_lldp_fltr_ctrl - check NVM version supports lldp_fltr_ctrl\n * @hw: pointer to HW struct\n+ *\n+ * Check if firmware supports the LLDP filter control feature (AQ command\n+ * 0x0A0A). Different hardware families require different minimum firmware\n+ * API versions:\n+ * - E810 and E82x: API version >= 1.7.1\n+ * - E830: API version >= 1.7.11\n */\n bool ice_fw_supports_lldp_fltr_ctrl(struct ice_hw *hw)\n {\n-\tif (hw->mac_type != ICE_MAC_E810)\n+\tswitch (hw->mac_type) {\n+\tcase ICE_MAC_E830:\n+\t\treturn ice_is_fw_api_min_ver(hw, ICE_FW_API_LLDP_FLTR_MAJ_E830,\n+\t\t\t\t\t ICE_FW_API_LLDP_FLTR_MIN_E830,\n+\t\t\t\t\t ICE_FW_API_LLDP_FLTR_PATCH_E830);\n+\tcase ICE_MAC_E810:\n+\tcase ICE_MAC_GENERIC:\n+\t\treturn ice_is_fw_api_min_ver(hw, ICE_FW_API_LLDP_FLTR_MAJ,\n+\t\t\t\t\t ICE_FW_API_LLDP_FLTR_MIN,\n+\t\t\t\t\t ICE_FW_API_LLDP_FLTR_PATCH);\n+\tdefault:\n \t\treturn false;\n-\n-\treturn ice_is_fw_api_min_ver(hw, ICE_FW_API_LLDP_FLTR_MAJ,\n-\t\t\t\t ICE_FW_API_LLDP_FLTR_MIN,\n-\t\t\t\t ICE_FW_API_LLDP_FLTR_PATCH);\n+\t}\n }\n \n /**\ndiff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h\nindex 1e82f4c..03de54f 100644\n--- a/drivers/net/ethernet/intel/ice/ice_type.h\n+++ b/drivers/net/ethernet/intel/ice/ice_type.h\n@@ -1215,11 +1215,16 @@ struct ice_aq_get_set_rss_lut_params {\n \n #define ICE_SR_WORDS_IN_1KB\t\t512\n \n-/* AQ API version for LLDP_FILTER_CONTROL */\n+/* AQ API version for LLDP_FILTER_CONTROL - E810 and E82x */\n #define ICE_FW_API_LLDP_FLTR_MAJ\t1\n #define ICE_FW_API_LLDP_FLTR_MIN\t7\n #define ICE_FW_API_LLDP_FLTR_PATCH\t1\n \n+/* AQ API version for LLDP_FILTER_CONTROL - E830 */\n+#define ICE_FW_API_LLDP_FLTR_MAJ_E830\t\t1\n+#define ICE_FW_API_LLDP_FLTR_MIN_E830\t\t7\n+#define ICE_FW_API_LLDP_FLTR_PATCH_E830\t11\n+\n /* AQ API version for report default configuration */\n #define ICE_FW_API_REPORT_DFLT_CFG_MAJ\t\t1\n #define ICE_FW_API_REPORT_DFLT_CFG_MIN\t\t7\n", "prefixes": [ "net", "v1" ] }