Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2213741/?format=api
{ "id": 2213741, "url": "http://patchwork.ozlabs.org/api/patches/2213741/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260320050556.422762-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260320050556.422762-1-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-20T05:05:56", "name": "[iwl-next] ice: use ice_fill_eth_hdr() in ice_fill_sw_rule()", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "2b32359c40ed29da07d6b3dfb33a47a8022d1060", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260320050556.422762-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 496757, "url": "http://patchwork.ozlabs.org/api/series/496757/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496757", "date": "2026-03-20T05:05:56", "name": "[iwl-next] ice: use ice_fill_eth_hdr() in ice_fill_sw_rule()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/496757/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2213741/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2213741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=hZgpcuWh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fcVrr0rhwz1xxW\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Mar 2026 16:06:04 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 969D2617A3;\n\tFri, 20 Mar 2026 05:06:02 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Lc9OBs5oHkxz; Fri, 20 Mar 2026 05:06:01 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 1FEAE617A1;\n\tFri, 20 Mar 2026 05:06:01 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id D791625C\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 05:05:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id BDB1E41398\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 05:05:59 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 1gGeHSLMZAdZ for <intel-wired-lan@lists.osuosl.org>;\n Fri, 20 Mar 2026 05:05:58 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp2.osuosl.org (Postfix) with ESMTPS id B6CA740176\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 05:05:58 +0000 (UTC)", "from orviesa010.jf.intel.com ([10.64.159.150])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Mar 2026 22:05:59 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa010.jf.intel.com with ESMTP; 19 Mar 2026 22:05:57 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1FEAE617A1", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org B6CA740176" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773983161;\n\tbh=mbaf63ZzqfY4I8B7uPgoLGLIHL6DFbD38yudVPaB9hA=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=hZgpcuWhbXDsDf8ofUnLWUUJAwVwBpXB2KQYni80ZgILemNkskEkLvhsJX12BrSQ9\n\t /ZeDFcf+rMLWRC+22WS+sPHddZ6yWeaVH/v1Z7cc1iof7X490NZXKZ+xNE9j3wEIPX\n\t OWN2lEiR3jwiEbcWY/PY8AdNkpowmz5gYwHJs2nT9KVFRgbK1zjsEvNaiVIF5jMSs1\n\t 2iJKZK88rTOqmjSAEY9+TkrF8N21Q5JtYs/vhHSPqonui5yFEupfTwoBbLvm153slO\n\t DtFIxCnDetHxEdI9rebvC5tvje5iDdw64LDBHPpBfkj6WoLaX0LRt1sm6ml9Ak4Koy\n\t cr7G2XkTwzVYw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org B6CA740176", "X-CSE-ConnectionGUID": [ "6m9JdcdJTYGZWH7u4qe9Qw==", "RJ3+qZZdRzeIErmzfNHdcQ==" ], "X-CSE-MsgGUID": [ "h39RwX9lR9S77BUusoMa4Q==", "YbQQwoUQRu+C4tpP1NTBhA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11734\"; a=\"75251823\"", "E=Sophos;i=\"6.23,130,1770624000\"; d=\"scan'208\";a=\"75251823\"", "E=Sophos;i=\"6.23,130,1770624000\"; d=\"scan'208\";a=\"222399193\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org, Marcin Szycik <marcin.szycik@intel.com>,\n Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@intel.com>", "Date": "Fri, 20 Mar 2026 06:05:56 +0100", "Message-ID": "<20260320050556.422762-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1773983159; x=1805519159;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=LxEywRrRZkpe4jxH/2u4lRCW8+puW7+zbqXpiIYZ+7k=;\n b=FSpctJReDHQGlGgG/Svkm0Uq3o+GiPG7G4/Hkp0k4PlmqrDMuHn1HbT1\n eamUCwJugI19Y2h7M4c7Yr3intSzOBOCoahHUpvVmSgRfjtvIWPEOP/L2\n qkYfwqgjKB7q0gFK22oCDNJXQK+1abpyXdP2C1sMpop/r5kjnKiT12zSO\n Ge9WPHYcnttbP+IwFDNuwZLNrYL/N+E3x9WpUSnHSYoE2hu2qwm02vd3q\n YP6GrSLfuCzubGIKv50YTX90lBbTHwEwSUWdLqTPXN0ECfYMo9Q13MHnx\n BmAHppklNBzHeyhLLfT4b4CnDQQVbTMrjuRxGUdB03YqpF/fqr+MynUK8\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=FSpctJRe" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next] ice: use ice_fill_eth_hdr() in\n ice_fill_sw_rule()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Marcin Szycik <marcin.szycik@intel.com>\n\nUse the already existing helper function to fill Ethernet header. Also\nreplace sizeof with a (also existing) macro to reduce the number of\nvariables.\n\nSuggested-by: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@intel.com>\nSigned-off-by: Marcin Szycik <marcin.szycik@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_switch.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c\nindex bb0f990..6496534 100644\n--- a/drivers/net/ethernet/intel/ice/ice_switch.c\n+++ b/drivers/net/ethernet/intel/ice/ice_switch.c\n@@ -2612,7 +2612,6 @@ ice_fill_sw_rule(struct ice_hw *hw, struct ice_fltr_info *f_info,\n \tu16 vlan_id = ICE_MAX_VLAN_ID + 1;\n \tu16 vlan_tpid = ETH_P_8021Q;\n \tvoid *daddr = NULL;\n-\tu16 eth_hdr_sz;\n \tu8 *eth_hdr;\n \tu32 act = 0;\n \t__be16 *off;\n@@ -2625,11 +2624,10 @@ ice_fill_sw_rule(struct ice_hw *hw, struct ice_fltr_info *f_info,\n \t\treturn;\n \t}\n \n-\teth_hdr_sz = sizeof(dummy_eth_header);\n \teth_hdr = s_rule->hdr_data;\n \n \t/* initialize the ether header with a dummy header */\n-\tmemcpy(eth_hdr, dummy_eth_header, eth_hdr_sz);\n+\tice_fill_eth_hdr(eth_hdr);\n \tice_fill_sw_info(hw, f_info);\n \n \tswitch (f_info->fltr_act) {\n@@ -2730,7 +2728,7 @@ ice_fill_sw_rule(struct ice_hw *hw, struct ice_fltr_info *f_info,\n \n \t/* Create the switch rule with the final dummy Ethernet header */\n \tif (opc != ice_aqc_opc_update_sw_rules)\n-\t\ts_rule->hdr_len = cpu_to_le16(eth_hdr_sz);\n+\t\ts_rule->hdr_len = cpu_to_le16(DUMMY_ETH_HDR_LEN);\n }\n \n /**\n", "prefixes": [ "iwl-next" ] }