Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2213738/?format=api
{ "id": 2213738, "url": "http://patchwork.ozlabs.org/api/patches/2213738/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260320050544.422640-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260320050544.422640-1-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-20T05:05:44", "name": "[iwl-next] ice: prevent integer overflow", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "b6c0756fd86700c9fed5bb901d9e5a6af64885ae", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260320050544.422640-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 496754, "url": "http://patchwork.ozlabs.org/api/series/496754/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496754", "date": "2026-03-20T05:05:44", "name": "[iwl-next] ice: prevent integer overflow", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/496754/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2213738/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2213738/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=TO1l0BsG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fcVrc2B4Tz1xxW\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Mar 2026 16:05:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id CDD49617A2;\n\tFri, 20 Mar 2026 05:05:50 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id uOdjaxZJkt1S; Fri, 20 Mar 2026 05:05:50 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 0A7CF6179C;\n\tFri, 20 Mar 2026 05:05:50 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 7490625C\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 05:05:48 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 6663841398\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 05:05:48 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fFof5HxuQP5s for <intel-wired-lan@lists.osuosl.org>;\n Fri, 20 Mar 2026 05:05:47 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp2.osuosl.org (Postfix) with ESMTPS id B1E9E40176\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Mar 2026 05:05:47 +0000 (UTC)", "from orviesa010.jf.intel.com ([10.64.159.150])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Mar 2026 22:05:47 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa010.jf.intel.com with ESMTP; 19 Mar 2026 22:05:46 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0A7CF6179C", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org B1E9E40176" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773983150;\n\tbh=RbxkWCKjnyLo4sjH7GA5zQ2P4H9UP0gib2PxP9NwLfo=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=TO1l0BsG/pOIYhWFcPRcIpHYHiQZ9f2/kD60sljoxAPJJDMFbEJ7HFMiu4rF1GWOr\n\t 3J8Cq805XhfgqycnbxlaPOxcpwxffngiJuPWIoWEsxdeVOAlj7BWlQioNwxC+bllZK\n\t QweQjwc8amLTuwxNtCLBizNzG79s8SY5ECOdupxIWJvz33Cvdf00MGX4lfp6GMha+Z\n\t 85Zr/7WgNJC+2OINjPAMwr0p9LbCFhmIVK7t1M+wDfY0vOS5mnhRooNU3TT9erYURS\n\t 0Kku1rHICwtKUYsSj9B6rjUdUuLmT3wBVXTFttvWREGuI4NwmEsi81vxn6Vy2XniaP\n\t MlYmnhTUd/SCQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org B1E9E40176", "X-CSE-ConnectionGUID": [ "NFgQlUdFQ56I1NgDzHQ8XQ==", "GhOkh8fsRsy7umJCDo+W2A==" ], "X-CSE-MsgGUID": [ "ZskzFhmgSZKhYkxJRIebAw==", "YqqaZk+oSm2reQOSuI4i/A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11734\"; a=\"75251813\"", "E=Sophos;i=\"6.23,130,1770624000\"; d=\"scan'208\";a=\"75251813\"", "E=Sophos;i=\"6.23,130,1770624000\"; d=\"scan'208\";a=\"222399163\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tLukasz Czapnik <lukasz.czapnik@intel.com>", "Date": "Fri, 20 Mar 2026 06:05:44 +0100", "Message-ID": "<20260320050544.422640-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1773983148; x=1805519148;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=QtubdldAllXyG0emmWV/zJMO0HuQ0Y0WQHq1vT6skuQ=;\n b=cnQem81JCxtXC6rGVuxLk5/+8Nncl82X9yaovggTnNKCFYtPGlz0n+tP\n ossTqhXXS24QZBpRf3mQ3qEu+LMyj1x60/Kei7grQ05CC25jMWBtuKrer\n WHsgbeCuAzQoWmqnchkJ2QnW2SAh11bFeGUyKlu5U0HkeA4hbp/hTAJgJ\n 42SDX4X9I6xtOLEbLc3QUTrCGCUiXEP/kd0n4pM7Rh9PS64IX9YuVt0RY\n 6lfHMACm0uXHEnicktMb5UMkN2tVTz3H2dbZEVrfc7bphQcRIkbW/xQjO\n 7k1Wypb7U8YQDrlboF3BxwT7s7Ymj7MKM136j1ic/gfzTVTiqoNGVNhb2\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=cnQem81J" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next] ice: prevent integer overflow", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Lukasz Czapnik <lukasz.czapnik@intel.com>\n\nIn ice_sched_bw_to_rl_profile(), the loop over 64 bits computes the\nscheduler timestamp rate as:\n\n ts_rate = div64_long((s64)hw->psm_clk_freq,\n pow_result * ICE_RL_PROF_TS_MULTIPLIER);\n\nwhere pow_result = BIT_ULL(i). For large values of i, the product\npow_result * ICE_RL_PROF_TS_MULTIPLIER overflows u64 before being used\nas the divisor, producing incorrect ts_rate values and potentially\nundefined behaviour.\n\nFix this by pre-computing ts_freq = hw->psm_clk_freq /\nICE_RL_PROF_TS_MULTIPLIER once before the loop and then dividing only\nby pow_result inside the loop. The division order avoids the overflow\nwhile preserving the same mathematical result. Declare ts_freq as s64\nto match the type domain of the surrounding arithmetic and avoid a\nredundant cast at the use site.\n\nWhile at it, scope the loop variable i to the for statement itself.\n\nFixes: 1ddef455f4a8 (\"ice: Add NDO callback to set the maximum per-queue bitrate\")\nSigned-off-by: Lukasz Czapnik <lukasz.czapnik@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_sched.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_sched.c b/drivers/net/ethernet/intel/ice/ice_sched.c\nindex fff0c1a..edea262c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sched.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sched.c\n@@ -3237,12 +3237,12 @@ static int\n ice_sched_bw_to_rl_profile(struct ice_hw *hw, u32 bw,\n \t\t\t struct ice_aqc_rl_profile_elem *profile)\n {\n+\ts64 ts_freq = hw->psm_clk_freq / ICE_RL_PROF_TS_MULTIPLIER;\n \ts64 bytes_per_sec, ts_rate, mv_tmp;\n \tint status = -EINVAL;\n \tbool found = false;\n \ts32 encode = 0;\n \ts64 mv = 0;\n-\ts32 i;\n \n \t/* Bw settings range is from 0.5Mb/sec to 100Gb/sec */\n \tif (bw < ICE_SCHED_MIN_BW || bw > ICE_SCHED_MAX_BW)\n@@ -3255,8 +3255,7 @@ ice_sched_bw_to_rl_profile(struct ice_hw *hw, u32 bw,\n-\tfor (i = 0; i < 64; i++) {\n+\tfor (int i = 0; i < 64; i++) {\n \t\tu64 pow_result = BIT_ULL(i);\n \n-\t\tts_rate = div64_long((s64)hw->psm_clk_freq,\n-\t\t\t\t pow_result * ICE_RL_PROF_TS_MULTIPLIER);\n+\t\tts_rate = div64_long(ts_freq, pow_result);\n \t\tif (ts_rate <= 0)\n \t\t\tcontinue;\n \n", "prefixes": [ "iwl-next" ] }