Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2213567/?format=api
{ "id": 2213567, "url": "http://patchwork.ozlabs.org/api/patches/2213567/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260319224159.23885-1-emil.s.tantilov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260319224159.23885-1-emil.s.tantilov@intel.com>", "list_archive_url": null, "date": "2026-03-19T22:41:59", "name": "[iwl-net,v2] idpf: fix xdp crash in soft reset error path", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "8eceb8b06a5609cdfc3d27cb6d9709d6e213c545", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260319224159.23885-1-emil.s.tantilov@intel.com/mbox/", "series": [ { "id": 496725, "url": "http://patchwork.ozlabs.org/api/series/496725/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496725", "date": "2026-03-19T22:41:59", "name": "[iwl-net,v2] idpf: fix xdp crash in soft reset error path", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/496725/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2213567/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2213567/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=kX1/FOk/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fcLKk1ZYjz1xyt\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Mar 2026 09:42:01 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B30E440BF7;\n\tThu, 19 Mar 2026 22:41:59 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id lJ1x6yBi1UOH; Thu, 19 Mar 2026 22:41:59 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id F253240B68;\n\tThu, 19 Mar 2026 22:41:58 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 2D9D825C\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 22:41:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 7E4F740E0A\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 22:41:57 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ajRBwOmphePV for <intel-wired-lan@lists.osuosl.org>;\n Thu, 19 Mar 2026 22:41:56 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.19])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 730804127C\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 22:41:56 +0000 (UTC)", "from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Mar 2026 15:41:54 -0700", "from estantil-desk.jf.intel.com ([10.166.241.24])\n by orviesa007.jf.intel.com with ESMTP; 19 Mar 2026 15:41:53 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org F253240B68", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 730804127C" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773960119;\n\tbh=saz8XRSorsaiipg6521Aj2lNXTTo1+lPMfuS0rj39UI=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=kX1/FOk/HRGfbo06KTwWTm3eD69kojaaR6W8vY/pA0WdHATtQp8mseUC0c4824bUm\n\t 2yiKsYWEQIykRcopC3TehH5dGflMdWtOD3QDh9gOiflOJIEhB7ADxyN0sJzTQGuJTU\n\t hjhW4A4z7zeBZ8rtPmiGBXuEPCx4r6CgfZEN2esWtga0qoKFbxyRuw6tKzpzJNWuTI\n\t 7aUlKiwcBA/WwV5tH3bqpIYnfpHq7TtsmJ6UnvUj98rFAvL2BEI+uPib20mNJPYTcA\n\t 8Qey6HxZvUH/r8rQWpl3HEjVsXkzUJom9TkHk+Gn3O8ZDfpj3rlZo30eA2pUE24tTL\n\t Ch4SDUvVmQXtQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.19;\n helo=mgamail.intel.com; envelope-from=emil.s.tantilov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 730804127C", "X-CSE-ConnectionGUID": [ "vq3Z8qcuQ+Wymf1b/+/4UQ==", "cjgj4rPqS52u0ucCRTXghw==" ], "X-CSE-MsgGUID": [ "9e45JixyT4OThBf/aHujIQ==", "7P+ErQc7SHKpge4J3R2xDA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11734\"; a=\"74060148\"", "E=Sophos;i=\"6.23,130,1770624000\"; d=\"scan'208\";a=\"74060148\"", "E=Sophos;i=\"6.23,130,1770624000\"; d=\"scan'208\";a=\"223326020\"" ], "X-ExtLoop1": "1", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com, przemyslaw.kitszel@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,\n hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me,\n bpf@vger.kernel.org, aleksander.lobakin@intel.com, decot@google.com,\n willemb@google.com, Emil Tantilov <emil.s.tantilov@intel.com>,\n stable@vger.kernel.org", "Date": "Thu, 19 Mar 2026 15:41:59 -0700", "Message-Id": "<20260319224159.23885-1-emil.s.tantilov@intel.com>", "X-Mailer": "git-send-email 2.17.2", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1773960116; x=1805496116;\n h=from:to:cc:subject:date:message-id;\n bh=w42GVYaBOiENOnZTs/bf+y6P5cN1lu44uYlM0XIDM0A=;\n b=I1JwJQpl7aVXUiWUETz/DQ8gBTrzfMNVvVk9L939LkakZ+T9jC5KR0IL\n Xt9RapGN4mCQBNaGqNMMJYRbT4Q1dhj7ke9BA0X3TRBIMK2LO5WxJqL9m\n ZJNaSj+iF6Cnwi5+ijtWaI916gDBRO3k5+nMU2Wxn+CUii0eVqT03A1uP\n 4gOXMVgVkvY3URPgzZ1s+Lm/nji3aWeR9ifzx3cG07yhzgsb1IlRadKSJ\n ks7SXBGwMjxASPQxDdOLnA0rxjzKprH4EPDtN1jbze3v5yU+RMRqdE3da\n ltli5vT7cofA9R3c9rxhPfGn5z2vvB6Va25a9F/Z4u5LCjESbDHzSnZYc\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=I1JwJQpl" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v2] idpf: fix xdp crash in soft\n reset error path", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "NULL pointer dereference is reported in cases where idpf_vport_open()\nfails during soft reset:\n\n./xdpsock -i <inf> -q -r -N\n\n[ 3179.186687] idpf 0000:83:00.0: Failed to initialize queue ids for vport 0: -12\n[ 3179.276739] BUG: kernel NULL pointer dereference, address: 0000000000000010\n[ 3179.277636] #PF: supervisor read access in kernel mode\n[ 3179.278470] #PF: error_code(0x0000) - not-present page\n[ 3179.279285] PGD 0\n[ 3179.280083] Oops: Oops: 0000 [#1] SMP NOPTI\n...\n[ 3179.283997] Workqueue: events xp_release_deferred\n[ 3179.284770] RIP: 0010:idpf_find_rxq_vec+0x17/0x30 [idpf]\n...\n[ 3179.291937] Call Trace:\n[ 3179.292392] <TASK>\n[ 3179.292843] idpf_qp_switch+0x25/0x820 [idpf]\n[ 3179.293325] idpf_xsk_pool_setup+0x7c/0x520 [idpf]\n[ 3179.293803] idpf_xdp+0x59/0x240 [idpf]\n[ 3179.294275] xp_disable_drv_zc+0x62/0xb0\n[ 3179.294743] xp_clear_dev+0x40/0xb0\n[ 3179.295198] xp_release_deferred+0x1f/0xa0\n[ 3179.295648] process_one_work+0x226/0x730\n[ 3179.296106] worker_thread+0x19e/0x340\n[ 3179.296557] ? __pfx_worker_thread+0x10/0x10\n[ 3179.297009] kthread+0xf4/0x130\n[ 3179.297459] ? __pfx_kthread+0x10/0x10\n[ 3179.297910] ret_from_fork+0x32c/0x410\n[ 3179.298361] ? __pfx_kthread+0x10/0x10\n[ 3179.298702] ret_from_fork_asm+0x1a/0x30\n\nFix the error handling of the soft reset in idpf_xdp_setup_prog() by\nrestoring the vport->xdp_prog to the old value. This avoids referencing\nthe orphaned prog that was copied to vport->xdp_prog in the soft reset\nand prevents subsequent false positive by idpf_xdp_enabled().\n\nUpdate the restart check in idpf_xsk_pool_setup() to use IDPF_VPORT_UP bit\ninstead of netif_running(). The idpf_vport_stop/start() calls will not\nupdate the __LINK_STATE_START bit, making this test a false positive\nshould the soft reset fail.\n\nFixes: 3d57b2c00f09 (\"idpf: add XSk pool initialization\")\nCc: stable@vger.kernel.org\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\nChangelog:\nv1->v2:\n- Cleaned up the error handling in idpf_xdp_setup_prog() to avoid extra\n check and bpf_prog_put() call in the error path and fixed indentation\n at the assignment of restart. Caught in review by Alexander Lobakin.\n\nv1:\nhttps://lore.kernel.org/netdev/20260318011545.12874-1-emil.s.tantilov@intel.com/\n---\n drivers/net/ethernet/intel/idpf/xdp.c | 1 +\n drivers/net/ethernet/intel/idpf/xsk.c | 4 +++-\n 2 files changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/xdp.c b/drivers/net/ethernet/intel/idpf/xdp.c\nindex cbccd4546768..18a6e7062863 100644\n--- a/drivers/net/ethernet/intel/idpf/xdp.c\n+++ b/drivers/net/ethernet/intel/idpf/xdp.c\n@@ -488,6 +488,7 @@ static int idpf_xdp_setup_prog(struct idpf_vport *vport,\n \t\t\t\t \"Could not reopen the vport after XDP setup\");\n \n \t\tcfg->user_config.xdp_prog = old;\n+\t\tvport->xdp_prog = old;\n \t\told = prog;\n \t}\n \ndiff --git a/drivers/net/ethernet/intel/idpf/xsk.c b/drivers/net/ethernet/intel/idpf/xsk.c\nindex d95d3efdfd36..3d8c430efd2b 100644\n--- a/drivers/net/ethernet/intel/idpf/xsk.c\n+++ b/drivers/net/ethernet/intel/idpf/xsk.c\n@@ -553,6 +553,7 @@ int idpf_xskrq_poll(struct idpf_rx_queue *rxq, u32 budget)\n \n int idpf_xsk_pool_setup(struct idpf_vport *vport, struct netdev_bpf *bpf)\n {\n+\tconst struct idpf_netdev_priv *np = netdev_priv(vport->netdev);\n \tstruct xsk_buff_pool *pool = bpf->xsk.pool;\n \tu32 qid = bpf->xsk.queue_id;\n \tbool restart;\n@@ -568,7 +569,8 @@ int idpf_xsk_pool_setup(struct idpf_vport *vport, struct netdev_bpf *bpf)\n \t\treturn -EINVAL;\n \t}\n \n-\trestart = idpf_xdp_enabled(vport) && netif_running(vport->netdev);\n+\trestart = idpf_xdp_enabled(vport) &&\n+\t\t test_bit(IDPF_VPORT_UP, np->state);\n \tif (!restart)\n \t\tgoto pool;\n \n", "prefixes": [ "iwl-net", "v2" ] }