Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2213241/?format=api
{ "id": 2213241, "url": "http://patchwork.ozlabs.org/api/patches/2213241/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260319135859.690041-1-lgs201920130244@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260319135859.690041-1-lgs201920130244@gmail.com>", "list_archive_url": null, "date": "2026-03-19T13:58:59", "name": "[v2] ice: fix double free in ice_sf_eth_activate() error path", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "75893f052f062f0c633430b16b092e0b497ea6eb", "submitter": { "id": 91722, "url": "http://patchwork.ozlabs.org/api/people/91722/?format=api", "name": "Guangshuo Li", "email": "lgs201920130244@gmail.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260319135859.690041-1-lgs201920130244@gmail.com/mbox/", "series": [ { "id": 496655, "url": "http://patchwork.ozlabs.org/api/series/496655/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496655", "date": "2026-03-19T13:58:59", "name": "[v2] ice: fix double free in ice_sf_eth_activate() error path", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/496655/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2213241/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2213241/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=BgpqC+IN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fc6kr10v7z1y1P\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Mar 2026 00:59:32 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id A45ED8423B;\n\tThu, 19 Mar 2026 13:59:30 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id la0F-Bn23bux; Thu, 19 Mar 2026 13:59:29 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id EFA4584237;\n\tThu, 19 Mar 2026 13:59:28 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 7ADF91AD\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 13:59:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 6C7FB84237\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 13:59:27 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id RDmd0w-iAIdG for <intel-wired-lan@lists.osuosl.org>;\n Thu, 19 Mar 2026 13:59:27 +0000 (UTC)", "from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com\n [IPv6:2607:f8b0:4864:20::42e])\n by smtp1.osuosl.org (Postfix) with ESMTPS id C25CB84234\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 13:59:26 +0000 (UTC)", "by mail-pf1-x42e.google.com with SMTP id\n d2e1a72fcca58-82a73593410so412194b3a.1\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 06:59:26 -0700 (PDT)", "from lgs.. ([223.80.110.53]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82a6b56df09sm6237700b3a.21.2026.03.19.06.59.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Mar 2026 06:59:25 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org EFA4584237", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org C25CB84234" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773928769;\n\tbh=FM5u2uHSz/VZ9Qz362czB/Bn/2senFQYOZTR+Pv+J5M=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=BgpqC+INwqTU2LwTt8lIz/BJIbr81Pb/C8iMkd2B12QNeqLVU6O313rMyytlzuogk\n\t 48SMj2LNpGOYBa55275GC9k+H2rkPeHL/gsuuRkuAJcSOW062X6U9qJbAYMTYeRR9D\n\t cJHlrRN3naMTr4oP2ucSmOQld4iD7YI7m6AtTX7xJiweeyD8qoVImxVk10O2xHVs/D\n\t AeAh3deBNnDR0HY/d4xdF79smRx2BLRnHSbllDvK0yyCky6kFJS+ZAswcSAQY4jXw4\n\t Z4ZQZQ/iDS3D1m3tVNMgpyKA3fPyem+hu0jNrjYe5JcYlWn15WzpoPKNOHXYWhmii6\n\t Z933Zh+q3975w==", "Received-SPF": "Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::42e; helo=mail-pf1-x42e.google.com;\n envelope-from=lgs201920130244@gmail.com; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org C25CB84234", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1773928766; x=1774533566;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FM5u2uHSz/VZ9Qz362czB/Bn/2senFQYOZTR+Pv+J5M=;\n b=WbbVmhIo+qHAFsGac0KHNyCS76BPqOZYpTo4v773AbwKEMkTPBW38D5M4r1R8n+LvU\n bdqTIBj0TQsmRvg6L92sEu6N1H6QmBagKnBQ77RLsA86VFXF/5AHlx19j90RGLBq/l9f\n 1/BaEoUqCWfeZzF+PuQtYorZVjqeWzw1dYcYpAkUsxKtp03tVro0Ob15wam03xznpe0v\n /a2b/MIRIw5ZRjeVvV71sWLYKD+EVVyRQIitaJ2EErUV40qlWQvh3tw+PQrU/rC1cMaf\n AEx0LFTBI8J0Ilafc7EOdt8QsTi7Vue6rZBlM9xuYAPmyyKM81OYWwGPfSPw6euzPaHV\n vnWg==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVCtvdgHZ/yycS+FEZbNYxNWNhHPPLaI5zq08J9zni6zbxsw5ZdOZPXSfY+n1bLOVpVoRBlbeRuMAjiTG6jv90=@lists.osuosl.org", "X-Gm-Message-State": "AOJu0YxJ9JpGAYbsQDkSOltCS1maa6VTW+V4xZuE3AKmUgm2nYcyUAnZ\n J0go0ko7LxMZFfxTRw5NZ1pHQVNW+V/4hKiywOYUo45v40GbPHtazLHs", "X-Gm-Gg": "ATEYQzz0J5Gm3S18A2/HVUiCKh00vkg86rTtn5d88Fwu/mCAAs7yTG94g7muZUG6FO5\n x8I0S5xOiWL+3dF/Xa6L0QBJr+eQzd+OyzN+VVGMZG9Jgf9sAL4OJW58PRAV0OFnEBfHORQMuQ/\n Y9LFi6J4AYlGARPVlVZdZEofzJxCkuLcmae5SJHse0QmMrZFFFekel0jPz6GrzBJULav8qpgPQx\n uB6GC107mTcAtQK8tDgBrqARnc9jrTomPAhKsI0VylBGd98GniDy2VIRrSSkUMj4vsK5hBq5pQA\n U+56dwSPTPPEezD9ViejTAYf83kwi1cXllf9bzJm5hHoBxpWg0jqHIoiV0+miv6Pcx6hLNxOtfE\n vtveszES/fFFBDKrDVF4B55sJpd/Ao2zZc8WTA19urYLq9G3XTykxwszCK3c67GkLsm3O/acaDG\n GlTexB0TMas3IVqQX7AaJF", "X-Received": "by 2002:a05:6a00:3319:b0:82a:6255:247b with SMTP id\n d2e1a72fcca58-82a6ae78489mr6376248b3a.62.1773928765908;\n Thu, 19 Mar 2026 06:59:25 -0700 (PDT)", "From": "Guangshuo Li <lgs201920130244@gmail.com>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Piotr Raczynski <piotr.raczynski@intel.com>,\n Simon Horman <horms@kernel.org>, intel-wired-lan@lists.osuosl.org,\n netdev@vger.kernel.org, linux-kernel@vger.kernel.org", "Cc": "Guangshuo Li <lgs201920130244@gmail.com>, stable@vger.kernel.org,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Thu, 19 Mar 2026 21:58:59 +0800", "Message-ID": "<20260319135859.690041-1-lgs201920130244@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1773928766; x=1774533566; darn=lists.osuosl.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=FM5u2uHSz/VZ9Qz362czB/Bn/2senFQYOZTR+Pv+J5M=;\n b=e0QgKZElbk3Ed5pybrFvXe36f6OlO6yhchW09lZfuJ6jnJG0n9JLDTsD+x4yWocJdA\n Y9g+d5LKtVWzwOhke/42aFstqtfshr133bdwpDULpexRgMX+aOlgRfUmSiCtR8jMmkfk\n fah4xReyhVQNQsgKpiPaWZNN/5FazD6w1ZpBo0uiNS9wWWTNpQ9R3EjQrJezN1A2XNDY\n KCoWPeun6UBG6VNN7AOmYRLrcm1pMyceKZ2DimJq+qUWGkVOKy6WNltZGRMN1gcpcsY0\n YUbVeLQTInj4iL2vc+Ok15QLT9r8ZLafeDbaGflVXp33Xd0gov2kgyztTgZ0FtUEFt+5\n Gr2Q==", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=e0QgKZEl" ], "Subject": "[Intel-wired-lan] [PATCH v2] ice: fix double free in\n ice_sf_eth_activate() error path", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When auxiliary_device_add() fails, ice_sf_eth_activate() jumps to\naux_dev_uninit and calls auxiliary_device_uninit(&sf_dev->adev).\n\nThe device release callback ice_sf_dev_release() frees sf_dev, but\nthe current error path falls through to sf_dev_free and calls\nkfree(sf_dev) again, causing a double free.\n\nKeep kfree(sf_dev) for the auxiliary_device_init() failure path, but\navoid falling through to sf_dev_free after auxiliary_device_uninit().\n\nFixes: 13acc5c4cdbe (\"ice: subfunction activation and base devlink ops\")\nCc: stable@vger.kernel.org\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Guangshuo Li <lgs201920130244@gmail.com>\n---\nv2:\n - replace goto xa_erase with return err after auxiliary_device_uninit()\n - avoid xa_erase() in the auxiliary_device_uninit() path since it is already\n done in ice_sf_dev_release()\n\n drivers/net/ethernet/intel/ice/ice_sf_eth.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_sf_eth.c b/drivers/net/ethernet/intel/ice/ice_sf_eth.c\nindex 1a2c94375ca7..f7266d036815 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sf_eth.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sf_eth.c\n@@ -305,6 +305,8 @@ ice_sf_eth_activate(struct ice_dynamic_port *dyn_port,\n \n aux_dev_uninit:\n \tauxiliary_device_uninit(&sf_dev->adev);\n+\treturn err;\n+\n sf_dev_free:\n \tkfree(sf_dev);\n xa_erase:\n", "prefixes": [ "v2" ] }