Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2213155/?format=api
{ "id": 2213155, "url": "http://patchwork.ozlabs.org/api/patches/2213155/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260319111659.551039-1-przemyslaw.korba@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260319111659.551039-1-przemyslaw.korba@intel.com>", "list_archive_url": null, "date": "2026-03-19T11:13:27", "name": "[iwl-net,v2] ice: fix posted write support for sideband queue operations", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "473114fcec3eb3fd9fe848bd593d981c6fc6573e", "submitter": { "id": 89670, "url": "http://patchwork.ozlabs.org/api/people/89670/?format=api", "name": "Korba, Przemyslaw", "email": "przemyslaw.korba@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260319111659.551039-1-przemyslaw.korba@intel.com/mbox/", "series": [ { "id": 496615, "url": "http://patchwork.ozlabs.org/api/series/496615/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496615", "date": "2026-03-19T11:13:27", "name": "[iwl-net,v2] ice: fix posted write support for sideband queue operations", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/496615/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2213155/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2213155/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=fMSXAwNS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fc35s6t3Pz1xyt\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Mar 2026 22:15:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 786EC818CD;\n\tThu, 19 Mar 2026 11:15:43 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pIvXRW5ixAlM; Thu, 19 Mar 2026 11:15:42 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B408084158;\n\tThu, 19 Mar 2026 11:15:42 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 5A9301AD\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 11:15:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 445EB84158\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 11:15:41 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 7a6pcku_MAJ9 for <intel-wired-lan@lists.osuosl.org>;\n Thu, 19 Mar 2026 11:15:40 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 82FD6818CD\n for <intel-wired-lan@lists.osuosl.org>; Thu, 19 Mar 2026 11:15:40 +0000 (UTC)", "from orviesa005.jf.intel.com ([10.64.159.145])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Mar 2026 04:15:40 -0700", "from pae-d-dell-r7525-263.igk.intel.com ([172.28.191.240])\n by orviesa005.jf.intel.com with ESMTP; 19 Mar 2026 04:15:37 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org B408084158", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 82FD6818CD" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773918942;\n\tbh=yaq6+Hhzp4zw0nkot33XSpte/mo6SWbXTSMNFnOdEXc=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=fMSXAwNSurI9ojwX3oEGfStHzQ4UvPmYHkqn8YyTgBYyBfBrTrXMt6USJM47Zufur\n\t Gnf4hxdDCHKg3xdkuCNYC0axcCDHasCxTLIJkch+CmJvjfVA6cKp4f+qTd+CZM6nBE\n\t ypEbyA8BvqKuDigRFk+5sAH+CDhJtPBKFPG+2DOnmNa6I4KOpxwXKaKwh5yvg3O9Ba\n\t dmBxFDFD1Didsn+g/KLbAgdbLUKy/d5mVs0ukIU4fizqIpxq896AgdeHHfZGf2wEUd\n\t jvSj+tOuHzR6z3dnwMu0VmlTS/GgoPrDJY5IPwUOGcni6F+Zilr1ADs+reBYhFKo2L\n\t O5qemKF0EHAmw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.7;\n helo=mgamail.intel.com; envelope-from=przemyslaw.korba@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 82FD6818CD", "X-CSE-ConnectionGUID": [ "6MDf4+NJQrC4aIH3GgOhhQ==", "AffE8heKRyec2BTK0xZLsw==" ], "X-CSE-MsgGUID": [ "3syTB2uSRl2uQ5mCfPAt+Q==", "RLvw22A1RIih9nqtA2HKzw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11733\"; a=\"100446755\"", "E=Sophos;i=\"6.23,129,1770624000\"; d=\"scan'208\";a=\"100446755\"", "E=Sophos;i=\"6.23,129,1770624000\"; d=\"scan'208\";a=\"227871884\"" ], "X-ExtLoop1": "1", "From": "Przemyslaw Korba <przemyslaw.korba@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, anthony.l.nguyen@intel.com,\n przemyslaw.kitszel@intel.com, Przemyslaw Korba <przemyslaw.korba@intel.com>", "Date": "Thu, 19 Mar 2026 12:13:27 +0100", "Message-ID": "<20260319111659.551039-1-przemyslaw.korba@intel.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1773918940; x=1805454940;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=b3u8qHqjs+0jCYSUxvjLhz4Rrt+YcdNbJ5aChfrAIdg=;\n b=hoAIAzCAtKZ6x005r8aqxzRJLGfkf9iJ+STY2VG7Zim4ncoxS6oIArvp\n UmYvxOuU3govG146B2DNCW6Bb4PKnfacRo9s+238luuW8NApP5HrBClsI\n uO8GdaqbQKBCVk3z3gJImItLp+ZWh4S5jLbqMPGni65osfaOl2CXb+UVK\n /qQ803uzVK0l/jRCPxUH4ttys1Pvpl2q4rWRy9bri0OTYRAOkbsAd8bsE\n 15VNnoJvqsmPf4/gspw9U5Kvr0+OrslRs5pORvNFjrATGm4x5kGiBsEzX\n RBUBp7M3zEnFHTPBUz9xjC0z1XeM9t+6ki5Agz6cwPXzIVmLjvZPCku1P\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=hoAIAzCA" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v2] ice: fix posted write support\n for sideband queue operations", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "On E830, PTP time adjustment commands sent via\nSBQ don't generate completion responses, causing the driver to\ntimeout waiting and return -EIO, when trying:\n\nphc_ctl eth8 get adj 2 get\ndmesg: ice 0000:1a:00.0: PTP failed to adjust time, err -5\n\nAdd support for posted mode not to wait for completion response.\n\nFixes: 8f5ee3c477a8 (\"ice: add support for sideband messages\")\nSigned-off-by: Przemyslaw Korba <przemyslaw.korba@intel.com>\n---\nv2:\n- change \"postpone\" to \"posted\"\n- init struct with {} instead of {0}\nv1:\nhttps://lore.kernel.org/intel-wired-lan/20260310110700.345904-1-przemyslaw.korba@intel.com/\n\n drivers/net/ethernet/intel/ice/ice_common.c | 7 ++++++-\n drivers/net/ethernet/intel/ice/ice_controlq.c | 4 ++++\n drivers/net/ethernet/intel/ice/ice_controlq.h | 1 +\n 3 files changed, 11 insertions(+), 1 deletion(-)\n\n\nbase-commit: acd2abc52dea91c3bc3d1b6dd8a92b9631d48bbf", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\nindex 8866902efb91..c89c6ca1281b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.c\n+++ b/drivers/net/ethernet/intel/ice/ice_common.c\n@@ -1765,6 +1765,7 @@ int ice_sbq_rw_reg(struct ice_hw *hw, struct ice_sbq_msg_input *in, u16 flags)\n {\n \tstruct ice_sbq_cmd_desc desc = {0};\n \tstruct ice_sbq_msg_req msg = {0};\n+\tstruct ice_sq_cd cd = {};\n \tu16 msg_len;\n \tint status;\n \n@@ -1785,10 +1786,14 @@ int ice_sbq_rw_reg(struct ice_hw *hw, struct ice_sbq_msg_input *in, u16 flags)\n \t\t */\n \t\tmsg_len -= sizeof(msg.data);\n \n+\tif (in->opcode == ice_sbq_msg_wr)\n+\t\tcd.posted = 1;\n+\n \tdesc.flags = cpu_to_le16(flags);\n \tdesc.opcode = cpu_to_le16(ice_sbq_opc_neigh_dev_req);\n \tdesc.param0.cmd_len = cpu_to_le16(msg_len);\n-\tstatus = ice_sbq_send_cmd(hw, &desc, &msg, msg_len, NULL);\n+\tstatus = ice_sbq_send_cmd(hw, &desc, &msg, msg_len, &cd);\n+\n \tif (!status && !in->opcode)\n \t\tin->data = le32_to_cpu\n \t\t\t(((struct ice_sbq_msg_cmpl *)&msg)->data);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_controlq.c b/drivers/net/ethernet/intel/ice/ice_controlq.c\nindex dcb837cadd18..a6008dc77fa4 100644\n--- a/drivers/net/ethernet/intel/ice/ice_controlq.c\n+++ b/drivers/net/ethernet/intel/ice/ice_controlq.c\n@@ -1086,6 +1086,10 @@ ice_sq_send_cmd(struct ice_hw *hw, struct ice_ctl_q_info *cq,\n \twr32(hw, cq->sq.tail, cq->sq.next_to_use);\n \tice_flush(hw);\n \n+\t/* If the message is posted, don't wait for completion. */\n+\tif (cd && cd->posted)\n+\t\tgoto sq_send_command_error;\n+\n \t/* Wait for the command to complete. If it finishes within the\n \t * timeout, copy the descriptor back to temp.\n \t */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_controlq.h b/drivers/net/ethernet/intel/ice/ice_controlq.h\nindex 788040dd662e..c50d6fcbacba 100644\n--- a/drivers/net/ethernet/intel/ice/ice_controlq.h\n+++ b/drivers/net/ethernet/intel/ice/ice_controlq.h\n@@ -77,6 +77,7 @@ struct ice_ctl_q_ring {\n /* sq transaction details */\n struct ice_sq_cd {\n \tstruct libie_aq_desc *wb_desc;\n+\tu8 posted : 1;\n };\n \n /* rq event information */\n", "prefixes": [ "iwl-net", "v2" ] }