Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2211723/?format=api
{ "id": 2211723, "url": "http://patchwork.ozlabs.org/api/patches/2211723/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260317062205.39406-3-kohei@enjuk.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260317062205.39406-3-kohei@enjuk.jp>", "list_archive_url": null, "date": "2026-03-17T06:21:46", "name": "[iwl-next,v2,2/2] igc: enable build_skb on the non-XDP small-frame RX path", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "c0aeafe87ffe61753970e444e5a9dd8d63f3aee4", "submitter": { "id": 92459, "url": "http://patchwork.ozlabs.org/api/people/92459/?format=api", "name": "Kohei Enju", "email": "kohei@enjuk.jp" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260317062205.39406-3-kohei@enjuk.jp/mbox/", "series": [ { "id": 496198, "url": "http://patchwork.ozlabs.org/api/series/496198/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496198", "date": "2026-03-17T06:21:44", "name": "igc: enable build_skb path", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/496198/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2211723/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2211723/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=4kSBTMXN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fZhhp3QPYz1xyt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Mar 2026 17:22:50 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 5108F81434;\n\tTue, 17 Mar 2026 06:22:46 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id BNpGwRd5j9Wk; Tue, 17 Mar 2026 06:22:44 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 83B9F8144F;\n\tTue, 17 Mar 2026 06:22:44 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 1F63B3BE\n for <intel-wired-lan@lists.osuosl.org>; Tue, 17 Mar 2026 06:22:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 10AB941442\n for <intel-wired-lan@lists.osuosl.org>; Tue, 17 Mar 2026 06:22:42 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Ac6T1f8xZrrQ for <intel-wired-lan@lists.osuosl.org>;\n Tue, 17 Mar 2026 06:22:41 +0000 (UTC)", "from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91])\n by smtp4.osuosl.org (Postfix) with ESMTPS id D6ED641414\n for <intel-wired-lan@lists.osuosl.org>; Tue, 17 Mar 2026 06:22:40 +0000 (UTC)", "from ms-a2 (16.4.31.150.dy.iij4u.or.jp [150.31.4.16])\n (authenticated bits=0)\n by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 62H6MFGB069015\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Tue, 17 Mar 2026 15:22:15 +0900 (JST) (envelope-from kohei@enjuk.jp)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 83B9F8144F", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org D6ED641414" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773728564;\n\tbh=U0c0no8qOQMhS+4Ff84jEoupUlPveySfmNiJKU+YoOs=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=4kSBTMXNjiwPmu1iL8vdSvsVTIw2lG17UqyCEQ8qqyCOwS57PPqts2wKteRq+2+e5\n\t 2yMlk9rsqKM6MZYh4TecYJrk3KRx9XUy1Pc+3h/94gpNWDH4rWzQwQesGFoThddwEZ\n\t TtVUZj7oqGj7+7tpFY55382fcY/eGbaM12KiTiikhzWnXjxP+0MH7+HuPQ2YJSf1cb\n\t 9orm7BT5KxvJHO7AUOPoviP1Y/uPeUrxhBFEaDxbegp88n9I8ZpZcjdigKHzHRPeEA\n\t PLlEp+4eR4NxnZ7E/tB7WhO5cq/wuZeu+7ZxCUGcaZLBinYkQXhqD8lWThB4fj9mk9\n\t 3j1z9bEaiMsOA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91;\n helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org D6ED641414", "From": "Kohei Enju <kohei@enjuk.jp>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Cc": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, dima.ruinskiy@intel.com,\n kohei.enju@gmail.com, Kohei Enju <kohei@enjuk.jp>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Tue, 17 Mar 2026 06:21:46 +0000", "Message-ID": "<20260317062205.39406-3-kohei@enjuk.jp>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260317062205.39406-1-kohei@enjuk.jp>", "References": "<20260317062205.39406-1-kohei@enjuk.jp>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "a=rsa-sha256;\n bh=U0c0no8qOQMhS+4Ff84jEoupUlPveySfmNiJKU+YoOs=;\n c=relaxed/relaxed; d=enjuk.jp;\n h=From:Message-ID:To:Subject:Date;\n s=rs20251215; t=1773728536; v=1;\n b=TJTOZ7+V/mCxUCGS7AljPoa45TxfGqhV/+/mADeZuHUN8prPHkhvj8GtK/oST9Nr\n sLavL70/izk6R8YpKdEEtkdZTCH6isRAMaxYc465Pny7DOyWbSSWo1iHMd5ZJPy/\n ZND8Knn15TV1BtThtOnkdQybVzOLf2Or6hfIFqsyp18T4t6FySh8XvNnqXuWgAK0\n A9/njzdVf6GGlfHZvCwQ8ss0NLCxtMhHG5fyY+4VPNi1K2QnjyV3DUNbCOU7/DBR\n T+J4STSBkhvC69fJCNIrVuXWOnUlTMLLlkfLOSVVtSLaMuJcQhHo7U3+yH/q+vtp\n Z95a+9WQTUSY6HeLhae1sQ==", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=enjuk.jp", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=enjuk.jp header.i=@enjuk.jp header.a=rsa-sha256\n header.s=rs20251215 header.b=TJTOZ7+V" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v2 2/2] igc: enable build_skb on\n the non-XDP small-frame RX path", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "igc implements igc_build_skb(), but it is currently unused because the\nIGC_RING_FLAG_RX_BUILD_SKB_ENABLED bit is never set. Enable the\nbuild_skb path when XDP is not active and the configured maximum frame\nsize fits within IGC_MAX_FRAME_BUILD_SKB.\n\nIn a single-queue small-packet (64-byte) RX microbenchmark on my setup,\nenabling build_skb improved the receive rate from about 3.11 Mpps to\nabout 3.30 Mpps, while reducing missed packets from about 484 kpps to\nabout 300 kpps.\n\nKeep the XDP path unchanged for now, since it uses a different RX buffer\nlayout based on XDP_PACKET_HEADROOM, and enabling it there would need\nseparate validation and buffer layout adjustments.\n\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Kohei Enju <kohei@enjuk.jp>\n---\n drivers/net/ethernet/intel/igc/igc.h | 4 ++++\n drivers/net/ethernet/intel/igc/igc_main.c | 4 ++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h\nindex e66799507f81..acbd2c237667 100644\n--- a/drivers/net/ethernet/intel/igc/igc.h\n+++ b/drivers/net/ethernet/intel/igc/igc.h\n@@ -734,6 +734,10 @@ enum igc_ring_flags_t {\n \n #define ring_uses_build_skb(ring) \\\n \ttest_bit(IGC_RING_FLAG_RX_BUILD_SKB_ENABLED, &(ring)->flags)\n+#define set_ring_uses_build_skb(ring) \\\n+\tset_bit(IGC_RING_FLAG_RX_BUILD_SKB_ENABLED, &(ring)->flags)\n+#define clear_ring_uses_build_skb(ring) \\\n+\tclear_bit(IGC_RING_FLAG_RX_BUILD_SKB_ENABLED, &(ring)->flags)\n \n static inline unsigned int igc_rx_bufsz(struct igc_ring *ring)\n {\ndiff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 79192b02e6be..b44f89311a4e 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -474,6 +474,7 @@ static void igc_clean_rx_ring(struct igc_ring *ring)\n \t\tigc_clean_rx_ring_page_shared(ring);\n \n \tclear_ring_uses_large_buffer(ring);\n+\tclear_ring_uses_build_skb(ring);\n \n \tring->next_to_alloc = 0;\n \tring->next_to_clean = 0;\n@@ -654,6 +655,9 @@ static void igc_configure_rx_ring(struct igc_adapter *adapter,\n \n \tif (igc_xdp_is_enabled(adapter))\n \t\tset_ring_uses_large_buffer(ring);\n+\telse if (!(adapter->flags & IGC_FLAG_RX_LEGACY) &&\n+\t\t adapter->max_frame_size <= IGC_MAX_FRAME_BUILD_SKB)\n+\t\tset_ring_uses_build_skb(ring);\n \n \t/* disable the queue */\n \twr32(IGC_RXDCTL(reg_idx), 0);\n", "prefixes": [ "iwl-next", "v2", "2/2" ] }