Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2211722/?format=api
{ "id": 2211722, "url": "http://patchwork.ozlabs.org/api/patches/2211722/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260317062205.39406-2-kohei@enjuk.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260317062205.39406-2-kohei@enjuk.jp>", "list_archive_url": null, "date": "2026-03-17T06:21:45", "name": "[iwl-next,v2,1/2] igc: set RX hardware timestamps in igc_build_skb()", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "37cc5547ff675286ad4e872d831076cdcaec0034", "submitter": { "id": 92459, "url": "http://patchwork.ozlabs.org/api/people/92459/?format=api", "name": "Kohei Enju", "email": "kohei@enjuk.jp" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260317062205.39406-2-kohei@enjuk.jp/mbox/", "series": [ { "id": 496198, "url": "http://patchwork.ozlabs.org/api/series/496198/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496198", "date": "2026-03-17T06:21:44", "name": "igc: enable build_skb path", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/496198/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2211722/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2211722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=AWGYbqoN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fZhhl3NMTz1xyt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Mar 2026 17:22:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C802A4148A;\n\tTue, 17 Mar 2026 06:22:44 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Qub_eKWOXpN8; Tue, 17 Mar 2026 06:22:44 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id F159441442;\n\tTue, 17 Mar 2026 06:22:43 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id B38D33BE\n for <intel-wired-lan@lists.osuosl.org>; Tue, 17 Mar 2026 06:22:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id B12246085B\n for <intel-wired-lan@lists.osuosl.org>; Tue, 17 Mar 2026 06:22:41 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id hZAWO0v_D87D for <intel-wired-lan@lists.osuosl.org>;\n Tue, 17 Mar 2026 06:22:39 +0000 (UTC)", "from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 62C0C60825\n for <intel-wired-lan@lists.osuosl.org>; Tue, 17 Mar 2026 06:22:39 +0000 (UTC)", "from ms-a2 (16.4.31.150.dy.iij4u.or.jp [150.31.4.16])\n (authenticated bits=0)\n by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 62H6MBPV068957\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Tue, 17 Mar 2026 15:22:11 +0900 (JST) (envelope-from kohei@enjuk.jp)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org F159441442", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 62C0C60825" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773728564;\n\tbh=FSGEy83Ejkug+FTTykT/GYOYqYSI90bywuoJAtinwXs=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=AWGYbqoNkA+n7HlPjxo4oGnBvtBdDvY1BkP7LPRwaZX2SV/PgGF6H8sqkd3eW2I31\n\t 4XsXP+Zbg0j/zloOLSWaCFxzIrn8ZvOWhc6DAyzJ8YhNQlN0dA/3zvCfoSx5eFGJ2E\n\t 9Qw/6+ycxML9cN5AcOXZKg+wwdv2+1RFsbltJ16lLN2uxhRKgk//2N87sANP8KY+0B\n\t Odbhql4Hzl5YgaFU1o8gLBXi97kS4DDFSOC8yGVCDjZSMx5bObzp1ytGHNtC4zhy4x\n\t 2DGypGsccd2rauMSet3yxIj0YUoHxPrSstroTbr5epsWTOePGBhjocKwm0PRvH32hO\n\t TLPGoU8c7EUUg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91;\n helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 62C0C60825", "From": "Kohei Enju <kohei@enjuk.jp>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Cc": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, dima.ruinskiy@intel.com,\n kohei.enju@gmail.com, Kohei Enju <kohei@enjuk.jp>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Tue, 17 Mar 2026 06:21:45 +0000", "Message-ID": "<20260317062205.39406-2-kohei@enjuk.jp>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260317062205.39406-1-kohei@enjuk.jp>", "References": "<20260317062205.39406-1-kohei@enjuk.jp>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "a=rsa-sha256;\n bh=FSGEy83Ejkug+FTTykT/GYOYqYSI90bywuoJAtinwXs=;\n c=relaxed/relaxed; d=enjuk.jp;\n h=From:Message-ID:To:Subject:Date;\n s=rs20251215; t=1773728532; v=1;\n b=naFxhx571U3+TZ4vOApOb3aP/gHwlhPXLNOiF02sU0376595d9Mnd93qitlYL+QA\n 2Zrxmz+FB24w/waeqCRV5EqZY88RhK6AK607jBDe8+wY5kmf33ySX4LDtvKdeBTg\n czheDR4m62aqNPB+kyOo1JS3aLuFXbwpski5HEwx23xZohbEfYiHVt6tgtQSrhYu\n 6CO2fTOBe0zgCDHN/D7LmIkB0jjYaClSK97CFfkGB994kMKDbdF3fRkW0uokbkK5\n NkiePoxVCcImcnlQfL9Q/gR/u6ThxqgBww8fyjYhp0ai0w5LgNqK6+UoNoh+/5A1\n CstwXAic7Alo3VcUGftqlg==", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=enjuk.jp", "smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=enjuk.jp header.i=@enjuk.jp\n header.a=rsa-sha256 header.s=rs20251215 header.b=naFxhx57" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v2 1/2] igc: set RX hardware\n timestamps in igc_build_skb()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "igc_construct_skb() sets RX hardware timestamps, but igc_build_skb()\ndoes not. This has not been observable so far since igc currently does\nnot enable the build_skb RX path.\n\nSet RX hardware timestamps in igc_build_skb() as well so that both skb\nconstruction paths provide the same behavior.\n\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Kohei Enju <kohei@enjuk.jp>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex cad5a26cc84d..79192b02e6be 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -1964,8 +1964,9 @@ static void igc_add_rx_frag(struct igc_ring *rx_ring,\n \n static struct sk_buff *igc_build_skb(struct igc_ring *rx_ring,\n \t\t\t\t struct igc_rx_buffer *rx_buffer,\n-\t\t\t\t struct xdp_buff *xdp)\n+\t\t\t\t struct igc_xdp_buff *ctx)\n {\n+\tstruct xdp_buff *xdp = &ctx->xdp;\n \tunsigned int size = xdp->data_end - xdp->data;\n \tunsigned int truesize = igc_get_rx_frame_truesize(rx_ring, size);\n \tunsigned int metasize = xdp->data - xdp->data_meta;\n@@ -1979,6 +1980,11 @@ static struct sk_buff *igc_build_skb(struct igc_ring *rx_ring,\n \tif (unlikely(!skb))\n \t\treturn NULL;\n \n+\tif (ctx->rx_ts) {\n+\t\tskb_shinfo(skb)->tx_flags |= SKBTX_HW_TSTAMP_NETDEV;\n+\t\tskb_hwtstamps(skb)->netdev_data = ctx->rx_ts;\n+\t}\n+\n \t/* update pointers within the skb to store the data */\n \tskb_reserve(skb, xdp->data - xdp->data_hard_start);\n \t__skb_put(skb, size);\n@@ -2681,7 +2687,7 @@ static int igc_clean_rx_irq(struct igc_q_vector *q_vector, const int budget)\n \t\t} else if (skb)\n \t\t\tigc_add_rx_frag(rx_ring, rx_buffer, skb, size);\n \t\telse if (ring_uses_build_skb(rx_ring))\n-\t\t\tskb = igc_build_skb(rx_ring, rx_buffer, &ctx.xdp);\n+\t\t\tskb = igc_build_skb(rx_ring, rx_buffer, &ctx);\n \t\telse\n \t\t\tskb = igc_construct_skb(rx_ring, rx_buffer, &ctx);\n \n", "prefixes": [ "iwl-next", "v2", "1/2" ] }