Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2210433/?format=api
{ "id": 2210433, "url": "http://patchwork.ozlabs.org/api/patches/2210433/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260313082230.195208-1-mschmidt@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260313082230.195208-1-mschmidt@redhat.com>", "list_archive_url": null, "date": "2026-03-13T08:22:29", "name": "[iwl-net] ixgbevf: add missing negotiate_features op to Hyper-V ops table", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "98fc3120d6a452a0618eb52678068adb5c9c4663", "submitter": { "id": 1162, "url": "http://patchwork.ozlabs.org/api/people/1162/?format=api", "name": "Michal Schmidt", "email": "mschmidt@redhat.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260313082230.195208-1-mschmidt@redhat.com/mbox/", "series": [ { "id": 495745, "url": "http://patchwork.ozlabs.org/api/series/495745/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=495745", "date": "2026-03-13T08:22:29", "name": "[iwl-net] ixgbevf: add missing negotiate_features op to Hyper-V ops table", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/495745/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2210433/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2210433/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=iI3o2aVP;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fXHYc084Pz1xyW\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Mar 2026 19:23:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 45C8880FBA;\n\tFri, 13 Mar 2026 08:23:11 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id aJOsD4lt8mBp; Fri, 13 Mar 2026 08:23:10 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 6D1D280FBC;\n\tFri, 13 Mar 2026 08:23:10 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 1F15C201\n for <intel-wired-lan@lists.osuosl.org>; Fri, 13 Mar 2026 08:23:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 0450E80F4E\n for <intel-wired-lan@lists.osuosl.org>; Fri, 13 Mar 2026 08:23:09 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id FTLYQzLSRrh1 for <intel-wired-lan@lists.osuosl.org>;\n Fri, 13 Mar 2026 08:23:08 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id A27E980F4B\n for <intel-wired-lan@lists.osuosl.org>; Fri, 13 Mar 2026 08:23:07 +0000 (UTC)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-ekQ4lWhHNAe1UGNtzV4MHQ-1; Fri,\n 13 Mar 2026 04:23:02 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 3686D1953994; Fri, 13 Mar 2026 08:23:00 +0000 (UTC)", "from rhel-developer-toolbox-latest.redhat.com (unknown\n [10.45.224.182])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 3BB0219540C2; Fri, 13 Mar 2026 08:22:54 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6D1D280FBC", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org A27E980F4B" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773390190;\n\tbh=S8sQ0TAcroRGq0uf1yum4YwrjSAHtvMIJWZZlC5Jd9E=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=iI3o2aVPc5Q1h8rpStCGP2AC9su65XzeAoWMVmclMnVEAmhnn0DCSL9uzhEjUQVND\n\t ax3qmI61NDTsZD24mkxRdnsDNU7r8AaiEG5w1MMyxZiK6e9IG+VqIx/BlnFPZ8KFAb\n\t oSqFmBOlr+8igsd5h4BAJaYPB7F9LoVvswdIX7s/6yn5iZluUk1cfxXW0n4LW8W1Z6\n\t z4atjNKIcOLI4PlYwfuuNu+5Wgs9PHYvZrc2CEOFAUCLLBEj8K9ugGbqu5jWdEiPHp\n\t f9eXhpsry+aT3FJK8I7OOjUnafBZWz7DukbwQvmKE5UvAQlNnNTu5gZ2GF9eZPQmkx\n\t ltDxQWrEeH1cQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=mschmidt@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org A27E980F4B", "X-MC-Unique": "ekQ4lWhHNAe1UGNtzV4MHQ-1", "X-Mimecast-MFC-AGG-ID": "ekQ4lWhHNAe1UGNtzV4MHQ_1773390180", "From": "Michal Schmidt <mschmidt@redhat.com>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, Jacob Keller <jacob.e.keller@intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Jedrzej Jagielski <jedrzej.jagielski@intel.com>", "Cc": "Xiaoqiang Xiong <xxiong@redhat.com>, intel-wired-lan@lists.osuosl.org,\n netdev@vger.kernel.org, linux-kernel@vger.kernel.org", "Date": "Fri, 13 Mar 2026 09:22:29 +0100", "Message-ID": "<20260313082230.195208-1-mschmidt@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-MFC-PROC-ID": "ndZ60gdYGrmiLGnQGE0c8ak-OIrHElDwrWEdWTvZ0VM_1773390180", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1773390186;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=S8sQ0TAcroRGq0uf1yum4YwrjSAHtvMIJWZZlC5Jd9E=;\n b=Yqai50zM0fipkh5mHH0ov+83VxR2lBmG9Y+XelX7Bt3wNqsVr9z0jkRCjcwWcOxqdKOQbL\n jNssZWAS1tTZxct4/P3QufoO9ucynfT0w1iqvmNqJeJ67wZET3sT7tt7++IdnGEH63Mz+w\n VTCzB0Od5tjMYymqzaY1E1fhdn7gvT4=", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp1.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Yqai50zM" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net] ixgbevf: add missing\n negotiate_features op to Hyper-V ops table", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Commit a7075f501bd3 (\"ixgbevf: fix mailbox API compatibility by\nnegotiating supported features\") added the .negotiate_features callback\nto ixgbe_mac_operations and populated it in ixgbevf_mac_ops, but forgot\nto add it to ixgbevf_hv_mac_ops. This leaves the function pointer NULL\non Hyper-V VMs.\n\nDuring probe, ixgbevf_negotiate_api() calls ixgbevf_set_features(),\nwhich unconditionally dereferences hw->mac.ops.negotiate_features().\nOn Hyper-V this results in a NULL pointer dereference:\n\n BUG: kernel NULL pointer dereference, address: 0000000000000000\n [...]\n Hardware name: Microsoft Corporation Virtual Machine/Virtual Machine [...]\n Workqueue: events work_for_cpu_fn\n RIP: 0010:0x0\n [...]\n Call Trace:\n ixgbevf_negotiate_api+0x66/0x160 [ixgbevf]\n ixgbevf_sw_init+0xe4/0x1f0 [ixgbevf]\n ixgbevf_probe+0x20f/0x4a0 [ixgbevf]\n local_pci_probe+0x50/0xa0\n work_for_cpu_fn+0x1a/0x30\n [...]\n\nAdd ixgbevf_hv_negotiate_features_vf() that returns -EOPNOTSUPP and\nwire it into ixgbevf_hv_mac_ops. The caller already handles -EOPNOTSUPP\ngracefully.\n\nFixes: a7075f501bd3 (\"ixgbevf: fix mailbox API compatibility by negotiating supported features\")\nReported-by: Xiaoqiang Xiong <xxiong@redhat.com>\nCloses: https://issues.redhat.com/browse/RHEL-155455\nAssisted-by: Claude:claude-4.6-opus-high Cursor\nTested-by: Xiaoqiang Xiong <xxiong@redhat.com>\nSigned-off-by: Michal Schmidt <mschmidt@redhat.com>\n---\n drivers/net/ethernet/intel/ixgbevf/vf.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c\nindex b67b580f7f1c..f6df86d124b9 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c\n@@ -709,6 +709,12 @@ static int ixgbevf_negotiate_features_vf(struct ixgbe_hw *hw, u32 *pf_features)\n \treturn err;\n }\n \n+static int ixgbevf_hv_negotiate_features_vf(struct ixgbe_hw *hw,\n+\t\t\t\t\t u32 *pf_features)\n+{\n+\treturn -EOPNOTSUPP;\n+}\n+\n /**\n * ixgbevf_set_vfta_vf - Set/Unset VLAN filter table address\n * @hw: pointer to the HW structure\n@@ -1142,6 +1148,7 @@ static const struct ixgbe_mac_operations ixgbevf_hv_mac_ops = {\n \t.setup_link\t\t= ixgbevf_setup_mac_link_vf,\n \t.check_link\t\t= ixgbevf_hv_check_mac_link_vf,\n \t.negotiate_api_version\t= ixgbevf_hv_negotiate_api_version_vf,\n+\t.negotiate_features\t= ixgbevf_hv_negotiate_features_vf,\n \t.set_rar\t\t= ixgbevf_hv_set_rar_vf,\n \t.update_mc_addr_list\t= ixgbevf_hv_update_mc_addr_list_vf,\n \t.update_xcast_mode\t= ixgbevf_hv_update_xcast_mode,\n", "prefixes": [ "iwl-net" ] }