Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2206576/?format=api
{ "id": 2206576, "url": "http://patchwork.ozlabs.org/api/patches/2206576/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260307021247.1259624-1-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260307021247.1259624-1-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2026-03-07T02:12:47", "name": "[iwl-net] idpf: only assign num refillqs if allocation was successful", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c6dd89fd83976848d8dcc5dd662f81b1a2f15146", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260307021247.1259624-1-joshua.a.hay@intel.com/mbox/", "series": [ { "id": 494795, "url": "http://patchwork.ozlabs.org/api/series/494795/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=494795", "date": "2026-03-07T02:12:47", "name": "[iwl-net] idpf: only assign num refillqs if allocation was successful", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/494795/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2206576/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2206576/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=74MYVXoC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fSRNb4SJmz1xyl\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Mar 2026 13:02:06 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 1930F60AD6;\n\tSat, 7 Mar 2026 02:02:05 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id SyEjKxaugVwp; Sat, 7 Mar 2026 02:02:04 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 594A360AB3;\n\tSat, 7 Mar 2026 02:02:04 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id B2DA8223\n for <intel-wired-lan@lists.osuosl.org>; Sat, 7 Mar 2026 02:02:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 98AC540760\n for <intel-wired-lan@lists.osuosl.org>; Sat, 7 Mar 2026 02:02:02 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id e-FRgQNBeESE for <intel-wired-lan@lists.osuosl.org>;\n Sat, 7 Mar 2026 02:02:02 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n by smtp4.osuosl.org (Postfix) with ESMTPS id D917040707\n for <intel-wired-lan@lists.osuosl.org>; Sat, 7 Mar 2026 02:01:59 +0000 (UTC)", "from fmviesa003.fm.intel.com ([10.60.135.143])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Mar 2026 18:01:58 -0800", "from dcskidmo-m40.jf.intel.com ([10.166.241.14])\n by fmviesa003.fm.intel.com with ESMTP; 06 Mar 2026 18:01:58 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 594A360AB3", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org D917040707" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1772848924;\n\tbh=k6RP1YYCaVgYdHe1eehvjmD6K60u+lszZ6MYO4nThPg=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=74MYVXoCqpXjIXg4D5cZhEym5UQQXqccRNDh56vYxuOJ8yD/a5m4Jvuh8MHuOwI3S\n\t Q/rnLbwU1XPLMGQWGoIMniBKRbPhMAOrUVq9uFeT9kpvSkp98R76r2+zGpehzFHsLZ\n\t dSDm/qYOTcw71VU5YHhoyeUwASB+WfTRmzEVLPJcMvd1of1qAgfHxTFMR/ptJWpMDu\n\t KiqZqVHPkWEPDO3tGWL5Nc3hxritOSQiJUCM4j9DYc99fbNMvxIYnCTwt2Yu5xqQrt\n\t UcGPZ1tM/QIdAjijPoDNOgU98M5Jc4GbRTNBTzFnJeW+dlZ7VRrVGtMf/3tAL+5Zrr\n\t sSkWHdu1mKaeQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12;\n helo=mgamail.intel.com; envelope-from=joshua.a.hay@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org D917040707", "X-CSE-ConnectionGUID": [ "1lHM7RmsTy2dviLRTqZQAQ==", "GJOabdEYRmC0WpSeHeKghw==" ], "X-CSE-MsgGUID": [ "RrPmNGllQDCHPpSuQvJ4uQ==", "WPDC6zbAQAmqpcamPC/ELQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11721\"; a=\"77839205\"", "E=Sophos;i=\"6.23,105,1770624000\"; d=\"scan'208\";a=\"77839205\"" ], "X-ExtLoop1": "1", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, Joshua Hay <joshua.a.hay@intel.com>,\n Madhu Chittim <madhu.chittim@intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Fri, 6 Mar 2026 18:12:47 -0800", "Message-Id": "<20260307021247.1259624-1-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1772848921; x=1804384921;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=jq1XXb3w5dDHDIPGLpDnaXdLQU6hLD53Lqu7W/qctOE=;\n b=FO4JanwZugjFZIoJrMjkNcVL59f6T8eV6kq4SDvCEp/lOx7DMA2sSftN\n u64wPHBWG5jlWHShQWcmkzXmFICcI1fSbK1YV4J9LXcWRYFB5EGkX8Q9I\n VWqoOwWqzDfwh9H+/ARnFHnxTMoA2mtHf1+573DLTNeu2bEFXd10h8IV7\n Ss0Sf5V57beO+MXJIT90+l6/g1vAPJPHRx4Mf83JTjELpbw/qSZQtiDVd\n JPtucGVVz7Zi2MEJYhEwCVKZfJsycUBiFT53HleuWGl5glhbrO1rZdtS4\n Pn2aSAtyKAi+50K8rrL2o3OzwQLLtW57Wpri2cRkNcss5Cgictr/rV44p\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=FO4JanwZ" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net] idpf: only assign num refillqs if\n allocation was successful", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "As reported by AI review [1], if the refillqs allocation fails, refillqs\nwill be NULL but num_refillqs will be non-zero. The release function\nwill then dereference refillqs since it thinks the refillqs are present,\nresulting in a NULL ptr dereference.\n\nOnly assign the num refillqs if the allocation was successful. This will\nprevent the release function from entering the loop and accessing\nrefillqs.\n\n[1] https://lore.kernel.org/netdev/20260227035625.2632753-1-kuba@kernel.org/\n\nFixes: 95af467d9a4e3 (\"idpf: configure resources for RX queues\")\nSigned-off-by: Joshua Hay <joshua.a.hay@intel.com>\nReviewed-by: Madhu Chittim <madhu.chittim@intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\nindex 252259993022..f6b3b15364ff 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n@@ -1860,13 +1860,13 @@ static int idpf_rxq_group_alloc(struct idpf_vport *vport,\n \t\t\tidpf_queue_assign(HSPLIT_EN, q, hs);\n \t\t\tidpf_queue_assign(RSC_EN, q, rsc);\n \n-\t\t\tbufq_set->num_refillqs = num_rxq;\n \t\t\tbufq_set->refillqs = kcalloc(num_rxq, swq_size,\n \t\t\t\t\t\t GFP_KERNEL);\n \t\t\tif (!bufq_set->refillqs) {\n \t\t\t\terr = -ENOMEM;\n \t\t\t\tgoto err_alloc;\n \t\t\t}\n+\t\t\tbufq_set->num_refillqs = num_rxq;\n \t\t\tfor (unsigned int k = 0; k < bufq_set->num_refillqs; k++) {\n \t\t\t\tstruct idpf_sw_queue *refillq =\n \t\t\t\t\t&bufq_set->refillqs[k];\n", "prefixes": [ "iwl-net" ] }