Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2206457/?format=api
{ "id": 2206457, "url": "http://patchwork.ozlabs.org/api/patches/2206457/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260306181304.2426352-16-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260306181304.2426352-16-sjg@chromium.org>", "list_archive_url": null, "date": "2026-03-06T18:12:43", "name": "[v2,15/23] binman: test: Move symbol test files to test/symbols/", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "19029e64af05f87fe675275ae90eff6e0a0b4b63", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260306181304.2426352-16-sjg@chromium.org/mbox/", "series": [ { "id": 494765, "url": "http://patchwork.ozlabs.org/api/series/494765/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=494765", "date": "2026-03-06T18:12:28", "name": "binman: test: Organise test files into subdirectories", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/494765/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2206457/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2206457/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=dzcUAd+H;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"dzcUAd+H\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fSF2v2YCKz1xw1\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Mar 2026 05:16:07 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 70DAB8402F;\n\tFri, 6 Mar 2026 19:14:12 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 8DCCF8402F; Fri, 6 Mar 2026 19:14:11 +0100 (CET)", "from mail-qk1-x730.google.com (mail-qk1-x730.google.com\n [IPv6:2607:f8b0:4864:20::730])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id F1BB68382A\n for <u-boot@lists.denx.de>; Fri, 6 Mar 2026 19:14:07 +0100 (CET)", "by mail-qk1-x730.google.com with SMTP id\n af79cd13be357-8cb5c9ba82bso1498256785a.2\n for <u-boot@lists.denx.de>; Fri, 06 Mar 2026 10:14:07 -0800 (PST)", "from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8cd6f5736c0sm155930885a.49.2026.03.06.10.14.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 06 Mar 2026 10:14:03 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1772820846; x=1773425646; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rMe7GwndHKiAq8L2By8CItADKTCSSX79rLLaf5mshVM=;\n b=dzcUAd+HKcN0nSos51PYe5galyjm9dHn5x1Gu7LAZj0/oq8WbteINb8kx6el0Uv1ab\n Uw8pM3kvQYrlNQjgLLS63GybVQ0ZCjKe/tB8FgDemrFy9CE3Y5qvy74z0kIxPCLgAJda\n RBWFPlFGq2lONkITDsu0B7sh17V9iI3kXCniw=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1772820846; x=1773425646;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=rMe7GwndHKiAq8L2By8CItADKTCSSX79rLLaf5mshVM=;\n b=qBCDVEeEQml1R+pEBbXn+JcGfcOpnWq9UyWLIJBWBw5wS4YckENKLIH9sZrGzDjYSh\n zCbQRMmK9xuqkQgA3jKYf5IZ+nYRDiqAMg8/Z4YK55BnIGDpqPIHt5uOMpYtTnFLmy7M\n XT8LCRQw6C8XhWo4eY/KLWUUOa8A26Bex6lc+53HzSsfILU/TFdVAv5YBfBXcj6xd+ZX\n wV9k9yZq1PJvWlxdTc5nye7hIUS4VpJ7lgZ3q3jNOCM6R1+wzgFqy/lE5uM7z9gGOkUi\n Hy1r5So9wY7plKXt3zBb5NE3rJlD1PA0a2JKuAJ7WK1KU1lCullKnKIwkDpD75JJzx0v\n eZSg==", "X-Gm-Message-State": "AOJu0YwaBZxFpbJ50u5xhfEB28Y6FYQEzAbqAXntU0GG9cbiFJsE5T5q\n kivQNgmk22FzLlaWjPe3oQsp7MbiLVjJLy5bAM2B8g2yRtw920vZb6Tq4BjaFP5WXBIyAvQgfsB\n a3fI=", "X-Gm-Gg": "ATEYQzzEejXEvsKe64T6By3skMM+su0tIR9nkdwP/6VZIsTGRIxgt5/OwoYjS7Fg6y/\n 4PajzzfnWmgj4ikizPL22b0C5hOxQchxEmZAljGUcnAER2i2ggPFHT655MNI21875tK562tEKnP\n oMXr6szgVuhuVNSjQOxVr9VYtyMKXFJX76P/Tv+hX+DC1knU8/kuFG7iPiqqjU0v/zWqKI6zlWA\n D/yZ4Palv25V3jFN+WDqmL4RjECi5auaag/DFTrJqvxGHjmy0dH/3TqnGRark3xsxwHofHt9G/m\n 3W10/2JgNENMW0Atq7un+lG6esKzpJb5+WSitkW/Np/pHVZ7yuL/9fQG+iLCsn3gGDXD5bUuwau\n cj8Bq0Lu67TJGmS7G2Lmf2blJ0jFNkv4MblO7BH6xuqxAy00Im+jE+e1YfSl+xxhAjrkEyf35Li\n 9KTwZObuGQ797TOv2pBQ==", "X-Received": "by 2002:a05:620a:7114:b0:8ca:3c67:891c with SMTP id\n af79cd13be357-8cd6d51bcadmr447706385a.71.1772820844709;\n Fri, 06 Mar 2026 10:14:04 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "u-boot@lists.denx.de", "Cc": "Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>,\n Simon Glass <simon.glass@canonical.com>,\n Alper Nebi Yasak <alpernebiyasak@gmail.com>, Bryan Brattlof <bb@ti.com>,\n Neha Malcom Francis <n-francis@ti.com>, Peng Fan <peng.fan@nxp.com>,\n Philippe Reynes <philippe.reynes@softathome.com>,\n Simon Glass <sjg@chromium.org>,\n Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,\n Yannic Moog <y.moog@phytec.de>", "Subject": "[PATCH v2 15/23] binman: test: Move symbol test files to\n test/symbols/", "Date": "Fri, 6 Mar 2026 11:12:43 -0700", "Message-ID": "<20260306181304.2426352-16-sjg@chromium.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260306181304.2426352-1-sjg@chromium.org>", "References": "<20260306181304.2426352-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "From: Simon Glass <simon.glass@canonical.com>\n\nMove about 10 test files for binman symbol patching into a symbols/\nsubdirectory. Drop the numeric prefixes and the redundant symbols_\nfilename prefix, and update all references.\n\nSigned-off-by: Simon Glass <simon.glass@canonical.com>\nReviewed-by: Quentin Schulz <quentin.schulz@cherry.de>\n---\n\n(no changes since v1)\n\n tools/binman/ftest.py | 24 +++++++++----------\n .../base.dts} | 0\n .../base_expand.dts} | 0\n .../comp.dts} | 0\n .../disable.dts} | 0\n .../{260_symbols_elf.dts => symbols/elf.dts} | 0\n .../expand.dts} | 0\n .../nodtb.dts} | 0\n .../{187_symbols_sub.dts => symbols/sub.dts} | 0\n .../{053_symbols.dts => symbols/symbols.dts} | 0\n .../{149_symbols_tpl.dts => symbols/tpl.dts} | 0\n 11 files changed, 12 insertions(+), 12 deletions(-)\n rename tools/binman/test/{336_symbols_base.dts => symbols/base.dts} (100%)\n rename tools/binman/test/{337_symbols_base_expand.dts => symbols/base_expand.dts} (100%)\n rename tools/binman/test/{338_symbols_comp.dts => symbols/comp.dts} (100%)\n rename tools/binman/test/{282_symbols_disable.dts => symbols/disable.dts} (100%)\n rename tools/binman/test/{260_symbols_elf.dts => symbols/elf.dts} (100%)\n rename tools/binman/test/{197_symbols_expand.dts => symbols/expand.dts} (100%)\n rename tools/binman/test/{196_symbols_nodtb.dts => symbols/nodtb.dts} (100%)\n rename tools/binman/test/{187_symbols_sub.dts => symbols/sub.dts} (100%)\n rename tools/binman/test/{053_symbols.dts => symbols/symbols.dts} (100%)\n rename tools/binman/test/{149_symbols_tpl.dts => symbols/tpl.dts} (100%)", "diff": "diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py\nindex 3743071eb85..0e4f349aae9 100644\n--- a/tools/binman/ftest.py\n+++ b/tools/binman/ftest.py\n@@ -1611,11 +1611,11 @@ class TestFunctional(unittest.TestCase):\n \n def testSymbols(self):\n \"\"\"Test binman can assign symbols embedded in U-Boot\"\"\"\n- self.checkSymbols('053_symbols.dts', U_BOOT_SPL_DATA, 0x1c)\n+ self.checkSymbols('symbols/symbols.dts', U_BOOT_SPL_DATA, 0x1c)\n \n def testSymbolsNoDtb(self):\n \"\"\"Test binman can assign symbols embedded in U-Boot SPL\"\"\"\n- self.checkSymbols('196_symbols_nodtb.dts',\n+ self.checkSymbols('symbols/nodtb.dts',\n U_BOOT_SPL_NODTB_DATA + U_BOOT_SPL_DTB_DATA,\n 0x38)\n \n@@ -3833,7 +3833,7 @@ class TestFunctional(unittest.TestCase):\n \"\"\"Test binman can assign symbols embedded in U-Boot TPL in a section\"\"\"\n self._SetupSplElf('u_boot_binman_syms')\n self._SetupTplElf('u_boot_binman_syms')\n- self._CheckSymbolsTplSection('149_symbols_tpl.dts',\n+ self._CheckSymbolsTplSection('symbols/tpl.dts',\n [0x04, 0x20, 0x10 + 0x3c, 0x04])\n \n def testSymbolsTplSectionX86(self):\n@@ -4756,7 +4756,7 @@ class TestFunctional(unittest.TestCase):\n \n def testSymbolsSubsection(self):\n \"\"\"Test binman can assign symbols from a subsection\"\"\"\n- self.checkSymbols('187_symbols_sub.dts', U_BOOT_SPL_DATA, 0x1c)\n+ self.checkSymbols('symbols/sub.dts', U_BOOT_SPL_DATA, 0x1c)\n \n def testReadImageEntryArg(self):\n \"\"\"Test reading an image that would need an entry arg to generate\"\"\"\n@@ -5007,7 +5007,7 @@ class TestFunctional(unittest.TestCase):\n entry_args = {\n 'spl-dtb': '1',\n }\n- self.checkSymbols('197_symbols_expand.dts', U_BOOT_SPL_NODTB_DATA +\n+ self.checkSymbols('symbols/expand.dts', U_BOOT_SPL_NODTB_DATA +\n U_BOOT_SPL_DTB_DATA, 0x38,\n entry_args=entry_args, use_expanded=True)\n \n@@ -6406,7 +6406,7 @@ fdt fdtmap Extract the devicetree blob from the fdtmap\n self._SetupTplElf('u_boot_binman_syms')\n self._SetupVplElf('u_boot_binman_syms')\n self._SetupSplElf('u_boot_binman_syms')\n- data = self._DoReadFileDtb('260_symbols_elf.dts')[0]\n+ data = self._DoReadFileDtb('symbols/elf.dts')[0]\n image_fname = tools.get_output_filename('image.bin')\n \n image = control.images['image']\n@@ -6449,7 +6449,7 @@ fdt fdtmap Extract the devicetree blob from the fdtmap\n try:\n elf.ELF_TOOLS = False\n with self.assertRaises(ValueError) as exc:\n- self._DoReadFileDtb('260_symbols_elf.dts')\n+ self._DoReadFileDtb('symbols/elf.dts')\n finally:\n elf.ELF_TOOLS = True\n self.assertIn(\n@@ -6987,7 +6987,7 @@ fdt fdtmap Extract the devicetree blob from the fdtmap\n def testSymbolNoWrite(self):\n \"\"\"Test disabling of symbol writing\"\"\"\n self._SetupSplElf()\n- self.checkSymbols('282_symbols_disable.dts', U_BOOT_SPL_DATA, 0x1c,\n+ self.checkSymbols('symbols/disable.dts', U_BOOT_SPL_DATA, 0x1c,\n no_write_symbols=True)\n \n def testSymbolNoWriteExpanded(self):\n@@ -6995,7 +6995,7 @@ fdt fdtmap Extract the devicetree blob from the fdtmap\n entry_args = {\n 'spl-dtb': '1',\n }\n- self.checkSymbols('282_symbols_disable.dts', U_BOOT_SPL_NODTB_DATA +\n+ self.checkSymbols('symbols/disable.dts', U_BOOT_SPL_NODTB_DATA +\n U_BOOT_SPL_DTB_DATA, 0x38,\n entry_args=entry_args, use_expanded=True,\n no_write_symbols=True)\n@@ -7874,7 +7874,7 @@ fdt fdtmap Extract the devicetree blob from the fdtmap\n \n def testSymbolsBase(self):\n \"\"\"Test handling of symbols-base\"\"\"\n- self.checkSymbols('336_symbols_base.dts', U_BOOT_SPL_DATA, 0x1c,\n+ self.checkSymbols('symbols/base.dts', U_BOOT_SPL_DATA, 0x1c,\n symbols_base=0)\n \n def testSymbolsBaseExpanded(self):\n@@ -7882,7 +7882,7 @@ fdt fdtmap Extract the devicetree blob from the fdtmap\n entry_args = {\n 'spl-dtb': '1',\n }\n- self.checkSymbols('337_symbols_base_expand.dts', U_BOOT_SPL_NODTB_DATA +\n+ self.checkSymbols('symbols/base_expand.dts', U_BOOT_SPL_NODTB_DATA +\n U_BOOT_SPL_DTB_DATA, 0x38,\n entry_args=entry_args, use_expanded=True,\n symbols_base=0)\n@@ -7890,7 +7890,7 @@ fdt fdtmap Extract the devicetree blob from the fdtmap\n def testSymbolsCompressed(self):\n \"\"\"Test binman complains about symbols from a compressed section\"\"\"\n with terminal.capture() as (stdout, stderr):\n- self.checkSymbols('338_symbols_comp.dts', U_BOOT_SPL_DATA, None)\n+ self.checkSymbols('symbols/comp.dts', U_BOOT_SPL_DATA, None)\n out = stdout.getvalue()\n self.assertIn('Symbol-writing: no value for /binman/section/u-boot',\n out)\ndiff --git a/tools/binman/test/336_symbols_base.dts b/tools/binman/test/symbols/base.dts\nsimilarity index 100%\nrename from tools/binman/test/336_symbols_base.dts\nrename to tools/binman/test/symbols/base.dts\ndiff --git a/tools/binman/test/337_symbols_base_expand.dts b/tools/binman/test/symbols/base_expand.dts\nsimilarity index 100%\nrename from tools/binman/test/337_symbols_base_expand.dts\nrename to tools/binman/test/symbols/base_expand.dts\ndiff --git a/tools/binman/test/338_symbols_comp.dts b/tools/binman/test/symbols/comp.dts\nsimilarity index 100%\nrename from tools/binman/test/338_symbols_comp.dts\nrename to tools/binman/test/symbols/comp.dts\ndiff --git a/tools/binman/test/282_symbols_disable.dts b/tools/binman/test/symbols/disable.dts\nsimilarity index 100%\nrename from tools/binman/test/282_symbols_disable.dts\nrename to tools/binman/test/symbols/disable.dts\ndiff --git a/tools/binman/test/260_symbols_elf.dts b/tools/binman/test/symbols/elf.dts\nsimilarity index 100%\nrename from tools/binman/test/260_symbols_elf.dts\nrename to tools/binman/test/symbols/elf.dts\ndiff --git a/tools/binman/test/197_symbols_expand.dts b/tools/binman/test/symbols/expand.dts\nsimilarity index 100%\nrename from tools/binman/test/197_symbols_expand.dts\nrename to tools/binman/test/symbols/expand.dts\ndiff --git a/tools/binman/test/196_symbols_nodtb.dts b/tools/binman/test/symbols/nodtb.dts\nsimilarity index 100%\nrename from tools/binman/test/196_symbols_nodtb.dts\nrename to tools/binman/test/symbols/nodtb.dts\ndiff --git a/tools/binman/test/187_symbols_sub.dts b/tools/binman/test/symbols/sub.dts\nsimilarity index 100%\nrename from tools/binman/test/187_symbols_sub.dts\nrename to tools/binman/test/symbols/sub.dts\ndiff --git a/tools/binman/test/053_symbols.dts b/tools/binman/test/symbols/symbols.dts\nsimilarity index 100%\nrename from tools/binman/test/053_symbols.dts\nrename to tools/binman/test/symbols/symbols.dts\ndiff --git a/tools/binman/test/149_symbols_tpl.dts b/tools/binman/test/symbols/tpl.dts\nsimilarity index 100%\nrename from tools/binman/test/149_symbols_tpl.dts\nrename to tools/binman/test/symbols/tpl.dts\n", "prefixes": [ "v2", "15/23" ] }