Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2206452/?format=api
{ "id": 2206452, "url": "http://patchwork.ozlabs.org/api/patches/2206452/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260306181304.2426352-11-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260306181304.2426352-11-sjg@chromium.org>", "list_archive_url": null, "date": "2026-03-06T18:12:38", "name": "[v2,10/23] binman: test: Move ChromeOS test files to test/cros/", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "68df3a1481351086c7bc578d4093c88053393f76", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260306181304.2426352-11-sjg@chromium.org/mbox/", "series": [ { "id": 494765, "url": "http://patchwork.ozlabs.org/api/series/494765/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=494765", "date": "2026-03-06T18:12:28", "name": "binman: test: Organise test files into subdirectories", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/494765/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2206452/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2206452/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=QGGgv/TH;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"QGGgv/TH\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fSF1z5By2z1xw1\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Mar 2026 05:15:19 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0E72283FED;\n\tFri, 6 Mar 2026 19:13:58 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 2436B83FF8; Fri, 6 Mar 2026 19:13:56 +0100 (CET)", "from mail-qk1-x735.google.com (mail-qk1-x735.google.com\n [IPv6:2607:f8b0:4864:20::735])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id AD8A283FC5\n for <u-boot@lists.denx.de>; Fri, 6 Mar 2026 19:13:53 +0100 (CET)", "by mail-qk1-x735.google.com with SMTP id\n af79cd13be357-8cb39647a70so917652185a.0\n for <u-boot@lists.denx.de>; Fri, 06 Mar 2026 10:13:53 -0800 (PST)", "from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8cd6f5736c0sm155930885a.49.2026.03.06.10.13.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 06 Mar 2026 10:13:51 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1772820832; x=1773425632; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=CHiFHT3RwN8UIP8DtgaCCrmefE9cz1dME+yGqfBrBfY=;\n b=QGGgv/THepJwHiil4ZDtHk8WtEGmUUo28an017OIcA5xpxziZQUicFY78YpVo6m8D3\n A5DTBoRBAuulTaXZdpdj/sWZNW9GKzuqbDsOzefJ8oflXYR75qO5bUC8G+gAeJPpaGEd\n x+xp4+2PX+dSTL8f3n8LZw1eNn8F+NOMZ44OY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1772820832; x=1773425632;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=CHiFHT3RwN8UIP8DtgaCCrmefE9cz1dME+yGqfBrBfY=;\n b=iA5ddAchpJQi61ssxjqdIH0pCJkCC5gKIYcPztg4NMXSaHN9+O/2MFmRuAUKdHjLmj\n FdmwSO6QYyNmvuxWBvlnAvR0VxqsqsgSk+bVz2y9Owiz6ipAn92KF3UnPKMP7Gp0Y3Ze\n lSdK90OAMZxv5GVsQRp9VY8nZlNRDsFqST9lRp4DAnG9aqwxkbcKFcBIdHE+HX/px51h\n pRGYU4EGw75KQAuL3hvMgIovak2PyLfrGwwVAxDyMj4hmgBgOnf4UCDzQGwt4+/OT+J1\n pDHdU1sRCubcN/HsYnGoxUdJGK9fTBAQPodSfX2SHbHXm001AmBM3G76Ym2loCGz1i22\n L1+Q==", "X-Gm-Message-State": "AOJu0Yxeu549zLGAxPolNguYNvOinft+ViNDhIaRdDpVxfaYjaYKbHEO\n NAB8bQlpCUgeJ5GY1FMVpQheSrYIJMK2YcPOtQKOIzNSc5bkL9Xg2QDKskkqhCRUWap032WL4dW\n G/oU=", "X-Gm-Gg": "ATEYQzw8PXuoOHV5ers7JZTOHkGOnjAKDkiKBu9sbVF5Qpd8V8o0bZWZCcoK2l+pDZq\n 0thoDq0b+86kgdaZuoI4dadulRWrn9TbKxcgPOw9WpsFroCOaEO1kqQZ9oX476CyBqEIe+EQGEw\n TcRyPYIq7/3ENOVNiCFpJNl6CBB17z5arVJv1/YjH2XxkBFmx5Sx6cGODrhRF5YbQcfwCs7BP32\n QZvYbJDbXJxAJ534KJxTOD4pWMsspNCc1xxABsxKe5oDW843328OIxWh3RD7PJxKbyLqOvIxows\n 7eLibZO0T3ieOpHVDfMW1P+digcgFfOG5InU6rEcba/UvUoesovaSiD7Cg+YI3Z2sRrkQGqCA1Z\n B7rNoXLuB2BsL/IXsOc56ayKU4hDjjdozQEYvJqC+71CTQK57HUyWCDZpjOFFqp+zVF0xp4vIHM\n zuB6FU179ri+xKiQpzdQ==", "X-Received": "by 2002:a05:620a:bd5:b0:8c8:82a1:11c9 with SMTP id\n af79cd13be357-8cd6d415927mr376666485a.14.1772820831909;\n Fri, 06 Mar 2026 10:13:51 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "u-boot@lists.denx.de", "Cc": "Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>,\n Simon Glass <simon.glass@canonical.com>,\n Alper Nebi Yasak <alpernebiyasak@gmail.com>, Bryan Brattlof <bb@ti.com>,\n Neha Malcom Francis <n-francis@ti.com>, Peng Fan <peng.fan@nxp.com>,\n Philippe Reynes <philippe.reynes@softathome.com>,\n Simon Glass <sjg@chromium.org>,\n Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,\n Yannic Moog <y.moog@phytec.de>", "Subject": "[PATCH v2 10/23] binman: test: Move ChromeOS test files to test/cros/", "Date": "Fri, 6 Mar 2026 11:12:38 -0700", "Message-ID": "<20260306181304.2426352-11-sjg@chromium.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260306181304.2426352-1-sjg@chromium.org>", "References": "<20260306181304.2426352-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "From: Simon Glass <simon.glass@canonical.com>\n\nMove about 10 test files for ChromeOS entries (GBB, vblock, FMAP)\ninto a cros/ subdirectory. Drop the numeric prefixes and update all\nreferences.\n\nSigned-off-by: Simon Glass <simon.glass@canonical.com>\nReviewed-by: Quentin Schulz <quentin.schulz@cherry.de>\n---\n\n(no changes since v1)\n\n doc/develop/binman_tests.rst | 2 +-\n tools/binman/ftest.py | 22 +++++++++----------\n .../test/{067_fmap.dts => cros/fmap.dts} | 0\n .../binman/test/{071_gbb.dts => cros/gbb.dts} | 0\n .../gbb_no_size.dts} | 0\n .../gbb_too_small.dts} | 0\n .../test/{074_vblock.dts => cros/vblock.dts} | 0\n .../vblock_bad_entry.dts} | 0\n .../vblock_bad_phandle.dts} | 0\n .../vblock_content.dts} | 0\n .../vblock_no_content.dts} | 0\n 11 files changed, 12 insertions(+), 12 deletions(-)\n rename tools/binman/test/{067_fmap.dts => cros/fmap.dts} (100%)\n rename tools/binman/test/{071_gbb.dts => cros/gbb.dts} (100%)\n rename tools/binman/test/{073_gbb_no_size.dts => cros/gbb_no_size.dts} (100%)\n rename tools/binman/test/{072_gbb_too_small.dts => cros/gbb_too_small.dts} (100%)\n rename tools/binman/test/{074_vblock.dts => cros/vblock.dts} (100%)\n rename tools/binman/test/{077_vblock_bad_entry.dts => cros/vblock_bad_entry.dts} (100%)\n rename tools/binman/test/{076_vblock_bad_phandle.dts => cros/vblock_bad_phandle.dts} (100%)\n rename tools/binman/test/{189_vblock_content.dts => cros/vblock_content.dts} (100%)\n rename tools/binman/test/{075_vblock_no_content.dts => cros/vblock_no_content.dts} (100%)", "diff": "diff --git a/doc/develop/binman_tests.rst b/doc/develop/binman_tests.rst\nindex 745ca259d44..c7fa9ae6199 100644\n--- a/doc/develop/binman_tests.rst\n+++ b/doc/develop/binman_tests.rst\n@@ -436,7 +436,7 @@ correct. You can to this with ``terminal.capture()``, for example:\n .. code-block:: python\n \n with terminal.capture() as (_, stderr):\n- self._DoTestFile('071_gbb.dts', force_missing_bintools='futility',\n+ self._DoTestFile('cros/gbb.dts', force_missing_bintools='futility',\n entry_args=entry_args)\n err = stderr.getvalue()\n self.assertRegex(err, \"Image 'image'.*missing bintools.*: futility\")\ndiff --git a/tools/binman/ftest.py b/tools/binman/ftest.py\nindex d43bb9183bb..87055a53bdf 100644\n--- a/tools/binman/ftest.py\n+++ b/tools/binman/ftest.py\n@@ -1816,7 +1816,7 @@ class TestFunctional(unittest.TestCase):\n \n def testFmap(self):\n \"\"\"Basic test of generation of a flashrom fmap\"\"\"\n- data = self._DoReadFile('067_fmap.dts')\n+ data = self._DoReadFile('cros/fmap.dts')\n fhdr, fentries = fmap_util.DecodeFmap(data[32:])\n expected = (U_BOOT_DATA + tools.get_bytes(ord('!'), 12) +\n U_BOOT_DATA + tools.get_bytes(ord('a'), 12))\n@@ -1898,7 +1898,7 @@ class TestFunctional(unittest.TestCase):\n 'keydir': 'devkeys',\n 'bmpblk': 'bmpblk.bin',\n }\n- data, _, _, _ = self._DoReadFileDtb('071_gbb.dts', entry_args=entry_args)\n+ data, _, _, _ = self._DoReadFileDtb('cros/gbb.dts', entry_args=entry_args)\n \n # Since futility\n expected = (GBB_DATA + GBB_DATA + tools.get_bytes(0, 8) +\n@@ -1908,14 +1908,14 @@ class TestFunctional(unittest.TestCase):\n def testGbbTooSmall(self):\n \"\"\"Test for the Chromium OS Google Binary Block being large enough\"\"\"\n with self.assertRaises(ValueError) as e:\n- self._DoReadFileDtb('072_gbb_too_small.dts')\n+ self._DoReadFileDtb('cros/gbb_too_small.dts')\n self.assertIn(\"Node '/binman/gbb': GBB is too small\",\n str(e.exception))\n \n def testGbbNoSize(self):\n \"\"\"Test for the Chromium OS Google Binary Block having a size\"\"\"\n with self.assertRaises(ValueError) as e:\n- self._DoReadFileDtb('073_gbb_no_size.dts')\n+ self._DoReadFileDtb('cros/gbb_no_size.dts')\n self.assertIn(\"Node '/binman/gbb': GBB must have a fixed size\",\n str(e.exception))\n \n@@ -1925,7 +1925,7 @@ class TestFunctional(unittest.TestCase):\n 'keydir': 'devkeys',\n }\n with terminal.capture() as (_, stderr):\n- self._DoTestFile('071_gbb.dts', force_missing_bintools='futility',\n+ self._DoTestFile('cros/gbb.dts', force_missing_bintools='futility',\n entry_args=entry_args)\n err = stderr.getvalue()\n self.assertRegex(err, \"Image 'image'.*missing bintools.*: futility\")\n@@ -1966,7 +1966,7 @@ class TestFunctional(unittest.TestCase):\n entry_args = {\n 'keydir': 'devkeys',\n }\n- data, _, _, _ = self._DoReadFileDtb('074_vblock.dts',\n+ data, _, _, _ = self._DoReadFileDtb('cros/vblock.dts',\n entry_args=entry_args)\n expected = U_BOOT_DATA + VBLOCK_DATA + U_BOOT_DTB_DATA\n self.assertEqual(expected, data)\n@@ -1974,21 +1974,21 @@ class TestFunctional(unittest.TestCase):\n def testVblockNoContent(self):\n \"\"\"Test we detect a vblock which has no content to sign\"\"\"\n with self.assertRaises(ValueError) as e:\n- self._DoReadFile('075_vblock_no_content.dts')\n+ self._DoReadFile('cros/vblock_no_content.dts')\n self.assertIn(\"Node '/binman/vblock': Collection must have a 'content' \"\n 'property', str(e.exception))\n \n def testVblockBadPhandle(self):\n \"\"\"Test that we detect a vblock with an invalid phandle in contents\"\"\"\n with self.assertRaises(ValueError) as e:\n- self._DoReadFile('076_vblock_bad_phandle.dts')\n+ self._DoReadFile('cros/vblock_bad_phandle.dts')\n self.assertIn(\"Node '/binman/vblock': Cannot find node for phandle \"\n '1000', str(e.exception))\n \n def testVblockBadEntry(self):\n \"\"\"Test that we detect an entry that points to a non-entry\"\"\"\n with self.assertRaises(ValueError) as e:\n- self._DoReadFile('077_vblock_bad_entry.dts')\n+ self._DoReadFile('cros/vblock_bad_entry.dts')\n self.assertIn(\"Node '/binman/vblock': Cannot find entry for node \"\n \"'other'\", str(e.exception))\n \n@@ -2000,7 +2000,7 @@ class TestFunctional(unittest.TestCase):\n 'keydir': 'devkeys',\n }\n data = self._DoReadFileDtb(\n- '189_vblock_content.dts', use_real_dtb=True, update_dtb=True,\n+ 'cros/vblock_content.dts', use_real_dtb=True, update_dtb=True,\n entry_args=entry_args)[0]\n hashlen = 32 # SHA256 hash is 32 bytes\n self.assertEqual(U_BOOT_DATA, data[:len(U_BOOT_DATA)])\n@@ -2021,7 +2021,7 @@ class TestFunctional(unittest.TestCase):\n 'keydir': 'devkeys',\n }\n with terminal.capture() as (_, stderr):\n- self._DoTestFile('074_vblock.dts',\n+ self._DoTestFile('cros/vblock.dts',\n force_missing_bintools='futility',\n entry_args=entry_args)\n err = stderr.getvalue()\ndiff --git a/tools/binman/test/067_fmap.dts b/tools/binman/test/cros/fmap.dts\nsimilarity index 100%\nrename from tools/binman/test/067_fmap.dts\nrename to tools/binman/test/cros/fmap.dts\ndiff --git a/tools/binman/test/071_gbb.dts b/tools/binman/test/cros/gbb.dts\nsimilarity index 100%\nrename from tools/binman/test/071_gbb.dts\nrename to tools/binman/test/cros/gbb.dts\ndiff --git a/tools/binman/test/073_gbb_no_size.dts b/tools/binman/test/cros/gbb_no_size.dts\nsimilarity index 100%\nrename from tools/binman/test/073_gbb_no_size.dts\nrename to tools/binman/test/cros/gbb_no_size.dts\ndiff --git a/tools/binman/test/072_gbb_too_small.dts b/tools/binman/test/cros/gbb_too_small.dts\nsimilarity index 100%\nrename from tools/binman/test/072_gbb_too_small.dts\nrename to tools/binman/test/cros/gbb_too_small.dts\ndiff --git a/tools/binman/test/074_vblock.dts b/tools/binman/test/cros/vblock.dts\nsimilarity index 100%\nrename from tools/binman/test/074_vblock.dts\nrename to tools/binman/test/cros/vblock.dts\ndiff --git a/tools/binman/test/077_vblock_bad_entry.dts b/tools/binman/test/cros/vblock_bad_entry.dts\nsimilarity index 100%\nrename from tools/binman/test/077_vblock_bad_entry.dts\nrename to tools/binman/test/cros/vblock_bad_entry.dts\ndiff --git a/tools/binman/test/076_vblock_bad_phandle.dts b/tools/binman/test/cros/vblock_bad_phandle.dts\nsimilarity index 100%\nrename from tools/binman/test/076_vblock_bad_phandle.dts\nrename to tools/binman/test/cros/vblock_bad_phandle.dts\ndiff --git a/tools/binman/test/189_vblock_content.dts b/tools/binman/test/cros/vblock_content.dts\nsimilarity index 100%\nrename from tools/binman/test/189_vblock_content.dts\nrename to tools/binman/test/cros/vblock_content.dts\ndiff --git a/tools/binman/test/075_vblock_no_content.dts b/tools/binman/test/cros/vblock_no_content.dts\nsimilarity index 100%\nrename from tools/binman/test/075_vblock_no_content.dts\nrename to tools/binman/test/cros/vblock_no_content.dts\n", "prefixes": [ "v2", "10/23" ] }