Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2205093/?format=api
{ "id": 2205093, "url": "http://patchwork.ozlabs.org/api/patches/2205093/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260304160345.1340940-11-larysa.zaremba@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260304160345.1340940-11-larysa.zaremba@intel.com>", "list_archive_url": null, "date": "2026-03-04T16:03:42", "name": "[iwl-next,v3,10/10] ixgbevf: allow changing MTU when XDP program is attached", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "a7de720185c31817b4167e1bb6bd1dd81baa50e4", "submitter": { "id": 84900, "url": "http://patchwork.ozlabs.org/api/people/84900/?format=api", "name": "Larysa Zaremba", "email": "larysa.zaremba@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260304160345.1340940-11-larysa.zaremba@intel.com/mbox/", "series": [ { "id": 494412, "url": "http://patchwork.ozlabs.org/api/series/494412/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=494412", "date": "2026-03-04T16:03:32", "name": "libeth and full XDP for ixgbevf", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/494412/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2205093/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2205093/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=pRZ8XrNq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fQywq4WK7z1xws\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 05 Mar 2026 03:36:27 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2267281399;\n\tWed, 4 Mar 2026 16:36:19 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pgm_zauUYa1y; Wed, 4 Mar 2026 16:36:18 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 51A9781326;\n\tWed, 4 Mar 2026 16:36:18 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 202BE231\n for <intel-wired-lan@lists.osuosl.org>; Wed, 4 Mar 2026 16:36:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 129DB6086F\n for <intel-wired-lan@lists.osuosl.org>; Wed, 4 Mar 2026 16:36:17 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id XOk8A-oORW3u for <intel-wired-lan@lists.osuosl.org>;\n Wed, 4 Mar 2026 16:36:16 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.18])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 18AF06086D\n for <intel-wired-lan@lists.osuosl.org>; Wed, 4 Mar 2026 16:36:16 +0000 (UTC)", "from fmviesa002.fm.intel.com ([10.60.135.142])\n by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Mar 2026 08:36:15 -0800", "from irvmail002.ir.intel.com ([10.43.11.120])\n by fmviesa002.fm.intel.com with ESMTP; 04 Mar 2026 08:36:11 -0800", "from lincoln.igk.intel.com (lincoln.igk.intel.com [10.102.21.235])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id 109DB312CB;\n Wed, 4 Mar 2026 16:36:10 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 51A9781326", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 18AF06086D" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1772642178;\n\tbh=/KCNSrI38Kvpa9Ekv7MohsZg2V5yozSNTh42CygIqK8=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=pRZ8XrNqOv67zF+AP/OLH/DQMHAQwgskAQv7/3kw75VnKqP0mcASmELZVugtsM1wu\n\t pJTqocmWNtbiTQh36d80vNV2d1/Y/pE5EwROQZTRr/NwfSUf/sHcMt6zlipfNRcxCe\n\t TZ+7BS4mzOURTka6Qffhds30/zBocwiunBityqy6/9EJsVjVO4NeimiSPjwiHyDBY3\n\t R9b/NQqfivV4thqp5mqvvYYzFKAuJ08lhe57j0G17fhk7ySNEUuvCeIqccrHEYXivf\n\t sRWvrfoZe0hHicOjZ5rtnNQ2rg/nwNFvenrdBaqp16AIFIixSpHD4dbuwOPOkXxMSc\n\t VYJ+70T9edoug==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.18;\n helo=mgamail.intel.com; envelope-from=larysa.zaremba@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 18AF06086D", "X-CSE-ConnectionGUID": [ "LtyG/zclR32P3A7xgJvHrQ==", "7wkR9efNR9uyL5ijqtiN3Q==" ], "X-CSE-MsgGUID": [ "XjUA+CwaTIiknQ3ptWKVag==", "1fYrwHwiR7qWLIM1XMTJOw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11719\"; a=\"72906464\"", "E=Sophos;i=\"6.21,324,1763452800\"; d=\"scan'208\";a=\"72906464\"", "E=Sophos;i=\"6.21,324,1763452800\"; d=\"scan'208\";a=\"241405043\"" ], "X-ExtLoop1": "1", "From": "Larysa Zaremba <larysa.zaremba@intel.com>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>, intel-wired-lan@lists.osuosl.org", "Cc": "Larysa Zaremba <larysa.zaremba@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>,\n Alexander Lobakin <aleksander.lobakin@intel.com>,\n Simon Horman <horms@kernel.org>, Alexei Starovoitov <ast@kernel.org>,\n Daniel Borkmann <daniel@iogearbox.net>,\n Jesper Dangaard Brouer <hawk@kernel.org>,\n John Fastabend <john.fastabend@gmail.com>,\n Stanislav Fomichev <sdf@fomichev.me>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Natalia Wochtman <natalia.wochtman@intel.com>, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, bpf@vger.kernel.org", "Date": "Wed, 4 Mar 2026 17:03:42 +0100", "Message-ID": "<20260304160345.1340940-11-larysa.zaremba@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260304160345.1340940-1-larysa.zaremba@intel.com>", "References": "<20260304160345.1340940-1-larysa.zaremba@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1772642176; x=1804178176;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=xSoRegfDOP/5IirhtXxj8ro8oytZUXfZQIPbEnLhFj0=;\n b=W1fvYWFHPWDTUvwr+a6TUurNqZ/eK7OHMrVTvsKdUEegMXpoVQChGinI\n 1GjOKr9JJyANH+TkqeLaIy7z8KeEknOgV7czEtfVZblp22HWnCKF4We/g\n VEkABcEN9q4fTOvQNPj3c3XGMF/C1osDQszLCwJRSO+rtHvAFNtFI8PbM\n MJO/Y8rILcbXS55L2/tdTyhMl9N4aPT2SMxwqgffyb9vsX9Sy73HmV9Aa\n doxQ4cs5T7pVkB3H4nqrcQnoJJR7G5A+Pf4WiyaEsgDvw3M6tmABDP/zm\n wuVfRasade6sYtJu49yel6SvrB0c1CpihF/4Y0oDibNst+nr3f+5ke/gz\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=W1fvYWFH" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v3 10/10] ixgbevf: allow changing\n MTU when XDP program is attached", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "xskxceiver attempts to change MTU after attaching XDP program,\nixgbevf rejects the request leading to test being failed.\n\nSupport MTU change operation even when XDP program is already attached,\nperform the same frame size check as when attaching a program.\n\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Larysa Zaremba <larysa.zaremba@intel.com>\n---\n .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 37 ++++++++++++++-----\n 1 file changed, 27 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 196e51eb516a..08ea2ae45cea 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -569,8 +569,8 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring,\n \t};\n \tu16 ntu = rx_ring->next_to_use;\n \n-\t/* nothing to do or no valid netdev defined */\n-\tif (unlikely(!cleaned_count || !rx_ring->netdev))\n+\t/* nothing to do or page pool is not present */\n+\tif (unlikely(!cleaned_count || !fq.pp))\n \t\treturn;\n \n \trx_desc = IXGBEVF_RX_DESC(rx_ring, ntu);\n@@ -1764,6 +1764,7 @@ static void ixgbevf_configure_rx_ring(struct ixgbevf_adapter *adapter,\n \tbool rlpml_valid = false;\n \tu64 rdba = ring->dma;\n \tu32 rxdctl;\n+\tint err;\n \n \t/* disable queue to avoid issues while updating state */\n \trxdctl = IXGBE_READ_REG(hw, IXGBE_VFRXDCTL(reg_idx));\n@@ -1797,7 +1798,13 @@ static void ixgbevf_configure_rx_ring(struct ixgbevf_adapter *adapter,\n \tring->next_to_clean = 0;\n \tring->next_to_use = 0;\n \n-\tixgbevf_rx_create_pp(ring);\n+\terr = ixgbevf_rx_create_pp(ring);\n+\tif (err) {\n+\t\tnetdev_err(ring->netdev,\n+\t\t\t \"Failed to create Page Pool for buffer allocation: (%pe), RxQ %d is disabled, driver reload may be needed\\n\",\n+\t\t\t ERR_PTR(err), ring->queue_index);\n+\t\treturn;\n+\t}\n \n \t/* RXDCTL.RLPML does not work on 82599 */\n \tif (adapter->hw.mac.type != ixgbe_mac_82599_vf) {\n@@ -4082,6 +4089,18 @@ static int ixgbevf_set_mac(struct net_device *netdev, void *p)\n \treturn 0;\n }\n \n+static bool ixgbevf_xdp_mtu_ok(const struct ixgbevf_adapter *adapter,\n+\t\t\t const struct bpf_prog *prog, unsigned int mtu)\n+{\n+\tu32 frame_size = mtu + LIBETH_RX_LL_LEN;\n+\tbool requires_mbuf;\n+\n+\trequires_mbuf = frame_size > IXGBEVF_RX_PAGE_LEN(LIBETH_XDP_HEADROOM) ||\n+\t\t\tadapter->flags & IXGBEVF_FLAG_HSPLIT;\n+\n+\treturn prog->aux->xdp_has_frags || !requires_mbuf;\n+}\n+\n /**\n * ixgbevf_change_mtu - Change the Maximum Transfer Unit\n * @netdev: network interface device structure\n@@ -4097,8 +4116,10 @@ static int ixgbevf_change_mtu(struct net_device *netdev, int new_mtu)\n \tint ret;\n \n \t/* prevent MTU being changed to a size unsupported by XDP */\n-\tif (adapter->xdp_prog) {\n-\t\tdev_warn(&adapter->pdev->dev, \"MTU cannot be changed while XDP program is loaded\\n\");\n+\tif (adapter->xdp_prog &&\n+\t !ixgbevf_xdp_mtu_ok(adapter, adapter->xdp_prog, new_mtu)) {\n+\t\tnetdev_warn(netdev,\n+\t\t\t \"MTU value provided cannot be set while current XDP program is attached\\n\");\n \t\treturn -EPERM;\n \t}\n \n@@ -4261,14 +4282,10 @@ ixgbevf_features_check(struct sk_buff *skb, struct net_device *dev,\n static int ixgbevf_xdp_setup(struct net_device *dev, struct bpf_prog *prog,\n \t\t\t struct netlink_ext_ack *extack)\n {\n-\tu32 frame_size = READ_ONCE(dev->mtu) + LIBETH_RX_LL_LEN;\n \tstruct ixgbevf_adapter *adapter = netdev_priv(dev);\n \tstruct bpf_prog *old_prog;\n-\tbool requires_mbuf;\n \n-\trequires_mbuf = frame_size > IXGBEVF_RX_PAGE_LEN(LIBETH_XDP_HEADROOM) ||\n-\t\t\tadapter->flags & IXGBEVF_FLAG_HSPLIT;\n-\tif (prog && !prog->aux->xdp_has_frags && requires_mbuf) {\n+\tif (prog && !ixgbevf_xdp_mtu_ok(adapter, prog, READ_ONCE(dev->mtu))) {\n \t\tNL_SET_ERR_MSG_MOD(extack,\n \t\t\t\t \"Configured MTU or HW limitations require non-linear frames and XDP prog does not support frags\");\n \t\treturn -EOPNOTSUPP;\n", "prefixes": [ "iwl-next", "v3", "10/10" ] }