Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2205087/?format=api
{ "id": 2205087, "url": "http://patchwork.ozlabs.org/api/patches/2205087/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260304160345.1340940-5-larysa.zaremba@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260304160345.1340940-5-larysa.zaremba@intel.com>", "list_archive_url": null, "date": "2026-03-04T16:03:36", "name": "[iwl-next,v3,04/10] ixgbevf: branch prediction and cleanup", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "e53af513f70bfc818453021116be1d695b254842", "submitter": { "id": 84900, "url": "http://patchwork.ozlabs.org/api/people/84900/?format=api", "name": "Larysa Zaremba", "email": "larysa.zaremba@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260304160345.1340940-5-larysa.zaremba@intel.com/mbox/", "series": [ { "id": 494412, "url": "http://patchwork.ozlabs.org/api/series/494412/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=494412", "date": "2026-03-04T16:03:32", "name": "libeth and full XDP for ixgbevf", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/494412/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2205087/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2205087/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=z8wlJQBf;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fQywY2ptfz1xws\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 05 Mar 2026 03:36:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id E02008133F;\n\tWed, 4 Mar 2026 16:36:08 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id VzSGpviBJcvE; Wed, 4 Mar 2026 16:36:07 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 0B5318133E;\n\tWed, 4 Mar 2026 16:36:07 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 5D1BE1EB\n for <intel-wired-lan@lists.osuosl.org>; Wed, 4 Mar 2026 16:36:05 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 4F50E6086D\n for <intel-wired-lan@lists.osuosl.org>; Wed, 4 Mar 2026 16:36:05 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MyZhd4GWSfYP for <intel-wired-lan@lists.osuosl.org>;\n Wed, 4 Mar 2026 16:36:04 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 9846C6086F\n for <intel-wired-lan@lists.osuosl.org>; Wed, 4 Mar 2026 16:36:04 +0000 (UTC)", "from orviesa004.jf.intel.com ([10.64.159.144])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Mar 2026 08:36:04 -0800", "from irvmail002.ir.intel.com ([10.43.11.120])\n by orviesa004.jf.intel.com with ESMTP; 04 Mar 2026 08:35:59 -0800", "from lincoln.igk.intel.com (lincoln.igk.intel.com [10.102.21.235])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id BD90E312CB;\n Wed, 4 Mar 2026 16:35:57 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0B5318133E", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9846C6086F" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1772642167;\n\tbh=hNv/JCxyEfODysJznGOb9inHnBec7P5QUf7yBNavZxY=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=z8wlJQBfJUN+TwVxV8ss9ZNK/bdkwv6d6YqpJ1+rsqOdavUV357EwgdbJQtp0M9fM\n\t LDF/nwHG6Emv9R9kkF65FA9Mv3QECzLrr1BlkQR56MCaZCDr2BES31NLO2bLEPoZHG\n\t ZSo9npzwVe+XM+LFe+FatwdNQduWEx8MW6zwZNJKaUAs4z0NP1MGQddV+RoYMGk/ft\n\t 8vZpYyc7qW+ypo4rllP99wruMzs1y1teHUSicKsme0mvMCIpMgMG8p+wACGyd6T4aB\n\t QVBa7TchmxxLuaSn4FApXyVPPGgnnoAZO/M1/u5QjGq8qHB9rIsFR/XafsECh94Uuw\n\t YhQZl5HgxDx8A==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12;\n helo=mgamail.intel.com; envelope-from=larysa.zaremba@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 9846C6086F", "X-CSE-ConnectionGUID": [ "49Yyw+P+QD6gNicPcLgOQA==", "CXspW5VzSoe+MV4hhdt45g==" ], "X-CSE-MsgGUID": [ "1QkSARx5SjOwpYa3MtgzNQ==", "F+Spye3VRzyYF4xcsZtV8Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11719\"; a=\"77580047\"", "E=Sophos;i=\"6.21,324,1763452800\"; d=\"scan'208\";a=\"77580047\"", "E=Sophos;i=\"6.21,324,1763452800\"; d=\"scan'208\";a=\"222895571\"" ], "X-ExtLoop1": "1", "From": "Larysa Zaremba <larysa.zaremba@intel.com>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>, intel-wired-lan@lists.osuosl.org", "Cc": "Larysa Zaremba <larysa.zaremba@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>,\n Alexander Lobakin <aleksander.lobakin@intel.com>,\n Simon Horman <horms@kernel.org>, Alexei Starovoitov <ast@kernel.org>,\n Daniel Borkmann <daniel@iogearbox.net>,\n Jesper Dangaard Brouer <hawk@kernel.org>,\n John Fastabend <john.fastabend@gmail.com>,\n Stanislav Fomichev <sdf@fomichev.me>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Natalia Wochtman <natalia.wochtman@intel.com>, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, bpf@vger.kernel.org", "Date": "Wed, 4 Mar 2026 17:03:36 +0100", "Message-ID": "<20260304160345.1340940-5-larysa.zaremba@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260304160345.1340940-1-larysa.zaremba@intel.com>", "References": "<20260304160345.1340940-1-larysa.zaremba@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1772642165; x=1804178165;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=oCACM2F8kkfEfXBuuh5iayPiq9mwGCDlUS6bp5gDtSo=;\n b=ULYjj+WMdvI172ztMLuPkdlGfuzgXi7/vxq2YG86hTFu1Vgz6DCHpfYA\n JrreLpF/JMAu9MOHZI9ecqPwggzvdKxW1/lfgDROD5XRHWfpkFqhgwvhZ\n j+lpM1rnfWmkFKah612w+P9N451ve4xRZjwVW/VFSwFazkVeUl6b8dqL5\n qVDh3QLGO5O9efwLv5n6oQH9J1IFyoiSiZVuv92L2jSuS74/wpQ0wO8ta\n gm6No0bo6wf3R8Bo3xOEGg/gIigELkwVS+GX2fh5A1W0kqhiM74Gjbdmn\n hEQvlUcOrUU22B4VK0gBRXraUBb5y2DEV5Tw6io02wpbHaNpRRdfIVuJn\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=ULYjj+WM" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v3 04/10] ixgbevf: branch\n prediction and cleanup", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Add likely/unlikely markers for better branch prediction. While touching\nsome functions, cleanup the code a little bit.\n\nThis patch is not supposed to make any logic changes aside from making\ntotal_rx_bytes and total_rx_packets more correlated.\n\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nReviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>\nSigned-off-by: Larysa Zaremba <larysa.zaremba@intel.com>\n---\n .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 29 +++++++++----------\n 1 file changed, 14 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 5a270dd2c7aa..4619f2bea1ab 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -570,7 +570,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring,\n \tu16 ntu = rx_ring->next_to_use;\n \n \t/* nothing to do or no valid netdev defined */\n-\tif (!cleaned_count || !rx_ring->netdev)\n+\tif (unlikely(!cleaned_count || !rx_ring->netdev))\n \t\treturn;\n \n \trx_desc = IXGBEVF_RX_DESC(rx_ring, ntu);\n@@ -586,7 +586,7 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring,\n \n \t\trx_desc++;\n \t\tntu++;\n-\t\tif (unlikely(ntu == rx_ring->count)) {\n+\t\tif (unlikely(ntu == fq.count)) {\n \t\t\trx_desc = IXGBEVF_RX_DESC(rx_ring, 0);\n \t\t\tntu = 0;\n \t\t}\n@@ -823,7 +823,7 @@ static int ixgbevf_clean_rx_irq(struct ixgbevf_q_vector *q_vector,\n \n \t\trx_desc = IXGBEVF_RX_DESC(rx_ring, rx_ring->next_to_clean);\n \t\tsize = le16_to_cpu(rx_desc->wb.upper.length);\n-\t\tif (!size)\n+\t\tif (unlikely(!size))\n \t\t\tbreak;\n \n \t\t/* This memory barrier is needed to keep us from reading\n@@ -855,7 +855,7 @@ static int ixgbevf_clean_rx_irq(struct ixgbevf_q_vector *q_vector,\n \t\t}\n \n \t\t/* exit if we failed to retrieve a buffer */\n-\t\tif (!xdp_res && !skb) {\n+\t\tif (unlikely(!xdp_res && !skb)) {\n \t\t\trx_ring->rx_stats.alloc_rx_buff_failed++;\n \t\t\tbreak;\n \t\t}\n@@ -867,21 +867,19 @@ static int ixgbevf_clean_rx_irq(struct ixgbevf_q_vector *q_vector,\n \t\t\tcontinue;\n \n \t\t/* verify the packet layout is correct */\n-\t\tif (xdp_res || ixgbevf_cleanup_headers(rx_ring, rx_desc, skb)) {\n+\t\tif (xdp_res ||\n+\t\t unlikely(ixgbevf_cleanup_headers(rx_ring, rx_desc, skb))) {\n \t\t\tskb = NULL;\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/* probably a little skewed due to removing CRC */\n-\t\ttotal_rx_bytes += skb->len;\n-\n \t\t/* Workaround hardware that can't do proper VEPA multicast\n \t\t * source pruning.\n \t\t */\n-\t\tif ((skb->pkt_type == PACKET_BROADCAST ||\n-\t\t skb->pkt_type == PACKET_MULTICAST) &&\n-\t\t ether_addr_equal(rx_ring->netdev->dev_addr,\n-\t\t\t\t eth_hdr(skb)->h_source)) {\n+\t\tif (unlikely((skb->pkt_type == PACKET_BROADCAST ||\n+\t\t\t skb->pkt_type == PACKET_MULTICAST) &&\n+\t\t\t ether_addr_equal(rx_ring->netdev->dev_addr,\n+\t\t\t\t\t eth_hdr(skb)->h_source))) {\n \t\t\tdev_kfree_skb_irq(skb);\n \t\t\tcontinue;\n \t\t}\n@@ -889,13 +887,14 @@ static int ixgbevf_clean_rx_irq(struct ixgbevf_q_vector *q_vector,\n \t\t/* populate checksum, VLAN, and protocol */\n \t\tixgbevf_process_skb_fields(rx_ring, rx_desc, skb);\n \n+\t\t/* probably a little skewed due to removing CRC */\n+\t\ttotal_rx_bytes += skb->len;\n+\t\ttotal_rx_packets++;\n+\n \t\tixgbevf_rx_skb(q_vector, skb);\n \n \t\t/* reset skb pointer */\n \t\tskb = NULL;\n-\n-\t\t/* update budget accounting */\n-\t\ttotal_rx_packets++;\n \t}\n \n \t/* place incomplete frames back on ring for completion */\n", "prefixes": [ "iwl-next", "v3", "04/10" ] }