Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2204734/?format=api
{ "id": 2204734, "url": "http://patchwork.ozlabs.org/api/patches/2204734/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260304084232.2937498-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260304084232.2937498-1-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-04T08:42:32", "name": "[iwl-net,v1] ixgbe: stop re-reading flash on every get_drvinfo for e610", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "cfef0db72d6026f29cc21c8d47b9e380c57f26a4", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260304084232.2937498-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 494332, "url": "http://patchwork.ozlabs.org/api/series/494332/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=494332", "date": "2026-03-04T08:42:32", "name": "[iwl-net,v1] ixgbe: stop re-reading flash on every get_drvinfo for e610", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/494332/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2204734/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2204734/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=i5PLOwpw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fQmQ94DH3z1xw1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 04 Mar 2026 19:42:40 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 7A70560769;\n\tWed, 4 Mar 2026 08:42:39 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id eN27dadYGd8W; Wed, 4 Mar 2026 08:42:38 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 6D79060752;\n\tWed, 4 Mar 2026 08:42:38 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id A5B5925B\n for <intel-wired-lan@lists.osuosl.org>; Wed, 4 Mar 2026 08:42:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id A343B80DC3\n for <intel-wired-lan@lists.osuosl.org>; Wed, 4 Mar 2026 08:42:37 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id AlCjyQH2kHRM for <intel-wired-lan@lists.osuosl.org>;\n Wed, 4 Mar 2026 08:42:36 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 4136580DBB\n for <intel-wired-lan@lists.osuosl.org>; Wed, 4 Mar 2026 08:42:35 +0000 (UTC)", "from orviesa005.jf.intel.com ([10.64.159.145])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Mar 2026 00:42:35 -0800", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa005.jf.intel.com with ESMTP; 04 Mar 2026 00:42:34 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6D79060752", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4136580DBB" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1772613758;\n\tbh=SpRG4xOm3agqqJ0NwCz/uivaKqGE9/5HXuAADqvN+F0=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=i5PLOwpwPwCX6TP07MT0WdbUASPBhq8iWB2rhXAw8C9R9rQk5Mow3VZgsoDyYqjKP\n\t gujO7P+tDfygR10gCHkJXKlJrPUUwTUoZd2evuNAuktdjWODMEGtn7Q57QXCSaBSBU\n\t RhU67wgIZZemcBIYcw8V4yKFVUSrLDcSWNYJGNpYEprsd+XvBOGSaIt4jOPPbbZJia\n\t o1pfCkXzeRlrnTNkAGrEmGp83r4MgmzGUs9CzB2lmGrAue8BJz88hWIYNfX56F9wFX\n\t zx6rp2bx1MUKgvyNnA2eJC78QjIZIJBJDTNcizerxpK6+JTyOrJbX0b0jeTDzLYaAS\n\t FJKJzWr22fR0w==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 4136580DBB", "X-CSE-ConnectionGUID": [ "VSdnkDXXR/a3EIdy0xIbnw==", "OgIxrAcgSuKhqP54zY8mEw==" ], "X-CSE-MsgGUID": [ "JU/XkXUTQ+2kWYizsfFMNQ==", "bwVf6cETSwS5ob7SiSHtsQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11718\"; a=\"73736621\"", "E=Sophos;i=\"6.21,323,1763452800\"; d=\"scan'208\";a=\"73736621\"", "E=Sophos;i=\"6.21,323,1763452800\"; d=\"scan'208\";a=\"223270421\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tJedrzej Jagielski <jedrzej.jagielski@intel.com>", "Date": "Wed, 4 Mar 2026 09:42:32 +0100", "Message-ID": "<20260304084232.2937498-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1772613756; x=1804149756;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=BKssnUpC3b9eO8LjpnPOwjycyVQrdp45Uj5fbygo95o=;\n b=mgYV3ZW1PGEBfTL+GauFzzN+f2jwoI8RM63Aseka+34UyMDSymxEgp2O\n NojTtREnFpK+qH8BOEl+RDMJf2BchAyBy00CiqKFbXuQt8I8gVJOrPEWP\n InnvXNpiBlS5OvR6BIdBbYDjSy6dFG/rYCH68ibB3VZslaamu6psYfuW3\n h6x3qyPZfoXhkEeGYmdHkDdiGB9Co54oHKvILK64Z1i7rob5VAqXGVdGT\n pRnAwoYjYZsA3bIRv7it/8vV2AUkoDkBHvN06R9M8qDoES/vMSKh1m9zd\n Hn2RA3SlZ8DljGgkkH3wbc3jUQOpKo9cERcKeTxnBzFsC1bwaVrvy1DuO\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=mgYV3ZW1" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v1] ixgbe: stop re-reading flash\n on every get_drvinfo for e610", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ixgbe_get_drvinfo() calls ixgbe_refresh_fw_version() on every ethtool\nquery for e610 adapters. That ends up in ixgbe_discover_flash_size(),\nwhich bisects the full 16 MB NVM space issuing one ACI command per\nstep (~20 ms each, ~24 steps total = ~500 ms).\n\nProfiling on an idle E610-XAT2 system with telegraf scraping ethtool\nstats every 10 seconds:\n\n kretprobe:ixgbe_get_drvinfo took 527603 us\n kretprobe:ixgbe_get_drvinfo took 523978 us\n kretprobe:ixgbe_get_drvinfo took 552975 us\n kretprobe:ice_get_drvinfo took 3 us\n kretprobe:igb_get_drvinfo took 2 us\n kretprobe:i40e_get_drvinfo took 5 us\n\nThe half-second stall happens under the RTNL lock, causing visible\nlatency on ip-link and friends.\n\nThe FW version can only change after an EMPR reset. All flash data is\nalready populated at probe time and the cached adapter->eeprom_id is\nwhat get_drvinfo should be returning. The only place that needs to\ntrigger a re-read is ixgbe_devlink_reload_empr_finish(), right after\nthe EMPR completes and new firmware is running. Additionally, refresh\nthe FW version in ixgbe_reinit_locked() so that any PF that undergoes a\nreinit after an EMPR (e.g. triggered by another PF's devlink reload)\nalso picks up the new version in adapter->eeprom_id.\n\nixgbe_devlink_info_get() keeps its refresh call for explicit\n\"devlink dev info\" queries, which is fine given those are user-initiated.\n\nFixes: c9e563cae19e (\"ixgbe: add support for devlink reload\")\nCo-developed-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>\nSigned-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/devlink/devlink.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 13 +++++++------\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++++++++++\n 4 files changed, 19 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c b/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c\nindex d227f4d..f32e640 100644\n--- a/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c\n+++ b/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c\n@@ -474,7 +474,7 @@ static int ixgbe_devlink_reload_empr_finish(struct devlink *devlink,\n \tadapter->flags2 &= ~(IXGBE_FLAG2_API_MISMATCH |\n \t\t\t IXGBE_FLAG2_FW_ROLLBACK);\n \n-\treturn 0;\n+\treturn ixgbe_refresh_fw_version(adapter);\n }\n \n static const struct devlink_ops ixgbe_devlink_ops = {\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\nindex dce4936..047f040455 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n@@ -973,7 +973,7 @@ int ixgbe_init_interrupt_scheme(struct ixgbe_adapter *adapter);\n bool ixgbe_wol_supported(struct ixgbe_adapter *adapter, u16 device_id,\n \t\t\t u16 subdevice_id);\n void ixgbe_set_fw_version_e610(struct ixgbe_adapter *adapter);\n-void ixgbe_refresh_fw_version(struct ixgbe_adapter *adapter);\n+int ixgbe_refresh_fw_version(struct ixgbe_adapter *adapter);\n #ifdef CONFIG_PCI_IOV\n void ixgbe_full_sync_mac_table(struct ixgbe_adapter *adapter);\n #endif\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex bb4b53f..358b50c 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -1155,12 +1155,17 @@ static int ixgbe_set_eeprom(struct net_device *netdev,\n \treturn ret_val;\n }\n \n-void ixgbe_refresh_fw_version(struct ixgbe_adapter *adapter)\n+int ixgbe_refresh_fw_version(struct ixgbe_adapter *adapter)\n {\n \tstruct ixgbe_hw *hw = &adapter->hw;\n+\tint err;\n+\n+\terr = ixgbe_get_flash_data(hw);\n+\tif (err)\n+\t\treturn err;\n \n-\tixgbe_get_flash_data(hw);\n \tixgbe_set_fw_version_e610(adapter);\n+\treturn 0;\n }\n \n static void ixgbe_get_drvinfo(struct net_device *netdev,\n@@ -1168,10 +1173,6 @@ static void ixgbe_get_drvinfo(struct net_device *netdev,\n {\n \tstruct ixgbe_adapter *adapter = ixgbe_from_netdev(netdev);\n \n-\t/* need to refresh info for e610 in case fw reloads in runtime */\n-\tif (adapter->hw.mac.type == ixgbe_mac_e610)\n-\t\tixgbe_refresh_fw_version(adapter);\n-\n \tstrscpy(drvinfo->driver, ixgbe_driver_name, sizeof(drvinfo->driver));\n \n \tstrscpy(drvinfo->fw_version, adapter->eeprom_id,\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex c58051e4..8b07f25 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -6289,6 +6289,16 @@ void ixgbe_reinit_locked(struct ixgbe_adapter *adapter)\n \tif (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)\n \t\tmsleep(2000);\n \tixgbe_up(adapter);\n+\n+\t/* E610 has no FW event to notify all PFs of an EMPR reset, so\n+\t * refresh the FW version here to pick up any new FW version after\n+\t * a hardware reset (e.g. EMPR triggered by another PF's devlink\n+\t * reload). ixgbe_refresh_fw_version() updates both hw->flash and\n+\t * adapter->eeprom_id so ethtool -i reports the correct string.\n+\t */\n+\tif (adapter->hw.mac.type == ixgbe_mac_e610)\n+\t\t(void)ixgbe_refresh_fw_version(adapter);\n+\n \tclear_bit(__IXGBE_RESETTING, &adapter->state);\n }\n \n", "prefixes": [ "iwl-net", "v1" ] }