Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2203976/?format=api
{ "id": 2203976, "url": "http://patchwork.ozlabs.org/api/patches/2203976/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260303012831.662492-1-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260303012831.662492-1-joshua.a.hay@intel.com>", "list_archive_url": null, "date": "2026-03-03T01:28:31", "name": "[iwl-net] idpf: clear stale cdev_info ptr", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "13cb8d2e898cf46ac8909deb2bbdd7b6b66f2c21", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260303012831.662492-1-joshua.a.hay@intel.com/mbox/", "series": [ { "id": 494103, "url": "http://patchwork.ozlabs.org/api/series/494103/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=494103", "date": "2026-03-03T01:28:31", "name": "[iwl-net] idpf: clear stale cdev_info ptr", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/494103/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2203976/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2203976/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=N2iLYAiS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fPyc020X4z1xw1\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 03 Mar 2026 12:18:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 2082141ADE;\n\tTue, 3 Mar 2026 01:18:21 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id a12tCngQVd0Q; Tue, 3 Mar 2026 01:18:20 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 577BE41963;\n\tTue, 3 Mar 2026 01:18:20 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id A6C3D25B\n for <intel-wired-lan@lists.osuosl.org>; Tue, 3 Mar 2026 01:18:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 8CDA781DF7\n for <intel-wired-lan@lists.osuosl.org>; Tue, 3 Mar 2026 01:18:19 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id gFIgP98tY103 for <intel-wired-lan@lists.osuosl.org>;\n Tue, 3 Mar 2026 01:18:18 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.9])\n by smtp1.osuosl.org (Postfix) with ESMTPS id C00C281DF1\n for <intel-wired-lan@lists.osuosl.org>; Tue, 3 Mar 2026 01:17:57 +0000 (UTC)", "from orviesa010.jf.intel.com ([10.64.159.150])\n by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Mar 2026 17:17:57 -0800", "from dcskidmo-m40.jf.intel.com ([10.166.241.14])\n by orviesa010.jf.intel.com with ESMTP; 02 Mar 2026 17:17:57 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 577BE41963", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org C00C281DF1" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1772500700;\n\tbh=WZ8e7Xak0ZBcO99hGC51nMf3+uY6CrxdyTmG5FFQVFc=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=N2iLYAiSCV8BdtR31iacy2MkvhSdarxf/ck1OYijuVtyU3oHM5RDqdUM/P39ijL0O\n\t YodpxsSD1oikIINHBC8vvyVic8l2xSDa7pAn+x628fxn3gKN5L5KHmIgycWEDG7yPX\n\t jz3xdYTGOcyUC6T2OR1WLSchPIOflNVJcS4PI3QLGiTlk3ESzAioXp2tTRayelBfIx\n\t pXESQJe+7z+vm0BphYGFsm5eOb98E0X8eWzarqmMF2axFe/3pzkLCqwPyAsmPBjWV2\n\t EleFKrfgChAO6x21aouvwHiRDOx19QMst+1LtT7qk0mnmgmYwRPpTydagh3I7C8aCH\n\t /tRh0Be/cY9Nw==", "Received-SPF": "Temperror (mailfrom) identity=mailfrom; client-ip=198.175.65.9;\n helo=mgamail.intel.com; envelope-from=joshua.a.hay@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org C00C281DF1", "X-CSE-ConnectionGUID": [ "6zepvtHCRCCmQy8ahvaZBA==", "7B/3Sl81TgG4P9UlbQocbg==" ], "X-CSE-MsgGUID": [ "HtwLIKtOSCG0Mr6U42mFNw==", "r7+fbmdWQ/+ld7cGDSSWwA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11717\"; a=\"96137599\"", "E=Sophos;i=\"6.21,321,1763452800\"; d=\"scan'208\";a=\"96137599\"", "E=Sophos;i=\"6.21,321,1763452800\"; d=\"scan'208\";a=\"217064310\"" ], "X-ExtLoop1": "1", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, Joshua Hay <joshua.a.hay@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Mon, 2 Mar 2026 17:28:31 -0800", "Message-Id": "<20260303012831.662492-1-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1772500698; x=1804036698;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=YyV/2W+rzuQDsuStd2bW++jjatn642X5DiNInwOahgE=;\n b=Ugz8z3V+5WgU9/1CmX8dJgdMdJw+AqR8SBIEVFYYVAhv1LcwMoDvcP2F\n lvI/hoszDKbq9pcB//TZoMgm8urR7vP/KCHqJSU1raDpy+QYi4DI0DIvg\n P1C0Xc/eDPIsLipZifgC+S2sPZwYxyUXv/ZvrsGv6IAyAWJQALZx7u1Dd\n K+d4nuHgKRtD2oNeyuR4MsmNnU8hQHys4PcS5PfJYvg2QZQiRliLV10tw\n 9b0BDbMck2Bxxrf4tyKs+BBsOibbDfxQAIwsDVLsdDO/DfC83Cl4XNW9k\n 0VvjcIVSGYIvz0WEHDvbqhsP52Ml8OFNhELlSR7MajCyMqInn4BCz4PHD\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Ugz8z3V+" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net] idpf: clear stale cdev_info ptr", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Deinit calls idpf_idc_deinit_core_aux_device to free the cdev_info\nmemory, but leaves the adapter->cdev_info field with a stale pointer\nvalue. This will bypass subsequent \"if (!cdev_info)\" checks if cdev_info\nis not reallocated. For example, if idc_init fails after a reset,\ncdev_info will already have been freed during the reset handling, but it\nwill not have been reallocated. The next reset or rmmod will result in a\ncrash.\n\n[ +0.000008] BUG: kernel NULL pointer dereference, address: 00000000000000d0\n[ +0.000033] #PF: supervisor read access in kernel mode\n[ +0.000020] #PF: error_code(0x0000) - not-present page\n[ +0.000017] PGD 2097dfa067 P4D 0\n[ +0.000017] Oops: Oops: 0000 [#1] SMP NOPTI\n...\n[ +0.000018] RIP: 0010:device_del+0x3e/0x3d0\n[ +0.000010] Call Trace:\n[ +0.000010] <TASK>\n[ +0.000012] idpf_idc_deinit_core_aux_device+0x36/0x70 [idpf]\n[ +0.000034] idpf_vc_core_deinit+0x3e/0x180 [idpf]\n[ +0.000035] idpf_remove+0x40/0x1d0 [idpf]\n[ +0.000035] pci_device_remove+0x42/0xb0\n[ +0.000020] device_release_driver_internal+0x19c/0x200\n[ +0.000024] driver_detach+0x48/0x90\n[ +0.000018] bus_remove_driver+0x6d/0x100\n[ +0.000023] pci_unregister_driver+0x2e/0xb0\n[ +0.000022] __do_sys_delete_module.isra.0+0x18c/0x2b0\n[ +0.000025] ? kmem_cache_free+0x2c2/0x390\n[ +0.000023] do_syscall_64+0x107/0x7d0\n[ +0.000023] entry_SYSCALL_64_after_hwframe+0x76/0x7e\n\nPass the adapter struct into idpf_idc_deinit_core_aux_device instead and\nclear the cdev_info ptr.\n\nFixes: f4312e6bfa2a (\"idpf: implement core RDMA auxiliary dev create, init, and destroy\")\nSigned-off-by: Joshua Hay <joshua.a.hay@intel.com>\nReviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/idpf/idpf.h | 2 +-\n drivers/net/ethernet/intel/idpf/idpf_idc.c | 6 ++++--\n drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 2 +-\n 3 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h\nindex b206fba092c8..ec1b75f039bb 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf.h\n+++ b/drivers/net/ethernet/intel/idpf/idpf.h\n@@ -1066,7 +1066,7 @@ bool idpf_vport_set_hsplit(const struct idpf_vport *vport, u8 val);\n int idpf_idc_init(struct idpf_adapter *adapter);\n int idpf_idc_init_aux_core_dev(struct idpf_adapter *adapter,\n \t\t\t enum iidc_function_type ftype);\n-void idpf_idc_deinit_core_aux_device(struct iidc_rdma_core_dev_info *cdev_info);\n+void idpf_idc_deinit_core_aux_device(struct idpf_adapter *adapter);\n void idpf_idc_deinit_vport_aux_device(struct iidc_rdma_vport_dev_info *vdev_info);\n void idpf_idc_issue_reset_event(struct iidc_rdma_core_dev_info *cdev_info);\n void idpf_idc_vdev_mtu_event(struct iidc_rdma_vport_dev_info *vdev_info,\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ethernet/intel/idpf/idpf_idc.c\nindex bd4785fb8d3e..7e4f4ac92653 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_idc.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n@@ -470,10 +470,11 @@ int idpf_idc_init_aux_core_dev(struct idpf_adapter *adapter,\n \n /**\n * idpf_idc_deinit_core_aux_device - de-initialize Auxiliary Device(s)\n- * @cdev_info: IDC core device info pointer\n+ * @adapter: driver private data structure\n */\n-void idpf_idc_deinit_core_aux_device(struct iidc_rdma_core_dev_info *cdev_info)\n+void idpf_idc_deinit_core_aux_device(struct idpf_adapter *adapter)\n {\n+\tstruct iidc_rdma_core_dev_info *cdev_info = adapter->cdev_info;\n \tstruct iidc_rdma_priv_dev_info *privd;\n \n \tif (!cdev_info)\n@@ -485,6 +486,7 @@ void idpf_idc_deinit_core_aux_device(struct iidc_rdma_core_dev_info *cdev_info)\n \tkfree(privd->mapped_mem_regions);\n \tkfree(privd);\n \tkfree(cdev_info);\n+\tadapter->cdev_info = NULL;\n }\n \n /**\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\nindex d5a877e1fef8..113ecfc16dd7 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n@@ -3668,7 +3668,7 @@ void idpf_vc_core_deinit(struct idpf_adapter *adapter)\n \n \tidpf_ptp_release(adapter);\n \tidpf_deinit_task(adapter);\n-\tidpf_idc_deinit_core_aux_device(adapter->cdev_info);\n+\tidpf_idc_deinit_core_aux_device(adapter);\n \tidpf_rel_rx_pt_lkup(adapter);\n \tidpf_intr_rel(adapter);\n \n", "prefixes": [ "iwl-net" ] }