Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2202636/?format=api
{ "id": 2202636, "url": "http://patchwork.ozlabs.org/api/patches/2202636/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227223207.972-2-shiju.jose@huawei.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260227223207.972-2-shiju.jose@huawei.com>", "list_archive_url": null, "date": "2026-02-27T22:32:04", "name": "[1/3] hw/cxl: Add fixes in maintenance and memory sparing", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d60f0f6445802978511b983071541e6ba9bb95e4", "submitter": { "id": 71296, "url": "http://patchwork.ozlabs.org/api/people/71296/?format=api", "name": "shiju.jose--- via qemu development", "email": "qemu-devel@nongnu.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227223207.972-2-shiju.jose@huawei.com/mbox/", "series": [ { "id": 493825, "url": "http://patchwork.ozlabs.org/api/series/493825/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=493825", "date": "2026-02-27T22:32:05", "name": "hw/cxl: Add fixes in maintenance, PPR and event records", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/493825/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2202636/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2202636/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fN34P3PZ3z1xyX\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2026 09:32:53 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vw6Nh-0004BM-AY; Fri, 27 Feb 2026 17:32:21 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <shiju.jose@huawei.com>)\n id 1vw6Nf-0004AV-NT\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 17:32:19 -0500", "from frasgout.his.huawei.com ([185.176.79.56])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <shiju.jose@huawei.com>)\n id 1vw6Nd-0001k2-SH\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 17:32:19 -0500", "from mail.maildlp.com (unknown [172.18.224.83])\n by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4fN32X329NzHnGch;\n Sat, 28 Feb 2026 06:31:16 +0800 (CST)", "from dubpeml500008.china.huawei.com (unknown [7.214.146.94])\n by mail.maildlp.com (Postfix) with ESMTPS id 1962240569;\n Sat, 28 Feb 2026 06:32:03 +0800 (CST)", "from P_UKIT01-A7bmah.china.huawei.com (10.126.175.34) by\n dubpeml500008.china.huawei.com (7.214.146.94) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1544.11; Fri, 27 Feb 2026 22:32:02 +0000" ], "To": "<qemu-devel@nongnu.org>, <linux-cxl@vger.kernel.org>, <mst@redhat.com>,\n <peter.maydell@linaro.org>, <jonathan.cameron@huawei.com>,\n <dave@stgolabs.net>", "CC": "<linuxarm@huawei.com>, <shiju.jose@huawei.com>", "Subject": "[PATCH 1/3] hw/cxl: Add fixes in maintenance and memory sparing", "Date": "Fri, 27 Feb 2026 22:32:04 +0000", "Message-ID": "<20260227223207.972-2-shiju.jose@huawei.com>", "X-Mailer": "git-send-email 2.43.0.windows.1", "In-Reply-To": "<20260227223207.972-1-shiju.jose@huawei.com>", "References": "<20260227223207.972-1-shiju.jose@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.175.34]", "X-ClientProxiedBy": "lhrpeml100012.china.huawei.com (7.191.174.184) To\n dubpeml500008.china.huawei.com (7.214.146.94)", "Received-SPF": "pass client-ip=185.176.79.56;\n envelope-from=shiju.jose@huawei.com;\n helo=frasgout.his.huawei.com", "X-Spam_score_int": "-30", "X-Spam_score": "-3.1", "X-Spam_bar": "---", "X-Spam_report": "(-3.1 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.706,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.401,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Reply-to": "<shiju.jose@huawei.com>", "From": "shiju.jose--- via qemu development <qemu-devel@nongnu.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Shiju Jose <shiju.jose@huawei.com>\n\nAdd following fixes to the commit: hw/cxl: Add support for Maintenance\ncommand and Post Package Repair (PPR).\n\n1. In cxl_create_mem_sparing_event_records(), replace strncpy with memcpy to\nsolve coverity warning because full size of the array to use as length in\nstrncpy to copy the entire component id data, which is 16 bytes.\n\n2. In cxl_maintenance_insert(),\n - replace strncpy with memcpy in to copy full data because component id is\n 16 bytes data.\n - remove memset which is not required.\n\nReported-by: Peter Maydell <peter.maydell@linaro.org>\nSigned-off-by: Shiju Jose <shiju.jose@huawei.com>\n---\n hw/cxl/cxl-mailbox-utils.c | 4 ++--\n hw/mem/cxl_type3.c | 4 +---\n 2 files changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c\nindex c83b5f90d4..9c99422cd4 100644\n--- a/hw/cxl/cxl-mailbox-utils.c\n+++ b/hw/cxl/cxl-mailbox-utils.c\n@@ -1994,8 +1994,8 @@ static void cxl_create_mem_sparing_event_records(CXLType3Dev *ct3d,\n stw_le_p(&event_rec.column, ent->column);\n event_rec.sub_channel = ent->sub_channel;\n if (ent->validity_flags & CXL_MSER_VALID_COMP_ID) {\n- strncpy((char *)event_rec.component_id, (char *)ent->component_id,\n- sizeof(event_rec.component_id));\n+ memcpy(event_rec.component_id, ent->component_id,\n+ sizeof(event_rec.component_id));\n }\n } else if (sparing_pi) {\n event_rec.flags = CXL_MSER_FLAGS_QUERY_RESOURCES;\ndiff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c\nindex 4739239da3..3cb1096e16 100644\n--- a/hw/mem/cxl_type3.c\n+++ b/hw/mem/cxl_type3.c\n@@ -1767,7 +1767,6 @@ static void cxl_maintenance_insert(CXLType3Dev *ct3d, uint64_t dpa,\n }\n }\n m = g_new0(CXLMaintenance, 1);\n- memset(m, 0, sizeof(*m));\n m->dpa = dpa;\n m->validity_flags = 0;\n \n@@ -1804,8 +1803,7 @@ static void cxl_maintenance_insert(CXLType3Dev *ct3d, uint64_t dpa,\n m->validity_flags |= CXL_MSER_VALID_SUB_CHANNEL;\n }\n if (component_id) {\n- strncpy((char *)m->component_id, component_id,\n- sizeof(m->component_id) - 1);\n+ memcpy(m->component_id, component_id, sizeof(m->component_id));\n m->validity_flags |= CXL_MSER_VALID_COMP_ID;\n if (has_comp_id_pldm && is_comp_id_pldm) {\n m->validity_flags |= CXL_MSER_VALID_COMP_ID_FORMAT;\n", "prefixes": [ "1/3" ] }