Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2202627/?format=api
{ "id": 2202627, "url": "http://patchwork.ozlabs.org/api/patches/2202627/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227221632.827046-10-vivek.kasireddy@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260227221632.827046-10-vivek.kasireddy@intel.com>", "list_archive_url": null, "date": "2026-02-27T22:13:55", "name": "[v8,09/10] virtio-gpu-dmabuf: Improve error handling with 'Error **' and err enum", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3c0e631347ec45524b5e23555143c333fe267da9", "submitter": { "id": 81116, "url": "http://patchwork.ozlabs.org/api/people/81116/?format=api", "name": "Vivek Kasireddy", "email": "vivek.kasireddy@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227221632.827046-10-vivek.kasireddy@intel.com/mbox/", "series": [ { "id": 493824, "url": "http://patchwork.ozlabs.org/api/series/493824/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=493824", "date": "2026-02-27T22:13:46", "name": "vfio: Create dmabuf from multiple VFIO ranges and use it in virtio-gpu", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/493824/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2202627/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2202627/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=dr2iPaaZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fN2p94WqGz1xxx\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2026 09:20:33 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vw6Bl-00067k-JJ; Fri, 27 Feb 2026 17:20:01 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vivek.kasireddy@intel.com>)\n id 1vw6Bh-00067B-NR\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 17:19:57 -0500", "from mgamail.intel.com ([198.175.65.16])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vivek.kasireddy@intel.com>)\n id 1vw6Bf-0007m5-6R\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 17:19:56 -0500", "from fmviesa003.fm.intel.com ([10.60.135.143])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Feb 2026 14:19:41 -0800", "from vkasired-desk2.fm.intel.com ([10.105.128.132])\n by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Feb 2026 14:19:40 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1772230795; x=1803766795;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=tvGLLWt/KVjrGwxv7KBoBI5nAuzCFdI/ypVr4mmfOqY=;\n b=dr2iPaaZRU2W5pTHBoUViAGuVoAf+HwS25WAxNeV5iQCL6GwIbymAAgQ\n 1kAt8+qvSg8lYZw66vEywuJdXBVITmL26rmEGKFSj95xZSL83wCfMWSOU\n JpX9vfm5KrsO4aV/DPxSGK2cIY5PFn5AIysa0NIAhxBmd6VvTVFFW/JsP\n YdDbk5i1J77tEnD+Fx0yYFbwnRsSHoAuAvbKxXfZLIJilf8TbuptAYDQD\n ZjIehxtAovu/hvgQnnL5ep2oTK0MrqgVWyTSEAvnrHka0IPw0fWEGOkvV\n c+ZGPTn9WF7iD6ohVnKMzqF9FQW8M+BcDwvwRRorNwY6TnOQNUHdT8AyI g==;", "X-CSE-ConnectionGUID": [ "wvGPkJOQSyihfrJXenM9bg==", "SjVVzUI4TCmCae/aCs3JMQ==" ], "X-CSE-MsgGUID": [ "UHp+2VrbSTSfwD71sjBwzA==", "NXkHtFmwSh6Gve+hqZlFmw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11714\"; a=\"73509368\"", "E=Sophos;i=\"6.21,314,1763452800\"; d=\"scan'208\";a=\"73509368\"" ], "X-ExtLoop1": "1", "From": "Vivek Kasireddy <vivek.kasireddy@intel.com>", "To": "qemu-devel@nongnu.org", "Cc": "Vivek Kasireddy <vivek.kasireddy@intel.com>, =?utf-8?q?Marc-Andr=C3=A9_L?=\n\t=?utf-8?q?ureau?= <marcandre.lureau@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Dmitry Osipenko <dmitry.osipenko@collabora.com>,\n Alex Williamson <alex@shazbot.org>,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@redhat.com>", "Subject": "[PATCH v8 09/10] virtio-gpu-dmabuf: Improve error handling with\n 'Error **' and err enum", "Date": "Fri, 27 Feb 2026 14:13:55 -0800", "Message-ID": "<20260227221632.827046-10-vivek.kasireddy@intel.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260227221632.827046-1-vivek.kasireddy@intel.com>", "References": "<20260227221632.827046-1-vivek.kasireddy@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.16;\n envelope-from=vivek.kasireddy@intel.com; helo=mgamail.intel.com", "X-Spam_score_int": "-32", "X-Spam_score": "-3.3", "X-Spam_bar": "---", "X-Spam_report": "(-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.706,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.401, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Make the error handling more robust in virtio_gpu_init_udmabuf()\nby introducing 'Error **' parameter to capture errors and using an\nenum from VFIO to categorize Guest and Host errors. This allows\nfor better error reporting and handling of errors from\nvirtio_gpu_create_udmabuf() and virtio_gpu_remap_dmabuf().\n\nCc: Marc-André Lureau <marcandre.lureau@redhat.com>\nCc: Alex Bennée <alex.bennee@linaro.org>\nCc: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>\nCc: Dmitry Osipenko <dmitry.osipenko@collabora.com>\nCc: Alex Williamson <alex@shazbot.org>\nCc: Cédric Le Goater <clg@redhat.com>\nSigned-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>\n---\n hw/display/virtio-gpu-dmabuf.c | 61 ++++++++++++++++++++++++----------\n 1 file changed, 43 insertions(+), 18 deletions(-)", "diff": "diff --git a/hw/display/virtio-gpu-dmabuf.c b/hw/display/virtio-gpu-dmabuf.c\nindex 8d67ef7c2a..b2badfc1bd 100644\n--- a/hw/display/virtio-gpu-dmabuf.c\n+++ b/hw/display/virtio-gpu-dmabuf.c\n@@ -18,6 +18,7 @@\n #include \"ui/console.h\"\n #include \"hw/virtio/virtio-gpu.h\"\n #include \"hw/virtio/virtio-gpu-pixman.h\"\n+#include \"hw/vfio/vfio-device.h\"\n #include \"trace.h\"\n #include \"system/ramblock.h\"\n #include \"system/hostmem.h\"\n@@ -27,16 +28,18 @@\n #include \"standard-headers/linux/udmabuf.h\"\n #include \"standard-headers/drm/drm_fourcc.h\"\n \n-static void virtio_gpu_create_udmabuf(struct virtio_gpu_simple_resource *res)\n+static int virtio_gpu_create_udmabuf(struct virtio_gpu_simple_resource *res,\n+ Error **errp)\n {\n g_autofree struct udmabuf_create_list *list = NULL;\n RAMBlock *rb;\n ram_addr_t offset;\n- int udmabuf, i;\n+ int udmabuf, i, fd;\n \n udmabuf = udmabuf_fd();\n if (udmabuf < 0) {\n- return;\n+ error_setg(errp, \"udmabuf device not available or enabled\");\n+ return VFIO_DMABUF_CREATE_HOST_ERROR;\n }\n \n list = g_malloc0(sizeof(struct udmabuf_create_list) +\n@@ -45,7 +48,8 @@ static void virtio_gpu_create_udmabuf(struct virtio_gpu_simple_resource *res)\n for (i = 0; i < res->iov_cnt; i++) {\n rb = qemu_ram_block_from_host(res->iov[i].iov_base, false, &offset);\n if (!rb || rb->fd < 0) {\n- return;\n+ error_setg(errp, \"IOV memory address incompatible with udmabuf \");\n+ return VFIO_DMABUF_CREATE_GUEST_ERROR;\n }\n \n list->list[i].memfd = rb->fd;\n@@ -56,22 +60,30 @@ static void virtio_gpu_create_udmabuf(struct virtio_gpu_simple_resource *res)\n list->count = res->iov_cnt;\n list->flags = UDMABUF_FLAGS_CLOEXEC;\n \n- res->dmabuf_fd = ioctl(udmabuf, UDMABUF_CREATE_LIST, list);\n- if (res->dmabuf_fd < 0) {\n- warn_report(\"%s: UDMABUF_CREATE_LIST: %s\", __func__,\n- strerror(errno));\n+ fd = ioctl(udmabuf, UDMABUF_CREATE_LIST, list);\n+ if (fd < 0) {\n+ error_setg_errno(errp, errno, \"UDMABUF_CREATE_LIST: ioctl failed\");\n+ if (errno == EINVAL || errno == EBADFD) {\n+ return VFIO_DMABUF_CREATE_GUEST_ERROR;\n+ }\n+ return VFIO_DMABUF_CREATE_HOST_ERROR;\n }\n+ return fd;\n }\n \n-static void virtio_gpu_remap_dmabuf(struct virtio_gpu_simple_resource *res)\n+static bool virtio_gpu_remap_dmabuf(struct virtio_gpu_simple_resource *res,\n+ Error **errp)\n {\n- res->remapped = mmap(NULL, res->blob_size, PROT_READ,\n- MAP_SHARED, res->dmabuf_fd, 0);\n- if (res->remapped == MAP_FAILED) {\n- warn_report(\"%s: dmabuf mmap failed: %s\", __func__,\n- strerror(errno));\n+ void *map;\n+\n+ map = mmap(NULL, res->blob_size, PROT_READ, MAP_SHARED, res->dmabuf_fd, 0);\n+ if (map == MAP_FAILED) {\n+ error_setg_errno(errp, errno, \"dmabuf mmap failed\");\n res->remapped = NULL;\n+ return false;\n }\n+ res->remapped = map;\n+ return true;\n }\n \n static void virtio_gpu_destroy_dmabuf(struct virtio_gpu_simple_resource *res)\n@@ -125,19 +137,32 @@ bool virtio_gpu_have_udmabuf(void)\n \n void virtio_gpu_init_dmabuf(struct virtio_gpu_simple_resource *res)\n {\n+ Error *local_err = NULL;\n void *pdata = NULL;\n+ int ret;\n \n res->dmabuf_fd = -1;\n if (res->iov_cnt == 1 &&\n res->iov[0].iov_len < 4096) {\n pdata = res->iov[0].iov_base;\n } else {\n- virtio_gpu_create_udmabuf(res);\n- if (res->dmabuf_fd < 0) {\n+ ret = virtio_gpu_create_udmabuf(res, &local_err);\n+ if (ret < 0) {\n+ error_prepend(&local_err, \"Cannot create dmabuf: \");\n+\n+ if (ret == VFIO_DMABUF_CREATE_GUEST_ERROR) {\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"Cannot create dmabuf: incompatible memory\\n\");\n+ error_free(local_err);\n+ return;\n+ }\n+ error_report_err(local_err);\n return;\n }\n- virtio_gpu_remap_dmabuf(res);\n- if (!res->remapped) {\n+\n+ res->dmabuf_fd = ret;\n+ if (!virtio_gpu_remap_dmabuf(res, &local_err)) {\n+ error_report_err(local_err);\n return;\n }\n pdata = res->remapped;\n", "prefixes": [ "v8", "09/10" ] }