Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2202617/?format=api
{ "id": 2202617, "url": "http://patchwork.ozlabs.org/api/patches/2202617/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-gpio/patch/20260227215624.1094832-2-ethantidmore06@gmail.com/", "project": { "id": 42, "url": "http://patchwork.ozlabs.org/api/projects/42/?format=api", "name": "Linux GPIO development", "link_name": "linux-gpio", "list_id": "linux-gpio.vger.kernel.org", "list_email": "linux-gpio@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260227215624.1094832-2-ethantidmore06@gmail.com>", "list_archive_url": null, "date": "2026-02-27T21:56:23", "name": "[v2,1/2] pinctrl: pinctrl-pic32: Fix resource leak", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f2121202d47030ef32808f90237641c5091a0890", "submitter": { "id": 92641, "url": "http://patchwork.ozlabs.org/api/people/92641/?format=api", "name": "Ethan Tidmore", "email": "ethantidmore06@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-gpio/patch/20260227215624.1094832-2-ethantidmore06@gmail.com/mbox/", "series": [ { "id": 493821, "url": "http://patchwork.ozlabs.org/api/series/493821/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-gpio/list/?series=493821", "date": "2026-02-27T21:56:22", "name": "pinctrl: pinctrl-pic32: Fix resource leak and convert last manual allocation to devres", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/493821/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2202617/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2202617/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-gpio+bounces-32334-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-gpio@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=a8kxxp+3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-32334-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"a8kxxp+3\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=74.125.224.45", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fN2H10GTRz1xph\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2026 08:57:00 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id E1E4930698E2\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Feb 2026 21:56:53 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7E57E47A0CD;\n\tFri, 27 Feb 2026 21:56:49 +0000 (UTC)", "from mail-yx1-f45.google.com (mail-yx1-f45.google.com\n [74.125.224.45])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 235523451CC\n\tfor <linux-gpio@vger.kernel.org>; Fri, 27 Feb 2026 21:56:48 +0000 (UTC)", "by mail-yx1-f45.google.com with SMTP id\n 956f58d0204a3-64aea64bf15so2253949d50.2\n for <linux-gpio@vger.kernel.org>;\n Fri, 27 Feb 2026 13:56:48 -0800 (PST)", "from tux ([2601:7c0:c37c:4c00::5c0b])\n by smtp.gmail.com with ESMTPSA id\n 956f58d0204a3-64cb75a1157sm2948509d50.6.2026.02.27.13.56.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Feb 2026 13:56:46 -0800 (PST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1772229409; cv=none;\n b=VKXxBxIDkplFeloDqa4r+1Lnbq/JodvQyFPHJa6esw8sLX1eMwfuuGycCpUpeV6UiQBZ+pTH0NGcl+Mhpa4DzuO/SsgczcpXwppoN+MW9w3Mo2NOoV35z4MBSowmxf4rXzkbsqRn/MonXlz9hYlkT/aqeXH384yj36ENXBATNWU=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1772229409; c=relaxed/simple;\n\tbh=GQDN1R2s9mM921F8hqC+JQetSAhVPiZawRGbiievuNw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=d2w9daDDWnstHetadwYoB2yUXQ9qFyqIH7RN6wUSf2DeGx3ukwO5vLesilqfOBWCq4Nw7ZBPrCk1xIhmpIPnHXn+1df+wXgkMrGc+pljduiLzG4CzYAtDFZvzvN5ht3r59jF54Da6GU7YnOWGdMLdwqtbaLYxn/b7uYpgdXFrxM=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=a8kxxp+3; arc=none smtp.client-ip=74.125.224.45", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1772229407; x=1772834207;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=b/E4mXwswRGJTxuG0f6Dlg/ntBjWKWPl5F6qxEETdII=;\n b=a8kxxp+3mQs36q2WcTPuyJZvM5LR83EWWI77/h6QUcf4L/vOlG2edVn9tcPigWqp/y\n JoK3WNZPifxgqzeizEA83VD4V5HW72zjtCMBK3FYiBE1JVfKMGxHREBTGbEnp8p7TGCP\n ufh2HhZQ9q7X8y/pOuND+n1G1hiLs6EvXLABNSdLZ8firoagLpaXows2nq21n60Q/dGz\n WyWIS9WnCVUlRp+TkmnhyXrvuK/falfnGkWyzdsXHf0S9B1+6PFDbigROcagHF9rLv2d\n QP4bm7i1fx1tfXmAgisAyvEashz+VSFAvjLKnWoYrm4KJ9qmJJWF4kBbVOA3DduuuHxA\n CT7Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1772229407; x=1772834207;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=b/E4mXwswRGJTxuG0f6Dlg/ntBjWKWPl5F6qxEETdII=;\n b=DQsmrtLfUReOFGZzQhkQF5P+CK73wyXIuyhVW+36692dMeDvkeIkEzd8ag6kAgRzDy\n 2pVMR+5cOn1N6WkGHAA2rUwN2HCortVQFUCr+vM+exnWVmEuT8fw4ZqVOg1q5oTV0Zyh\n Ds8OHtzddsU6GhefyFXa5hW3mHQkpBl3JMriK5Ulq2I1HukIwz5+6LQgPTjrzhGVBtiL\n ksN5d772pnjJXf5ZPauDL/5U1XKWtMSq95hn1t1zIUBEakQ0ujUNzYxQfv0JiQ/pMyW1\n 6ZFwPUZ5MgmE7YB4w9d2xnBURl9PcNGyGrKzxv+NPpMyvGzwQWJ+PEUdShWmgDwJjI8r\n Vm2g==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCXe7O/s3eKXk8QTQaEd/wslGnr4CaBp/F6kSlPuOQz4vCyGwspV9bJhTrGbeG51lu3/Xes3GSdktXhA@vger.kernel.org", "X-Gm-Message-State": "AOJu0Ywi2VNB/4kYV0hHarRWZhF+9/7Puj+oMicTuT3FXwdvQLuVV2mT\n\tQ3ecRsypWgQ+6NOJ+aTBAdbxPy4aHeYpjE8NvZ1FbZArqb5lVR/wrZNz4HcTapOW3nA=", "X-Gm-Gg": "ATEYQzwOlOYEcarLkQaRz2F3qQgZ3wLOXqF2j0ocG/vxA5vmPGkY0/RyIHfKCes1mbU\n\tuEG4fqL71pr5LLUkC80FGu5XMOSxA/RqcefP+3/110KV70oX34GSFXXHzqPWq17O4zsH3pvpUpm\n\tkRn5qt8sBiioTSyqW5egEvFogRDXRiMUygOGbo/iCz5zayBHnXVFvfA1UJu5yPV6lB78awWF3yT\n\tNrgW/GEd/a2xVPJa651ahRgWUfCQg5fnebMtfY4fGotYJycUPQfr1l3O4B4GfvmCpBKQz5yIusr\n\tIzAIlPiU38tY86rDi+8uyg7HxSJFM4Q4WrKR4m2FQy6GZptLlGFzFgQEeXYrGC2ttU97fYguVSb\n\tDDStfIx/wiu6ck1aD20zvmcZPrwD9Dwc0iytm0+VUmA5QybrPzFyqaUbUsAS1VX0yUWtooFkbbe\n\trTZXONHYfcti3ld1XgAMQbBVoaYU1vsRjIh1BzCohkvDGsxclBKFMlO8zjg2gYbCP1IuiHtrsgW\n\tUSTA9+e0lK8XIhBr9yMJG00", "X-Received": "by 2002:a53:e02f:0:b0:64a:d74f:2580 with SMTP id\n 956f58d0204a3-64cc2082d28mr2750707d50.1.1772229407133;\n Fri, 27 Feb 2026 13:56:47 -0800 (PST)", "From": "Ethan Tidmore <ethantidmore06@gmail.com>", "To": "Linus Walleij <linusw@kernel.org>", "Cc": "Joshua Henderson <joshua.henderson@microchip.com>,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tEthan Tidmore <ethantidmore06@gmail.com>", "Subject": "[PATCH v2 1/2] pinctrl: pinctrl-pic32: Fix resource leak", "Date": "Fri, 27 Feb 2026 15:56:23 -0600", "Message-ID": "<20260227215624.1094832-2-ethantidmore06@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260227215624.1094832-1-ethantidmore06@gmail.com>", "References": "<20260227215624.1094832-1-ethantidmore06@gmail.com>", "Precedence": "bulk", "X-Mailing-List": "linux-gpio@vger.kernel.org", "List-Id": "<linux-gpio.vger.kernel.org>", "List-Subscribe": "<mailto:linux-gpio+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-gpio+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Fix three possible resource leaks by using the devres version of\nclk_prepare_enable(). Also, update error message accordingly.\n\nDetected by Smatch:\ndrivers/pinctrl/pinctrl-pic32.c:2211 pic32_pinctrl_probe() warn:\n'pctl->clk' from clk_prepare_enable() not released on lines: 2208.\n\ndrivers/pinctrl/pinctrl-pic32.c:2274 pic32_gpio_probe() warn:\n'bank->clk' from clk_prepare_enable() not released on lines: 2264,2272.\n\nFixes: 2ba384e6c3810 (\"pinctrl: pinctrl-pic32: Add PIC32 pin control driver\")\nSigned-off-by: Ethan Tidmore <ethantidmore06@gmail.com>\n---\nv2:\n- Use devres instead of manual cleanup.\n\n drivers/pinctrl/pinctrl-pic32.c | 20 ++++----------------\n 1 file changed, 4 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/pinctrl/pinctrl-pic32.c b/drivers/pinctrl/pinctrl-pic32.c\nindex eb438c9d9667..d185fe48dc0d 100644\n--- a/drivers/pinctrl/pinctrl-pic32.c\n+++ b/drivers/pinctrl/pinctrl-pic32.c\n@@ -2174,16 +2174,10 @@ static int pic32_pinctrl_probe(struct platform_device *pdev)\n \tif (IS_ERR(pctl->reg_base))\n \t\treturn PTR_ERR(pctl->reg_base);\n \n-\tpctl->clk = devm_clk_get(&pdev->dev, NULL);\n+\tpctl->clk = devm_clk_get_enabled(&pdev->dev, NULL);\n \tif (IS_ERR(pctl->clk)) {\n \t\tret = PTR_ERR(pctl->clk);\n-\t\tdev_err(&pdev->dev, \"clk get failed\\n\");\n-\t\treturn ret;\n-\t}\n-\n-\tret = clk_prepare_enable(pctl->clk);\n-\tif (ret) {\n-\t\tdev_err(&pdev->dev, \"clk enable failed\\n\");\n+\t\tdev_err(&pdev->dev, \"Failed to get and enable clock\\n\");\n \t\treturn ret;\n \t}\n \n@@ -2239,16 +2233,10 @@ static int pic32_gpio_probe(struct platform_device *pdev)\n \tif (irq < 0)\n \t\treturn irq;\n \n-\tbank->clk = devm_clk_get(&pdev->dev, NULL);\n+\tbank->clk = devm_clk_get_enabled(&pdev->dev, NULL);\n \tif (IS_ERR(bank->clk)) {\n \t\tret = PTR_ERR(bank->clk);\n-\t\tdev_err(&pdev->dev, \"clk get failed\\n\");\n-\t\treturn ret;\n-\t}\n-\n-\tret = clk_prepare_enable(bank->clk);\n-\tif (ret) {\n-\t\tdev_err(&pdev->dev, \"clk enable failed\\n\");\n+\t\tdev_err(&pdev->dev, \"Failed to get and enable clock\\n\");\n \t\treturn ret;\n \t}\n \n", "prefixes": [ "v2", "1/2" ] }