Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2202600/?format=api
{ "id": 2202600, "url": "http://patchwork.ozlabs.org/api/patches/2202600/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227203944.746471-16-chad@jablonski.xyz/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260227203944.746471-16-chad@jablonski.xyz>", "list_archive_url": null, "date": "2026-02-27T20:39:41", "name": "[v9,15/18] ati-vga: Move source bounds validation to ati_2d_blt", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "71d63d77444124eef26d32f97f1772e2df2c4b80", "submitter": { "id": 91805, "url": "http://patchwork.ozlabs.org/api/people/91805/?format=api", "name": "Chad Jablonski", "email": "chad@jablonski.xyz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227203944.746471-16-chad@jablonski.xyz/mbox/", "series": [ { "id": 493814, "url": "http://patchwork.ozlabs.org/api/series/493814/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=493814", "date": "2026-02-27T20:39:27", "name": "ati-vga: Implement HOST_DATA transfers to enable X.org text rendering", "version": 9, "mbox": "http://patchwork.ozlabs.org/series/493814/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2202600/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2202600/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=jablonski.xyz header.i=@jablonski.xyz\n header.a=rsa-sha256 header.s=fm2 header.b=LXjUivcW;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=messagingengine.com header.i=@messagingengine.com\n header.a=rsa-sha256 header.s=fm3 header.b=rzofRfbY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fN0cs1lLvz1xxx\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2026 07:42:21 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vw4eX-0003Oj-Iw; Fri, 27 Feb 2026 15:41:37 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <chad@jablonski.xyz>)\n id 1vw4eC-0002c8-MF\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 15:41:16 -0500", "from fhigh-a7-smtp.messagingengine.com ([103.168.172.158])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <chad@jablonski.xyz>)\n id 1vw4eB-0007Qj-5A\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 15:41:16 -0500", "from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44])\n by mailfhigh.phl.internal (Postfix) with ESMTP id 8CAE6140018E;\n Fri, 27 Feb 2026 15:41:01 -0500 (EST)", "from phl-frontend-03 ([10.202.2.162])\n by phl-compute-04.internal (MEProxy); Fri, 27 Feb 2026 15:41:01 -0500", "by mail.messagingengine.com (Postfix) with ESMTPA; Fri,\n 27 Feb 2026 15:41:01 -0500 (EST)", "from localhost (chomposaur [local])\n by chomposaur (OpenSMTPD) with ESMTPA id 7f897a38;\n Fri, 27 Feb 2026 20:40:55 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz;\n h=cc:cc:content-transfer-encoding:content-type:date:date:from\n :from:in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to; s=fm2; t=1772224861; x=\n 1772311261; bh=RDbi4ttHSzdqquBLMjV4+kyLt9CNxdkTZv/NdVntPT4=; b=L\n XjUivcWSfsexWCdRmcyuO+dyA6A8u3mOOCTBgs22sZ8OSzx3DH5SBReiuCPB6gfG\n YSyRBOLY9Q9/5gSMuHF0QSZNNApycr4NDBSna14i5WViIZvVu8yy+2yslnC1GjoJ\n ecxDPxsfaG9gVH9VrXpKN37rAcw/HJCfc6NNFDqYI9M/1g74s3jYMRtgIA6t/9nL\n 2IpPnDU/c4LVUPSjM9GkpccCplTSiYiM4PvvAqLb1wNycmUgPrQLISSufMP2l4hy\n EJthGXhMHHOxt9mIjg3QzjVlJI6roUqzxRaxlKW2IqrQLC35rDKWK7hTNJX4mSE0\n 2FwOcruhcqeKrU5L5kyIg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:date:date:feedback-id:feedback-id:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender\n :x-me-sender:x-sasl-enc; s=fm3; t=1772224861; x=1772311261; bh=R\n Dbi4ttHSzdqquBLMjV4+kyLt9CNxdkTZv/NdVntPT4=; b=rzofRfbYtTebl8L2V\n FBwjsReIk3dmyAPPd6HRzpYtk/wlPTGr09NYUbVAkePn+PDyhpq+ywMn25NlSG88\n PqMQqieoDWtlTZp1WuGMOJJ/FC68wvtMKig3SNXCJJS1QY2juJ91+x36skG9KPjW\n XQTdy/XloX+HKzVjGnpMikLwl9elJtopNzJJKGhPXSnyG760YrIC2VNMZBCRIZ1z\n LHpF1MMuX3fgSEHq5PiiP5+YBaOVjPfgukqp+4FREzOBkNxeaz78dfSjCGENMvXQ\n Pyu7beNCfYCz69FIsbMIHDBu3cpwN8zaDWoAUVUA+SFN/a86XPUjGjqiYoqYjH18\n LJSSw==" ], "X-ME-Sender": "<xms:XQGiadvmGJwTRp2bJzL5IxdXxU1Sw0D43128gfoKV3_CDFqoLrF-BA>\n <xme:XQGiadXzE63CbIfhMp2Aad3DsPtr91gmpFKeWyCiXxOtwC3aZaOXTCggGRTR2faMJ\n XRNXbyIPIuXxaGbT0M2OXNKxX1nInQcKMX02jPnN_YweSn-_LzwqCQ>", "X-ME-Received": "\n <xmr:XQGiaZHC_r-sKttxVp9hTfRb5JYs1LYu0y_fbXA0UDSIwZEC552RYz7WKNWb>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvgeelleelucetufdoteggodetrf\n dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh\n hlucfvnfffucdljedtmdenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddt\n necuhfhrohhmpeevhhgrugculfgrsghlohhnshhkihcuoegthhgrugesjhgrsghlohhnsh\n hkihdrgiihiieqnecuggftrfgrthhtvghrnhepgfeiteejhfelheefieetjefgleejfffh\n ueffvdduieejgfeuueeuvddvkeejhfelnecuvehluhhsthgvrhfuihiivgepudenucfrrg\n hrrghmpehmrghilhhfrhhomheptghhrggusehjrggslhhonhhskhhirdighiiipdhnsggp\n rhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehqvghmuhdqug\n gvvhgvlhesnhhonhhgnhhurdhorhhgpdhrtghpthhtohepmhgrrhgtrghnughrvgdrlhhu\n rhgvrghusehrvgguhhgrthdrtghomhdprhgtphhtthhopehkrhgrgigvlhesrhgvughhrg\n htrdgtohhmpdhrtghpthhtohepsggrlhgrthhonhesvghikhdrsghmvgdrhhhupdhrtghp\n thhtoheptghhrggusehjrggslhhonhhskhhirdighiii", "X-ME-Proxy": "<xmx:XQGiaf1HlEOGAltomeWHD5isO7jh22QaDe51bM2H4sa7CVrej8usWw>\n <xmx:XQGiabOxIfd7gctVxR8NV8Blg4H6pxYUz8Rzj1gNUIP6ykN5fkQ8xw>\n <xmx:XQGiae7U_40bUQCMFu-Jy0yZ9aqMGGBhw7Rpa5YsGOcZcHE0IF-hZA>\n <xmx:XQGiaV3F3FS6biUZiw_WuuLb3xHnrDLXKCe8Mf6FwNCHRKP-hwUOBA>\n <xmx:XQGiabwMhcXhmhLBLtEToLmcT9RPY-bUz3c1HCk7DGJMOKoVEMoihjSQ>", "Feedback-ID": "ib26944c1:Fastmail", "From": "Chad Jablonski <chad@jablonski.xyz>", "To": "qemu-devel@nongnu.org", "Cc": "BALATON Zoltan <balaton@eik.bme.hu>, Gerd Hoffmann <kraxel@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Chad Jablonski <chad@jablonski.xyz>", "Subject": "[PATCH v9 15/18] ati-vga: Move source bounds validation to ati_2d_blt", "Date": "Fri, 27 Feb 2026 15:39:41 -0500", "Message-ID": "<20260227203944.746471-16-chad@jablonski.xyz>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260227203944.746471-1-chad@jablonski.xyz>", "References": "<20260227203944.746471-1-chad@jablonski.xyz>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=103.168.172.158;\n envelope-from=chad@jablonski.xyz;\n helo=fhigh-a7-smtp.messagingengine.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1,\n DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5,\n PDS_OTHER_BAD_TLD=1.999, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.706,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.401,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "A call to ati_2d_blt implies that the source will be vram. Checking\nbounds is useful in that case. Other sources (HOST_DATA) will not make\nsense to check against vram bounds.\n\nSigned-off-by: Chad Jablonski <chad@jablonski.xyz>\nReviewed-by: BALATON Zoltan <balaton@eik.bme.hu>\n\n---\n\nChanges from v8:\n\nThe source bound validation was being performed in all cases, even for\nblits that weren't using the source. It now limits the validation to the\nROP3_SRCCOPY case.\n---\n hw/display/ati_2d.c | 19 +++++++++----------\n 1 file changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/hw/display/ati_2d.c b/hw/display/ati_2d.c\nindex 440c1d159a..dbc8791824 100644\n--- a/hw/display/ati_2d.c\n+++ b/hw/display/ati_2d.c\n@@ -138,9 +138,9 @@ static void ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_pixman)\n return;\n }\n int dst_stride_words = ctx->dst_stride / sizeof(uint32_t);\n- if (ctx->dst.x > 0x3fff || ctx->dst.y > 0x3fff\n- || ctx->dst_bits >= ctx->vram_end || ctx->dst_bits + ctx->dst.x\n- + (ctx->dst.y + ctx->dst.height) * ctx->dst_stride >= ctx->vram_end) {\n+ if (ctx->dst.x > 0x3fff || ctx->dst.y > 0x3fff ||\n+ ctx->dst_bits >= ctx->vram_end || ctx->dst_bits + ctx->dst.x +\n+ (ctx->dst.y + ctx->dst.height) * ctx->dst_stride >= ctx->vram_end) {\n qemu_log_mask(LOG_UNIMP, \"blt outside vram not implemented\\n\");\n return;\n }\n@@ -153,13 +153,6 @@ static void ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_pixman)\n return;\n }\n int src_stride_words = ctx->src_stride / sizeof(uint32_t);\n- if (ctx->src.x > 0x3fff || ctx->src.y > 0x3fff\n- || ctx->src_bits >= ctx->vram_end\n- || ctx->src_bits + ctx->src.x + (ctx->src.y + ctx->dst.height)\n- * ctx->src_stride >= ctx->vram_end) {\n- qemu_log_mask(LOG_UNIMP, \"blt outside vram not implemented\\n\");\n- return;\n- }\n \n DPRINTF(\"pixman_blt(%p, %p, %d, %d, %d, %d, %d, %d, %d, %d, %d, %d)\\n\",\n ctx->src_bits, ctx->dst_bits, src_stride_words,\n@@ -268,6 +261,12 @@ void ati_2d_blt(ATIVGAState *s)\n {\n ATI2DCtx ctx;\n setup_2d_blt_ctx(s, &ctx);\n+ if (ctx.rop3 == ROP3_SRCCOPY && (ctx.src.x > 0x3fff || ctx.src.y > 0x3fff ||\n+ ctx.src_bits >= ctx.vram_end || ctx.src_bits + ctx.src.x +\n+ (ctx.src.y + ctx.dst.height) * ctx.src_stride >= ctx.vram_end)) {\n+ qemu_log_mask(LOG_UNIMP, \"blt outside vram not implemented\\n\");\n+ return;\n+ }\n ati_2d_do_blt(&ctx, s->use_pixman);\n ati_set_dirty(&s->vga, &ctx);\n }\n", "prefixes": [ "v9", "15/18" ] }