Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2202598/?format=api
{ "id": 2202598, "url": "http://patchwork.ozlabs.org/api/patches/2202598/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227203944.746471-3-chad@jablonski.xyz/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260227203944.746471-3-chad@jablonski.xyz>", "list_archive_url": null, "date": "2026-02-27T20:39:28", "name": "[v9,02/18] ati-vga: Fix DST_PITCH and SRC_PITCH reads", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0821b9247f957fdd6ae181a817ddf03ca81cecc7", "submitter": { "id": 91805, "url": "http://patchwork.ozlabs.org/api/people/91805/?format=api", "name": "Chad Jablonski", "email": "chad@jablonski.xyz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227203944.746471-3-chad@jablonski.xyz/mbox/", "series": [ { "id": 493814, "url": "http://patchwork.ozlabs.org/api/series/493814/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=493814", "date": "2026-02-27T20:39:27", "name": "ati-vga: Implement HOST_DATA transfers to enable X.org text rendering", "version": 9, "mbox": "http://patchwork.ozlabs.org/series/493814/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2202598/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2202598/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=jablonski.xyz header.i=@jablonski.xyz\n header.a=rsa-sha256 header.s=fm2 header.b=ghTsCywn;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=messagingengine.com header.i=@messagingengine.com\n header.a=rsa-sha256 header.s=fm3 header.b=VtIFlPbn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fN0cn4kmzz1xyQ\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2026 07:42:17 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vw4eA-0002UB-TG; Fri, 27 Feb 2026 15:41:15 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <chad@jablonski.xyz>)\n id 1vw4dz-0001Pl-Q5\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 15:41:05 -0500", "from fout-a1-smtp.messagingengine.com ([103.168.172.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <chad@jablonski.xyz>)\n id 1vw4dw-0007Ou-00\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 15:41:02 -0500", "from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49])\n by mailfout.phl.internal (Postfix) with ESMTP id B5DDAEC0633;\n Fri, 27 Feb 2026 15:40:58 -0500 (EST)", "from phl-frontend-03 ([10.202.2.162])\n by phl-compute-09.internal (MEProxy); Fri, 27 Feb 2026 15:40:58 -0500", "by mail.messagingengine.com (Postfix) with ESMTPA; Fri,\n 27 Feb 2026 15:40:58 -0500 (EST)", "from localhost (chomposaur [local])\n by chomposaur (OpenSMTPD) with ESMTPA id 7c776d26;\n Fri, 27 Feb 2026 20:40:55 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz;\n h=cc:cc:content-transfer-encoding:content-type:date:date:from\n :from:in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to; s=fm2; t=1772224858; x=\n 1772311258; bh=ABtiVlaCZkrAUapG4ZkghRtl4BtewIcQLfaOOoKZZwo=; b=g\n hTsCywnugsCpoiwV+587HAeQThacyykacXsfbWifdCwPKV2b2MoL6DLfjefA4X2b\n n1ZTZBwduZ7DlffMvzYKLnU7jlf5Y0EizHQovImMz+bQCKmkfp1igKGyFTZb3YlD\n 25E8MyR40Ch9E9WBHF91J4gGCJgt+UeEQOckdi9Lj+myOQhI0fS3e5aRDmbH/twQ\n bGMrcYstRtHuYiBOels5/huUvVXbeFVoVMDCI/57o3/DIVlXw3stKHv4dzMgqHra\n OY2/AdkYXuYrUXncCqd0sVaI7WwA74H5f4wsICoyucMpI3lhuuy+YM8iUuTYe13z\n 0NN022ddm9QwKWn8xgqkw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:date:date:feedback-id:feedback-id:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender\n :x-me-sender:x-sasl-enc; s=fm3; t=1772224858; x=1772311258; bh=A\n BtiVlaCZkrAUapG4ZkghRtl4BtewIcQLfaOOoKZZwo=; b=VtIFlPbntc+XuBDGA\n HgyIG+rk2l22vRdCTUdAONUZh0k7rPcIbmQ0A2OBdI15mViEUKGsQ8zLNLR0/x8+\n gdJZxZoEZZALon1RVPUcRFFSm+YOfo8h2qtWiGQo5I4QkMyj8Qjlq6Se5gQpp3RQ\n gDtZWbg9lxo9nztI1bGdePwi2bNwJjrgJEExB627U8l6NYcKnNl2TNdYMV97gX+v\n htFg33TSaegKspuUwQqNLZktn52yuSFHiXjLP4MMx0s5jiGLJPLAUhMFJPTBUXms\n JAEOLW/QX6HuaMkpeHHPO197wHN/L5uFRN9yz/JZOMAexUDlfVzVBv9RXU2NVWDF\n 7BDjQ==" ], "X-ME-Sender": "<xms:WgGiachRg6bJPlnHyYVd69Zd3F6yGVifEo6JCcfo_NP7M-9O1q3J3Q>\n <xme:WgGiab5o8NCUoVw84ty1Is45XhzvkVK4DC8Vmc4VjiwP5FGFuJYOOkM80iAe9QcGK\n 6DAGnOMgdGxUusCSm7Pp9FSGk07oqr9Vsy5MSWZp7DyabYZKCpRt4vu>", "X-ME-Received": "\n <xmr:WgGiacbfseoLLV2gvXLtFVNRa9tg7gGl8W_E9i76e--6yLbddKi5XQshxB_9>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvgeelleekucetufdoteggodetrf\n dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh\n hlucfvnfffucdljedtmdenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddt\n necuhfhrohhmpeevhhgrugculfgrsghlohhnshhkihcuoegthhgrugesjhgrsghlohhnsh\n hkihdrgiihiieqnecuggftrfgrthhtvghrnhepgfeiteejhfelheefieetjefgleejfffh\n ueffvdduieejgfeuueeuvddvkeejhfelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg\n hrrghmpehmrghilhhfrhhomheptghhrggusehjrggslhhonhhskhhirdighiiipdhnsggp\n rhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehqvghmuhdqug\n gvvhgvlhesnhhonhhgnhhurdhorhhgpdhrtghpthhtohepmhgrrhgtrghnughrvgdrlhhu\n rhgvrghusehrvgguhhgrthdrtghomhdprhgtphhtthhopegthhgrugesjhgrsghlohhnsh\n hkihdrgiihiidprhgtphhtthhopehkrhgrgigvlhesrhgvughhrghtrdgtohhmpdhrtghp\n thhtohepsggrlhgrthhonhesvghikhdrsghmvgdrhhhu", "X-ME-Proxy": "<xmx:WgGiaY5V8UDgbNBN6Sa9mt3aAfNMrd2ZAE13kZ5XN6e3MwTYmErQZg>\n <xmx:WgGiaXC-nLFJGOG68JpOQrrlcaTPIigxAedqJMCrK7RjI_LeR9ozAA>\n <xmx:WgGiaWcPEiZ14s-eloV5g4jBtwIX8NrAc_-6brcdOEMvUJRV8yxVZQ>\n <xmx:WgGiaeJgtEp-Y5bRCk-14kks_QujUfZmcvLzCX6irJI3_Q8tepfmSQ>\n <xmx:WgGiaVGEOqeO0OPSxj4sxbuIDVFcHRorXmqrHfoPGfKISqRe6jhchQq0>", "Feedback-ID": "ib26944c1:Fastmail", "From": "Chad Jablonski <chad@jablonski.xyz>", "To": "qemu-devel@nongnu.org", "Cc": "BALATON Zoltan <balaton@eik.bme.hu>, Gerd Hoffmann <kraxel@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Chad Jablonski <chad@jablonski.xyz>", "Subject": "[PATCH v9 02/18] ati-vga: Fix DST_PITCH and SRC_PITCH reads", "Date": "Fri, 27 Feb 2026 15:39:28 -0500", "Message-ID": "<20260227203944.746471-3-chad@jablonski.xyz>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260227203944.746471-1-chad@jablonski.xyz>", "References": "<20260227203944.746471-1-chad@jablonski.xyz>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=103.168.172.144;\n envelope-from=chad@jablonski.xyz;\n helo=fout-a1-smtp.messagingengine.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1,\n DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5,\n PDS_OTHER_BAD_TLD=1.999, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.706,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.401,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Reading DST_PITCH and SRC_PITCH on the Rage 128 is broken. The read\nhandlers attempt to construct the value from pitch and tile bits in\nthe register state but mistakenly AND them instead of ORing them. This\nmeans the pitch is always zero on read.\n\nSigned-off-by: Chad Jablonski <chad@jablonski.xyz>\nReviewed-by: BALATON Zoltan <balaton@eik.bme.hu>\n---\n hw/display/ati.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/display/ati.c b/hw/display/ati.c\nindex 8438a77de0..777a6b0a2e 100644\n--- a/hw/display/ati.c\n+++ b/hw/display/ati.c\n@@ -438,7 +438,7 @@ static uint64_t ati_mm_read(void *opaque, hwaddr addr, unsigned int size)\n case DST_PITCH:\n val = s->regs.dst_pitch;\n if (s->dev_id == PCI_DEVICE_ID_ATI_RAGE128_PF) {\n- val &= s->regs.dst_tile << 16;\n+ val |= s->regs.dst_tile << 16;\n }\n break;\n case DST_WIDTH:\n@@ -468,7 +468,7 @@ static uint64_t ati_mm_read(void *opaque, hwaddr addr, unsigned int size)\n case SRC_PITCH:\n val = s->regs.src_pitch;\n if (s->dev_id == PCI_DEVICE_ID_ATI_RAGE128_PF) {\n- val &= s->regs.src_tile << 16;\n+ val |= s->regs.src_tile << 16;\n }\n break;\n case DP_BRUSH_BKGD_CLR:\n", "prefixes": [ "v9", "02/18" ] }