Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2202593/?format=api
{ "id": 2202593, "url": "http://patchwork.ozlabs.org/api/patches/2202593/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227203944.746471-19-chad@jablonski.xyz/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260227203944.746471-19-chad@jablonski.xyz>", "list_archive_url": null, "date": "2026-02-27T20:39:44", "name": "[v9,18/18] ati-vga: Implement HOST_DATA flush to VRAM", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9cc16085723701038f908b6d5bc817e20e0b9dce", "submitter": { "id": 91805, "url": "http://patchwork.ozlabs.org/api/people/91805/?format=api", "name": "Chad Jablonski", "email": "chad@jablonski.xyz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227203944.746471-19-chad@jablonski.xyz/mbox/", "series": [ { "id": 493814, "url": "http://patchwork.ozlabs.org/api/series/493814/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=493814", "date": "2026-02-27T20:39:27", "name": "ati-vga: Implement HOST_DATA transfers to enable X.org text rendering", "version": 9, "mbox": "http://patchwork.ozlabs.org/series/493814/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2202593/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2202593/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=jablonski.xyz header.i=@jablonski.xyz\n header.a=rsa-sha256 header.s=fm2 header.b=kKACyQJX;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=messagingengine.com header.i=@messagingengine.com\n header.a=rsa-sha256 header.s=fm3 header.b=vBvY9R6m;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fN0cP4NKKz1xyX\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2026 07:41:57 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vw4eW-0003D3-T0; Fri, 27 Feb 2026 15:41:36 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <chad@jablonski.xyz>)\n id 1vw4e3-0001f3-6Y\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 15:41:07 -0500", "from fhigh-a7-smtp.messagingengine.com ([103.168.172.158])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <chad@jablonski.xyz>)\n id 1vw4dz-0007Qn-SO\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 15:41:06 -0500", "from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45])\n by mailfhigh.phl.internal (Postfix) with ESMTP id 4CC24140021F;\n Fri, 27 Feb 2026 15:41:02 -0500 (EST)", "from phl-frontend-03 ([10.202.2.162])\n by phl-compute-05.internal (MEProxy); Fri, 27 Feb 2026 15:41:02 -0500", "by mail.messagingengine.com (Postfix) with ESMTPA; Fri,\n 27 Feb 2026 15:41:01 -0500 (EST)", "from localhost (chomposaur [local])\n by chomposaur (OpenSMTPD) with ESMTPA id 18a79bad;\n Fri, 27 Feb 2026 20:40:55 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz;\n h=cc:cc:content-transfer-encoding:content-type:date:date:from\n :from:in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to; s=fm2; t=1772224862; x=\n 1772311262; bh=bg1pEv+jWssKiS2j9WPghce6rJN8doMUtH8ssfpl4sg=; b=k\n KACyQJXK+v1v4/n3dHau5hUsr6ZwnkfHQrHoxLumbnlEwCBw6DPUvkSHHxuU6+lO\n 9Z8tF4Qhy78rwneEW5BtiVk0UvRa4/Y9xy1Aop8y9QWEmZNyV0DOWdDlRixP6z2r\n DRnrqMqn/5fLK5ejL3bb9/ACc3maEAiVib8giLOuPWaMfL+ttyk2Z4CIZQL318Sf\n /IdXeO1x7J9bNb9phQGyLiTxzUBicZxFYOIeJLvU+NcuyhE6C3wwsCn3A0e+1Ygv\n cE6LU2oKgPIl/AjtRPpSfNosYm33Osn6hllPV2sMBuzkMlL3SZvCfpMs4ZHBdNyh\n eeJ0dToBLt4Qu2odUipRw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:date:date:feedback-id:feedback-id:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender\n :x-me-sender:x-sasl-enc; s=fm3; t=1772224862; x=1772311262; bh=b\n g1pEv+jWssKiS2j9WPghce6rJN8doMUtH8ssfpl4sg=; b=vBvY9R6mUjouYgjOH\n lpZsB/hYPIB9ilfNWn64uvJ7h3Bjqp0siuCnLjOwJkGIgKTJqtQ83ZapjZsUzMLF\n ysiEDrQMVBkhVcgNO3s4/541c7TZLnhEW4YorDShEEr+OFpUXxRK5091BBJ8LuHF\n Irz1Mvine0vbDsiNjEz7ZJ3WLKZaunXwplqgmX05T4BptryonAb3hqcvFgYVT2Jl\n Ti1tN9G9ZVIJCWKguJFGqdoDilb+nmA4UWmxuFBxPYCEjnhqaVaJWjMWFKRBc8ya\n /k7cNjjs5hY1QKJ3Ss8uoJNTO1UCykQg9FeFunNwc4AWAr4bwVTy2cqz9C6tgJlG\n BOerA==" ], "X-ME-Sender": "<xms:XgGiaXXxTo0wwMmmfPXxm-rmhu0Dp_VAoSLqrg27cH2l_qNgMfV85A>\n <xme:XgGiaWfTlEACox1d_hOlKmOWSl43_lSiOyiEnXWtqvTIxx0iCS18Dr87mOoA7jnFH\n u_sBAgaEtmQnqoOVV4x3axxFsyyytPZlOu945qeiP0cnTa87JJOaLM>", "X-ME-Received": "\n <xmr:XgGiabsfUw1hNvUQuEnHzQ69UlXS0tC0T04sNLEWFLPvCy5hHwNvWIz79zwo>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvgeelleelucetufdoteggodetrf\n dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh\n hlucfvnfffucdljedtmdenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddt\n necuhfhrohhmpeevhhgrugculfgrsghlohhnshhkihcuoegthhgrugesjhgrsghlohhnsh\n hkihdrgiihiieqnecuggftrfgrthhtvghrnhepgfeiteejhfelheefieetjefgleejfffh\n ueffvdduieejgfeuueeuvddvkeejhfelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg\n hrrghmpehmrghilhhfrhhomheptghhrggusehjrggslhhonhhskhhirdighiiipdhnsggp\n rhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegthhgrugesjh\n grsghlohhnshhkihdrgiihiidprhgtphhtthhopehkrhgrgigvlhesrhgvughhrghtrdgt\n ohhmpdhrtghpthhtohepmhgrrhgtrghnughrvgdrlhhurhgvrghusehrvgguhhgrthdrtg\n homhdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgpdhrtghp\n thhtohepsggrlhgrthhonhesvghikhdrsghmvgdrhhhu", "X-ME-Proxy": "<xmx:XgGiad-u60rFtL6eWJrzNdGr-5yVr1qAf2amsERGb0PApt0TDqVUAA>\n <xmx:XgGiae2LH3Iwx2hQGs6RD188dwT432rGopCABoxeut8IIuVeABkOfg>\n <xmx:XgGiaaDbnXdjXVKO30VLshcTvrDErUEfyUdRR-Hyeo0cg7Ha_vTRCQ>\n <xmx:XgGiaSeLQU_pZBHtn4vkXLT9t-oXVzssvzZxv-7KwF2GqzXbNLZw-Q>\n <xmx:XgGiae6k_5hT0TSmKP-123IXUCbAf9NsETFmWB9LNaYpJw2bC5K7fEgS>", "Feedback-ID": "ib26944c1:Fastmail", "From": "Chad Jablonski <chad@jablonski.xyz>", "To": "qemu-devel@nongnu.org", "Cc": "BALATON Zoltan <balaton@eik.bme.hu>, Gerd Hoffmann <kraxel@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Chad Jablonski <chad@jablonski.xyz>", "Subject": "[PATCH v9 18/18] ati-vga: Implement HOST_DATA flush to VRAM", "Date": "Fri, 27 Feb 2026 15:39:44 -0500", "Message-ID": "<20260227203944.746471-19-chad@jablonski.xyz>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260227203944.746471-1-chad@jablonski.xyz>", "References": "<20260227203944.746471-1-chad@jablonski.xyz>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=103.168.172.158;\n envelope-from=chad@jablonski.xyz;\n helo=fhigh-a7-smtp.messagingengine.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1,\n DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5,\n PDS_OTHER_BAD_TLD=1.999, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.706,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.401,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Implement flushing the 128-bit HOST_DATA accumulator to VRAM to enable\ntext rendering in X. Supports all datatypes (monochrome frgd/bkgd,\nmonochrome frgd, and color), however monochrome frgd support is\npartial and does not properly handle transparency/leave-alone.\n\nThe flush is broken up into two steps. First, if necessary, expansion of the\nmonochrome bits to the destination color depth. Then the expanded pixels\nare sent to the ati_2d_do_blt one scanline at a time. ati_2d_do_blt then\nclips and performs the blit.\n\nSigned-off-by: Chad Jablonski <chad@jablonski.xyz>\n---\n hw/display/ati.c | 5 +-\n hw/display/ati_2d.c | 126 ++++++++++++++++++++++++++++++++++++++++++\n hw/display/ati_int.h | 2 +\n hw/display/ati_regs.h | 4 ++\n 4 files changed, 134 insertions(+), 3 deletions(-)", "diff": "diff --git a/hw/display/ati.c b/hw/display/ati.c\nindex 3757b8426e..4468c345b1 100644\n--- a/hw/display/ati.c\n+++ b/hw/display/ati.c\n@@ -1038,7 +1038,7 @@ static void ati_mm_write(void *opaque, hwaddr addr,\n s->host_data.acc[s->host_data.next] = data;\n if (s->host_data.next % ATI_HOST_DATA_FLUSH_WORDS ==\n ATI_HOST_DATA_FLUSH_WORDS - 1) {\n- qemu_log_mask(LOG_UNIMP, \"HOST_DATA flush not yet implemented\\n\");\n+ ati_flush_host_data(s);\n }\n s->host_data.next = (s->host_data.next + 1) %\n ARRAY_SIZE(s->host_data.acc);\n@@ -1048,8 +1048,7 @@ static void ati_mm_write(void *opaque, hwaddr addr,\n break;\n }\n s->host_data.acc[s->host_data.next] = data;\n- qemu_log_mask(LOG_UNIMP,\n- \"HOST_DATA finish flush not yet implemented\\n\");\n+ ati_finish_host_data(s);\n break;\n default:\n break;\ndiff --git a/hw/display/ati_2d.c b/hw/display/ati_2d.c\nindex 2b3a239da3..8de9d0f414 100644\n--- a/hw/display/ati_2d.c\n+++ b/hw/display/ati_2d.c\n@@ -290,6 +290,19 @@ static void ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_pixman)\n void ati_2d_blt(ATIVGAState *s)\n {\n ATI2DCtx ctx;\n+ uint32_t src_source = s->regs.dp_mix & DP_SRC_SOURCE;\n+\n+ /* Finish any active HOST_DATA blits before starting a new blit */\n+ ati_finish_host_data(s);\n+\n+ if (src_source == DP_SRC_HOST || src_source == DP_SRC_HOST_BYTEALIGN) {\n+ /* Begin a HOST_DATA blit */\n+ s->host_data.active = true;\n+ s->host_data.next = 0;\n+ s->host_data.col = 0;\n+ s->host_data.row = 0;\n+ return;\n+ }\n setup_2d_blt_ctx(s, &ctx);\n if (ctx.rop3 == ROP3_SRCCOPY && (ctx.src.x > 0x3fff || ctx.src.y > 0x3fff ||\n ctx.src_bits >= ctx.vram_end || ctx.src_bits + ctx.src.x +\n@@ -300,3 +313,116 @@ void ati_2d_blt(ATIVGAState *s)\n ati_2d_do_blt(&ctx, s->use_pixman);\n ati_set_dirty(&s->vga, &ctx);\n }\n+\n+bool ati_flush_host_data(ATIVGAState *s)\n+{\n+ ATI2DCtx ctx, chunk;\n+ uint32_t fg = s->regs.dp_src_frgd_clr;\n+ uint32_t bg = s->regs.dp_src_bkgd_clr;\n+ unsigned bypp, pix_count, row, col, base, idx;\n+ uint8_t pix_buf[ATI_HOST_DATA_FLUSH_BITS * sizeof(uint32_t)];\n+ uint32_t byte_pix_order = s->regs.dp_datatype & DP_BYTE_PIX_ORDER;\n+ uint32_t src_source = s->regs.dp_mix & DP_SRC_SOURCE;\n+ uint32_t src_datatype = s->regs.dp_datatype & DP_SRC_DATATYPE;\n+\n+ if (!s->host_data.active) {\n+ return false;\n+ }\n+ if (src_source != DP_SRC_HOST) {\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"host_data_blt: unsupported src_source %x\\n\", src_source);\n+ return false;\n+ }\n+ if (src_datatype != SRC_MONO_FRGD_BKGD && src_datatype != SRC_MONO_FRGD &&\n+ src_datatype != SRC_COLOR) {\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"host_data_blt: undefined src_datatype %x\\n\",\n+ src_datatype);\n+ return false;\n+ }\n+\n+ setup_2d_blt_ctx(s, &ctx);\n+\n+ if (!ctx.left_to_right || !ctx.top_to_bottom) {\n+ qemu_log_mask(LOG_UNIMP,\n+ \"host_data_blt: unsupported blit direction %c%c\\n\",\n+ ctx.left_to_right ? '>' : '<',\n+ ctx.top_to_bottom ? 'v' : '^');\n+ return false;\n+ }\n+\n+ bypp = ctx.bpp / 8;\n+ base = (s->host_data.next / ATI_HOST_DATA_FLUSH_WORDS) *\n+ ATI_HOST_DATA_FLUSH_WORDS;\n+ DPRINTF(\"expand @ base: %d\\n\", base);\n+\n+ if (src_datatype == SRC_COLOR) {\n+ pix_count = ATI_HOST_DATA_FLUSH_BITS / ctx.bpp;\n+ memcpy(pix_buf, &s->host_data.acc[base],\n+ ATI_HOST_DATA_FLUSH_WORDS * sizeof(uint32_t));\n+ } else {\n+ pix_count = ATI_HOST_DATA_FLUSH_BITS;\n+ /* Expand monochrome bits to color pixels */\n+ idx = 0;\n+ for (int word = base; word < base + ATI_HOST_DATA_FLUSH_WORDS; word++) {\n+ for (int byte = 0; byte < 4; byte++) {\n+ uint8_t byte_val = s->host_data.acc[word] >> (byte * 8);\n+ for (int i = 0; i < 8; i++) {\n+ bool is_fg = byte_val & BIT(byte_pix_order ? i : 7 - i);\n+ uint32_t color = is_fg ? fg : bg;\n+ stn_he_p(&pix_buf[idx * bypp], bypp, color);\n+ idx += 1;\n+ }\n+ }\n+ }\n+ }\n+\n+ /* Copy and then modify blit ctx for use in a chunked blit */\n+ chunk = ctx;\n+ chunk.src_bits = pix_buf;\n+ chunk.src.y = 0;\n+ chunk.src_stride = ATI_HOST_DATA_FLUSH_BITS * bypp;\n+\n+ /* Blit one scanline chunk at a time */\n+ row = s->host_data.row;\n+ col = s->host_data.col;\n+ idx = 0;\n+ DPRINTF(\"blt %dpx @ row: %d, col: %d\\n\", pix_count, row, col);\n+ while (idx < pix_count && row < ctx.dst.height) {\n+ unsigned pix_in_scanline = MIN(pix_count - idx,\n+ ctx.dst.width - col);\n+ chunk.src.x = idx;\n+ /* Build a rect for this scanline chunk */\n+ chunk.dst.x = ctx.dst.x + col;\n+ chunk.dst.y = ctx.dst.y + row;\n+ chunk.dst.width = pix_in_scanline;\n+ chunk.dst.height = 1;\n+ DPRINTF(\"blt %dpx span @ row: %d, col: %d to dst (%d,%d)\\n\",\n+ pix_in_scanline, row, col, chunk.dst.x, chunk.dst.y);\n+ ati_2d_do_blt(&chunk, s->use_pixman);\n+ ati_set_dirty(&s->vga, &chunk);\n+ idx += pix_in_scanline;\n+ col += pix_in_scanline;\n+ if (col >= ctx.dst.width) {\n+ col = 0;\n+ row += 1;\n+ }\n+ }\n+\n+ /* Track state of the overall blit for use by the next flush */\n+ s->host_data.row = row;\n+ s->host_data.col = col;\n+ if (s->host_data.row >= ctx.dst.height) {\n+ s->host_data.active = false;\n+ }\n+\n+ return s->host_data.active;\n+}\n+\n+void ati_finish_host_data(ATIVGAState *s)\n+{\n+ while (ati_flush_host_data(s)) {\n+ s->host_data.next = (s->host_data.next + ATI_HOST_DATA_FLUSH_WORDS) %\n+ ARRAY_SIZE(s->host_data.acc);\n+ }\n+}\ndiff --git a/hw/display/ati_int.h b/hw/display/ati_int.h\nindex b285b6eba5..9e77bf8ebd 100644\n--- a/hw/display/ati_int.h\n+++ b/hw/display/ati_int.h\n@@ -128,5 +128,7 @@ struct ATIVGAState {\n const char *ati_reg_name(int num);\n \n void ati_2d_blt(ATIVGAState *s);\n+bool ati_flush_host_data(ATIVGAState *s);\n+void ati_finish_host_data(ATIVGAState *s);\n \n #endif /* ATI_INT_H */\ndiff --git a/hw/display/ati_regs.h b/hw/display/ati_regs.h\nindex 48f15e9b1d..b813fa119e 100644\n--- a/hw/display/ati_regs.h\n+++ b/hw/display/ati_regs.h\n@@ -397,7 +397,11 @@\n #define DST_32BPP 0x00000006\n #define DP_DST_DATATYPE 0x0000000f\n #define DP_BRUSH_DATATYPE 0x00000f00\n+#define SRC_MONO_FRGD_BKGD 0x00000000\n+#define SRC_MONO_FRGD 0x00010000\n+#define SRC_COLOR 0x00030000\n #define DP_SRC_DATATYPE 0x00030000\n+#define DP_BYTE_PIX_ORDER 0x40000000\n \n #define BRUSH_SOLIDCOLOR 0x00000d00\n \n", "prefixes": [ "v9", "18/18" ] }