Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2202588/?format=api
{ "id": 2202588, "url": "http://patchwork.ozlabs.org/api/patches/2202588/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227203944.746471-18-chad@jablonski.xyz/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260227203944.746471-18-chad@jablonski.xyz>", "list_archive_url": null, "date": "2026-02-27T20:39:43", "name": "[v9,17/18] ati-vga: Implement HOST_DATA register writes", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "23ea3877c2fa69da3cf7c17287e96bb9b72c7e18", "submitter": { "id": 91805, "url": "http://patchwork.ozlabs.org/api/people/91805/?format=api", "name": "Chad Jablonski", "email": "chad@jablonski.xyz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260227203944.746471-18-chad@jablonski.xyz/mbox/", "series": [ { "id": 493814, "url": "http://patchwork.ozlabs.org/api/series/493814/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=493814", "date": "2026-02-27T20:39:27", "name": "ati-vga: Implement HOST_DATA transfers to enable X.org text rendering", "version": 9, "mbox": "http://patchwork.ozlabs.org/series/493814/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2202588/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2202588/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=jablonski.xyz header.i=@jablonski.xyz\n header.a=rsa-sha256 header.s=fm2 header.b=ESxYhtSL;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=messagingengine.com header.i=@messagingengine.com\n header.a=rsa-sha256 header.s=fm3 header.b=mTug60T8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fN0cH3WR1z1xxx\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2026 07:41:51 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vw4e4-0001mL-Ef; Fri, 27 Feb 2026 15:41:08 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <chad@jablonski.xyz>)\n id 1vw4e2-0001bV-Q8\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 15:41:06 -0500", "from fhigh-a7-smtp.messagingengine.com ([103.168.172.158])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <chad@jablonski.xyz>)\n id 1vw4dz-0007Qk-Q7\n for qemu-devel@nongnu.org; Fri, 27 Feb 2026 15:41:06 -0500", "from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49])\n by mailfhigh.phl.internal (Postfix) with ESMTP id 32E78140021E;\n Fri, 27 Feb 2026 15:41:02 -0500 (EST)", "from phl-frontend-03 ([10.202.2.162])\n by phl-compute-09.internal (MEProxy); Fri, 27 Feb 2026 15:41:02 -0500", "by mail.messagingengine.com (Postfix) with ESMTPA; Fri,\n 27 Feb 2026 15:41:01 -0500 (EST)", "from localhost (chomposaur [local])\n by chomposaur (OpenSMTPD) with ESMTPA id 63ba524a;\n Fri, 27 Feb 2026 20:40:55 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz;\n h=cc:cc:content-transfer-encoding:content-type:date:date:from\n :from:in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to; s=fm2; t=1772224862; x=\n 1772311262; bh=KjHEB8cmWHa2uUjg4kmJyfG0LpAhVZnYiRB4AQrz5hA=; b=E\n SxYhtSL8MF/7DHSryIVr/OYCVM2YnmAtCJP7wxUZ84BuD1vcm+IzjSNqCxxRVN3p\n zV/k0l6ijRa5WibUsOK6m9gaRtjdMBWSn39klzFm7zAtCgCF7ymZPSGCtPhMdCvN\n F2W7plX6BLFq1Peiq2YOScBYWyjx1GvfILo2Q1bM4d1vD3dj7nvtVPJ8P85N34GJ\n gIrl1/IhV8UtN9gFmZSg4Jy6Pq/ne7oIuHbO9bYt2vBdwQsyOsVcMWEticKhxVqb\n ywr07R1bCB/67OXfQTKDWi6MHhbIE0ZmDR0mDNGtTj+QTSdMTPMMlMYU/d4ZFWYK\n Hk8xCDMi92mKb1RWV+waA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:date:date:feedback-id:feedback-id:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender\n :x-me-sender:x-sasl-enc; s=fm3; t=1772224862; x=1772311262; bh=K\n jHEB8cmWHa2uUjg4kmJyfG0LpAhVZnYiRB4AQrz5hA=; b=mTug60T8f+W0CF3gB\n tchR9F4KamnY4ZHdPXEHzMvbTYMXChXLzW6QQLy1C0Vz62x9chJ4EeWBXQvEBmw9\n aVJ+ZFg1oCiXgamUI3szEWG+LPpe3lf0uLXRkb/nfOD6+kKIKnCX3GCLlpiJfic5\n d4FtrJ1Xf308HnJ/1JAWtgI2695jkSKFL1jzvfsvz1enaiiW5IHoMSIKQ6hglKIj\n dmzMwbMLFI3pIzRB4JVKeLWozCR63AXv/CYwvo3xPjxwCIsNdPk10f09iHtb8wZd\n tjyuYEjtwH/HVKw9YhYe/66FYxeW5TuxmfPsAbHgDPKD15ib/0PNpKAKNDohQlil\n zdnZA==" ], "X-ME-Sender": "<xms:XgGiacKpVWiuwRJArKjZCeOasvsL3o3Qgjtnd28RVmKyT4nlKRsKiQ>\n <xme:XgGiaTB6AjnwQrbF0MkH90A-QGqdLtvtByXlp0RJbstNn5bDGfMOLaAOebMzaw1LT\n ZhpyLCBRkpSeatfEGRGQmcFWh2ejaYtxRUWb0xgVW9GJTiuzRz2rkk>", "X-ME-Received": "\n <xmr:XgGiaVC5J2e2XFsmK_A0XFmd-jfkOWc0oa_JuGz3k-yxZsLGHC8pMmyS4VUj>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvgeelleekucetufdoteggodetrf\n dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh\n hlucfvnfffucdljedtmdenucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddt\n necuhfhrohhmpeevhhgrugculfgrsghlohhnshhkihcuoegthhgrugesjhgrsghlohhnsh\n hkihdrgiihiieqnecuggftrfgrthhtvghrnhepgfeiteejhfelheefieetjefgleejfffh\n ueffvdduieejgfeuueeuvddvkeejhfelnecuvehluhhsthgvrhfuihiivgepudenucfrrg\n hrrghmpehmrghilhhfrhhomheptghhrggusehjrggslhhonhhskhhirdighiiipdhnsggp\n rhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsrghlrghtoh\n hnsegvihhkrdgsmhgvrdhhuhdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhg\n nhhurdhorhhgpdhrtghpthhtohepmhgrrhgtrghnughrvgdrlhhurhgvrghusehrvgguhh\n grthdrtghomhdprhgtphhtthhopehkrhgrgigvlhesrhgvughhrghtrdgtohhmpdhrtghp\n thhtoheptghhrggusehjrggslhhonhhskhhirdighiii", "X-ME-Proxy": "<xmx:XgGiaVDxyFcdMvvseA5t1OsPQj5AfZ2XtNVLdCHMPg4h41ELI7ql_g>\n <xmx:XgGiaQpcMvTR0cVjysNWlLPKtGkIqDLIKwBt7XXbDiZUTlp1VpU6EA>\n <xmx:XgGiafmFVsEwH7EsQLpDrQujza5pIgFiJiJQxo-ri29l1ToAB-PfhQ>\n <xmx:XgGiaQwJ-tOifYhotGwM1YoFkmgh3LWM-xTdohYfDkIEnEfWSma-CA>\n <xmx:XgGiaQfYHVlaYXmaoiWyroxQML5cZPEeiMvvBl_xS6pM2WUPj3FuANSC>", "Feedback-ID": "ib26944c1:Fastmail", "From": "Chad Jablonski <chad@jablonski.xyz>", "To": "qemu-devel@nongnu.org", "Cc": "BALATON Zoltan <balaton@eik.bme.hu>, Gerd Hoffmann <kraxel@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Chad Jablonski <chad@jablonski.xyz>", "Subject": "[PATCH v9 17/18] ati-vga: Implement HOST_DATA register writes", "Date": "Fri, 27 Feb 2026 15:39:43 -0500", "Message-ID": "<20260227203944.746471-18-chad@jablonski.xyz>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260227203944.746471-1-chad@jablonski.xyz>", "References": "<20260227203944.746471-1-chad@jablonski.xyz>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=103.168.172.158;\n envelope-from=chad@jablonski.xyz;\n helo=fhigh-a7-smtp.messagingengine.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1,\n DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5,\n PDS_OTHER_BAD_TLD=1.999, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.706,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.401,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Writing to any of the HOST_DATA0-7 registers pushes the written data\ninto a 128-bit accumulator. When the accumulator is full a flush is\ntriggered to copy it to the framebuffer. A final write to HOST_DATA_LAST\nwill also initiate a flush. The flush itself is left for the next patch.\n\nUnaligned HOST_DATA* writes result in, from what I can tell, undefined\nbehavior on real hardware. A well-behaved driver shouldn't be doing this\nanyway. For that reason they are not handled here at all.\n\nSigned-off-by: Chad Jablonski <chad@jablonski.xyz>\nReviewed-by: BALATON Zoltan <balaton@eik.bme.hu>\n---\n hw/display/ati.c | 32 ++++++++++++++++++++++++++++++++\n hw/display/ati_dbg.c | 9 +++++++++\n hw/display/ati_int.h | 11 +++++++++++\n hw/display/ati_regs.h | 9 +++++++++\n 4 files changed, 61 insertions(+)", "diff": "diff --git a/hw/display/ati.c b/hw/display/ati.c\nindex 6cf243bcf9..3757b8426e 100644\n--- a/hw/display/ati.c\n+++ b/hw/display/ati.c\n@@ -1024,6 +1024,33 @@ static void ati_mm_write(void *opaque, hwaddr addr,\n case SRC_SC_BOTTOM:\n s->regs.src_sc_bottom = data & 0x3fff;\n break;\n+ case HOST_DATA0:\n+ case HOST_DATA1:\n+ case HOST_DATA2:\n+ case HOST_DATA3:\n+ case HOST_DATA4:\n+ case HOST_DATA5:\n+ case HOST_DATA6:\n+ case HOST_DATA7:\n+ if (!s->host_data.active) {\n+ break;\n+ }\n+ s->host_data.acc[s->host_data.next] = data;\n+ if (s->host_data.next % ATI_HOST_DATA_FLUSH_WORDS ==\n+ ATI_HOST_DATA_FLUSH_WORDS - 1) {\n+ qemu_log_mask(LOG_UNIMP, \"HOST_DATA flush not yet implemented\\n\");\n+ }\n+ s->host_data.next = (s->host_data.next + 1) %\n+ ARRAY_SIZE(s->host_data.acc);\n+ break;\n+ case HOST_DATA_LAST:\n+ if (!s->host_data.active) {\n+ break;\n+ }\n+ s->host_data.acc[s->host_data.next] = data;\n+ qemu_log_mask(LOG_UNIMP,\n+ \"HOST_DATA finish flush not yet implemented\\n\");\n+ break;\n default:\n break;\n }\n@@ -1129,6 +1156,11 @@ static void ati_vga_reset(DeviceState *dev)\n /* reset vga */\n vga_common_reset(&s->vga);\n s->mode = VGA_MODE;\n+\n+ s->host_data.active = false;\n+ s->host_data.next = 0;\n+ s->host_data.row = 0;\n+ s->host_data.col = 0;\n }\n \n static void ati_vga_exit(PCIDevice *dev)\ndiff --git a/hw/display/ati_dbg.c b/hw/display/ati_dbg.c\nindex 3ffa7f35df..5c799d540a 100644\n--- a/hw/display/ati_dbg.c\n+++ b/hw/display/ati_dbg.c\n@@ -252,6 +252,15 @@ static struct ati_regdesc ati_reg_names[] = {\n {\"MC_SRC1_CNTL\", 0x19D8},\n {\"TEX_CNTL\", 0x1800},\n {\"RAGE128_MPP_TB_CONFIG\", 0x01c0},\n+ {\"HOST_DATA0\", 0x17c0},\n+ {\"HOST_DATA1\", 0x17c4},\n+ {\"HOST_DATA2\", 0x17c8},\n+ {\"HOST_DATA3\", 0x17cc},\n+ {\"HOST_DATA4\", 0x17d0},\n+ {\"HOST_DATA5\", 0x17d4},\n+ {\"HOST_DATA6\", 0x17d8},\n+ {\"HOST_DATA7\", 0x17dc},\n+ {\"HOST_DATA_LAST\", 0x17e0},\n {NULL, -1}\n };\n \ndiff --git a/hw/display/ati_int.h b/hw/display/ati_int.h\nindex 98f57ca5fa..b285b6eba5 100644\n--- a/hw/display/ati_int.h\n+++ b/hw/display/ati_int.h\n@@ -32,6 +32,8 @@\n \n #define ATI_RAGE128_LINEAR_APER_SIZE (64 * MiB)\n #define ATI_R100_LINEAR_APER_SIZE (128 * MiB)\n+#define ATI_HOST_DATA_FLUSH_BITS 128\n+#define ATI_HOST_DATA_FLUSH_WORDS (ATI_HOST_DATA_FLUSH_BITS / 32)\n \n #define TYPE_ATI_VGA \"ati-vga\"\n OBJECT_DECLARE_SIMPLE_TYPE(ATIVGAState, ATI_VGA)\n@@ -95,6 +97,14 @@ typedef struct ATIVGARegs {\n uint32_t default_tile;\n } ATIVGARegs;\n \n+typedef struct ATIHostDataState {\n+ bool active;\n+ uint32_t row;\n+ uint32_t col;\n+ uint32_t next;\n+ uint32_t acc[ATI_HOST_DATA_FLUSH_WORDS * 2];\n+} ATIHostDataState;\n+\n struct ATIVGAState {\n PCIDevice dev;\n VGACommonState vga;\n@@ -112,6 +122,7 @@ struct ATIVGAState {\n MemoryRegion io;\n MemoryRegion mm;\n ATIVGARegs regs;\n+ ATIHostDataState host_data;\n };\n \n const char *ati_reg_name(int num);\ndiff --git a/hw/display/ati_regs.h b/hw/display/ati_regs.h\nindex 3999edb9b7..48f15e9b1d 100644\n--- a/hw/display/ati_regs.h\n+++ b/hw/display/ati_regs.h\n@@ -252,6 +252,15 @@\n #define DP_T12_CNTL 0x178c\n #define DST_BRES_T1_LNTH 0x1790\n #define DST_BRES_T2_LNTH 0x1794\n+#define HOST_DATA0 0x17c0\n+#define HOST_DATA1 0x17c4\n+#define HOST_DATA2 0x17c8\n+#define HOST_DATA3 0x17cc\n+#define HOST_DATA4 0x17d0\n+#define HOST_DATA5 0x17d4\n+#define HOST_DATA6 0x17d8\n+#define HOST_DATA7 0x17dc\n+#define HOST_DATA_LAST 0x17e0\n #define SCALE_SRC_HEIGHT_WIDTH 0x1994\n #define SCALE_OFFSET_0 0x1998\n #define SCALE_PITCH 0x199c\n", "prefixes": [ "v9", "17/18" ] }