Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2202529/?format=api
{ "id": 2202529, "url": "http://patchwork.ozlabs.org/api/patches/2202529/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260227200848.114019-9-david@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260227200848.114019-9-david@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260227200848.114019-9-david@kernel.org/", "date": "2026-02-27T20:08:39", "name": "[v1,08/16] mm/memory: move adjusting of address range to unmap_vmas()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c95ba7d2f7c43cbafae967564bad385162ff5d8f", "submitter": { "id": 92023, "url": "http://patchwork.ozlabs.org/api/people/92023/?format=api", "name": "David Hildenbrand (Arm)", "email": "david@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260227200848.114019-9-david@kernel.org/mbox/", "series": [ { "id": 493807, "url": "http://patchwork.ozlabs.org/api/series/493807/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=493807", "date": "2026-02-27T20:08:31", "name": "mm: cleanups around unmapping / zapping", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/493807/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2202529/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2202529/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-17416-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PYP8hi5N;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-17416-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PYP8hi5N;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=david@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fMzx91B4tz1xxx\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2026 07:11:25 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fMzx86X2pz3bt7;\n\tSat, 28 Feb 2026 07:11:24 +1100 (AEDT)", "from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fMzx76nl3z2xMt\n\tfor <linuxppc-dev@lists.ozlabs.org>; Sat, 28 Feb 2026 07:11:23 +1100 (AEDT)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 9BCB560126;\n\tFri, 27 Feb 2026 20:11:21 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 11DAAC116C6;\n\tFri, 27 Feb 2026 20:11:04 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772223084;\n\tcv=none;\n b=fPRxh3hH5+JvVJbIcpP9aMPJtQlv5+DhsfrVCTpEMlRAs1SdrPdOKk/mtHE8gjOF+CX0NRp6xyOPlN8A82eMgeIQ4Y9msUriSimZy2j5oL4m9RA2fR6ZijdnA8x++sbw0QvMMSAGXyz+yIRIU4vZ4aWRwkv7ZJIe2AfIX8u9GEDO36bqD/MwX3k3CTvaI9tJ8vQ5cgPk3uDlp0DENCkHUUsGtBSGCF6aq+/r+WbnR112Z9411fj11IWpKGiUvBtZuT7oa0meCRSfsbjQLHsFiNDbd+cOXu+R31Ku7ktXzwIUrh3SJqvZuMcDWzOuXL3AYwzK3aC3p1Pr6Baux8C0ig==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1772223084; c=relaxed/relaxed;\n\tbh=qAaAKrA9C/+XAY4LI5BZgGXKSy2ztkeyRwN6gL5w5a8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=CtSlwddjWlMUX4lUJZlpSausSJU6OR7TaNrxFFfxt3BOFi3oKfU9sHuVdDnr5X3BRR9pUF3cfMwnmkk4xFfaA8oLteav5WIxL5h1+8wycP+zEzeV2FEUpyStu+waI2UAHXkWmabmvRPzWQjkULv2IfggpgocZCV7+hgI5sKe3KGbrQ5EiXkh/y0ysQRs3tRKZ/gMRYMP3nQ5K0eKXVWGFn52bqsiV7luhgljUA1goC1OIfxjxC+vqNLl7nt+Dl1gdOefPGqQiDyH9wmU+aL3acPnXm2A85joVZ3pDyVcLu2wOxlGhNIW47R+Hodddf7/r91vVAF/R3vfVBs+4rbLJA==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PYP8hi5N; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=david@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1772223081;\n\tbh=Ms86RD0Otoj1d6fzyHR5o28Ex/YjZExC3FyxUcdS+A8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PYP8hi5N5sGdSXGeQeQx0PGG2qoBngPOdHIav4EUqj7du6tyiIkdIqI1w8m/NqulN\n\t yXTxgx+g53/5ilvSpYisK6g/8IOBFrnfp7OT3nq69Vw+lSxB4peBlnL7oBBrBFteR+\n\t M2xZ9SjZBvkW0pqpQ/Xabhkha8T9/aSY5mi7v8CLxJ+sb4/YPmxDWucCxYnzccFDiZ\n\t EBFkzzUicUwOCfYz7Mnqy0dyy3jiaAtOm+CqJElfZ27AJo9RZVjXuSUjS95x5xGJ2w\n\t JLFZQYbU59MSVTJrtE+3FkB7Em2PBv3oHfoONvXgNLI0cd8vWkaGCUZ4/ZP0s9duB7\n\t TSoGd5pRM7nbA==", "From": "\"David Hildenbrand (Arm)\" <david@kernel.org>", "To": "linux-kernel@vger.kernel.org", "Cc": "\"linux-mm @ kvack . org\" <linux-mm@kvack.org>,\n \"David Hildenbrand (Arm)\" <david@kernel.org>,\n Andrew Morton <akpm@linux-foundation.org>,\n Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,\n \"Liam R. Howlett\" <Liam.Howlett@oracle.com>,\n Vlastimil Babka <vbabka@kernel.org>, Mike Rapoport <rppt@kernel.org>,\n Suren Baghdasaryan <surenb@google.com>, Michal Hocko <mhocko@suse.com>,\n Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,\n David Rientjes <rientjes@google.com>, Shakeel Butt <shakeel.butt@linux.dev>,\n \"Matthew Wilcox (Oracle)\" <willy@infradead.org>,\n Alice Ryhl <aliceryhl@google.com>, Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>,\n Christian Borntraeger <borntraeger@linux.ibm.com>,\n Janosch Frank <frankja@linux.ibm.com>,\n Claudio Imbrenda <imbrenda@linux.ibm.com>,\n Alexander Gordeev <agordeev@linux.ibm.com>,\n Gerald Schaefer <gerald.schaefer@linux.ibm.com>,\n Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,\n Jarkko Sakkinen <jarkko@kernel.org>, Thomas Gleixner <tglx@kernel.org>,\n Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,\n Greg Kroah-Hartman <gregkh@linuxfoundation.org>, =?utf-8?q?Arve_Hj=C3=B8nne?=\n\t=?utf-8?q?v=C3=A5g?= <arve@android.com>, Todd Kjos <tkjos@android.com>,\n Christian Brauner <brauner@kernel.org>, Carlos Llamas <cmllamas@google.com>,\n Ian Abbott <abbotti@mev.co.uk>,\n H Hartley Sweeten <hsweeten@visionengravers.com>,\n Jani Nikula <jani.nikula@linux.intel.com>,\n Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,\n Rodrigo Vivi <rodrigo.vivi@intel.com>, Tvrtko Ursulin <tursulin@ursulin.net>,\n David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,\n Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,\n Dimitri Sivanich <dimitri.sivanich@hpe.com>, Arnd Bergmann <arnd@arndb.de>,\n Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,\n Andrii Nakryiko <andrii@kernel.org>, Peter Zijlstra <peterz@infradead.org>,\n Arnaldo Carvalho de Melo <acme@kernel.org>,\n Namhyung Kim <namhyung@kernel.org>, Andy Lutomirski <luto@kernel.org>,\n Vincenzo Frascino <vincenzo.frascino@arm.com>,\n Eric Dumazet <edumazet@google.com>, Neal Cardwell <ncardwell@google.com>,\n \"David S. Miller\" <davem@davemloft.net>, David Ahern <dsahern@kernel.org>,\n Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n Miguel Ojeda <ojeda@kernel.org>, linuxppc-dev@lists.ozlabs.org,\n kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org,\n intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,\n linux-rdma@vger.kernel.org, bpf@vger.kernel.org,\n linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org,\n netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org", "Subject": "[PATCH v1 08/16] mm/memory: move adjusting of address range to\n unmap_vmas()", "Date": "Fri, 27 Feb 2026 21:08:39 +0100", "Message-ID": "<20260227200848.114019-9-david@kernel.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260227200848.114019-1-david@kernel.org>", "References": "<20260227200848.114019-1-david@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "__zap_vma_range() has two callers, whereby\nzap_page_range_single_batched() documents that the range must fit into\nthe VMA range.\n\nSo move adjusting the range to unmap_vmas() where it is actually\nrequired and add a safety check in __zap_vma_range() instead. In\nunmap_vmas(), we'd never expect to have empty ranges (otherwise, why\nhave the vma in there in the first place).\n\n__zap_vma_range() will no longer be called with start == end, so\ncleanup the function a bit. While at it, simplify the overly long\ncomment to its core message.\n\nWe will no longer call uprobe_munmap() for start == end, which actually\nseems to be the right thing to do.\n\nNote that hugetlb_zap_begin()->...->adjust_range_if_pmd_sharing_possible()\ncannot result in the range exceeding the vma range.\n\nSigned-off-by: David Hildenbrand (Arm) <david@kernel.org>\n---\n mm/memory.c | 58 +++++++++++++++++++++--------------------------------\n 1 file changed, 23 insertions(+), 35 deletions(-)", "diff": "diff --git a/mm/memory.c b/mm/memory.c\nindex f0aaec57a66b..fdcd2abf29c2 100644\n--- a/mm/memory.c\n+++ b/mm/memory.c\n@@ -2073,44 +2073,28 @@ static void unmap_page_range(struct mmu_gather *tlb, struct vm_area_struct *vma,\n \ttlb_end_vma(tlb, vma);\n }\n \n-\n-static void __zap_vma_range(struct mmu_gather *tlb,\n-\t\tstruct vm_area_struct *vma, unsigned long start_addr,\n-\t\tunsigned long end_addr, struct zap_details *details)\n+static void __zap_vma_range(struct mmu_gather *tlb, struct vm_area_struct *vma,\n+\t\tunsigned long start, unsigned long end,\n+\t\tstruct zap_details *details)\n {\n-\tunsigned long start = max(vma->vm_start, start_addr);\n-\tunsigned long end;\n-\n-\tif (start >= vma->vm_end)\n-\t\treturn;\n-\tend = min(vma->vm_end, end_addr);\n-\tif (end <= vma->vm_start)\n-\t\treturn;\n+\tVM_WARN_ON_ONCE(start >= end || !range_in_vma(vma, start, end));\n \n \tif (vma->vm_file)\n \t\tuprobe_munmap(vma, start, end);\n \n-\tif (start != end) {\n-\t\tif (unlikely(is_vm_hugetlb_page(vma))) {\n-\t\t\t/*\n-\t\t\t * It is undesirable to test vma->vm_file as it\n-\t\t\t * should be non-null for valid hugetlb area.\n-\t\t\t * However, vm_file will be NULL in the error\n-\t\t\t * cleanup path of mmap_region. When\n-\t\t\t * hugetlbfs ->mmap method fails,\n-\t\t\t * mmap_region() nullifies vma->vm_file\n-\t\t\t * before calling this function to clean up.\n-\t\t\t * Since no pte has actually been setup, it is\n-\t\t\t * safe to do nothing in this case.\n-\t\t\t */\n-\t\t\tif (vma->vm_file) {\n-\t\t\t\tzap_flags_t zap_flags = details ?\n-\t\t\t\t details->zap_flags : 0;\n-\t\t\t\t__unmap_hugepage_range(tlb, vma, start, end,\n-\t\t\t\t\t\t\t NULL, zap_flags);\n-\t\t\t}\n-\t\t} else\n-\t\t\tunmap_page_range(tlb, vma, start, end, details);\n+\tif (unlikely(is_vm_hugetlb_page(vma))) {\n+\t\tzap_flags_t zap_flags = details ? details->zap_flags : 0;\n+\n+\t\t/*\n+\t\t * vm_file will be NULL when we fail early while instantiating\n+\t\t * a new mapping. In this case, no pages were mapped yet and\n+\t\t * there is nothing to do.\n+\t\t */\n+\t\tif (!vma->vm_file)\n+\t\t\treturn;\n+\t\t__unmap_hugepage_range(tlb, vma, start, end, NULL, zap_flags);\n+\t} else {\n+\t\tunmap_page_range(tlb, vma, start, end, details);\n \t}\n }\n \n@@ -2174,8 +2158,9 @@ void unmap_vmas(struct mmu_gather *tlb, struct unmap_desc *unmap)\n \t\t\t\tunmap->vma_start, unmap->vma_end);\n \tmmu_notifier_invalidate_range_start(&range);\n \tdo {\n-\t\tunsigned long start = unmap->vma_start;\n-\t\tunsigned long end = unmap->vma_end;\n+\t\tunsigned long start = max(vma->vm_start, unmap->vma_start);\n+\t\tunsigned long end = min(vma->vm_end, unmap->vma_end);\n+\n \t\thugetlb_zap_begin(vma, &start, &end);\n \t\t__zap_vma_range(tlb, vma, start, end, &details);\n \t\thugetlb_zap_end(vma, &details);\n@@ -2204,6 +2189,9 @@ void zap_page_range_single_batched(struct mmu_gather *tlb,\n \n \tVM_WARN_ON_ONCE(!tlb || tlb->mm != vma->vm_mm);\n \n+\tif (unlikely(!size))\n+\t\treturn;\n+\n \tmmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma->vm_mm,\n \t\t\t\taddress, end);\n \thugetlb_zap_begin(vma, &range.start, &range.end);\n", "prefixes": [ "v1", "08/16" ] }