Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2202500/?format=api
{ "id": 2202500, "url": "http://patchwork.ozlabs.org/api/patches/2202500/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20260227183851.2113417-6-adhemerval.zanella@linaro.org/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260227183851.2113417-6-adhemerval.zanella@linaro.org>", "list_archive_url": null, "date": "2026-02-27T18:37:47", "name": "[v7,5/5] elf: Allow RPATH/RUNPATH for static-pie", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "68b381f76bfafd09b03f64458d54443087774905", "submitter": { "id": 66065, "url": "http://patchwork.ozlabs.org/api/people/66065/?format=api", "name": "Adhemerval Zanella", "email": "adhemerval.zanella@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20260227183851.2113417-6-adhemerval.zanella@linaro.org/mbox/", "series": [ { "id": 493795, "url": "http://patchwork.ozlabs.org/api/series/493795/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=493795", "date": "2026-02-27T18:37:42", "name": "elf: Allow RPATH/RUNPATH for static-pie (BZ 33326)", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/493795/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2202500/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2202500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "libc-alpha@sourceware.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "libc-alpha@sourceware.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=cesL2myS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=cesL2myS", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "sourceware.org; spf=pass smtp.mailfrom=linaro.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=2607:f8b0:4864:20::e2d" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fMxvB6Pn3z1xxV\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 28 Feb 2026 05:39:34 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id EB67F4B9DB61\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Feb 2026 18:39:32 +0000 (GMT)", "from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com\n [IPv6:2607:f8b0:4864:20::e2d])\n by sourceware.org (Postfix) with ESMTPS id 7B4B84B9DB70\n for <libc-alpha@sourceware.org>; Fri, 27 Feb 2026 18:39:09 +0000 (GMT)", "by mail-vs1-xe2d.google.com with SMTP id\n ada2fe7eead31-5ff07cb35f2so1238503137.3\n for <libc-alpha@sourceware.org>; Fri, 27 Feb 2026 10:39:09 -0800 (PST)", "from ubuntu-vm.. ([191.54.27.153]) by smtp.gmail.com with ESMTPSA id\n ada2fe7eead31-5ff1ea6ea19sm6283369137.12.2026.02.27.10.39.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Feb 2026 10:39:07 -0800 (PST)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org EB67F4B9DB61", "OpenDKIM Filter v2.11.0 sourceware.org 7B4B84B9DB70" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 7B4B84B9DB70", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 7B4B84B9DB70", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772217549; cv=none;\n b=WBObMnojQloMxjvfOZwvT7s5cSv5kQa+2DNKwQFrpGQpmzrO4UaoBgxtpITc1L0t/WJsbq3oiVAAO5F95dHS+PU1r2g22CjER+aza+CNiZ8oG8kGAGxJ8DaE/uJH/VFmzw1K3XparSK6E1BANw6UNWCzdVHkiqc3tDYJYs19xCA=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1772217549; c=relaxed/simple;\n bh=Hcf6X3T4MmAW1y3g0bqXjmSL7gnaKmxD9Zq0u1r3Rb8=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=daTCY2CEx22gBDkP8NhYM47ahj4FsIqjT7KTQwrmvWHjVAR64RDdYQjko4OTd5Y/dEKudIUX3Wgs5SW2dwYHfuvNqaiLyhDrErCJV5vR8J90NCtr5pI6UFrlotNj6vzlA6CURWoYEXf+lWPcrUl6dkVrsymGb694uD/BMUFr35o=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1772217548; x=1772822348; darn=sourceware.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4C6YVkj5Ry10vreuIMEf6Nc3pbooH1Tz2E5TeeDbtC4=;\n b=cesL2myShklNq9PNJbNeB8WyHROthudsP01wSFxC/t9jzgf8dVqwiXf2Awt6c9ROFP\n Ax0wHw9ItL00qQ3/ZL10YCta/xTv2NhcPjYLqPT7tU/RgnnT3dxJLbtGTFkjS3IYTnj+\n zIIA8PEWc7H2hMxn92XjhA+QK91Rww+rHLvTYatqzhjTsDT0ZODcoZZt7yFfwsLNFj0E\n FfFMoAJ+bWQ79h/Ewl804hRiYdhFxhw3ey4or6KMyhOlbXhN8rarxIWUKUeVmjX66pCY\n zsjZ7oDInNiSCmIR7wgQpwPtoy9OmQ3uLtExeXG09YTQzc4PyuOGwzDedAU/3Dp7V0X3\n QODg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1772217548; x=1772822348;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4C6YVkj5Ry10vreuIMEf6Nc3pbooH1Tz2E5TeeDbtC4=;\n b=GmmYyv3Ousv3MsPtwaQ2rlSP5i1DANxY3lmJduEoTgWdxJaJKdqa7Ita68tch1qrN2\n VYypWIjprpjRx/TLOmGRKjtjHrXkwwErpwPx5trlwxJEKt8Gm/TlLomw7MWZ8nRvjI3M\n rOmFe9cEO7FPd/BVPYZQEyF3L+HDtIcVDeFOxbINYScFlhzDUDvMLcAxS0B3Wwq2RFRN\n 6xlIuLlYKJwG1D99FqhPYnJy4sfEX8jdHhcr4Am7sGd8b+J7BC1GHJoYC5F9JqarAlUW\n 8edQGvtBCaAuDra64jTajhuGCj7hAoLDg0QzSKpYyrHP5febc9CyPuolwwldrJV7bxUS\n Npkw==", "X-Gm-Message-State": "AOJu0YxvBu+MGW1I9myG6PyEe9xLz/XjYR1UpvshjNouK5Qql8EqAXdU\n 3nv8a+Jy74/BUir09GTfRRKy4rTSo+zQypAzqBQoVbZ1nOL/h2D41ZFADK45pp3zcMDZHHicE1p\n ox01o", "X-Gm-Gg": "ATEYQzyXq0LQJnrO1bBUc/Pt6tTpv54zRowhgOvlRK+sh78P5GCiqNaqGhz3+2uU41D\n p4ft4t9LGw37lKEGO6PD4GOcMg2nsanZt3zC/9fQ7ylgntIf+n0MgKtSVlpqoY9sBpzNA93yB2T\n 8YEBlmXN4bUSE1D5C6tgYTI2QxSdL9knXo1pnwLTKKHtombYqKlPo3183kZuayrcILHyqQPFEYs\n hftIkpN/zss7slaLIsNxseRvoBc6uvuWh2wi7gI0myDQHGxxeM+VfZ9E+DklXoKaHimoDwdk1HW\n WIJz2YdswVux686Oe+Oa+pE9RzaNqzUQ2MsWl6p6ZiMP+PC0jYqMotXgSQcvwnSY7ytGqMgcY0u\n W588c82bEb0S4Wm8Z6tZ6MkyDIIc35aYqFo23IpGx7wwDlqsd+tSp2BhostAxR/sKYQZWPVtD0S\n N8xgmDDuGH5vubKpP5x4YdySXCa+TQWyoa4as=", "X-Received": "by 2002:a05:6102:32d1:b0:5ef:a59e:617a with SMTP id\n ada2fe7eead31-5ff324e88d4mr2431270137.21.1772217548368;\n Fri, 27 Feb 2026 10:39:08 -0800 (PST)", "From": "Adhemerval Zanella <adhemerval.zanella@linaro.org>", "To": "libc-alpha@sourceware.org", "Cc": "Florian Weimer <fweimer@redhat.com>", "Subject": "[PATCH v7 5/5] elf: Allow RPATH/RUNPATH for static-pie", "Date": "Fri, 27 Feb 2026 18:37:47 +0000", "Message-ID": "<20260227183851.2113417-6-adhemerval.zanella@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260227183851.2113417-1-adhemerval.zanella@linaro.org>", "References": "<20260227183851.2113417-1-adhemerval.zanella@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libc-alpha@sourceware.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Libc-alpha mailing list <libc-alpha.sourceware.org>", "List-Unsubscribe": "<https://sourceware.org/mailman/options/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>", "List-Archive": "<https://sourceware.org/pipermail/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-request@sourceware.org?subject=help>", "List-Subscribe": "<https://sourceware.org/mailman/listinfo/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=subscribe>", "Errors-To": "libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org" }, "content": "The initial static-pie support (commit 9d7a3741c9e59eba87fb) reused\nld.so ELF parsing logic, even though RPATH/RUNPATH should not appear\nin the static-pie bootstrap. With static PIE, RPATH/RUNPATH on the\nloader typically indicates a toolchain misconfiguration. However,\nfor static PIE, the presence of RPATH/RUNPATH has no impact because\nthese binaries do not use dynamic linking at runtime.\n\nStatic binaries do not support rpath because they lack dynamic\nsections, and adding static-pie support affects only the dlopen\nfunction. If static dlopen support is removed, this change has no effect.\n\nThis change also simplifies elf_get_dynamic_info and removes a\ndifference between dynamic and static binaries.\n\nTested on aarch64-linux-gnu and x86_64-linux-gnu.\n\nReviewed-by: Florian Weimer <fweimer@redhat.com>\n---\n elf/Makefile | 11 ++++++++\n elf/dl-load.c | 2 +-\n elf/dl-reloc-static-pie.c | 2 +-\n elf/get-dynamic-info.h | 5 ++--\n elf/rtld.c | 4 +--\n elf/setup-vdso.h | 2 +-\n elf/tst-pie-rpath-mod.c | 19 ++++++++++++++\n elf/tst-pie-rpath-static.c | 52 ++++++++++++++++++++++++++++++++++++++\n 8 files changed, 89 insertions(+), 8 deletions(-)\n create mode 100644 elf/tst-pie-rpath-mod.c\n create mode 100644 elf/tst-pie-rpath-static.c", "diff": "diff --git a/elf/Makefile b/elf/Makefile\nindex d572d19a2f..6e6bb238a8 100644\n--- a/elf/Makefile\n+++ b/elf/Makefile\n@@ -1200,7 +1200,11 @@ tests += \\\n # tests\n tests-static += \\\n tst-pie-address-static \\\n+ tst-pie-rpath-static \\\n # tests-static\n+modules-names += \\\n+ tst-pie-rpath-mod \\\n+ # modules-names\n ifeq (yes,$(aligned-65536))\n tests += tst-pie-bss-static\n tests-static += tst-pie-bss-static\n@@ -3549,3 +3553,10 @@ $(objpfx)tst-assert-startup-static.out: $(objpfx)tst-assert-startup-static\n \tgrep -q 'Fatal glibc error: tst-assert-startup-static' $@ \\\n \t && grep -q '^status: 134$$' $@; \\\n \t $(evaluate-test)\n+\n+LDFLAGS-tst-pie-rpath-static += -Wl,-rpath,\\$$ORIGIN/tst-pie-rpath-static-subdir\n+CFLAGS-tst-pie-rpath-static.c += -DPFX=\\\"$(objpfx)\\\"\n+ifeq (no,$(build-hardcoded-path-in-tests))\n+LDFLAGS-tst-pie-rpath-mod.so += -Wl,-rpath,$(rpath-link)\n+endif\n+$(objpfx)tst-pie-rpath-static.out: $(objpfx)tst-pie-rpath-mod.so\ndiff --git a/elf/dl-load.c b/elf/dl-load.c\nindex 7355eef8e7..c5ea40fa4a 100644\n--- a/elf/dl-load.c\n+++ b/elf/dl-load.c\n@@ -1269,7 +1269,7 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd,\n if (l->l_ld != NULL)\n l->l_ld = (ElfW(Dyn) *) ((ElfW(Addr)) l->l_ld + l->l_addr);\n \n- elf_get_dynamic_info (l, false, false);\n+ elf_get_dynamic_info (l, false);\n \n /* Make sure we are not dlopen'ing an object that has the\n DF_1_NOOPEN flag set, or a PIE object. */\ndiff --git a/elf/dl-reloc-static-pie.c b/elf/dl-reloc-static-pie.c\nindex bdff2b5ee2..22acd9bb4f 100644\n--- a/elf/dl-reloc-static-pie.c\n+++ b/elf/dl-reloc-static-pie.c\n@@ -69,7 +69,7 @@ _dl_relocate_static_pie (void)\n /* Read our own dynamic section and fill in the info array. */\n main_map->l_ld = ((void *) l_addr + elf_machine_dynamic ());\n \n- elf_get_dynamic_info (main_map, false, true);\n+ elf_get_dynamic_info (main_map, false);\n \n # ifdef ELF_MACHINE_BEFORE_RTLD_RELOC\n ELF_MACHINE_BEFORE_RTLD_RELOC (main_map, main_map->l_info);\ndiff --git a/elf/get-dynamic-info.h b/elf/get-dynamic-info.h\nindex 46faa34acf..9591d00d59 100644\n--- a/elf/get-dynamic-info.h\n+++ b/elf/get-dynamic-info.h\n@@ -26,8 +26,7 @@\n #include <libc-diag.h>\n \n static inline void __attribute__ ((unused, always_inline))\n-elf_get_dynamic_info (struct link_map *l, bool bootstrap,\n-\t\t bool static_pie_bootstrap)\n+elf_get_dynamic_info (struct link_map *l, bool bootstrap)\n {\n #if __ELF_NATIVE_CLASS == 32\n typedef Elf32_Word d_tag_utype;\n@@ -128,7 +127,7 @@ elf_get_dynamic_info (struct link_map *l, bool bootstrap,\n #endif\n if (info[DT_RELR] != NULL)\n assert (info[DT_RELRENT]->d_un.d_val == sizeof (ElfW(Relr)));\n- if (bootstrap || static_pie_bootstrap)\n+ if (bootstrap)\n {\n assert (info[DT_RUNPATH] == NULL);\n assert (info[DT_RPATH] == NULL);\ndiff --git a/elf/rtld.c b/elf/rtld.c\nindex 29e7a4ddfa..0299d8bc64 100644\n--- a/elf/rtld.c\n+++ b/elf/rtld.c\n@@ -547,7 +547,7 @@ _dl_start (void *arg)\n /* Read our own dynamic section and fill in the info array. */\n bootstrap_map.l_ld = (void *) bootstrap_map.l_addr + elf_machine_dynamic ();\n bootstrap_map.l_ld_readonly = DL_RO_DYN_SECTION;\n- elf_get_dynamic_info (&bootstrap_map, true, false);\n+ elf_get_dynamic_info (&bootstrap_map, true);\n \n #if NO_TLS_OFFSET != 0\n bootstrap_map.l_tls_offset = NO_TLS_OFFSET;\n@@ -1701,7 +1701,7 @@ dl_main (const ElfW(Phdr) *phdr,\n if (! rtld_is_main)\n {\n /* Extract the contents of the dynamic section for easy access. */\n- elf_get_dynamic_info (main_map, false, false);\n+ elf_get_dynamic_info (main_map, false);\n \n /* If the main map is libc.so, update the base namespace to\n \t refer to this map. If libc.so is loaded later, this happens\ndiff --git a/elf/setup-vdso.h b/elf/setup-vdso.h\nindex 0dba7072d5..58b7712046 100644\n--- a/elf/setup-vdso.h\n+++ b/elf/setup-vdso.h\n@@ -64,7 +64,7 @@ setup_vdso (struct link_map *main_map __attribute__ ((unused)),\n l->l_addr = l->l_map_start - l->l_addr;\n l->l_map_end += l->l_addr;\n l->l_ld = (void *) ((ElfW(Addr)) l->l_ld + l->l_addr);\n- elf_get_dynamic_info (l, false, false);\n+ elf_get_dynamic_info (l, false);\n _dl_setup_hash (l);\n l->l_relocated = 1;\n \ndiff --git a/elf/tst-pie-rpath-mod.c b/elf/tst-pie-rpath-mod.c\nnew file mode 100644\nindex 0000000000..719eb41e09\n--- /dev/null\n+++ b/elf/tst-pie-rpath-mod.c\n@@ -0,0 +1,19 @@\n+/* Check if RPATH/RUNPATH is allowed for static-pie.\n+ Copyright (C) 2026 Free Software Foundation, Inc.\n+ This file is part of the GNU C Library.\n+\n+ The GNU C Library is free software; you can redistribute it and/or\n+ modify it under the terms of the GNU Lesser General Public\n+ License as published by the Free Software Foundation; either\n+ version 2.1 of the License, or (at your option) any later version.\n+\n+ The GNU C Library is distributed in the hope that it will be useful,\n+ but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ Lesser General Public License for more details.\n+\n+ You should have received a copy of the GNU Lesser General Public\n+ License along with the GNU C Library; if not, see\n+ <https://www.gnu.org/licenses/>. */\n+\n+int foo (void) { return 42; }\ndiff --git a/elf/tst-pie-rpath-static.c b/elf/tst-pie-rpath-static.c\nnew file mode 100644\nindex 0000000000..02fb05d2e6\n--- /dev/null\n+++ b/elf/tst-pie-rpath-static.c\n@@ -0,0 +1,52 @@\n+/* Check if RPATH/RUNPATH is allowed for static-pie.\n+ Copyright (C) 2026 Free Software Foundation, Inc.\n+ This file is part of the GNU C Library.\n+\n+ The GNU C Library is free software; you can redistribute it and/or\n+ modify it under the terms of the GNU Lesser General Public\n+ License as published by the Free Software Foundation; either\n+ version 2.1 of the License, or (at your option) any later version.\n+\n+ The GNU C Library is distributed in the hope that it will be useful,\n+ but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ Lesser General Public License for more details.\n+\n+ You should have received a copy of the GNU Lesser General Public\n+ License along with the GNU C Library; if not, see\n+ <https://www.gnu.org/licenses/>. */\n+\n+#include <stdlib.h>\n+#include <support/xunistd.h>\n+#include <support/support.h>\n+#include <support/xdlfcn.h>\n+#include <support/check.h>\n+#include <support/temp_file.h>\n+\n+#define LIBNAME \"tst-pie-rpath-mod.so\"\n+#define TESTSUBDIR PFX \"tst-pie-rpath-static-subdir\"\n+#define LIBPATH TESTSUBDIR \"/\" LIBNAME\n+\n+static void\n+do_prepare (int argc, char **argv)\n+{\n+ xmkdir (TESTSUBDIR, 0777);\n+ add_temp_file (TESTSUBDIR);\n+\n+ support_copy_file (PFX \"/\" LIBNAME, LIBPATH);\n+ add_temp_file (LIBPATH);\n+}\n+#define PREPARE do_prepare\n+\n+static int\n+do_test (void)\n+{\n+ void *h = xdlopen (LIBNAME, RTLD_NOW);\n+ int (*foo)(void) = xdlsym (h, \"foo\");\n+ TEST_COMPARE (foo (), 42);\n+ xdlclose (h);\n+\n+ return 0;\n+}\n+\n+#include <support/test-driver.c>\n", "prefixes": [ "v7", "5/5" ] }