Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2200817/?format=api
{ "id": 2200817, "url": "http://patchwork.ozlabs.org/api/patches/2200817/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260225100137.383527-1-poros@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260225100137.383527-1-poros@redhat.com>", "list_archive_url": null, "date": "2026-02-25T10:01:37", "name": "[iwl-net] iavf: fix VLAN filter lost on add/delete race", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4c7ff02398f1ab7f1714095c9ea4e6a353f83845", "submitter": { "id": 74657, "url": "http://patchwork.ozlabs.org/api/people/74657/?format=api", "name": "Petr Oros", "email": "poros@redhat.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260225100137.383527-1-poros@redhat.com/mbox/", "series": [ { "id": 493351, "url": "http://patchwork.ozlabs.org/api/series/493351/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=493351", "date": "2026-02-25T10:01:37", "name": "[iwl-net] iavf: fix VLAN filter lost on add/delete race", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/493351/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2200817/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2200817/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=FHvJ6z1w;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fLVWK03TPz1xwy\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Feb 2026 21:02:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 9D83F41D7B;\n\tWed, 25 Feb 2026 10:02:14 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ODUs0UzLwvmJ; Wed, 25 Feb 2026 10:02:12 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D3BA2407DF;\n\tWed, 25 Feb 2026 10:02:12 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id A7C9F204\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Feb 2026 10:02:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 999F560F71\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Feb 2026 10:02:11 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id DV_IAvZTO4Mu for <intel-wired-lan@lists.osuosl.org>;\n Wed, 25 Feb 2026 10:02:10 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 7BA4A60744\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Feb 2026 10:02:09 +0000 (UTC)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-Xc32Keg6NpmMeZ1XcMuGJw-1; Wed,\n 25 Feb 2026 05:02:04 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 82D53195609F; Wed, 25 Feb 2026 10:02:01 +0000 (UTC)", "from ShadowPeak.redhat.com (unknown [10.45.225.132])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6067E3003D8C; Wed, 25 Feb 2026 10:01:58 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org D3BA2407DF", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7BA4A60744" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1772013732;\n\tbh=Cg5Gjl2amw0T9d2qORAIX+1bQ59fHlgumxxtVuZFhPM=;\n\th=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:Cc:From;\n\tb=FHvJ6z1wbK7oustihnMLX9xxgwWebjWvr0HWAeJGgYQIek4fQR/zVKTJ4iWA7QKYA\n\t 9WTgMsUiEvtg0B/ahH4OwtUld34Vd8tI+GCVI5oVU70xk5dRSHXyWRv4s1s1Oc0/Tj\n\t 7PJX0Qz7KW7IaPpFqN9R1CMbXXwC7SQ6yct7O7KCC1AA8RfSgP+eQPqPl59Hy2G9r1\n\t zU3cE1NUDnJFDFovUymzwy464ysNH6TjZGnBmLMCSQ++BpMaY2OahKTRywbgf6iB+x\n\t yS4HxHZ5fvv/+a/kRr/Sf6bU5dstGJuTrmZG/cp7uYL663u+AKtTxNPmI8wiK+SwO3\n\t XQKXjrAEIAv9A==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 7BA4A60744", "X-MC-Unique": "Xc32Keg6NpmMeZ1XcMuGJw-1", "X-Mimecast-MFC-AGG-ID": "Xc32Keg6NpmMeZ1XcMuGJw_1772013722", "From": "Petr Oros <poros@redhat.com>", "To": "netdev@vger.kernel.org", "Date": "Wed, 25 Feb 2026 11:01:37 +0100", "Message-ID": "<20260225100137.383527-1-poros@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-MFC-PROC-ID": "HAMJ9E3S8MFXGNeZRWveheR1fq3jiAAmCnEJsknjGfE_1772013722", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1772013728;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=Cg5Gjl2amw0T9d2qORAIX+1bQ59fHlgumxxtVuZFhPM=;\n b=SxmYaFClrH0cWjRVSfXOZlJ4o0HReq2lJ28kCbZjMeiDe3ngdnQIhjdvBEoRnh4DE9Efp/\n 2q3pVODxzzGTx5SCTsctMVSwKztreWWhjSeI7UVNvworl5xIuklE7iTzm7aDcpyQFhZBS/\n UwLq9fdxLq09HiZrwA8K55+yHwzU2D4=", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp3.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=SxmYaFCl" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net] iavf: fix VLAN filter lost on\n add/delete race", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Eric Dumazet <edumazet@google.com>, Ahmed Zaki <ahmed.zaki@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n Tony Nguyen <anthony.l.nguyen@intel.com>,\n intel-wired-lan@lists.osuosl.org, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, \"David S. Miller\" <davem@davemloft.net>,\n linux-kernel@vger.kernel.org", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When iavf_add_vlan() finds an existing filter in IAVF_VLAN_REMOVE\nstate, it transitions the filter to IAVF_VLAN_ACTIVE assuming the\npending delete can simply be cancelled. However, there is no guarantee\nthat iavf_del_vlans() has not already processed the delete AQ request\nand removed the filter from the PF. In that case the filter remains in\nthe driver's list as IAVF_VLAN_ACTIVE but is no longer programmed on\nthe NIC. Since iavf_add_vlans() only picks up filters in\nIAVF_VLAN_ADD state, the filter is never re-added, and spoof checking\ndrops all traffic for that VLAN.\n\n CPU0 CPU1 Workqueue\n ---- ---- ---------\n iavf_del_vlan(vlan 100)\n f->state = REMOVE\n schedule AQ_DEL_VLAN\n iavf_add_vlan(vlan 100)\n f->state = ACTIVE\n iavf_del_vlans()\n f is ACTIVE, skip\n iavf_add_vlans()\n f is ACTIVE, skip\n\n Filter is ACTIVE in driver but absent from NIC.\n\nTransition to IAVF_VLAN_ADD instead and schedule\nIAVF_FLAG_AQ_ADD_VLAN_FILTER so iavf_add_vlans() re-programs the\nfilter. A duplicate add is idempotent on the PF.\n\nFixes: 0c0da0e95105 (\"iavf: refactor VLAN filter states\")\n\nSigned-off-by: Petr Oros <poros@redhat.com>\n---\n drivers/net/ethernet/intel/iavf/iavf_main.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c\nindex 4b0fc8f354bc90..6046b93c7f3472 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_main.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c\n@@ -782,10 +782,13 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter,\n \t\tadapter->num_vlan_filters++;\n \t\tiavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER);\n \t} else if (f->state == IAVF_VLAN_REMOVE) {\n-\t\t/* IAVF_VLAN_REMOVE means that VLAN wasn't yet removed.\n-\t\t * We can safely only change the state here.\n+\t\t/* Re-add the filter since we cannot tell whether the\n+\t\t * pending delete has already been processed by the PF.\n+\t\t * A duplicate add is harmless.\n \t\t */\n-\t\tf->state = IAVF_VLAN_ACTIVE;\n+\t\tf->state = IAVF_VLAN_ADD;\n+\t\tiavf_schedule_aq_request(adapter,\n+\t\t\t\t\t IAVF_FLAG_AQ_ADD_VLAN_FILTER);\n \t}\n \n clearout:\n", "prefixes": [ "iwl-net" ] }