Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2200514/?format=api
{ "id": 2200514, "url": "http://patchwork.ozlabs.org/api/patches/2200514/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/a38f6d7f-d970-4e22-bf76-b65f34911324@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<a38f6d7f-d970-4e22-bf76-b65f34911324@gmail.com>", "list_archive_url": null, "date": "2026-02-24T23:28:33", "name": "[v2,net] e1000/e1000e: Fix leak in DMA error cleanup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e414dd3d43888bb1c9e8ae8b31ed42615f01a070", "submitter": { "id": 92679, "url": "http://patchwork.ozlabs.org/api/people/92679/?format=api", "name": "Matt Vollrath", "email": "tactii@gmail.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/a38f6d7f-d970-4e22-bf76-b65f34911324@gmail.com/mbox/", "series": [ { "id": 493261, "url": "http://patchwork.ozlabs.org/api/series/493261/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=493261", "date": "2026-02-24T23:28:33", "name": "[v2,net] e1000/e1000e: Fix leak in DMA error cleanup", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/493261/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2200514/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2200514/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=5l5wsBij;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fLDS91Jkhz1xvx\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Feb 2026 10:28:40 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 108C461451;\n\tTue, 24 Feb 2026 23:28:39 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MNH8Vr9HrQkn; Tue, 24 Feb 2026 23:28:38 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 887436146B;\n\tTue, 24 Feb 2026 23:28:38 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id B881F23D\n for <intel-wired-lan@lists.osuosl.org>; Tue, 24 Feb 2026 23:28:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id AA411404B7\n for <intel-wired-lan@lists.osuosl.org>; Tue, 24 Feb 2026 23:28:37 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id BnYt5GMry3hF for <intel-wired-lan@lists.osuosl.org>;\n Tue, 24 Feb 2026 23:28:37 +0000 (UTC)", "from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com\n [IPv6:2607:f8b0:4864:20::112a])\n by smtp2.osuosl.org (Postfix) with ESMTPS id DC791403E5\n for <intel-wired-lan@osuosl.org>; Tue, 24 Feb 2026 23:28:36 +0000 (UTC)", "by mail-yw1-x112a.google.com with SMTP id\n 00721157ae682-7984d31b895so24274047b3.1\n for <intel-wired-lan@osuosl.org>; Tue, 24 Feb 2026 15:28:36 -0800 (PST)", "from ?IPV6:2600:6c5c:6b00:bf4:4216:7eff:fea9:90ad?\n ([2600:6c5c:6b00:bf4:4216:7eff:fea9:90ad])\n by smtp.gmail.com with ESMTPSA id\n 00721157ae682-79862083774sm6497867b3.14.2026.02.24.15.28.34\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 24 Feb 2026 15:28:34 -0800 (PST)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 887436146B", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org DC791403E5" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1771975718;\n\tbh=xJWI/FdW/cHCSkWJY18GYHJEjMobOqf5F+5n03qfkC0=;\n\th=Date:From:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=5l5wsBijRMuMeZJdRSa6lcwJdZ4eeyXOyoz/CpOPxs1tcW0CPiXsYBxtCLH4YQ5H0\n\t m5eBucMacpysUXToZWjD3K3VZR+LeNADckU9aunnRBHYCUMfGP96GTbd9E69JNzPBg\n\t eIgczLJaWdrdDBR6gGtqnIM1jSm2L4RVAPRdOWgf8aTnAi6qCQJ6SUd/m7Z17nUAoq\n\t lp40oW+C2B7lXAPzUUci/IwTok3liuPGWAjWR40mpxUBKa5+PmlBj2hxh3e6hP4Co4\n\t nnwOi98bSB+5ADww4hvvr4HJcNJOeGj4KE//iHSHjvBwgfUiL0W/6Ic806xzCkz+vJ\n\t n120eIRa2HXdQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::112a; helo=mail-yw1-x112a.google.com;\n envelope-from=tactii@gmail.com; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org DC791403E5", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771975715; x=1772580515;\n h=content-transfer-encoding:subject:cc:to:from:content-language\n :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=xJWI/FdW/cHCSkWJY18GYHJEjMobOqf5F+5n03qfkC0=;\n b=ZKEwx2XrRhuqBn5dEYramIaShmzIhqMzWMcnB84KPytv6nnPN2ERTbS1JEJ18wLnH2\n q8JvbA2MbqY4dv2yd7UFqiMTraWXZrsZrkH7VKQTg643CXwTxr/HQuUY5hictx5cl8qW\n oS2TCWFFoHW7Gduh5Wz6bonkyZsQyuag1jhTfHxUsXlR9Gf+lwzVIod3cGF0tI58E8HG\n PXw8A6fXJaPn4+3GBE1KqFK3EB6VigXIlIt4afVSeviVbsbMgKCeUOvGK3o+/XKv6Ao2\n FroCkW3XecEIkfbxO4IGlyw3KAWvDOUrcgnvtIp4R7mbUuCMUj2b/vejpCE3ukjYPuPw\n ygJA==", "X-Gm-Message-State": "AOJu0YwbqESMU7tG5XcLm32vKcqfyIR1Xroo7kEg7vRFi2bERHvJU0Kz\n rlqQgWjSuYpopQv8YRc8wGUqs1L24EN4u3E72XtOZEU+bVXMqKMRKiqrbYH4GNno", "X-Gm-Gg": "ATEYQzwUzaJVN2l/I31N6FcTMktBA80x9B1n9Ua1KABraSKNkplBtD7NjiHbvZipJL4\n Qu/7dm3R49Iz2Y56Gwo5Nxmz+2sccQtUBl8CA4Q16oAU3DQNDvKJO6j/GDnElYwUPoizgjW9cOg\n Idpc2BL2urXC1JBG4fwV1ljF2l2Cpvz+Sukhg7zMmfLpfnQ/I5HIrENYOCCzYEtZuuMY7655+Ke\n ryUJAfFQYhaxpQcgdptyvF7mkNH7srFD2a00Ois0MCi66EZs/tXyt+086z5O8hBc4M0z7i93jNJ\n lqgJXMkDkMRh7txCKkV+GZ4acBVmA/toJz+3fcXfrZodAhOR+S818JLWI7ihQkCNz1t4H9YZn7I\n G7bij5TeAle13yqHP7wkdTStFnIGp1O+NW1SUg20WqSmhcA+IF+Zt4kMUsltE8ZLknLYHg/xguG\n nCKtrhXhxeRjv9H2Ipe5EmV7RvKcOmmjmGKZwAglwVxJEexHpH//uRnv0gCtc0zT+Vti2v0n56x\n FxfEQ==", "X-Received": "by 2002:a05:690c:12:b0:794:8d58:cac0 with SMTP id\n 00721157ae682-798681107b3mr3824457b3.16.1771975714979;\n Tue, 24 Feb 2026 15:28:34 -0800 (PST)", "Message-ID": "<a38f6d7f-d970-4e22-bf76-b65f34911324@gmail.com>", "Date": "Tue, 24 Feb 2026 18:28:33 -0500", "MIME-Version": "1.0", "User-Agent": "Mozilla Thunderbird", "Content-Language": "en-US", "From": "Matt Vollrath <tactii@gmail.com>", "To": "intel-wired-lan@osuosl.org", "Cc": "anthony.l.nguyen@intel.com", "Content-Type": "text/plain; charset=UTF-8; format=flowed", "Content-Transfer-Encoding": "7bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771975715; x=1772580515; darn=osuosl.org;\n h=content-transfer-encoding:subject:cc:to:from:content-language\n :user-agent:mime-version:date:message-id:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xJWI/FdW/cHCSkWJY18GYHJEjMobOqf5F+5n03qfkC0=;\n b=MDGxjJ7GOrUkH3dIY3X8+4QXKor682vTPEhpq+TuJl0jri8IQ4fk1XJhkXT8w/YQcr\n PORwBNcp9RNp5dgf00NSipEQZxZODrrZI2JDkXKe/RllFVSpPoJ6EJ0p2cdQ1tvhy3ln\n uscBia8JZluqOsU/wiWZtdRAKQr2x7ZBEcUXxPggncVEgMda86WpTvusNkKSYDfSB0qi\n Xdc2xD+m8utXQb/8dhn0i7i+jaucVfpG8Lm1S5cPTkoW7KEtiWLDJVzf1DZaQcTiNGB8\n 06ZMbDf7gBQe+E9GH8WwPnitmUu5i61zhOPpSk2ITZWv4cgvHNbHKDXjzB2bVoLyBUCd\n bRiQ==", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20230601 header.b=MDGxjJ7G" ], "Subject": "[Intel-wired-lan] [PATCH v2 net] e1000/e1000e: Fix leak in DMA\n error cleanup", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "If an error is encountered while mapping TX buffers, the driver should\nunmap any buffers already mapped for that skb.\n\nBecause count is incremented after a successful mapping, it will always\nmatch the correct number of unmappings needed when dma_error is reached.\nDecrementing count before the while loop in dma_error causes an\noff-by-one error. If any mapping was successful before an unsuccessful\nmapping, exactly one DMA mapping would leak.\n\nIn these commits, a faulty while condition caused an infinite loop in\ndma_error:\nCommit 03b1320dfcee (\"e1000e: remove use of skb_dma_map from e1000e\ndriver\")\nCommit 602c0554d7b0 (\"e1000: remove use of skb_dma_map from e1000 driver\")\n\nCommit c1fa347f20f1 (\"e1000/e1000e/igb/igbvf/ixgb/ixgbe: Fix tests of\nunsigned in *_tx_map()\") fixed the infinite loop, but introduced the\noff-by-one error.\n\nThis issue may still exist in the igbvf driver, but I did not address it\nin this patch.\n\nFixes: c1fa347f20f1 (\"e1000/e1000e/igb/igbvf/ixgb/ixgbe: Fix tests of \nunsigned in *_tx_map()\")\nAssisted-by: Claude:claude-4.6-opus\nSigned-off-by: Matt Vollrath <tactii@gmail.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_main.c | 2 --\n drivers/net/ethernet/intel/e1000e/netdev.c | 2 --\n 2 files changed, 4 deletions(-)\n\n \t\tif (i == 0)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c \nb/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex 7f078ec9c14c..15160427c8b3 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -2952,8 +2952,6 @@ static int e1000_tx_map(struct e1000_adapter *adapter,\n dma_error:\n \tdev_err(&pdev->dev, \"TX DMA map failed\\n\");\n \tbuffer_info->dma = 0;\n-\tif (count)\n-\t\tcount--;\n\n \twhile (count--) {\n \t\tif (i == 0)\ndiff --git a/drivers/net/ethernet/intel/e1000e/netdev.c \nb/drivers/net/ethernet/intel/e1000e/netdev.c\nindex ddbe2f7d8112..6bcb57609d16 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -5654,8 +5654,6 @@ static int e1000_tx_map(struct e1000_ring \n*tx_ring, struct sk_buff *skb,\n dma_error:\n \tdev_err(&pdev->dev, \"Tx DMA map failed\\n\");\n \tbuffer_info->dma = 0;\n-\tif (count)\n-\t\tcount--;\n\n \twhile (count--) {\n", "prefixes": [ "v2", "net" ] }