Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2200193/?format=api
{ "id": 2200193, "url": "http://patchwork.ozlabs.org/api/patches/2200193/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260224111044.3487873-2-mika.westerberg@linux.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260224111044.3487873-2-mika.westerberg@linux.intel.com>", "list_archive_url": null, "date": "2026-02-24T11:10:40", "name": "[1/5] igc: Call netif_queue_set_napi() with rntl locked", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "39dd9aa4ef38fe198e995237a9c2db85f9580aad", "submitter": { "id": 14534, "url": "http://patchwork.ozlabs.org/api/people/14534/?format=api", "name": "Mika Westerberg", "email": "mika.westerberg@linux.intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260224111044.3487873-2-mika.westerberg@linux.intel.com/mbox/", "series": [ { "id": 493142, "url": "http://patchwork.ozlabs.org/api/series/493142/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=493142", "date": "2026-02-24T11:10:41", "name": "PCI / igc: Improvements related to PTM enabling", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/493142/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2200193/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2200193/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=HGTiOIDA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fKw521X1zz1xyB\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Feb 2026 22:11:02 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id ABD5060BF2;\n\tTue, 24 Feb 2026 11:10:55 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id wP5nqFFiP7d8; Tue, 24 Feb 2026 11:10:55 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id DCDAD60BBD;\n\tTue, 24 Feb 2026 11:10:54 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 1C6F6249\n for <intel-wired-lan@lists.osuosl.org>; Tue, 24 Feb 2026 11:10:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 75A3641BEC\n for <intel-wired-lan@lists.osuosl.org>; Tue, 24 Feb 2026 11:10:52 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fq9YeWuPwaS6 for <intel-wired-lan@lists.osuosl.org>;\n Tue, 24 Feb 2026 11:10:52 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 7B0C341BE9\n for <intel-wired-lan@lists.osuosl.org>; Tue, 24 Feb 2026 11:10:51 +0000 (UTC)", "from orviesa008.jf.intel.com ([10.64.159.148])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Feb 2026 03:10:50 -0800", "from black.igk.intel.com ([10.91.253.5])\n by orviesa008.jf.intel.com with ESMTP; 24 Feb 2026 03:10:45 -0800", "by black.igk.intel.com (Postfix, from userid 1001)\n id 1A74795; Tue, 24 Feb 2026 12:10:44 +0100 (CET)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org DCDAD60BBD", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7B0C341BE9" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1771931454;\n\tbh=b7SGsY27CdpAkxE8fKkuv4hWvQA7HeB3SBHwOZJPlGQ=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=HGTiOIDAx1ZT6b9JtEzW7+1rZivOLioTQQqW27lroqnCZEXI/QHCsRvQZQ60zTCJd\n\t ZJ5tMTKlRVaiPP1NWYQlUQGE0Kvw+yt0av5VL4RJtl6GntrYex6qOle41OEbaIG9I4\n\t ei3tLrJZmKngMS7sfs1YekbDYDSQjOiVZDMV5d4gFHXPEXlLyih/YPaLriSfmu6gTk\n\t aWYpPUDFRkZVD2F+zqABnayO/P0w+aRXX3QFBS7YLFxdDW7jAwePA7N4qR7byCwezc\n\t g3CC3QrHVOhoNfbmt04nUH7i0xr79l/jmNbcKGsemUWw1zO0mWtLRJOI+184R62Cwq\n\t VxFJX4iq1mBkQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.7;\n helo=mgamail.intel.com; envelope-from=mika.westerberg@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7B0C341BE9", "X-CSE-ConnectionGUID": [ "5IfbsP0iSxWm+f9iK11bDQ==", "YNqqA14XSzebFs1i1wvxyQ==" ], "X-CSE-MsgGUID": [ "4cxwow8iQWG4oK050Jtygg==", "lHEG7HAeTqm3HSQtwgxBow==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11710\"; a=\"98404997\"", "E=Sophos;i=\"6.21,308,1763452800\"; d=\"scan'208\";a=\"98404997\"", "E=Sophos;i=\"6.21,308,1763452800\"; d=\"scan'208\";a=\"215892053\"" ], "X-ExtLoop1": "1", "From": "Mika Westerberg <mika.westerberg@linux.intel.com>", "To": "linux-pci@vger.kernel.org", "Cc": "intel-wired-lan@lists.osuosl.org, Bjorn Helgaas <bhelgaas@google.com>,\n Lukas Wunner <lukas@wunner.de>, Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S . Miller\" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,\n Paolo Abeni <pabeni@redhat.com>, Saeed Mahameed <saeedm@nvidia.com>,\n Leon Romanovsky <leon@kernel.org>, Tariq Toukan <tariqt@nvidia.com>,\n Mark Bloch <mbloch@nvidia.com>, Richard Cochran <richardcochran@gmail.com>,\n Andy Shevchenko <andriy.shevchenko@intel.com>,\n Vitaly Lifshits <vitaly.lifshits@intel.com>,\n =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n Vinicius Costa Gomes <vinicius.gomes@intel.com>,\n Dima Ruinskiy <dima.ruinskiy@intel.com>,\n Mika Westerberg <mika.westerberg@linux.intel.com>", "Date": "Tue, 24 Feb 2026 12:10:40 +0100", "Message-ID": "<20260224111044.3487873-2-mika.westerberg@linux.intel.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260224111044.3487873-1-mika.westerberg@linux.intel.com>", "References": "<20260224111044.3487873-1-mika.westerberg@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1771931451; x=1803467451;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=4GiY9KnO3IGfcB9TBZYZbeVvvhjJF6YhNoqrn+ZUS4o=;\n b=AyeahibwmjN9cXOkwyfnFoi8RlxqZwFRFmB0/Nw0tu50bbBR9GHnVUiH\n qTRQOQqgcTB6+8MN+fawyVDA/wZ//nfrI/m9j3wlI+rvytfEuRWIb/FAf\n umG8US3c5eDJbBYLx3VcRpFYUI09sLVu23OmBG8TU3IJls24UQ/9rczi6\n 4rMyys+Fu/w/fn5/J9g8aRz8YS0NgTlwitshOYdZUDLKttg4lbY/x/Kfp\n UGSmpKrLfp8VixZp93mVEO0ZQheU8aEMx1g02OxYcz0hV7Z0ozM4weCD8\n fuTZnUKGENvZXpPWV+RpG1WSQHtFCyTZt8Bts/oRg9xlStGlHDLJgkBoQ\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Ayeahibw" ], "Subject": "[Intel-wired-lan] [PATCH 1/5] igc: Call netif_queue_set_napi() with\n rntl locked", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When runtime resuming igc we get:\n\n [ 516.161666] RTNL: assertion failed at ./include/net/netdev_lock.h (72)\n\nHappens because commit 310ae9eb2617 (\"net: designate queue -> napi\nlinking as \"ops protected\"\") added check for this. For this reason drop\nthe special case for runtime PM from __igc_resume(). This makes it take\nrtnl lock unconditionally.\n\nSigned-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 27e5c2109138..7ffd34bfa14e 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -7518,7 +7518,7 @@ static void igc_deliver_wake_packet(struct net_device *netdev)\n \tnetif_rx(skb);\n }\n \n-static int __igc_resume(struct device *dev, bool rpm)\n+static int __igc_resume(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n \tstruct net_device *netdev = pci_get_drvdata(pdev);\n@@ -7563,11 +7563,9 @@ static int __igc_resume(struct device *dev, bool rpm)\n \twr32(IGC_WUS, ~0);\n \n \tif (netif_running(netdev)) {\n-\t\tif (!rpm)\n-\t\t\trtnl_lock();\n+\t\trtnl_lock();\n \t\terr = __igc_open(netdev, true);\n-\t\tif (!rpm)\n-\t\t\trtnl_unlock();\n+\t\trtnl_unlock();\n \t\tif (!err)\n \t\t\tnetif_device_attach(netdev);\n \t}\n@@ -7577,12 +7575,12 @@ static int __igc_resume(struct device *dev, bool rpm)\n \n static int igc_resume(struct device *dev)\n {\n-\treturn __igc_resume(dev, false);\n+\treturn __igc_resume(dev);\n }\n \n static int igc_runtime_resume(struct device *dev)\n {\n-\treturn __igc_resume(dev, true);\n+\treturn __igc_resume(dev);\n }\n \n static int igc_suspend(struct device *dev)\n", "prefixes": [ "1/5" ] }