Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2199361/?format=api
{ "id": 2199361, "url": "http://patchwork.ozlabs.org/api/patches/2199361/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260223125157.819135-1-michal.swiatkowski@linux.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260223125157.819135-1-michal.swiatkowski@linux.intel.com>", "list_archive_url": null, "date": "2026-02-23T12:51:57", "name": "[iwl-net,v1] ice: set max queues in alloc_etherdev_mqs()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8c8d79bcd8f1674e62284029abb53370254c21c9", "submitter": { "id": 81972, "url": "http://patchwork.ozlabs.org/api/people/81972/?format=api", "name": "Michal Swiatkowski", "email": "michal.swiatkowski@linux.intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260223125157.819135-1-michal.swiatkowski@linux.intel.com/mbox/", "series": [ { "id": 492983, "url": "http://patchwork.ozlabs.org/api/series/492983/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=492983", "date": "2026-02-23T12:51:57", "name": "[iwl-net,v1] ice: set max queues in alloc_etherdev_mqs()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492983/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2199361/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2199361/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=VfcoK9Cx;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fKM6w2q6Pz1xvt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Feb 2026 00:25:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id E2D336073C;\n\tMon, 23 Feb 2026 13:25:42 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ijzLmACFAPKl; Mon, 23 Feb 2026 13:25:41 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 8122A60703;\n\tMon, 23 Feb 2026 13:25:41 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id DBE7C237\n for <intel-wired-lan@lists.osuosl.org>; Mon, 23 Feb 2026 13:25:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id C149840A12\n for <intel-wired-lan@lists.osuosl.org>; Mon, 23 Feb 2026 13:25:38 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id al-7ruT6FO3L for <intel-wired-lan@lists.osuosl.org>;\n Mon, 23 Feb 2026 13:25:37 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.16])\n by smtp4.osuosl.org (Postfix) with ESMTPS id D172C408CD\n for <intel-wired-lan@lists.osuosl.org>; Mon, 23 Feb 2026 13:25:36 +0000 (UTC)", "from orviesa001.jf.intel.com ([10.64.159.141])\n by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Feb 2026 05:25:35 -0800", "from os-delivery.igk.intel.com ([10.102.21.165])\n by orviesa001.jf.intel.com with ESMTP; 23 Feb 2026 05:25:31 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8122A60703", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org D172C408CD" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1771853141;\n\tbh=87m90BdOlbCVCbazRyH726TTlayvIP6wGlah0q525/A=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=VfcoK9CxHIFFbKsBNWe+/ZidtX5u9P6oY7SgSFp+6o6rlO+724eoKhXq4PXKtxwJe\n\t dk7YuyoaPxpqBLssy3bCwjmerV4QltUAoPVTrfT3uxUxPDvR7YucQg/LZsfge6QZVc\n\t 317XcTNg34lVGLlkpftrQE2FTnlgzeve9fRyQfw5NFBzqJLIZ3DdRssmVCHXFI9lQR\n\t ejAYvdshYEGDDVjVhmDw4gy+e6ShLIRwzHyVWQ6Uc3q3/1ARvmEV5UtY0K/BVTAaug\n\t epzm8S+4wLDyp6LJrvOsZ7V9/Af23vHwBGhYiBV4nxcqJ2ZJ1x2g9JEv54wDBBLoqc\n\t wNt9fGUBFgL6g==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.16;\n helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org D172C408CD", "X-CSE-ConnectionGUID": [ "hm7k9fnWTCu7zsyezgLyaw==", "qhMCWJpHSnazyPqUZFC/mQ==" ], "X-CSE-MsgGUID": [ "poURiJW2S5yHRhhOYPlKQw==", "iBZk0vBrQy2MbjUHGKSngg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11709\"; a=\"60421081\"", "E=Sophos;i=\"6.21,306,1763452800\"; d=\"scan'208\";a=\"60421081\"", "E=Sophos;i=\"6.21,306,1763452800\"; d=\"scan'208\";a=\"253283464\"" ], "X-ExtLoop1": "1", "From": "Michal Swiatkowski <michal.swiatkowski@linux.intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>", "Date": "Mon, 23 Feb 2026 13:51:57 +0100", "Message-ID": "<20260223125157.819135-1-michal.swiatkowski@linux.intel.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1771853136; x=1803389136;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=8GljxCdIML4JwqSHoSvnhyZ8D7LTSTtgjk4jLabrviM=;\n b=kA80m0ekNjp5c9hODYl7qvqS3JITzIzxJ13GwJmHTFQIy5y+2CKndDUk\n SUIeTyhTSB1gfqy2Re0+9YUlSQoasHfPyodV8JX1q/JbmwIYVNPui7Ko7\n E5HDeUkH6hUtardu/j6p+YndxnOco1FT5q14e24sA5vGm2+Ar7IlvSK1P\n PHn4kIeyzcQQEERB9xTQX8w1VJn7tpSL6oIL5xyZinM9M6gYV8cCY0idi\n HOQMhB7a428DXIQcfV+mYgR3/UGgVdFVClvSySqwAs2xL60nsef1OpvOt\n SbdWldB0+hN4NBFY9JL8e4XBITRt2RuB6eWs2lxbkC7SyGdrGyQKERd50\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=kA80m0ek" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v1] ice: set max queues in\n alloc_etherdev_mqs()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When allocating netdevice using alloc_etherdev_mqs() the maximum\nsupported queues number should be passed. The vsi->alloc_txq/rxq is\nstoring current number of queues, not the maximum ones.\n\nUse the same function for getting max Tx and Rx queues which is used\nduring ethtool -l call to set maximum number of queues during netdev\nallocation.\n\nReproduction steps:\n$ethtool -l $pf # says current 16, max 64\n$ethtool -S $pf # fine\n$ethtool -L $pf combined 40 # crash\n\n[491187.472594] Call Trace:\n[491187.472829] <TASK>\n[491187.473067] netif_set_xps_queue+0x26/0x40\n[491187.473305] ice_vsi_cfg_txq+0x265/0x3d0 [ice]\n[491187.473619] ice_vsi_cfg_lan_txqs+0x68/0xa0 [ice]\n[491187.473918] ice_vsi_cfg_lan+0x2b/0xa0 [ice]\n[491187.474202] ice_vsi_open+0x71/0x170 [ice]\n[491187.474484] ice_vsi_recfg_qs+0x17f/0x230 [ice]\n[491187.474759] ? dev_get_min_mp_channel_count+0xab/0xd0\n[491187.474987] ice_set_channels+0x185/0x3d0 [ice]\n[491187.475278] ethnl_set_channels+0x26f/0x340\n\nFixes: ee13aa1a2c5a (\"ice: use netif_get_num_default_rss_queues()\")\nReviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>\nSigned-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>\n---\n drivers/net/ethernet/intel/ice/ice.h | 22 ++++++++++++++++++++\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 18 ----------------\n drivers/net/ethernet/intel/ice/ice_main.c | 4 ++--\n 3 files changed, 24 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h\nindex f6a56a864459..725b130dd3a2 100644\n--- a/drivers/net/ethernet/intel/ice/ice.h\n+++ b/drivers/net/ethernet/intel/ice/ice.h\n@@ -839,6 +839,28 @@ static inline void ice_tx_xsk_pool(struct ice_vsi *vsi, u16 qid)\n \tWRITE_ONCE(ring->xsk_pool, ice_get_xp_from_qid(vsi, qid));\n }\n \n+/**\n+ * ice_get_max_txq - return the maximum number of Tx queues for in a PF\n+ * @pf: PF structure\n+ *\n+ * Return: maximum number of Tx queues\n+ */\n+static inline int ice_get_max_txq(struct ice_pf *pf)\n+{\n+\treturn min(num_online_cpus(), pf->hw.func_caps.common_cap.num_txq);\n+}\n+\n+/**\n+ * ice_get_max_rxq - return the maximum number of Rx queues for in a PF\n+ * @pf: PF structure\n+ *\n+ * Return: maximum number of Rx queues\n+ */\n+static inline int ice_get_max_rxq(struct ice_pf *pf)\n+{\n+\treturn min(num_online_cpus(), pf->hw.func_caps.common_cap.num_rxq);\n+}\n+\n /**\n * ice_get_main_vsi - Get the PF VSI\n * @pf: PF instance\ndiff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex a897a6b22495..a0b0416f5aea 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -3780,24 +3780,6 @@ ice_get_ts_info(struct net_device *dev, struct kernel_ethtool_ts_info *info)\n \treturn 0;\n }\n \n-/**\n- * ice_get_max_txq - return the maximum number of Tx queues for in a PF\n- * @pf: PF structure\n- */\n-static int ice_get_max_txq(struct ice_pf *pf)\n-{\n-\treturn min(num_online_cpus(), pf->hw.func_caps.common_cap.num_txq);\n-}\n-\n-/**\n- * ice_get_max_rxq - return the maximum number of Rx queues for in a PF\n- * @pf: PF structure\n- */\n-static int ice_get_max_rxq(struct ice_pf *pf)\n-{\n-\treturn min(num_online_cpus(), pf->hw.func_caps.common_cap.num_rxq);\n-}\n-\n /**\n * ice_get_combined_cnt - return the current number of combined channels\n * @vsi: PF VSI pointer\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex fa4095037be5..863ac81eebce 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -4699,8 +4699,8 @@ static int ice_cfg_netdev(struct ice_vsi *vsi)\n \tstruct net_device *netdev;\n \tu8 mac_addr[ETH_ALEN];\n \n-\tnetdev = alloc_etherdev_mqs(sizeof(*np), vsi->alloc_txq,\n-\t\t\t\t vsi->alloc_rxq);\n+\tnetdev = alloc_etherdev_mqs(sizeof(*np), ice_get_max_txq(vsi->back),\n+\t\t\t\t ice_get_max_rxq(vsi->back));\n \tif (!netdev)\n \t\treturn -ENOMEM;\n \n", "prefixes": [ "iwl-net", "v1" ] }