Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2198712/?format=api
{ "id": 2198712, "url": "http://patchwork.ozlabs.org/api/patches/2198712/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260220184031.60113-1-kohei@enjuk.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260220184031.60113-1-kohei@enjuk.jp>", "list_archive_url": null, "date": "2026-02-20T18:39:41", "name": "[v1,iwl-net] ice: fix potential NULL pointer deref in error path of ice_set_ringparam()", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "8535cc963515aa7e48bcb1d6aea47aef06864b1c", "submitter": { "id": 92459, "url": "http://patchwork.ozlabs.org/api/people/92459/?format=api", "name": "Kohei Enju", "email": "kohei@enjuk.jp" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260220184031.60113-1-kohei@enjuk.jp/mbox/", "series": [ { "id": 492815, "url": "http://patchwork.ozlabs.org/api/series/492815/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=492815", "date": "2026-02-20T18:39:41", "name": "[v1,iwl-net] ice: fix potential NULL pointer deref in error path of ice_set_ringparam()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492815/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2198712/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2198712/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=gNjzcIos;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fHfGK1vhXz1xwg\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 21 Feb 2026 05:41:12 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 9C50061014;\n\tFri, 20 Feb 2026 18:41:10 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id zU5izPoIkGpO; Fri, 20 Feb 2026 18:41:08 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 67C6F60ED4;\n\tFri, 20 Feb 2026 18:41:08 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 9E088183\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Feb 2026 18:41:06 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 9B4ED404A7\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Feb 2026 18:41:06 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Cep6VMdV87_W for <intel-wired-lan@lists.osuosl.org>;\n Fri, 20 Feb 2026 18:41:04 +0000 (UTC)", "from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 26EB04044C\n for <intel-wired-lan@lists.osuosl.org>; Fri, 20 Feb 2026 18:41:03 +0000 (UTC)", "from ms-a2 (54.52.30.125.dy.iij4u.or.jp [125.30.52.54])\n (authenticated bits=0)\n by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 61KIek8G071462\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Sat, 21 Feb 2026 03:40:46 +0900 (JST) (envelope-from kohei@enjuk.jp)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 67C6F60ED4", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 26EB04044C" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1771612868;\n\tbh=wJcqLA4o6q0LATmfKurtxsPZruiaPYV3Pbjtcv35Kjo=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=gNjzcIoswPZd1GomdFNE6dClQ8iCbPJ9fsUyrv5/Az9CwhLqLdSQ45ArL1ho7lz+A\n\t g5Z7m1AZAOduQJHGzbuqn96PEBrFfFpcrvxauD4BoVP+xVKFsMU9y8ae5tmorOFHeC\n\t LPHOHXwPTqVkDC7e50bWobBnmB+IvUm5EsB8riO7TS7higoUNsM2G9D75fp5bGkKuF\n\t C52qneA8sGh9848UhKD1AX026Hf/xmHblWM2lrpIiSYLv6Scjkyjwm+AAd/PjEueiU\n\t me9rOUR9zXQcve/S3XQrNC85ti2/NgMR5CiXZXgKzeImtjRgCrM89jjM78KWxg+neO\n\t xFrJm7nW7ehgg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91;\n helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 26EB04044C", "From": "Kohei Enju <kohei@enjuk.jp>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Cc": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Alice Michael <alice.michael@intel.com>,\n Paul Greenwalt <paul.greenwalt@intel.com>,\n Maciej Fijalkowski <maciej.fijalkowski@intel.com>,\n kohei.enju@gmail.com, Kohei Enju <kohei@enjuk.jp>", "Date": "Fri, 20 Feb 2026 18:39:41 +0000", "Message-ID": "<20260220184031.60113-1-kohei@enjuk.jp>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "a=rsa-sha256;\n bh=wJcqLA4o6q0LATmfKurtxsPZruiaPYV3Pbjtcv35Kjo=;\n c=relaxed/relaxed; d=enjuk.jp;\n h=From:To:Subject:Date:Message-ID;\n s=rs20251215; t=1771612846; v=1;\n b=N1OT53pG3p9VV9Ngd+yeVeyf4LFe1Ti/CazfkZWs03GBQpCbLM/UtpqNioyUDP7u\n TBxrVOGhca+F9boyXNw+yvEgAmfmVhd5q2QJecinEvVGG1cpkfgurLCVsBYDDeue\n U7OROSweswkydQ/TmJbrY9lYViWdUx5dMqZOoRC16c0Qvqd62nRltcmKc8F7HsCq\n 3T9qoQa8jkSoyKSt23bqGD3qzMH9KDSc5O+6QUEA2lyT3wUfPuV5zbc1jf2/Bkp9\n 6HGri+G+7oI4RPHyQbIAWlh0Sv0XCOGMchKevzeYiDdEpXMVwIm+Q+d7+Dyh5PW3\n sImW+8RNhpvnsOsYBQpDow==", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=enjuk.jp", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=enjuk.jp header.i=@enjuk.jp header.a=rsa-sha256\n header.s=rs20251215 header.b=N1OT53pG" ], "Subject": "[Intel-wired-lan] [PATCH v1 iwl-net] ice: fix potential NULL\n pointer deref in error path of ice_set_ringparam()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ice_set_ringparam nullifies tstamp_ring of temporary tx_rings, without\nclearing ICE_TX_RING_FLAGS_TXTIME bit.\nWhen ICE_TX_RING_FLAGS_TXTIME is set and the subsequent\nice_setup_tx_ring() call fails, a NULL pointer dereference could happen\nin the unwinding sequence:\n\nice_clean_tx_ring()\n-> ice_is_txtime_cfg() == true (ICE_TX_RING_FLAGS_TXTIME is set)\n-> ice_free_tx_tstamp_ring()\n -> ice_free_tstamp_ring()\n -> tstamp_ring->desc (NULL deref)\n\nClear ICE_TX_RING_FLAGS_TXTIME bit to avoid the potential issue.\n\nNote that this potential issue is found by manual code review.\nCompile test only since unfortunately I don't have E830 devices.\n\nFixes: ccde82e90946 (\"ice: add E830 Earliest TxTime First Offload support\")\nSigned-off-by: Kohei Enju <kohei@enjuk.jp>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 7f769a90dde1..5ed86648d0d6 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -3290,6 +3290,7 @@ ice_set_ringparam(struct net_device *netdev, struct ethtool_ringparam *ring,\n \t\ttx_rings[i].desc = NULL;\n \t\ttx_rings[i].tx_buf = NULL;\n \t\ttx_rings[i].tstamp_ring = NULL;\n+\t\tclear_bit(ICE_TX_RING_FLAGS_TXTIME, tx_rings[i].flags);\n \t\ttx_rings[i].tx_tstamps = &pf->ptp.port.tx;\n \t\terr = ice_setup_tx_ring(&tx_rings[i]);\n \t\tif (err) {\n", "prefixes": [ "v1", "iwl-net" ] }