Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2197755/?format=api
{ "id": 2197755, "url": "http://patchwork.ozlabs.org/api/patches/2197755/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218132633.29748-8-hreitz@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260218132633.29748-8-hreitz@redhat.com>", "list_archive_url": null, "date": "2026-02-18T13:26:16", "name": "[v4,07/24] fuse: Fix mount options", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f292767e5f0af72350e869c82e1c273b0bb4fb66", "submitter": { "id": 82279, "url": "http://patchwork.ozlabs.org/api/people/82279/?format=api", "name": "Hanna Czenczek", "email": "hreitz@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218132633.29748-8-hreitz@redhat.com/mbox/", "series": [ { "id": 492547, "url": "http://patchwork.ozlabs.org/api/series/492547/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492547", "date": "2026-02-18T13:26:09", "name": "export/fuse: Use coroutines and multi-threading", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/492547/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2197755/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197755/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=IuK+oieR;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=kZeWtETw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGHZR1lxsz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Feb 2026 00:35:27 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vshff-0004F3-Cv; Wed, 18 Feb 2026 08:32:51 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <hreitz@redhat.com>) id 1vshfR-0003yM-0z\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 08:32:38 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <hreitz@redhat.com>) id 1vshfA-0005GT-H7\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 08:32:32 -0500", "from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-441-mM2CUbCqPAqmQL-72PjDug-1; Wed, 18 Feb 2026 08:27:03 -0500", "by mail-wr1-f72.google.com with SMTP id\n ffacd0b85a97d-4362456500eso5072545f8f.3\n for <qemu-devel@nongnu.org>; Wed, 18 Feb 2026 05:27:02 -0800 (PST)", "from localhost\n (p200300cfd737d029edef7b8da7441ac2.dip0.t-ipconnect.de.\n [2003:cf:d737:d029:edef:7b8d:a744:1ac2])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796ac8075sm40458516f8f.29.2026.02.18.05.26.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 05:26:59 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771421526;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=gLvuW77pQ5x9M3qdYvEThGlMMRQ1FN319y82FStW6pw=;\n b=IuK+oieRBPbAHZ/PdGTg3HOp3VIzRwcwpMpn+WcQLUcTALzHNTjbV4dy8VZCFIcBztjEma\n F7eQfOBJAzZs54OdCKL5768EXo2ZzhUnwTnLIMe2/2aoRkIUUmpr5vWrVNYBRZvNTWH5Qv\n 91BIoH3so7/vbaOAZ8ocUwmmM4sPUlo=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1771421222; x=1772026022; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gLvuW77pQ5x9M3qdYvEThGlMMRQ1FN319y82FStW6pw=;\n b=kZeWtETweoTM0EvS4KMJRSPB84n6SdJafqNl7hBgDfygtwwN1n3mi7JMA6InRe4Vz+\n HBcMHDDvt3WzXTrSXW/JAQw6H7cXhtHI8ZGxZjRtTtmhTw4Dzdyeli0MfQ5elmrw2hhu\n OBB0pB3Wem/rgIme0KxLFBslPs9XYCZ5yLizQoxAhO3P1ktR4hyevjG3b4+kAzh9e0Nb\n Ut/Snn+uH7f5FOwdFJQH2g/BV6ywZ1nDEPRohG6ArGYsdNB2dKbvmlWduNepP1yIaq3l\n Rb6eiwzdsgFW6BIbx+9iAhS+DheenxesBjFGv3co/pfhOyGa6Ht8OxrL3JEPaju0meb0\n VuMQ==" ], "X-MC-Unique": "mM2CUbCqPAqmQL-72PjDug-1", "X-Mimecast-MFC-AGG-ID": "mM2CUbCqPAqmQL-72PjDug_1771421222", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771421222; x=1772026022;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=gLvuW77pQ5x9M3qdYvEThGlMMRQ1FN319y82FStW6pw=;\n b=lerPWVB7Pu2Xx2RkzLw/2XwpW3c2R9KsVS9wzAQRhe2S9ukBfAAXMNdHV2j8qA0/aM\n avo2HS/+2wa+cnkJ/pYrAVKMpyuox3OUA3vOVEURv4fSR39cxYpwV6kzzIwhuDytoLiS\n rlvHVSRvWw8YFYgByFiC+SeDKbhbDkS7aOsB2MIe/RI2pqYp+4Z+nIm7lQQyx+hH/w+H\n tA0QXXG792IU/Ha9S/AGy3/QwZ5OKMcBc1UOHwEldTAkQsVsRHTb2spm12oW3r3UAOuz\n F5hkuym/r2EOsKDrNwHU8TEXFOhpvkMsVVhtU4oEdxe5Z+NIzk2UiJ0KpUxApTqJb8D/\n liKQ==", "X-Gm-Message-State": "AOJu0Yy+tXNgPXQ2RMpTKQDF2+bYxwwKBMk2W+nPubTea1EpNaL8gdOc\n 2mkWL/+jsFtxlhy8LSaB6LxrqWJ+IAwSC+M9n72/2DWblRbjuUNjd0zVEoOYCYyxjwkFo09+KwN\n g2viIQfX5076NYgSdSJNWUAF5AlQ2LEEEg0p1PsW4FnPIOSWTEy3kIxiT", "X-Gm-Gg": "AZuq6aIs2fyCJnRltZRVN1tqUgGf4BQYcB0lqr5qe0lDNbOi0feOxFDGDRpspq7ULru\n 4hbKyOgua33j7c7voYtdCvFtU4D2ZLDnoXVqVggyfEyyyCco/czvERE8G69afGU0yQMczR7zJLH\n NyJT8vQ//WppU9pwxEVvKeUHjbtU9MvZAGluFMy4U3lDigWg06I40DEZnu4xZNcWLlLE893RAXy\n e3iWWXRC7xbgjJ/IUURNnHXEUqp0x+FUOAcnPaGEqxGmjSrmR2go93jmYFp1H6SPJICcrMsPBqa\n DXU6nZ8jOyVMW/6K71GnDluQxULEI0aTccbTb/d+/+QsOIUaNNtCMzxHIbExe8v+eWy8YgKns8R\n rSbMH5Peen9kZkPsYMVmqbhoapWFZbtQb5gaUFhqHcwP3IMhX9L5dLFt95zGwNb+zFR0MYbZ7Le\n pIn7KZ", "X-Received": [ "by 2002:a05:6000:4387:b0:437:75c1:5777 with SMTP id\n ffacd0b85a97d-43958e00726mr3005882f8f.16.1771421221778;\n Wed, 18 Feb 2026 05:27:01 -0800 (PST)", "by 2002:a05:6000:4387:b0:437:75c1:5777 with SMTP id\n ffacd0b85a97d-43958e00726mr3005839f8f.16.1771421221290;\n Wed, 18 Feb 2026 05:27:01 -0800 (PST)" ], "From": "Hanna Czenczek <hreitz@redhat.com>", "To": "qemu-block@nongnu.org", "Cc": "qemu-devel@nongnu.org, Hanna Czenczek <hreitz@redhat.com>,\n Kevin Wolf <kwolf@redhat.com>, Brian Song <hibriansong@gmail.com>", "Subject": "[PATCH v4 07/24] fuse: Fix mount options", "Date": "Wed, 18 Feb 2026 14:26:16 +0100", "Message-ID": "<20260218132633.29748-8-hreitz@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260218132633.29748-1-hreitz@redhat.com>", "References": "<20260218132633.29748-1-hreitz@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=hreitz@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Since I actually took a look into how mounting with libfuse works[1], I\nnow know that the FUSE mount options are not exactly standard mount\nsystem call options. Specifically:\n- We should add \"nosuid,nodev,noatime\" because that is going to be\n translated into the respective MS_ mount flags; and those flags make\n sense for us.\n- We can set rw/ro to make the mount writable or not. It makes sense to\n set this flag to produce a better error message for read-only exports\n (EROFS instead of EACCES).\n This changes behavior as can be seen in iotest 308: It is no longer\n possible to modify metadata of read-only exports.\n\nIn addition, in the comment, we can note that the FUSE mount() system\ncall actually expects some more parameters that we can omit because\nfusermount3 (i.e. libfuse) will figure them out by itself:\n- fd: /dev/fuse fd\n- rootmode: Inode mode of the root node\n- user_id/group_id: Mounter's UID/GID\n\n[1] It invokes fusermount3, an SUID libfuse helper program, which parses\n and processes some mount options before actually invoking the\n mount() system call.\n\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\nSigned-off-by: Hanna Czenczek <hreitz@redhat.com>\n---\n block/export/fuse.c | 14 +++++++++++---\n tests/qemu-iotests/308 | 4 ++--\n tests/qemu-iotests/308.out | 3 ++-\n 3 files changed, 15 insertions(+), 6 deletions(-)", "diff": "diff --git a/block/export/fuse.c b/block/export/fuse.c\nindex 82560ca071..0422cf4b8a 100644\n--- a/block/export/fuse.c\n+++ b/block/export/fuse.c\n@@ -246,10 +246,18 @@ static int mount_fuse_export(FuseExport *exp, Error **errp)\n int ret;\n \n /*\n- * max_read needs to match what fuse_init() sets.\n- * max_write need not be supplied.\n+ * Note that these mount options differ from what we would pass to a direct\n+ * mount() call:\n+ * - nosuid, nodev, and noatime are not understood by the kernel; libfuse\n+ * uses those options to construct the mount flags (MS_*)\n+ * - The FUSE kernel driver requires additional options (fd, rootmode,\n+ * user_id, group_id); these will be set by libfuse.\n+ * Note that max_read is set here, while max_write is set via the FUSE INIT\n+ * operation.\n */\n- mount_opts = g_strdup_printf(\"max_read=%zu,default_permissions%s\",\n+ mount_opts = g_strdup_printf(\"%s,nosuid,nodev,noatime,max_read=%zu,\"\n+ \"default_permissions%s\",\n+ exp->writable ? \"rw\" : \"ro\",\n FUSE_MAX_BOUNCE_BYTES,\n exp->allow_other ? \",allow_other\" : \"\");\n \ndiff --git a/tests/qemu-iotests/308 b/tests/qemu-iotests/308\nindex 6eced3aefb..033d5cbe22 100755\n--- a/tests/qemu-iotests/308\n+++ b/tests/qemu-iotests/308\n@@ -178,7 +178,7 @@ stat -c 'Permissions pre-chmod: %a' \"$EXT_MP\"\n chmod u+w \"$EXT_MP\" 2>&1 | _filter_testdir | _filter_imgfmt\n stat -c 'Permissions post-+w: %a' \"$EXT_MP\"\n \n-# But that we can set, say, +x (if we are so inclined)\n+# Same for other flags, like, say +x\n chmod u+x \"$EXT_MP\" 2>&1 | _filter_testdir | _filter_imgfmt\n stat -c 'Permissions post-+x: %a' \"$EXT_MP\"\n \n@@ -236,7 +236,7 @@ output=$($QEMU_IO -f raw -c 'write -P 42 1M 64k' \"$TEST_IMG\" 2>&1 \\\n \n # Expected reference output: Opening the file fails because it has no\n # write permission\n-reference=\"Could not open 'TEST_DIR/t.IMGFMT': Permission denied\"\n+reference=\"Could not open 'TEST_DIR/t.IMGFMT': Read-only file system\"\n \n if echo \"$output\" | grep -q \"$reference\"; then\n echo \"Writing to read-only export failed: OK\"\ndiff --git a/tests/qemu-iotests/308.out b/tests/qemu-iotests/308.out\nindex e5e233691d..aa96faab6d 100644\n--- a/tests/qemu-iotests/308.out\n+++ b/tests/qemu-iotests/308.out\n@@ -53,7 +53,8 @@ Images are identical.\n Permissions pre-chmod: 400\n chmod: changing permissions of 'TEST_DIR/t.IMGFMT.fuse': Read-only file system\n Permissions post-+w: 400\n-Permissions post-+x: 500\n+chmod: changing permissions of 'TEST_DIR/t.IMGFMT.fuse': Read-only file system\n+Permissions post-+x: 400\n \n === Mount over existing file ===\n {'execute': 'block-export-add',\n", "prefixes": [ "v4", "07/24" ] }