Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2197409/?format=api
{ "id": 2197409, "url": "http://patchwork.ozlabs.org/api/patches/2197409/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260217214741.1928576-2-cel@kernel.org/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260217214741.1928576-2-cel@kernel.org>", "list_archive_url": null, "date": "2026-02-17T21:47:25", "name": "[v8,01/17] fs: Move file_kattr initialization to callers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8c46fdf9178c78ed8759cf51723c6a33a62d4eb1", "submitter": { "id": 86689, "url": "http://patchwork.ozlabs.org/api/people/86689/?format=api", "name": "Chuck Lever", "email": "cel@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260217214741.1928576-2-cel@kernel.org/mbox/", "series": [ { "id": 492483, "url": "http://patchwork.ozlabs.org/api/series/492483/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=492483", "date": "2026-02-17T21:47:25", "name": "Subject: Exposing case folding behavior", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/492483/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2197409/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197409/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=GLqp=AV=vger.kernel.org=linux-ext4+bounces-13712-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ACVk7zGO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=glqp=av=vger.kernel.org=linux-ext4+bounces-13712-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.232.135.74 arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ACVk7zGO;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13712-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ACVk7zGO\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFtYB4R3Lz1xvq\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 08:47:58 +1100 (AEDT)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fFtYB3vmzz4w2R\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 08:47:58 +1100 (AEDT)", "by gandalf.ozlabs.org (Postfix)\n\tid 4fFtYB3pRtz4wB9; Wed, 18 Feb 2026 08:47:58 +1100 (AEDT)", "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fFtY66VZtz4w2R\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 18 Feb 2026 08:47:54 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 7EF51300DCEF\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 17 Feb 2026 21:47:51 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AC45C2FD1A5;\n\tTue, 17 Feb 2026 21:47:49 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 69B5B2F5308;\n\tTue, 17 Feb 2026 21:47:49 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 9A4A2C19421;\n\tTue, 17 Feb 2026 21:47:46 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1771364878; cv=pass;\n\tb=NdiNg1rFJ7d/ZeaKa0e6sbejftzUIw+lWH3vIiRfVq4bWNu0u5/VS/8I7MhP3QK+fPudojkkEOlH88k0p/Z9/rvmUWmxgti4RYwbZG5KfqwIjbd+KOFYGfYvNoL0VmCD6NdAXfXf+QJhTo5Tq+8y2rphPyUeJBPw5Zaw8lAp3DLKMBzaTHuvSnckHVi8jhSgpZGCk1SnzqRTp0h/nZD9n35bVwNl8W+zywjEr0JOsS74gOv2In8WbRWfmXUfCwDkKaNEJAijUKuvHe0glRF7LzBhgwKJvr0wDiwwHksPzuuxp/zLNLhp3gZOBDs1UcWd/LhcU9HaeITfwjjyeSg5Qg==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771364869; cv=none;\n b=bo9cPQJWoRpECuVr7moUp7ojoY+NksRRmNRyOkDTUUixwuKf7lpZ/Sg1bcpp0jW6ZAO7uDj5JAY/Ii1ZqhROdpeeHxWkb6+W6IVyvLe105XV6eyk36tCysVEBG5vWju0Othspd8v/UgqZWcG4zmj1lxt28WZOV1FDni7KQHGVxo=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1771364878; c=relaxed/relaxed;\n\tbh=C9lFiR/76UieHkY9rgBrSmf8X5TAjyrgwYvNhnTikeg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=uhX5rK1eJI+ZtKDPi/SjLiifaFWSaCRZjzdmMe4hH/MToGfIBBSnwja8J/SdDrcHFQ0LS8s08FzAj5n45rPYWPijQZIqwv8ZZgv8cmYn6BMOofbTczzv3xm87eikzKAE/IVOdJrsrRzttAla6TKZe5Nfbkw9xuoLkQKcTAvQyH3Py3YYNCiKLiFakxux6AZ0i87VrWBBvIsRdLEXmUirFAEnudiT1y4LkAhgWQJBxUjykLLNCBdZ8qD4LM7SQVzoAa8N8Og6NVXrSRH8hHBAtDZW4sQeduCe7mW6amRb0q0F5l+YLTs6JtSi80NzFlBAwJf0KN5qY66mZbqmiCBWKQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771364869; c=relaxed/simple;\n\tbh=LctAiSd9BeDNjjjmUFC0gRSRPzBQHPUhz2MMJP2LiZ8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=jESqOKCltqV5eDiKXWrqQmBMgArQl6U0aa/6O1ybxldzcsBwJ7K1o9mPe3u2vTREYuD3ZEBwtqpkmIfU8hK2LS/IKOcHgGkbsYCC2HBq9MzRJOPKb/Oa5oS8WGYZA1MzbWiwoSksF34rcsjAz1Ag6lXxJy4mHoYU/9hp2iJFB6s=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ACVk7zGO; dkim-atps=neutral;\n spf=pass (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13712-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ACVk7zGO; arc=none smtp.client-ip=10.30.226.201" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1771364868;\n\tbh=LctAiSd9BeDNjjjmUFC0gRSRPzBQHPUhz2MMJP2LiZ8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ACVk7zGO8Dvjx8+P4M4/0bzCltWT475XNNKSF6yfMizGEZZgP//NxuF4Cb+eRrosZ\n\t pJA2vtZNd9TvSzcMuXg3ghwDJHyvFGUZcVescGoarZpyQV1r9mOSl79rlbHvBBfDyB\n\t Cc/J6x62SFD6ufA7WFHs9uQVScYU7wbIZ8C30vGIsYXgMv0eIz8E0YFfiUg84KQMnT\n\t 50RhjiOPfJ4fymbO8V5Apyr3qcrn4LhY3UPg9X5JFPj/i3Vr3X8FdYyF+wqpZOEWfP\n\t FiyONdpkAkAfZevczJhlYl7XzAj0VQEb4cg5BlXLcgnSlil2/91cHl74i5G5DdTzyP\n\t jvLmt1WWdpvIA==", "From": "Chuck Lever <cel@kernel.org>", "To": "Al Viro <viro@zeniv.linux.org.uk>,\n\tChristian Brauner <brauner@kernel.org>,\n\tJan Kara <jack@suse.cz>", "Cc": "linux-fsdevel@vger.kernel.org,\n\tlinux-ext4@vger.kernel.org,\n\tlinux-xfs@vger.kernel.org,\n\tlinux-cifs@vger.kernel.org,\n\tlinux-nfs@vger.kernel.org,\n\tlinux-api@vger.kernel.org,\n\tlinux-f2fs-devel@lists.sourceforge.net,\n\thirofumi@mail.parknet.co.jp,\n\tlinkinjeon@kernel.org,\n\tsj1557.seo@samsung.com,\n\tyuezhang.mo@sony.com,\n\talmaz.alexandrovich@paragon-software.com,\n\tslava@dubeyko.com,\n\tglaubitz@physik.fu-berlin.de,\n\tfrank.li@vivo.com,\n\ttytso@mit.edu,\n\tadilger.kernel@dilger.ca,\n\tcem@kernel.org,\n\tsfrench@samba.org,\n\tpc@manguebit.org,\n\tronniesahlberg@gmail.com,\n\tsprasad@microsoft.com,\n\ttrondmy@kernel.org,\n\tanna@kernel.org,\n\tjaegeuk@kernel.org,\n\tchao@kernel.org,\n\thansg@kernel.org,\n\tsenozhatsky@chromium.org,\n\tChuck Lever <chuck.lever@oracle.com>,\n\t\"Darrick J. Wong\" <djwong@kernel.org>", "Subject": "[PATCH v8 01/17] fs: Move file_kattr initialization to callers", "Date": "Tue, 17 Feb 2026 16:47:25 -0500", "Message-ID": "<20260217214741.1928576-2-cel@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260217214741.1928576-1-cel@kernel.org>", "References": "<20260217214741.1928576-1-cel@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "From: Chuck Lever <chuck.lever@oracle.com>\n\nfileattr_fill_xflags() and fileattr_fill_flags() zero the entire\nfile_kattr struct before populating select fields. This behavior\nprevents callers from setting flags in fa->fsx_xflags before\ncalling these helpers; the zeroing clears any pre-set values.\n\nAs Darrick Wong observed, when a function named \"fill_xflags\"\nmodifies more than just xflags, filesystems must understand\nimplementation details beyond the function's apparent scope. When\ninitialization occurs at entry points, helper functions need not\nduplicate that zeroing.\n\nMove struct file_kattr zero-initialization from the fill functions\nto their callers. Entry points such as ioctl_setflags(),\nioctl_fssetxattr(), and the file_getattr/file_setattr syscalls\nnow perform aggregate initialization directly. The fill functions\nretain their field-setting logic but no longer clear the struct.\n\nThis change enables subsequent patches where filesystem\n->fileattr_get() handlers can set case-sensitivity flags\n(FS_XFLAG_CASEFOLD, FS_XFLAG_CASENONPRESERVING) in fa->fsx_xflags\nbefore calling the fill functions.\n\nSuggested-by: Darrick J. Wong <djwong@kernel.org>\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\n---\n fs/file_attr.c | 14 +++++---------\n fs/xfs/xfs_ioctl.c | 2 +-\n 2 files changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/fs/file_attr.c b/fs/file_attr.c\nindex 6d2a298a786d..42aa511111a0 100644\n--- a/fs/file_attr.c\n+++ b/fs/file_attr.c\n@@ -15,12 +15,10 @@\n * @fa:\t\tfileattr pointer\n * @xflags:\tFS_XFLAG_* flags\n *\n- * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags). All\n- * other fields are zeroed.\n+ * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags).\n */\n void fileattr_fill_xflags(struct file_kattr *fa, u32 xflags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->fsx_valid = true;\n \tfa->fsx_xflags = xflags;\n \tif (fa->fsx_xflags & FS_XFLAG_IMMUTABLE)\n@@ -48,11 +46,9 @@ EXPORT_SYMBOL(fileattr_fill_xflags);\n * @flags:\tFS_*_FL flags\n *\n * Set ->flags, ->flags_valid and ->fsx_xflags (translated flags).\n- * All other fields are zeroed.\n */\n void fileattr_fill_flags(struct file_kattr *fa, u32 flags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->flags_valid = true;\n \tfa->flags = flags;\n \tif (fa->flags & FS_SYNC_FL)\n@@ -325,7 +321,7 @@ int ioctl_setflags(struct file *file, unsigned int __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tunsigned int flags;\n \tint err;\n \n@@ -357,7 +353,7 @@ int ioctl_fssetxattr(struct file *file, void __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint err;\n \n \terr = copy_fsxattr_from_user(&fa, argp);\n@@ -378,7 +374,7 @@ SYSCALL_DEFINE5(file_getattr, int, dfd, const char __user *, filename,\n \tstruct path filepath __free(path_put) = {};\n \tunsigned int lookup_flags = 0;\n \tstruct file_attr fattr;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint error;\n \n \tBUILD_BUG_ON(sizeof(struct file_attr) < FILE_ATTR_SIZE_VER0);\n@@ -431,7 +427,7 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __user *, filename,\n \tstruct path filepath __free(path_put) = {};\n \tunsigned int lookup_flags = 0;\n \tstruct file_attr fattr;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint error;\n \n \tBUILD_BUG_ON(sizeof(struct file_attr) < FILE_ATTR_SIZE_VER0);\ndiff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c\nindex 4eeda4d4e3ab..369555275140 100644\n--- a/fs/xfs/xfs_ioctl.c\n+++ b/fs/xfs/xfs_ioctl.c\n@@ -498,7 +498,7 @@ xfs_ioc_fsgetxattra(\n \txfs_inode_t\t\t*ip,\n \tvoid\t\t\t__user *arg)\n {\n-\tstruct file_kattr\tfa;\n+\tstruct file_kattr\tfa = {};\n \n \txfs_ilock(ip, XFS_ILOCK_SHARED);\n \txfs_fill_fsxattr(ip, XFS_ATTR_FORK, &fa);\n", "prefixes": [ "v8", "01/17" ] }