Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2197262/?format=api
{ "id": 2197262, "url": "http://patchwork.ozlabs.org/api/patches/2197262/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217152517.271422-4-alexander@mihalicyn.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260217152517.271422-4-alexander@mihalicyn.com>", "list_archive_url": null, "date": "2026-02-17T15:25:16", "name": "[3/4] migration: add VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_ALLOC", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cf9e53e253762ea2d26b6941765ef0a46d562e11", "submitter": { "id": 81630, "url": "http://patchwork.ozlabs.org/api/people/81630/?format=api", "name": "Alexander Mikhalitsyn", "email": "alexander@mihalicyn.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217152517.271422-4-alexander@mihalicyn.com/mbox/", "series": [ { "id": 492445, "url": "http://patchwork.ozlabs.org/api/series/492445/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492445", "date": "2026-02-17T15:25:13", "name": "hw/nvme: add basic live migration support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492445/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2197262/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197262/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n secure) header.d=mihalicyn.com header.i=@mihalicyn.com header.a=rsa-sha256\n header.s=mihalicyn header.b=Zgo9xmHC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFkgj4KH0z1xwD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 02:53:05 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsNMC-0002Ka-W7; Tue, 17 Feb 2026 10:51:25 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alexander@mihalicyn.com>)\n id 1vsMx5-0003bn-Um\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 10:25:27 -0500", "from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alexander@mihalicyn.com>)\n id 1vsMx3-0005fs-Bm\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 10:25:27 -0500", "by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso59766745e9.0\n for <qemu-devel@nongnu.org>; Tue, 17 Feb 2026 07:25:24 -0800 (PST)", "from alex-laptop.lan\n (p200300cf574bcf00ffb15ba913f79a3b.dip0.t-ipconnect.de.\n [2003:cf:574b:cf00:ffb1:5ba9:13f7:9a3b])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4835dd0e327sm519169015e9.14.2026.02.17.07.25.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Feb 2026 07:25:22 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=mihalicyn.com; s=mihalicyn; t=1771341923; x=1771946723; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IlHEsOq1lRlSlooXzt+pm7Wiy/G62pSLyPWrCWOS3Ss=;\n b=Zgo9xmHCbHyQf5Ac4xadpHtoeuCl8D4XBQR6Wad89JN6KW1p7pQLM6OKUp0S3vBt9K\n pFSJcvIb/OSahgC7/7yb0OJmXTCaF3syFr0BknxuIA7Z+gk5BZxsyjjuZV2TGH8ZlRIq\n qQjIBTur1Q9SikCC+E4c+n8FRGaXDMVT/pybM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771341923; x=1771946723;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=IlHEsOq1lRlSlooXzt+pm7Wiy/G62pSLyPWrCWOS3Ss=;\n b=UgzdNmSR9ZIXLciWC8MqPrcuyp6KIVKhqXZN43lEh1Ix/jqlLoavOC5l/ZY2MpbceZ\n hggxat0uPLs3yNjUhVk3coh4k+hnaNtgvEtgCSDO4+7a32IpdEV4b3ZUk/hwpRxOta+G\n Kv5aVRcZN7mqQabUz3/TxpRfoDCaeJQPzEfYXDpLT6uzklxmv/fdl1IHVsU6fNTeAUd0\n SjeMiUzQw6hNNtMrxHJTmDurMCPd53IJR8uDXPhGKrwyAJBEdfRQ2zBc1JsIUcWEk+JW\n ApTVTYAxPtCsp4VwQejKS9irLiZSm73Fb7NXBgPH7AFFR5lcFjJGaWLlE0uv9aRmyZCO\n 5m1w==", "X-Gm-Message-State": "AOJu0Yz24rqNRDr/2lH8GTqufLH0XEfeL81HRpKJr7xE01waTbNpKrsC\n vZOOrCBhEKwoJfFcDvwpsa244QTD0/IfDd8w8+LVwvXtJS+5m0MkGQsOlPUR4B7/8/OBaOK2j5v\n elduz", "X-Gm-Gg": "AZuq6aK5k1wip9vWHx4oooi4Ha+pAwpG4onyiKdOsJc82zqiDeWb9LCoZZPGV4EJI98\n B3ilPg8kKwKdok0vfa3ELnK4KxSJ7KSZXEzpu898g22XVXkkcj26edw0HK/gYn0bMI9vPhkykWL\n y4onTg9/D5HIa6XiKZ1pTbUBhgWD4xjZYB1zhERo5fTukrNcgxNv5HR3GaM3rm5omtCf/nt/TRz\n +cmbI2dJLt6vrW5wdnVikkcruazex14Wg6Wb5pzOGvAzjYtvDdHNVnuDsKUzj68GWWeOYQWPNs+\n u1EdRDffgOV8vC4GNJOaW6Oz1K0AziPIIYuCMvldwdbXnmw0HrB8Rnj5gPvmDt2vHTDGKDJ6/4y\n gagQdLRolkC50uXPF8N6Dm23bfDr9+Jlx+erZEMluTyBNw4oJ/sj9pKNtKGM6QeyGTQGRntvaK8\n n+MNl9aGgpjQzWMcW5RwTWbF1h4cDCLE0Nj3RzGQ0hAmgSJaeUnk17T3Kq+kwCDek3WrwZNrQYv\n +iWdIuQv16K4MeOBnkTMlw=", "X-Received": "by 2002:a05:600c:6b6b:b0:477:9a61:fd06 with SMTP id\n 5b1f17b1804b1-48378d62cb2mr146393345e9.8.1771341923213;\n Tue, 17 Feb 2026 07:25:23 -0800 (PST)", "From": "Alexander Mikhalitsyn <alexander@mihalicyn.com>", "To": "qemu-devel@nongnu.org", "Cc": "Jesper Devantier <foss@defmacro.it>, Peter Xu <peterx@redhat.com>,\n Klaus Jensen <its@irrelevant.dk>, Fabiano Rosas <farosas@suse.de>,\n qemu-block@nongnu.org, Keith Busch <kbusch@kernel.org>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>", "Subject": "[PATCH 3/4] migration: add VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_ALLOC", "Date": "Tue, 17 Feb 2026 16:25:16 +0100", "Message-ID": "<20260217152517.271422-4-alexander@mihalicyn.com>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260217152517.271422-1-alexander@mihalicyn.com>", "References": "<20260217152517.271422-1-alexander@mihalicyn.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::331;\n envelope-from=alexander@mihalicyn.com; helo=mail-wm1-x331.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-Mailman-Approved-At": "Tue, 17 Feb 2026 10:51:21 -0500", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n\nAdd VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_ALLOC, which\nhelps to save/restore a dynamic array of pointers to\nstructures.\n\nSigned-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n---\n include/migration/vmstate.h | 21 +++++++++\n migration/vmstate-types.c | 88 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 109 insertions(+)", "diff": "diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h\nindex 89f9f49d20a..bc6495a7f67 100644\n--- a/include/migration/vmstate.h\n+++ b/include/migration/vmstate.h\n@@ -265,6 +265,7 @@ extern const VMStateInfo vmstate_info_bitmap;\n extern const VMStateInfo vmstate_info_qtailq;\n extern const VMStateInfo vmstate_info_gtree;\n extern const VMStateInfo vmstate_info_qlist;\n+extern const VMStateInfo vmstate_info_ptrs_array_entry;\n \n #define type_check_2darray(t1,t2,n,m) ((t1(*)[n][m])0 - (t2*)0)\n /*\n@@ -537,6 +538,26 @@ extern const VMStateInfo vmstate_info_qlist;\n .offset = vmstate_offset_array(_s, _f, _type*, _n), \\\n }\n \n+/*\n+ * For migrating a dynamically allocated uint32-indexed array\n+ * of pointers to structures (with NULL entries and with auto memory allocation).\n+ *\n+ * _type: type of structure pointed to\n+ * _vmsd: VMSD for structure\n+ * start: size of structure pointed to (for auto memory allocation)\n+ */\n+#define VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_ALLOC(_field, _state, _field_num, _version, _vmsd, _type) { \\\n+ .name = (stringify(_field)), \\\n+ .version_id = (_version), \\\n+ .num_offset = vmstate_offset_value(_state, _field_num, uint32_t), \\\n+ .info = &vmstate_info_ptrs_array_entry, \\\n+ .vmsd = &(_vmsd), \\\n+ .start = sizeof(_type), \\\n+ .size = sizeof(_type *), \\\n+ .flags = VMS_VARRAY_UINT32|VMS_POINTER, \\\n+ .offset = vmstate_offset_pointer(_state, _field, _type *), \\\n+}\n+\n #define VMSTATE_VARRAY_OF_POINTER_UINT32(_field, _state, _field_num, _version, _info, _type) { \\\n .name = (stringify(_field)), \\\n .version_id = (_version), \\\ndiff --git a/migration/vmstate-types.c b/migration/vmstate-types.c\nindex 89cb2114721..3335377cd07 100644\n--- a/migration/vmstate-types.c\n+++ b/migration/vmstate-types.c\n@@ -942,3 +942,91 @@ const VMStateInfo vmstate_info_qlist = {\n .get = get_qlist,\n .put = put_qlist,\n };\n+\n+static int put_ptrs_array_entry(QEMUFile *f, void *ppv, size_t unused_size,\n+ const VMStateField *field, JSONWriter *vmdesc)\n+{\n+ const VMStateDescription *vmsd = field->vmsd;\n+ int ret;\n+ Error *local_err = NULL;\n+ void *pv;\n+\n+ /*\n+ * (ppv) is an address of an i-th element of a dynamic array.\n+ *\n+ * (ppv) can not be NULL unless we have some regression/bug in\n+ * vmstate_save_state_v(), because it is result of pointer arithemic like:\n+ * first_elem + size * i.\n+ */\n+ if (ppv == NULL) {\n+ error_report(\"vmstate: put_ptrs_array_entry must be called with ppv != NULL\");\n+ return -EINVAL;\n+ }\n+\n+ /* get a pointer to a structure */\n+ pv = *(void **)ppv;\n+\n+ if (pv == NULL) {\n+ /* write a mark telling that there was a NULL pointer */\n+ qemu_put_byte(f, false);\n+ return 0;\n+ }\n+\n+ /* if pointer is not NULL, dump the structure contents with help of vmsd */\n+ qemu_put_byte(f, true);\n+ ret = vmstate_save_state(f, vmsd, pv, vmdesc, &local_err);\n+ if (ret) {\n+ error_report_err(local_err);\n+ return ret;\n+ }\n+\n+ return 0;\n+}\n+\n+static int get_ptrs_array_entry(QEMUFile *f, void *ppv, size_t unused_size,\n+ const VMStateField *field)\n+{\n+ int ret = 0;\n+ Error *local_err = NULL;\n+ const VMStateDescription *vmsd = field->vmsd;\n+ /* size of structure pointed to by elements of array */\n+ size_t size = field->start;\n+\n+ if (ppv == NULL) {\n+ error_report(\"vmstate: get_ptrs_array_entry must be called with ppv != NULL\");\n+ return -EINVAL;\n+ }\n+\n+ /*\n+ * We start from a clean array, all elements must be NULL, unless\n+ * something we haven't prepared for has changed in vmstate_save_state_v().\n+ * Let's check for this just in case.\n+ */\n+ if (*(void **)ppv != NULL) {\n+ error_report(\"vmstate: get_ptrs_array_entry must be called with *ppv == NULL\");\n+ return -EINVAL;\n+ }\n+\n+ if (qemu_get_byte(f)) {\n+ void *pv;\n+\n+ /* allocate memory for structure */\n+ pv = g_malloc0(size);\n+ ret = vmstate_load_state(f, vmsd, pv, vmsd->version_id, &local_err);\n+ if (ret) {\n+ error_report_err(local_err);\n+ g_free(pv);\n+ return ret;\n+ }\n+\n+ *(void **)ppv = pv;\n+ }\n+\n+ return ret;\n+}\n+\n+const VMStateInfo vmstate_info_ptrs_array_entry = {\n+ .name = \"ptrs_array_entry\",\n+ .get = get_ptrs_array_entry,\n+ .put = put_ptrs_array_entry,\n+};\n", "prefixes": [ "3/4" ] }