Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2197261/?format=api
{ "id": 2197261, "url": "http://patchwork.ozlabs.org/api/patches/2197261/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217152517.271422-2-alexander@mihalicyn.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260217152517.271422-2-alexander@mihalicyn.com>", "list_archive_url": null, "date": "2026-02-17T15:25:14", "name": "[1/4] hw/nvme: add migration blockers for non-supported cases", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "65ba4645b1fc8e3cf5f4177b2ce195e18e706dd1", "submitter": { "id": 81630, "url": "http://patchwork.ozlabs.org/api/people/81630/?format=api", "name": "Alexander Mikhalitsyn", "email": "alexander@mihalicyn.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217152517.271422-2-alexander@mihalicyn.com/mbox/", "series": [ { "id": 492445, "url": "http://patchwork.ozlabs.org/api/series/492445/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492445", "date": "2026-02-17T15:25:13", "name": "hw/nvme: add basic live migration support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492445/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2197261/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197261/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n secure) header.d=mihalicyn.com header.i=@mihalicyn.com header.a=rsa-sha256\n header.s=mihalicyn header.b=b2SHYh+J;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFkgh4qkpz1xwD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 02:53:04 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsNMC-0002KF-DZ; Tue, 17 Feb 2026 10:51:24 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alexander@mihalicyn.com>)\n id 1vsMx4-0003b7-Gq\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 10:25:26 -0500", "from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alexander@mihalicyn.com>)\n id 1vsMx1-0005fX-IM\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 10:25:26 -0500", "by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-48371119eacso40880785e9.2\n for <qemu-devel@nongnu.org>; Tue, 17 Feb 2026 07:25:22 -0800 (PST)", "from alex-laptop.lan\n (p200300cf574bcf00ffb15ba913f79a3b.dip0.t-ipconnect.de.\n [2003:cf:574b:cf00:ffb1:5ba9:13f7:9a3b])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4835dd0e327sm519169015e9.14.2026.02.17.07.25.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Feb 2026 07:25:20 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=mihalicyn.com; s=mihalicyn; t=1771341922; x=1771946722; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZTBRdCe4EKhZ7QFgzj0snqvNaQKXZdaqV+19ND1Hpu0=;\n b=b2SHYh+JH9qpU4D4C2w+d2nSB20eD2KgQ7bFdL6FpitMi3/pDx1pyUu6YWHFM9Icyr\n Fr2/KGZSboUiwd1U50gVOmc7ognnbshBa04ER8phkPQmay38AqpD+Vl3wTWfLAbXiFMt\n gkHGVS4PswJ8nHkZ+XwMiQgxmP3gyZA3aTYh4=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771341922; x=1771946722;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ZTBRdCe4EKhZ7QFgzj0snqvNaQKXZdaqV+19ND1Hpu0=;\n b=C5NOkb+OWywmSYT3waRTFg1ozLdrGj9+7SmwD8ValQoQDj8T1PGQOItCXWDULHKM5a\n lPSxwMQ06JT4CMmuAy3UhkaMypijFw/A9tNzecGyP3gaYkP1ok2oyzJzHB8FkQgO11iw\n vpLd5s91CmiJjnvYcuXwmTMLTqfnRoXTiYhrcVVzQ/F68CUs7I6PLv8qIW1/icTdNjiT\n g8To3bXZoguqfgo+Zyz2i2LyaBvm0AiJt7g1G5ZKVco7cH+vk7GIlX5BDAkqXM0m3d//\n 4rKFKLhdG3PXOda9OfGfPy8tCxfRgsYXjgK4cRrbvPiFdpgNNUhk7yI3CDJ+jG+nteDU\n XsMA==", "X-Gm-Message-State": "AOJu0YyLQp5mQrwaytKUpm7RlbAQHZKTilP5d++gMQ8GPKM5yoIVR1st\n Jieg9RHTI8Gay8GUuWL7KnCSeYce4O6BSQtxnWYae2NJSZCrA15pC7B18tDmqIya1r11CqNtu1t\n WBaRn", "X-Gm-Gg": "AZuq6aIHQLZj8fbvI9XM59ekrd7OJsFgKa9GJ+YTtXQrr8farMxt5qXUPfR/KRwFnX3\n TgR6g4P7P8znmah/Xvju0HrfMDFvYImlD6m1GKxjP1IwvFoZCg2Ga8WNrJ+OIKoXnpKXbluTlcU\n 3aFbuxh6tJkFNEfgoJuC7e9D74i/xdYQjDABerDjZrCTb/5Chh+dLX5MmjeDU5283xg57dkw5xX\n Qwfk4qOAmML24TZPB9RCkNTE4ZdeT9IQsr5NStvQ11pnzBHbZwz7iflDM08JCJB69N46YLjPu1B\n kqJCW4FgqXTKsNb6KrDCwGSyRcEBHli56aSaG9YF8lVC+ib1dtF0jmjYY9bXewJRUy0OrTntwxm\n 84JOjV241kFRI+rj5a57VFpNkSlWzXJ1yk2EiIRy6guwFLng9F4YCHyi3T1D73j40lhHFkqJfD+\n DOWtkLV0Fk2C95R2N952+MAqI5ltuKFGai8R2RrENbmEOa3DpiBRjj+S9bxecJGwegdlK1hI5Vw\n r7uvQT5gY7/YaXyX9QaB8UxDBIntfinJw==", "X-Received": "by 2002:a05:600c:1909:b0:480:4a90:1af2 with SMTP id\n 5b1f17b1804b1-48373a78e7amr247299305e9.35.1771341921128;\n Tue, 17 Feb 2026 07:25:21 -0800 (PST)", "From": "Alexander Mikhalitsyn <alexander@mihalicyn.com>", "To": "qemu-devel@nongnu.org", "Cc": "Jesper Devantier <foss@defmacro.it>, Peter Xu <peterx@redhat.com>,\n Klaus Jensen <its@irrelevant.dk>, Fabiano Rosas <farosas@suse.de>,\n qemu-block@nongnu.org, Keith Busch <kbusch@kernel.org>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>", "Subject": "[PATCH 1/4] hw/nvme: add migration blockers for non-supported cases", "Date": "Tue, 17 Feb 2026 16:25:14 +0100", "Message-ID": "<20260217152517.271422-2-alexander@mihalicyn.com>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260217152517.271422-1-alexander@mihalicyn.com>", "References": "<20260217152517.271422-1-alexander@mihalicyn.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=alexander@mihalicyn.com; helo=mail-wm1-x32a.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-Mailman-Approved-At": "Tue, 17 Feb 2026 10:51:21 -0500", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n\nLet's block migration for cases we don't support:\n- SR-IOV\n- CMB\n- PMR\n- SPDM\n\nNo functional changes here, because NVMe migration is\nnot supported at all as of this commit.\n\nSigned-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n---\n hw/nvme/ctrl.c | 35 +++++++++++++++++++++++++++++++++++\n hw/nvme/nvme.h | 3 +++\n 2 files changed, 38 insertions(+)", "diff": "diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c\nindex cc4593cd427..4694bdb4d02 100644\n--- a/hw/nvme/ctrl.c\n+++ b/hw/nvme/ctrl.c\n@@ -207,6 +207,7 @@\n #include \"hw/pci/msix.h\"\n #include \"hw/pci/pcie_sriov.h\"\n #include \"system/spdm-socket.h\"\n+#include \"migration/blocker.h\"\n #include \"migration/vmstate.h\"\n \n #include \"nvme.h\"\n@@ -8962,6 +8963,14 @@ static bool nvme_init_pci(NvmeCtrl *n, PCIDevice *pci_dev, Error **errp)\n pcie_endpoint_cap_init(pci_dev, 0x80);\n pcie_cap_flr_init(pci_dev);\n if (n->params.sriov_max_vfs) {\n+ if (n->migration_blocker == NULL) {\n+ error_setg(&n->migration_blocker,\n+ \"Migration is disabled when SR-IOV capability is set\");\n+ if (migrate_add_blocker(&n->migration_blocker, errp) < 0) {\n+ return false;\n+ }\n+ }\n+\n pcie_ari_init(pci_dev, 0x100);\n }\n \n@@ -9025,6 +9034,14 @@ static bool nvme_init_pci(NvmeCtrl *n, PCIDevice *pci_dev, Error **errp)\n if (pci_dev->spdm_port) {\n uint16_t doe_offset = PCI_CONFIG_SPACE_SIZE;\n \n+ if (n->migration_blocker == NULL) {\n+ error_setg(&n->migration_blocker,\n+ \"Migration is disabled when SPDM responder is used\");\n+ if (migrate_add_blocker(&n->migration_blocker, errp) < 0) {\n+ return false;\n+ }\n+ }\n+\n switch (pci_dev->spdm_trans) {\n case SPDM_SOCKET_TRANSPORT_TYPE_PCI_DOE:\n if (n->params.sriov_max_vfs) {\n@@ -9053,10 +9070,26 @@ static bool nvme_init_pci(NvmeCtrl *n, PCIDevice *pci_dev, Error **errp)\n }\n \n if (n->params.cmb_size_mb) {\n+ if (n->migration_blocker == NULL) {\n+ error_setg(&n->migration_blocker,\n+ \"Migration is disabled when CMB feature is used\");\n+ if (migrate_add_blocker(&n->migration_blocker, errp) < 0) {\n+ return false;\n+ }\n+ }\n+\n nvme_init_cmb(n, pci_dev);\n }\n \n if (n->pmr.dev) {\n+ if (n->migration_blocker == NULL) {\n+ error_setg(&n->migration_blocker,\n+ \"Migration is disabled when PMR feature is used\");\n+ if (migrate_add_blocker(&n->migration_blocker, errp) < 0) {\n+ return false;\n+ }\n+ }\n+\n if (!nvme_init_pmr(n, pci_dev, errp)) {\n return false;\n }\n@@ -9365,6 +9398,8 @@ static void nvme_exit(PCIDevice *pci_dev)\n }\n \n memory_region_del_subregion(&n->bar0, &n->iomem);\n+\n+ migrate_del_blocker(&n->migration_blocker);\n }\n \n static const Property nvme_props[] = {\ndiff --git a/hw/nvme/nvme.h b/hw/nvme/nvme.h\nindex d66f7dc82d5..457b6637249 100644\n--- a/hw/nvme/nvme.h\n+++ b/hw/nvme/nvme.h\n@@ -666,6 +666,9 @@ typedef struct NvmeCtrl {\n \n /* Socket mapping to SPDM over NVMe Security In/Out commands */\n int spdm_socket;\n+\n+ /* Migration-related stuff */\n+ Error *migration_blocker;\n } NvmeCtrl;\n \n typedef enum NvmeResetType {\n", "prefixes": [ "1/4" ] }