Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2197251/?format=api
{ "id": 2197251, "url": "http://patchwork.ozlabs.org/api/patches/2197251/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217153010.408739-3-ankita@nvidia.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260217153010.408739-3-ankita@nvidia.com>", "list_archive_url": null, "date": "2026-02-17T15:30:09", "name": "[v4,2/3] vfio: Add Error ** parameter to vfio_region_setup()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "19ba7e87d2180c15101c6672f96e1c157afa4e8c", "submitter": { "id": 86155, "url": "http://patchwork.ozlabs.org/api/people/86155/?format=api", "name": "Ankit Agrawal", "email": "ankita@nvidia.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217153010.408739-3-ankita@nvidia.com/mbox/", "series": [ { "id": 492441, "url": "http://patchwork.ozlabs.org/api/series/492441/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492441", "date": "2026-02-17T15:30:09", "name": "hw/vfio: Enable hugepfnmap for non-power-of-2 device memory regions", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/492441/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2197251/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197251/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=hdKOVpcL;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFkBp15x3z1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 02:31:30 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsN2l-0005o0-6F; Tue, 17 Feb 2026 10:31:19 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ankita@nvidia.com>) id 1vsN2X-0005hP-TX\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 10:31:10 -0500", "from mail-centralusazlp170110009.outbound.protection.outlook.com\n ([2a01:111:f403:c111::9] helo=DM5PR21CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ankita@nvidia.com>) id 1vsN2K-0006x2-Mh\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 10:30:55 -0500", "from CH0PR03CA0367.namprd03.prod.outlook.com (2603:10b6:610:119::24)\n by PH7PR12MB7353.namprd12.prod.outlook.com (2603:10b6:510:20c::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.13; Tue, 17 Feb\n 2026 15:30:36 +0000", "from CH1PEPF0000A348.namprd04.prod.outlook.com\n (2603:10b6:610:119:cafe::b7) by CH0PR03CA0367.outlook.office365.com\n (2603:10b6:610:119::24) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.13 via Frontend Transport; Tue,\n 17 Feb 2026 15:30:36 +0000", "from mail.nvidia.com (216.228.117.161) by\n CH1PEPF0000A348.mail.protection.outlook.com (10.167.244.4) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9632.12 via Frontend Transport; Tue, 17 Feb 2026 15:30:36 +0000", "from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 17 Feb\n 2026 07:30:13 -0800", "from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com\n (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 17 Feb\n 2026 07:30:13 -0800", "from localhost.nvidia.com (10.127.8.12) by mail.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Tue, 17 Feb 2026 07:30:12 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=h0jJ5N/nQHo2XrzpScs+2BzfQeL2pe2ISacImIeCARevzQOg+abSD9WlKI5FzF6SbFGEUxBObEt4c2+QuvS4UoqC46i8LBiz4MfkjeeXiJtw02tCk3TljUVOpoLII99MjdXDbTIsBfJxBlrVXr0MJlh8hzvYa3NcxDphSHHpSV37BvJQb3/+eVaxQEpCEebFfGEnN8ppkNhzZ5YZPli5KspPE7QkR9xXxTn94D7H6v91a0jIDyhw/V+MK7ycVcLoyfOeZvRAf63tndwsOxjLoCr4i7nFmVdIkp15EbnWHh4A2tUXqLl9GxMSMfa60vVj2Mv58YrDUftU+VI0YmR8Ug==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=MDqQBjjl33lfr86RHxlEYIwhIrv/kGfk84dVRYtf68M=;\n b=J4Fd1XI8tq2pQPbFntUUyYSqO+XpROmT0OASweF5liUgRg2WyrofpRsZxf5pEMvLD1Q5V5bdvbNjd7hAkj9Vw9g6FnMKi5VoWawN3xBDXJWZnpuxTGzeSszAUAe4wjLSdFqzQ3+Px5SsNC3tqNe6OJb6rLFp/CvUgam9/bu7MqDKh63FgefdBF7zo8tNdIYK6he/vK8e8fDTkNeHNh37fQMdghenFoLrotR3C9PQshGmq6BCGM7nBM8oWCl2gghYyfB5jx+N9svMKeSfzcafBRPfZ1pR/88GU4ysDWFw+MPDE6WjXDwpeblvq0XHR4qsPI0QgP0g+NdpoVfbPBeNqg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=shazbot.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=MDqQBjjl33lfr86RHxlEYIwhIrv/kGfk84dVRYtf68M=;\n b=hdKOVpcL3FN34815hJa/FcKCl//vui6w4YTwKBwoo5BhWQic5lTSrw06FaZnbQSzm1NxSFyGs+se2cgaz1FeEvm3sfIN6GTPOLlMmC6SPdqzWsi/1MpfEd778JC7xwXqfO8mGGeVjuvhM9m1kYRPsBy6POJCBMdyEOX3NrJ4EtPWIm2EOwW/X+2VMMTCzpM9CDZszaWYPIfJze4X8pivvhWyXAGbdEsLwpOFWG3YWSE4XVBA9hi6xvCFnnEJVtSyzh8bm12yUJNeuQQdzLYpTGc5VIGcbA5DX85RBxkFct5TRiL4oOgN5AcXqoK5k/qDqpCMuuyJnUb9VvbzbrEdHQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": [ "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "permerror client-ip=2a01:111:f403:c111::9;\n envelope-from=ankita@nvidia.com;\n helo=DM5PR21CU001.outbound.protection.outlook.com" ], "From": "<ankita@nvidia.com>", "To": "<ankita@nvidia.com>, <vsethi@nvidia.com>, <jgg@nvidia.com>,\n <skolothumtho@nvidia.com>, <alex@shazbot.org>, <clg@redhat.com>", "CC": "<aniketa@nvidia.com>, <cjia@nvidia.com>, <kwankhede@nvidia.com>,\n <targupta@nvidia.com>, <zhiw@nvidia.com>, <mochs@nvidia.com>,\n <kjaju@nvidia.com>, <qemu-devel@nongnu.org>", "Subject": "[PATCH v4 2/3] vfio: Add Error ** parameter to vfio_region_setup()", "Date": "Tue, 17 Feb 2026 15:30:09 +0000", "Message-ID": "<20260217153010.408739-3-ankita@nvidia.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260217153010.408739-1-ankita@nvidia.com>", "References": "<20260217153010.408739-1-ankita@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH1PEPF0000A348:EE_|PH7PR12MB7353:EE_", "X-MS-Office365-Filtering-Correlation-Id": "901112f4-e204-41cf-bdcc-08de6e397f58", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|82310400026|376014|36860700013|1800799024;", "X-Microsoft-Antispam-Message-Info": "\n q082Cmjj9Q012QlUZctg6Zoa2uamCP46QAmmj42cFCZ0jg9f4N0JUSgcAyyEzBw4wz2BHFHF+378HpyklTr1FqbRLB66b/sjib2+K4rZ5t3tVxDhz+ou4Fm4eJWSmpsNjiUUjc/STbj/XKKZjvmtR+jhxhh7OvKI0Sp8C08peosF9iA9PSsSFSkcAezjZu6iitZzMYaT30V4LxNj6TzNm/mPLKXsTbkWbz5Yz5hIzPIihk2FgvMPG/arV+JINGreNHiM+mht6z/76/rxSMomdfq07Z4dIlmw40ldeJKxyuFb9ybS4ZuidHvmANckbWfshD1Wg6R0+lsqeN1wLg6s78jJabNrpDP/GchOCY44zCRAGt3TYj4DL5mrB3mhaAz7Aj+d4IX+M31yoeQEpLLGdDEkmmd+N+24Uw1RAOVRlVXxeCIIWvtSXtrFv4lqJRIkI+1juH8CnF0T8/uRCegVwnDPm6JwKqeXNsAEmf8C8R9LwtNSkPd3fxC5eVr2ufksFE9aIxbwxLDEcWdD0FyOLFULmS6prW8g/w1P7fcW+0L7czENzgyQqdfIlxLeCaVsEsC6tg4rZOCF5vrsM2WIUjiATZJ7UFoSneCZHczk5G2kiZwSNF8fTh+vEWK6JDL/coEQB/WuspWeRzc2ZnWoOfP9m0i/crYsjIkiDetW7ylR9DVBI8mnj3R1+GvhPkiy9qEgrsIApnDXialFW2uZKAFneYKpR92he0VLgixUyfUZCmF2OrKh/rNHImQka1y4ha2FwLeAH86MZ0jWO7cTHD7uRvVpBVdYRaMdZUFOgCJE44YuQ5A9t5zgaoiUe0XQicJEvJbhx/rYiOSDktWMOEkAd32GN0lD87dwMHxXQdgrDowmbzvW5AzappfE3dmHDfmVQGKVI2o6Wt235zx7SzT6NklYX10xzYCJJaYaVVk8oeOGGylD5kdk6I8VMFEHOOvan5AQTVmYZzb23jXm25QvEnJf+WLcxrXbVu6aWxLNGXHBDisaEtUXCXTVe2SXFFMiIq2sZzSi2SlsOOARIUCddiqX0fOrRl8uK+0MS1+NcaZVmMaVkmamcy225pvGuPcjYCfTWBkR4KqpVPXCK/TyQhrBieTdo34evHDvbCHhlzRvquAufwwDhTd1BrkTo0D0t5piMb5tBPWjvilaTeDem5OrDgz2Jg37xLI7v0Um6z5UTz5ceMzK3RiGQ8JRhEoHgY4917Fefc0tJ3jizzPzxuBMS7vHTRePdBiA+w5rQw3buUrYkGMAo9eWv7teYHV8GtNYDVYz6wXTNuGvRAUFjTkRdH84KhWEAg/R6tdfMoEWyCaDIGopIEABjHHTyiw8+RoytswzAO9pQP8pll/XP+2zlcMueU9S/LKgVZ+6c+FX2h4IFkaaolO/GBkxr8B1lUImhuY4MP+pnflgvsiaemfjldqnKC7Wm9CEu1d/zCbT+aZJRGJxkq9KGUutIlj/ENAGe1E38BZqKsBpTx2eI5C3sGI+d+pMKleIx0NDszgbKgtbm7R/pv6uZSDdS0F+5I3d9vOLdrzAqvWZCksF5eWsgPU/wCHL23x9BpFeJm7sbRkM8yLTfhbd2fYOfGK7K/EDIjbLllBq0SQp//g1SUB33IMMco8RP3NN840AWHL/eOEvltv1Z+AOYoSW3nXcXuLW1AB6N66g6Slxfw==", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT;\n SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n u93vHZOlSjpI6cJSMcuFNcL+2vaK14akW4dysiFWcs++2xmohKAsTlQhHrP1yE3N4psjxlN4vEeU32SQBYZSmKcsWYBXVYr8OehlPAaj+Nhqjolxm0heqt4dldnB9tkvwMUHNCZnDl5SEDBPIAIhLq91eNl+u0vkxDL52DzOtPGzoPcOYlH8wWBhi2mZRpNXj0/AnJVrGOj198vXpx72Kll3qVSqcUzp7bZYhTdMIVn9A0bTL4erGLAnC/xwlgrzrcHhpnuRtIihrgjS3EL3ur0vbYnRPfO7Pf7mly24MsiMbV69SOraKJGHypQhZYH8vLpyQp+QJff6rJ7oPn67iMHLLGQJ3wtOHo7afKKUr1DEzuMhCafegdtNbwvFcvet2HGPSitIfZWyhttaeCq5z13wuQbY8fSNma08g+MvFYG5Wkrgh0R66wKKfNV+Bw2I", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Feb 2026 15:30:36.0282 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 901112f4-e204-41cf-bdcc-08de6e397f58", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CH1PEPF0000A348.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR12MB7353", "X-Spam_score_int": "-10", "X-Spam_score": "-1.1", "X-Spam_bar": "-", "X-Spam_report": "(-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FORGED_SPF_HELO=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_NONE=0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Ankit Agrawal <ankita@nvidia.com>\n\nAdd an Error **errp parameter to vfio_region_setup() and\nvfio_setup_region_sparse_mmaps to allow proper error handling\ninstead of just returning error codes.\n\nThe function sets errors via error_setg() when failure occur.\n\nSuggested-by: Cedric Le Goater <clg@redhat.com>\nSigned-off-by: Ankit Agrawal <ankita@nvidia.com>\n---\n hw/vfio/display.c | 6 +++---\n hw/vfio/pci.c | 3 +--\n hw/vfio/region.c | 20 +++++++++++---------\n hw/vfio/vfio-region.h | 2 +-\n 4 files changed, 16 insertions(+), 15 deletions(-)", "diff": "diff --git a/hw/vfio/display.c b/hw/vfio/display.c\nindex faacd9019a..5a42a6f7a2 100644\n--- a/hw/vfio/display.c\n+++ b/hw/vfio/display.c\n@@ -446,13 +446,13 @@ static void vfio_display_region_update(void *opaque)\n \n if (!dpy->region.buffer.size) {\n /* mmap region */\n+ Error *error = NULL;\n ret = vfio_region_setup(OBJECT(vdev), &vdev->vbasedev,\n &dpy->region.buffer,\n plane.region_index,\n- \"display\");\n+ \"display\", &error);\n if (ret != 0) {\n- error_report(\"%s: vfio_region_setup(%d): %s\",\n- __func__, plane.region_index, strerror(-ret));\n+ error_report_err(error);\n goto err;\n }\n ret = vfio_region_mmap(&dpy->region.buffer);\ndiff --git a/hw/vfio/pci.c b/hw/vfio/pci.c\nindex 36d8fbe872..c89f3fbea3 100644\n--- a/hw/vfio/pci.c\n+++ b/hw/vfio/pci.c\n@@ -3056,11 +3056,10 @@ bool vfio_pci_populate_device(VFIOPCIDevice *vdev, Error **errp)\n char *name = g_strdup_printf(\"%s BAR %d\", vbasedev->name, i);\n \n ret = vfio_region_setup(OBJECT(vdev), vbasedev,\n- &vdev->bars[i].region, i, name);\n+ &vdev->bars[i].region, i, name, errp);\n g_free(name);\n \n if (ret) {\n- error_setg_errno(errp, -ret, \"failed to get region %d info\", i);\n return false;\n }\n \ndiff --git a/hw/vfio/region.c b/hw/vfio/region.c\nindex 8fbc98918f..d464eadf9c 100644\n--- a/hw/vfio/region.c\n+++ b/hw/vfio/region.c\n@@ -163,7 +163,8 @@ static int vfio_mmap_compare_offset(const void *a, const void *b)\n }\n \n static int vfio_setup_region_sparse_mmaps(VFIORegion *region,\n- struct vfio_region_info *info)\n+ struct vfio_region_info *info,\n+ Error **errp)\n {\n struct vfio_info_cap_header *hdr;\n struct vfio_region_info_cap_sparse_mmap *sparse;\n@@ -210,12 +211,12 @@ static int vfio_setup_region_sparse_mmaps(VFIORegion *region,\n off_t prev_end = region->mmaps[i - 1].offset +\n region->mmaps[i - 1].size;\n if (prev_end > region->mmaps[i].offset) {\n- error_report(\"%s: overlapping sparse mmap regions detected \"\n- \"in region %d: [0x%\"PRIx64\"-0x%\"PRIx64\"] overlaps \"\n- \"with [0x%\"PRIx64\"-0x%\"PRIx64\"]\",\n- __func__, region->nr, region->mmaps[i - 1].offset,\n- prev_end - 1, region->mmaps[i].offset,\n- region->mmaps[i].offset + region->mmaps[i].size - 1);\n+ error_setg(errp, \"%s: overlapping sparse mmap regions detected \"\n+ \"in region %d: [0x%\"PRIx64\"-0x%\"PRIx64\"] overlaps \"\n+ \"with [0x%\"PRIx64\"-0x%\"PRIx64\"]\",\n+ __func__, region->nr, region->mmaps[i - 1].offset,\n+ prev_end - 1, region->mmaps[i].offset,\n+ region->mmaps[i].offset + region->mmaps[i].size - 1);\n g_free(region->mmaps);\n region->mmaps = NULL;\n region->nr_mmaps = 0;\n@@ -228,13 +229,14 @@ static int vfio_setup_region_sparse_mmaps(VFIORegion *region,\n }\n \n int vfio_region_setup(Object *obj, VFIODevice *vbasedev, VFIORegion *region,\n- int index, const char *name)\n+ int index, const char *name, Error **errp)\n {\n struct vfio_region_info *info = NULL;\n int ret;\n \n ret = vfio_device_get_region_info(vbasedev, index, &info);\n if (ret) {\n+ error_setg_errno(errp, -ret, \"failed to get region %d info\", index);\n return ret;\n }\n \n@@ -253,7 +255,7 @@ int vfio_region_setup(Object *obj, VFIODevice *vbasedev, VFIORegion *region,\n if (!vbasedev->no_mmap &&\n region->flags & VFIO_REGION_INFO_FLAG_MMAP) {\n \n- ret = vfio_setup_region_sparse_mmaps(region, info);\n+ ret = vfio_setup_region_sparse_mmaps(region, info, errp);\n \n if (ret == -ENODEV) {\n region->nr_mmaps = 1;\ndiff --git a/hw/vfio/vfio-region.h b/hw/vfio/vfio-region.h\nindex ede6e0c8f9..9b21d4ee5b 100644\n--- a/hw/vfio/vfio-region.h\n+++ b/hw/vfio/vfio-region.h\n@@ -38,7 +38,7 @@ void vfio_region_write(void *opaque, hwaddr addr,\n uint64_t vfio_region_read(void *opaque,\n hwaddr addr, unsigned size);\n int vfio_region_setup(Object *obj, VFIODevice *vbasedev, VFIORegion *region,\n- int index, const char *name);\n+ int index, const char *name, Error **errp);\n int vfio_region_mmap(VFIORegion *region);\n void vfio_region_mmaps_set_enabled(VFIORegion *region, bool enabled);\n void vfio_region_unmap(VFIORegion *region);\n", "prefixes": [ "v4", "2/3" ] }