Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2197174/?format=api
{ "id": 2197174, "url": "http://patchwork.ozlabs.org/api/patches/2197174/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217095106.598486-5-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260217095106.598486-5-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2026-02-17T09:51:03", "name": "[v2,4/7] page-vary: Build set_preferred_target_page_bits as common code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c344826b57e2136916c85f6467d821ab24636a5e", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217095106.598486-5-richard.henderson@linaro.org/mbox/", "series": [ { "id": 492403, "url": "http://patchwork.ozlabs.org/api/series/492403/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492403", "date": "2026-02-17T09:51:04", "name": "page-vary: Build once", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492403/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2197174/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197174/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=lMn250cD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFZhW1Bsbz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 20:53:15 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsHkn-00036j-1c; Tue, 17 Feb 2026 04:52:25 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1vsHkZ-0002rC-TF\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:52:11 -0500", "from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1vsHkQ-00068N-6E\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:52:11 -0500", "by mail-pl1-x636.google.com with SMTP id\n d9443c01a7336-2a962230847so33780955ad.3\n for <qemu-devel@nongnu.org>; Tue, 17 Feb 2026 01:51:22 -0800 (PST)", "from localhost.localdomain\n (2403-580b-742d-0-10a2-dce1-aa4a-dd32.ip6.aussiebb.net.\n [2403:580b:742d:0:10a2:dce1:aa4a:dd32])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ad1a6fa33esm99108675ad.13.2026.02.17.01.51.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Feb 2026 01:51:21 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771321882; x=1771926682; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=RA/xW5zJd5cGLeWZe1fjyerEL6z5rrn6x+7ECtoAUpw=;\n b=lMn250cDqgLgp8eNhGsLjHr5VhbSHRHkAdZ4V3x5/l10lR5EGUdfeuxssYNDqwYMf5\n 7a1KwjTPOwZ6MsS4JhExC7xq75YTGJ5egc2r8MgTCIksvE7Wdf/U36vAzdiuwwGnJlwH\n /95inPHlrSBxhZwi+wKzshr6W3N2lCjV7VujtUe90YGguEtVXTFxFF+ADkLNWSLkskng\n PR5lcFYZpaEkspfZZFMEXS9JzIjLEWWtvAtUT1d2vp1bm33BqjaL6Z7SnbKlO0S1VpUr\n d5CgUur+ra8sKK1U5ep11yfy2QA9aK8siRUk15BQ6j8pdQ8EKkadtauGLESv/gaEn3q5\n 6ZzA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771321882; x=1771926682;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=RA/xW5zJd5cGLeWZe1fjyerEL6z5rrn6x+7ECtoAUpw=;\n b=SiS8eHN6GhOXc+1cWTYQgYCNNCHrLVLnvd96O6TrwcVKGtKp8r4z/hwxz/UmsMM0vE\n BJWtgoUocNIiAk82D19ap9kQbzbo7Y6xyHZ7Wh0YOH6o2CVzNtWbX+6D/nErDdBQ3wvv\n UAEvQ5W1AkV3MQmvG2aR3ZfXd5efSBzwEC730nhBf1Au0CHeAZkrTlVS3J75ujpT9Q67\n tHCovVHuFsjxIbTqKTzJ19p6xervJLYi2e4oS6DY7aD7aNV5fO42p0jWUhNCoC7TwXxv\n ZuL+I1VDUnwz+44mFMTRDnpYklwJy66GswRPfzN1ZX1VRffQjOCgKVipsByWw0TlgJQS\n gf7Q==", "X-Gm-Message-State": "AOJu0YzrAQtlXBmXB7D+Ge1U8W735etWhJUcZq7I+b8hddQCW6v9O6Bw\n l3SGe6ODm6AWXaBwwNhHCGfu1G4GHAb55JLrh4mbK9DWAzQYt9GG9AyG8bVuE9uAyz7gDAkZh/P\n LIVD3mv0=", "X-Gm-Gg": "AZuq6aLDXNccoahAGn3d5sshpKDB5LqF6O/qkGQYauZ1IKx34aPcdYqF2uRpSmyrfeC\n U7UOHfSVWJ7gyDWKWfNmgTRCBtg/TXZUr8ZUfZOnMzZwI6MXj2l2uISZsrp2mjP7aSbLS6VLavb\n I5+C4IlR3kBoM+nxou86zc9nGTnB+q2silr+NBorCWPIy+zacPYKDrql1pkJxz1GBZLlcvtH5we\n Y6jClJqmfhtEdyV23B1Yn9BYbwOc60hY68sKRg+QXJMXTtWgzIdarOMRO21ijbv12wY0dm6SNUg\n kTgQD9hdiaV4ZB1G91A0K8pEVHC5JWAdLxp1X9kzYplTheFy7Ux0PvzaXfpVCAl+i/wxjp3AiKW\n 65NssKJebSDlQvmx0wM5HyhhyY8fmhOfNf3q3xAhLtJkurSk9WsA5SrFfSCIYU2zwbcHZ04F9/f\n msV1wMxVDKgy3qaiHGLDkD4jPGZnK+MWSd7BVGrVfTu0yyikxhJjHw6W2m874xwiix9fH3EPw5O\n TQMbqksKpobWivvq7vYB6UnoHOtiQjhbhIJkkMlkLSUcbcsVw==", "X-Received": "by 2002:a17:903:2444:b0:2aa:ec1b:d3c3 with SMTP id\n d9443c01a7336-2ab505c34bcmr139135335ad.43.1771321881566;\n Tue, 17 Feb 2026 01:51:21 -0800 (PST)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "philmd@linaro.org", "Subject": "[PATCH v2 4/7] page-vary: Build set_preferred_target_page_bits as\n common code", "Date": "Tue, 17 Feb 2026 19:51:03 +1000", "Message-ID": "<20260217095106.598486-5-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260217095106.598486-1-richard.henderson@linaro.org>", "References": "<20260217095106.598486-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::636;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Use target_info->page_bits_vary to merge\nset_preferred_target_page_bits_common into\nset_preferred_target_page_bits in page-vary-common.c.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n include/exec/page-vary.h | 1 -\n page-vary-common.c | 29 ++++++++++++++++++-----------\n page-vary-target.c | 10 ----------\n 3 files changed, 18 insertions(+), 22 deletions(-)", "diff": "diff --git a/include/exec/page-vary.h b/include/exec/page-vary.h\nindex 3c77689ca5..c4dc56634b 100644\n--- a/include/exec/page-vary.h\n+++ b/include/exec/page-vary.h\n@@ -41,7 +41,6 @@ typedef struct {\n } TargetPageBits;\n \n #ifdef IN_PAGE_VARY\n-bool set_preferred_target_page_bits_common(int bits);\n void finalize_target_page_bits_common(int min);\n #endif\n \ndiff --git a/page-vary-common.c b/page-vary-common.c\nindex ab77672dd4..b41137c644 100644\n--- a/page-vary-common.c\n+++ b/page-vary-common.c\n@@ -20,25 +20,32 @@\n #define IN_PAGE_VARY 1\n \n #include \"qemu/osdep.h\"\n+#include \"qemu/target-info-impl.h\"\n #include \"exec/page-vary.h\"\n \n /* WARNING: This file must *not* be complied with -flto. */\n \n TargetPageBits target_page;\n \n-bool set_preferred_target_page_bits_common(int bits)\n+bool set_preferred_target_page_bits(int bits)\n {\n- /*\n- * The target page size is the lowest common denominator for all\n- * the CPUs in the system, so we can only make it smaller, never\n- * larger. And we can't make it smaller once we've committed to\n- * a particular size.\n- */\n- if (target_page.bits == 0 || target_page.bits > bits) {\n- if (target_page.decided) {\n- return false;\n+ const TargetInfo *ti = target_info();\n+\n+ assert(bits >= TARGET_PAGE_BITS_MIN);\n+ if (ti->page_bits_vary) {\n+\n+ /*\n+ * The target page size is the lowest common denominator for all\n+ * the CPUs in the system, so we can only make it smaller, never\n+ * larger. And we can't make it smaller once we've committed to\n+ * a particular size.\n+ */\n+ if (target_page.bits == 0 || target_page.bits > bits) {\n+ if (target_page.decided) {\n+ return false;\n+ }\n+ target_page.bits = bits;\n }\n- target_page.bits = bits;\n }\n return true;\n }\ndiff --git a/page-vary-target.c b/page-vary-target.c\nindex 7c0565dd8d..d388c5c3d6 100644\n--- a/page-vary-target.c\n+++ b/page-vary-target.c\n@@ -39,16 +39,6 @@ int migration_legacy_page_bits(void)\n }\n #endif\n \n-bool set_preferred_target_page_bits(int bits)\n-{\n- assert(bits >= TARGET_PAGE_BITS_MIN);\n-#ifdef TARGET_PAGE_BITS_VARY\n- return set_preferred_target_page_bits_common(bits);\n-#else\n- return true;\n-#endif\n-}\n-\n void finalize_target_page_bits(void)\n {\n #ifndef TARGET_PAGE_BITS_VARY\n", "prefixes": [ "v2", "4/7" ] }