Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2197037/?format=api
{ "id": 2197037, "url": "http://patchwork.ozlabs.org/api/patches/2197037/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216213121.47122-8-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216213121.47122-8-philmd@linaro.org>", "list_archive_url": null, "date": "2026-02-16T21:31:20", "name": "[v2,7/8] hw/ppc: Set graphic display dimensions generically", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4de28a7450122fcfef4730d6e4372eb02a5323f8", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216213121.47122-8-philmd@linaro.org/mbox/", "series": [ { "id": 492356, "url": "http://patchwork.ozlabs.org/api/series/492356/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492356", "date": "2026-02-16T21:31:14", "name": "system: Absorb globals-target.c within common globals.c", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492356/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2197037/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197037/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=pYOlXz/j;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFGGG2MqXz1xwC\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 08:32:54 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vs6Cs-0002Ec-LS; Mon, 16 Feb 2026 16:32:38 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vs6Ca-00017Q-IX\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:32:24 -0500", "from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vs6CW-00044r-V1\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:32:18 -0500", "by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-483770e0b25so30819835e9.0\n for <qemu-devel@nongnu.org>; Mon, 16 Feb 2026 13:32:16 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48371a4b63dsm95104645e9.32.2026.02.16.13.32.13\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 16 Feb 2026 13:32:14 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771277535; x=1771882335; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=D+jMqivfnrcdUY1u8zHXwV1uu1QqH0rdk08fo1hOV0E=;\n b=pYOlXz/j7drTllQ9M6RbYVBWAt1MnxN2+npoJCGKlNPOUG36dxcfxSvoC6qhCbsHlj\n JXKoqN8aOWKfw2jtbM3l6Rc5Py8WvFXEefP8DMgLACmFJ8VE+vlmm7zcPglGvMIcUVgd\n rVY7T3OXvVv4QiNi4uGKwwZEsBkCvfF00jmWF7QExM1SHjypEnwIsRnQB2C1nzcswJtO\n a11l/0kqyFFfHQzUBhLBA9WEkF05RInNAB2JdYUWmvnRsT9bus9c/CgoIVPStiEFiHlt\n FZXFYw6+c3Za4Ms2ffsGJoZr3fmDKQjA8WXj7fq2sPT8j6oolchgsmKNFHElVUCf8xDi\n ttsA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771277535; x=1771882335;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=D+jMqivfnrcdUY1u8zHXwV1uu1QqH0rdk08fo1hOV0E=;\n b=ei3HxonPsdK3ZW2X9L374acPxwDRgdzMuvdqBUYCjUntHW4SKb2X0vIZQWH+TLSSP9\n i3lfAOWfCWe0+LfpI868XTc2Q8Zeg+lTxUm5vN2/BsowpA2Ab3IJm91AQaIcv37KHc5y\n k21JtuOphfxw/gc/0Mz++Rh/L7Ax7K7ZHvHgE9h2nf6BSlk3xkn3B+lwGn233t/WRLGy\n 9BkIety7bhsqMTHk3S+t8ZCOSM4ZFORMGEYDF8Vm/QtYn1MZf55a/e7BtgoGEB5ehOhE\n 9XIznxL4A5EI2Xn8QGrwmc2lQq3ZYnSKsfyU7aFMUHJYB5RCL0qVEJp7ostTl3xqa/S+\n 1I2g==", "X-Gm-Message-State": "AOJu0YyJjigwn7PFoOZ19RipwvhQ1wNf3Kvb/eIw1d+Yd1sYmnG+SgNl\n 3A1c21L4JxaGBhigJb1gQugxov28xMWgipjrbKjFvXZJYOLPkZ6DQfIA4xXYeLgeMn2NJKGQ5ZL\n titfc+Lg=", "X-Gm-Gg": "AZuq6aI+X04MUWhKrA8x4W7wh1rNB4R2nUn6rBI0SBsIwUDNPD0QNBSgEWuXoDwh1Kn\n bJacn3yJQAuHb5xXH99T9EeO05r/Mq4zIxBJKTZWmVK+3uiZSiokiThF6LFXuGhF0ZW4f/FtJKD\n ycgbpkEklwdD7dHnfParjUfJaNj52XwcfhTnW3pd9hQ1IgQ8lSsAzOLGB2l5SMz0++0BMzNSmfk\n IPcIbt5loVhvVzPebqz6q1K6h8NzUNJuxyJZoLe0YvkhE+bkQYKKpPz2PscCBCH2iOHWpE7LiYG\n e5AlkI63hKWrsXDj0ZWea3eDgGe8XobcWsGt29IwCn2/pXhk+aICEtg0sTL+DKuROgqkDal3u2Z\n QtyGuzc7YJiu6ZvShaO39gDrOO3/exCJZPGxYAqscd5lC6o493ZLr32davQnEDjN76cW7DNnTXc\n HOYMqjWjap03D/KUq7s5g83IVCvmpgqiwKk9kFREVksQjL+BzAKwPzVI259gQ1qb0pDaPZXzLe", "X-Received": "by 2002:a05:600c:6912:b0:483:456a:5146 with SMTP id\n 5b1f17b1804b1-4837108fed4mr208785135e9.25.1771277535103;\n Mon, 16 Feb 2026 13:32:15 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Nicholas Piggin <npiggin@gmail.com>,\n =?utf-8?q?Herv=C3=A9_Poussineau?= <hpoussin@reactos.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Chinmay Rath <rathc@linux.ibm.com>,\n Artyom Tarasenko <atar4qemu@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, qemu-ppc@nongnu.org,\n Harsh Prateek Bora <harshpb@linux.ibm.com>,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH v2 7/8] hw/ppc: Set graphic display dimensions generically", "Date": "Mon, 16 Feb 2026 22:31:20 +0100", "Message-ID": "<20260216213121.47122-8-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260216213121.47122-1-philmd@linaro.org>", "References": "<20260216213121.47122-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "If a dimension is not set, have the machine init code set\nthe default values.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n hw/ppc/mac_newworld.c | 9 +++++++++\n hw/ppc/mac_oldworld.c | 9 +++++++++\n hw/ppc/prep.c | 9 +++++++++\n hw/ppc/spapr.c | 9 +++++++++\n system/globals-target.c | 6 ------\n 5 files changed, 36 insertions(+), 6 deletions(-)", "diff": "diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c\nindex 7275563a155..3680d96ed39 100644\n--- a/hw/ppc/mac_newworld.c\n+++ b/hw/ppc/mac_newworld.c\n@@ -432,6 +432,15 @@ static void ppc_core99_init(MachineState *machine)\n \n pci_vga_init(pci_bus);\n \n+ if (!graphic_width) {\n+ graphic_width = 800;\n+ }\n+ if (!graphic_height) {\n+ graphic_height = 600;\n+ }\n+ if (!graphic_depth) {\n+ graphic_depth = 32;\n+ }\n if (graphic_depth != 15 && graphic_depth != 32 && graphic_depth != 8) {\n graphic_depth = 15;\n }\ndiff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c\nindex e679d338985..24d9f2e3d5c 100644\n--- a/hw/ppc/mac_oldworld.c\n+++ b/hw/ppc/mac_oldworld.c\n@@ -288,6 +288,15 @@ static void ppc_heathrow_init(MachineState *machine)\n pci_create_simple(pci_bus, -1, \"pci-ohci\");\n }\n \n+ if (!graphic_width) {\n+ graphic_width = 800;\n+ }\n+ if (!graphic_height) {\n+ graphic_height = 600;\n+ }\n+ if (!graphic_depth) {\n+ graphic_depth = 32;\n+ }\n if (graphic_depth != 15 && graphic_depth != 32 && graphic_depth != 8) {\n graphic_depth = 15;\n }\ndiff --git a/hw/ppc/prep.c b/hw/ppc/prep.c\nindex c4efd1d3908..e973b340992 100644\n--- a/hw/ppc/prep.c\n+++ b/hw/ppc/prep.c\n@@ -412,6 +412,15 @@ static void ibm_40p_init(MachineState *machine)\n fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)machine->ram_size);\n fw_cfg_add_i16(fw_cfg, FW_CFG_MACHINE_ID, ARCH_PREP);\n \n+ if (!graphic_width) {\n+ graphic_width = 800;\n+ }\n+ if (!graphic_height) {\n+ graphic_height = 600;\n+ }\n+ if (!graphic_depth) {\n+ graphic_depth = 32;\n+ }\n fw_cfg_add_i16(fw_cfg, FW_CFG_PPC_WIDTH, graphic_width);\n fw_cfg_add_i16(fw_cfg, FW_CFG_PPC_HEIGHT, graphic_height);\n fw_cfg_add_i16(fw_cfg, FW_CFG_PPC_DEPTH, graphic_depth);\ndiff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c\nindex 274f38785f2..0ab39dfea6b 100644\n--- a/hw/ppc/spapr.c\n+++ b/hw/ppc/spapr.c\n@@ -1177,6 +1177,15 @@ static void spapr_dt_chosen(SpaprMachineState *spapr, void *fdt, bool reset)\n if (machine->boot_config.has_menu && machine->boot_config.menu) {\n _FDT((fdt_setprop_cell(fdt, chosen, \"qemu,boot-menu\", true)));\n }\n+ if (!graphic_width) {\n+ graphic_width = 800;\n+ }\n+ if (!graphic_height) {\n+ graphic_height = 600;\n+ }\n+ if (!graphic_depth) {\n+ graphic_depth = 32;\n+ }\n _FDT(fdt_setprop_cell(fdt, chosen, \"qemu,graphic-width\", graphic_width));\n _FDT(fdt_setprop_cell(fdt, chosen, \"qemu,graphic-height\", graphic_height));\n _FDT(fdt_setprop_cell(fdt, chosen, \"qemu,graphic-depth\", graphic_depth));\ndiff --git a/system/globals-target.c b/system/globals-target.c\nindex 17a27a06218..ffa6c308b59 100644\n--- a/system/globals-target.c\n+++ b/system/globals-target.c\n@@ -9,12 +9,6 @@\n #include \"qemu/osdep.h\"\n #include \"system/system.h\"\n \n-#if defined(TARGET_SPARC) || defined(TARGET_M68K)\n int graphic_width;\n int graphic_height;\n int graphic_depth;\n-#else\n-int graphic_width = 800;\n-int graphic_height = 600;\n-int graphic_depth = 32;\n-#endif\n", "prefixes": [ "v2", "7/8" ] }