Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2197012/?format=api
{ "id": 2197012, "url": "http://patchwork.ozlabs.org/api/patches/2197012/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/3c7d569e09075992921c6d627c91934665a637d1.1771275704.git.daniel@makrotopia.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<3c7d569e09075992921c6d627c91934665a637d1.1771275704.git.daniel@makrotopia.org>", "list_archive_url": null, "date": "2026-02-16T21:24:13", "name": "[RFC,18/20] boot: bootmeth: openwrt: support MTD and UBI bootdevs", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "812362c9e4032a8ace2249ca423c6d405e0e804b", "submitter": { "id": 64091, "url": "http://patchwork.ozlabs.org/api/people/64091/?format=api", "name": "Daniel Golle", "email": "daniel@makrotopia.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/3c7d569e09075992921c6d627c91934665a637d1.1771275704.git.daniel@makrotopia.org/mbox/", "series": [ { "id": 492351, "url": "http://patchwork.ozlabs.org/api/series/492351/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=492351", "date": "2026-02-16T21:21:14", "name": "boot: add OpenWrt boot method and on-demand FIT loading", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492351/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2197012/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2197012/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=makrotopia.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=makrotopia.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=daniel@makrotopia.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFG6Z19rTz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 08:26:14 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E3EB083E85;\n\tMon, 16 Feb 2026 22:25:04 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id C94F083CB9; Mon, 16 Feb 2026 22:24:34 +0100 (CET)", "from pidgin.makrotopia.org (pidgin.makrotopia.org\n [IPv6:2a07:2ec0:3002::65])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E5BB783B8A\n for <u-boot@lists.denx.de>; Mon, 16 Feb 2026 22:24:32 +0100 (CET)", "from local\n by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)\n (Exim 4.99) (envelope-from <daniel@makrotopia.org>)\n id 1vs64m-000000002qL-3v7M; Mon, 16 Feb 2026 21:24:17 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "Date": "Mon, 16 Feb 2026 21:24:13 +0000", "From": "Daniel Golle <daniel@makrotopia.org>", "To": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Daniel Golle <daniel@makrotopia.org>,\n Kory Maincent <kory.maincent@bootlin.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>,\n Martin Schwan <m.schwan@phytec.de>, Anshul Dalal <anshuld@ti.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Sughosh Ganu <sughosh.ganu@arm.com>, Aristo Chen <jj251510319013@gmail.com>,\n\t=?utf-8?b?54mbIOW/l+Wujw==?= <Zone.Niuzh@hotmail.com>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Wolfgang Wallner <wolfgang.wallner@at.abb.com>,\n Frank Wunderlich <frank-w@public-files.de>,\n David Lechner <dlechner@baylibre.com>,\n Osama Abdelkader <osama.abdelkader@gmail.com>,\n Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,\n Michael Trimarchi <michael@amarulasolutions.com>,\n Miquel Raynal <miquel.raynal@bootlin.com>,\n Andrew Goodbody <andrew.goodbody@linaro.org>,\n Yegor Yefremov <yegorslists@googlemail.com>,\n Mike Looijmans <mike.looijmans@topic.nl>,\n Weijie Gao <weijie.gao@mediatek.com>,\n Alexander Stein <alexander.stein@ew.tq-group.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Mayuresh Chitale <mchitale@ventanamicro.com>,\n Paul HENRYS <paul.henrys_ext@softathome.com>, u-boot@lists.denx.de", "Cc": "John Crispin <john@phrozen.org>, Paul Spooren <mail@aparcar.org>", "Subject": "[RFC PATCH 18/20] boot: bootmeth: openwrt: support MTD and UBI\n bootdevs", "Message-ID": "\n <3c7d569e09075992921c6d627c91934665a637d1.1771275704.git.daniel@makrotopia.org>", "References": "<cover.1771275704.git.daniel@makrotopia.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<cover.1771275704.git.daniel@makrotopia.org>", "X-Mailman-Approved-At": "Mon, 16 Feb 2026 22:25:02 +0100", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Extend bootmeth_openwrt's boot() to handle all three storage backends:\n\n- Block devices: detected via bflow->blk, uses image_loader_init_blk()\n (existing path, refactored into openwrt_boot_blk() helper)\n- UBI volumes: detected by checking the bootdev driver name\n (\"ubi_bootdev\"), uses image_loader_init_ubi() with the volume name\n from bflow->bootmeth_priv\n- MTD partitions: fallback for non-block bootflows with a priv string,\n uses image_loader_init_mtd() with the partition name\n\nThe check() function does not need changes: bootflow_iter_check_blk()\nalready accepts non-network bootdevs including UCLASS_MTD parents.\n\nThe rest of boot() remains identical across backends — bootm_init(),\noptional bootconf config selection, bootm_run(), cleanup on error.\nEach backend path is guarded by IS_ENABLED(CONFIG_BOOTDEV_*) to\navoid link errors when not configured.\n\nSigned-off-by: Daniel Golle <daniel@makrotopia.org>\n---\n boot/bootmeth_openwrt.c | 29 +++++++++++++++++++++++------\n 1 file changed, 23 insertions(+), 6 deletions(-)", "diff": "diff --git a/boot/bootmeth_openwrt.c b/boot/bootmeth_openwrt.c\nindex 82f39c17d7f..e1f47b58f61 100644\n--- a/boot/bootmeth_openwrt.c\n+++ b/boot/bootmeth_openwrt.c\n@@ -73,21 +73,38 @@ static int openwrt_read_bootflow(struct udevice *dev, struct bootflow *bflow)\n \treturn 0;\n }\n \n-static int openwrt_boot(struct udevice *dev, struct bootflow *bflow)\n+static int openwrt_boot_blk(struct bootflow *bflow,\n+\t\t\t struct image_loader *ldr)\n {\n \tstruct blk_desc *desc = dev_get_uclass_plat(bflow->blk);\n \tconst char *ifname = blk_get_devtype(bflow->blk);\n+\tchar dev_part_str[32];\n+\n+\tsnprintf(dev_part_str, sizeof(dev_part_str), \"%d:%d\",\n+\t\t desc->devnum, bflow->part);\n+\n+\treturn image_loader_init_blk(ldr, ifname, dev_part_str);\n+}\n+\n+static int openwrt_boot(struct udevice *dev, struct bootflow *bflow)\n+{\n \tstruct image_loader ldr = {};\n \tstruct bootm_info bmi;\n-\tchar dev_part_str[32];\n \tchar addr_img[64];\n \tconst char *conf;\n \tint ret;\n \n-\tsnprintf(dev_part_str, sizeof(dev_part_str), \"%d:%d\",\n-\t\t desc->devnum, bflow->part);\n-\n-\tret = image_loader_init_blk(&ldr, ifname, dev_part_str);\n+\tif (bflow->blk) {\n+\t\tret = openwrt_boot_blk(bflow, &ldr);\n+\t} else if (IS_ENABLED(CONFIG_BOOTDEV_UBI) &&\n+\t\t !strcmp(bflow->dev->driver->name, \"ubi_bootdev\")) {\n+\t\tret = image_loader_init_ubi(&ldr, bflow->bootmeth_priv);\n+\t} else if (IS_ENABLED(CONFIG_BOOTDEV_MTD) &&\n+\t\t bflow->bootmeth_priv) {\n+\t\tret = image_loader_init_mtd(&ldr, bflow->bootmeth_priv);\n+\t} else {\n+\t\treturn log_msg_ret(\"typ\", -ENODEV);\n+\t}\n \tif (ret)\n \t\treturn log_msg_ret(\"ldr\", ret);\n \n", "prefixes": [ "RFC", "18/20" ] }