Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196995/?format=api
{ "id": 2196995, "url": "http://patchwork.ozlabs.org/api/patches/2196995/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/3cb8b55fd4f96dc612b6a3453acecc0d37ca24a5.1771275704.git.daniel@makrotopia.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<3cb8b55fd4f96dc612b6a3453acecc0d37ca24a5.1771275704.git.daniel@makrotopia.org>", "list_archive_url": null, "date": "2026-02-16T21:21:25", "name": "[RFC,01/20] boot: add image_loader on-demand loading abstraction", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cd6b1d652221011a25484a99779fc680f4b7160b", "submitter": { "id": 64091, "url": "http://patchwork.ozlabs.org/api/people/64091/?format=api", "name": "Daniel Golle", "email": "daniel@makrotopia.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/3cb8b55fd4f96dc612b6a3453acecc0d37ca24a5.1771275704.git.daniel@makrotopia.org/mbox/", "series": [ { "id": 492351, "url": "http://patchwork.ozlabs.org/api/series/492351/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=492351", "date": "2026-02-16T21:21:14", "name": "boot: add OpenWrt boot method and on-demand FIT loading", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492351/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196995/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196995/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=makrotopia.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=makrotopia.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=daniel@makrotopia.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFG341kpxz1xwD\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 08:23:12 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0AD8E83C72;\n\tMon, 16 Feb 2026 22:22:57 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 8BE3883C6C; Mon, 16 Feb 2026 22:21:58 +0100 (CET)", "from pidgin.makrotopia.org (pidgin.makrotopia.org\n [IPv6:2a07:2ec0:3002::65])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B58A28063E\n for <u-boot@lists.denx.de>; Mon, 16 Feb 2026 22:21:48 +0100 (CET)", "from local\n by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)\n (Exim 4.99) (envelope-from <daniel@makrotopia.org>)\n id 1vs624-000000002bn-3GXG; Mon, 16 Feb 2026 21:21:28 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "Date": "Mon, 16 Feb 2026 21:21:25 +0000", "From": "Daniel Golle <daniel@makrotopia.org>", "To": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Daniel Golle <daniel@makrotopia.org>,\n Kory Maincent <kory.maincent@bootlin.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>,\n Martin Schwan <m.schwan@phytec.de>, Anshul Dalal <anshuld@ti.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Sughosh Ganu <sughosh.ganu@arm.com>, Aristo Chen <jj251510319013@gmail.com>,\n\t=?utf-8?b?54mbIOW/l+Wujw==?= <Zone.Niuzh@hotmail.com>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Wolfgang Wallner <wolfgang.wallner@at.abb.com>,\n Frank Wunderlich <frank-w@public-files.de>,\n David Lechner <dlechner@baylibre.com>,\n Osama Abdelkader <osama.abdelkader@gmail.com>,\n Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,\n Michael Trimarchi <michael@amarulasolutions.com>,\n Miquel Raynal <miquel.raynal@bootlin.com>,\n Andrew Goodbody <andrew.goodbody@linaro.org>,\n Yegor Yefremov <yegorslists@googlemail.com>,\n Mike Looijmans <mike.looijmans@topic.nl>,\n Weijie Gao <weijie.gao@mediatek.com>,\n Alexander Stein <alexander.stein@ew.tq-group.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Mayuresh Chitale <mchitale@ventanamicro.com>,\n Paul HENRYS <paul.henrys_ext@softathome.com>, u-boot@lists.denx.de", "Cc": "John Crispin <john@phrozen.org>, Paul Spooren <mail@aparcar.org>", "Subject": "[RFC PATCH 01/20] boot: add image_loader on-demand loading\n abstraction", "Message-ID": "\n <3cb8b55fd4f96dc612b6a3453acecc0d37ca24a5.1771275704.git.daniel@makrotopia.org>", "References": "<cover.1771275704.git.daniel@makrotopia.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<cover.1771275704.git.daniel@makrotopia.org>", "X-Mailman-Approved-At": "Mon, 16 Feb 2026 22:22:55 +0100", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Introduce struct image_loader, a small generic layer that lets callers\nread arbitrary byte ranges from a storage device and keeps a translation\ntable of the regions that have already been loaded into RAM.\n\nThe API consists of four functions:\n\n image_loader_lookup() - check whether a range is already mapped\n image_loader_map() - return a mapped pointer, reading on demand\n image_loader_map_to() - read into a caller-supplied address\n image_loader_cleanup() - release all backend resources\n\nA read-callback (image_loader_read_fn) plus an opaque *priv pointer\nabstract the actual I/O so that block, MTD, and UBI back-ends can be\nadded in follow-up patches without touching the core.\n\nEach backend provides a .cleanup callback which is invoked by\nimage_loader_cleanup() to release held device references and free\nallocated memory. This ensures safe resource teardown between\nconsecutive boot attempts.\n\nThe translation table (struct image_loader_region[]) avoids redundant\nreads when the same region is requested more than once, and allows\nextending an existing mapping when a larger size is needed at the same\noffset. The table size is controlled by CONFIG_IMAGE_LOADER_MAX_REGIONS\n(default 16).\n\nSigned-off-by: Daniel Golle <daniel@makrotopia.org>\n---\n boot/Kconfig | 20 +++++\n boot/Makefile | 2 +\n boot/image-loader.c | 163 +++++++++++++++++++++++++++++++++++++++++\n include/image-loader.h | 141 +++++++++++++++++++++++++++++++++++\n 4 files changed, 326 insertions(+)\n create mode 100644 boot/image-loader.c\n create mode 100644 include/image-loader.h", "diff": "diff --git a/boot/Kconfig b/boot/Kconfig\nindex e5db165424a..f6908e04a51 100644\n--- a/boot/Kconfig\n+++ b/boot/Kconfig\n@@ -1167,6 +1167,26 @@ config SYS_BOOT_RAMDISK_HIGH\n \n endmenu\t\t# Boot images\n \n+config IMAGE_LOADER\n+\tbool \"On-demand image loading from storage\"\n+\thelp\n+\t Provides a generic abstraction for reading image data from\n+\t storage on demand. A translation table maps already-loaded\n+\t regions to their RAM addresses, avoiding redundant reads.\n+\n+\t Used by bootm when a storage device is specified instead of a\n+\t RAM address.\n+\n+config IMAGE_LOADER_MAX_REGIONS\n+\tint \"Maximum number of mapped regions in image loader\"\n+\tdefault 16 if IMAGE_LOADER\n+\tdefault 0\n+\thelp\n+\t Maximum number of distinct image regions that can be mapped\n+\t into RAM simultaneously. 16 is sufficient for typical FIT\n+\t images (FDT structure + kernel + device tree + ramdisk +\n+\t a few loadable sub-images).\n+\n config DISTRO_DEFAULTS\n \tbool \"(deprecated) Script-based booting of Linux distributions\"\n \tselect CMDLINE\ndiff --git a/boot/Makefile b/boot/Makefile\nindex 7fb56e7ef37..1dbc285dad8 100644\n--- a/boot/Makefile\n+++ b/boot/Makefile\n@@ -73,6 +73,8 @@ obj-$(CONFIG_$(PHASE_)BOOTMETH_VBE_SIMPLE_OS) += vbe_simple_os.o\n \n obj-$(CONFIG_$(PHASE_)BOOTMETH_ANDROID) += bootmeth_android.o\n \n+obj-$(CONFIG_IMAGE_LOADER) += image-loader.o\n+\n obj-$(CONFIG_$(PHASE_)BOOTMETH_VBE_ABREC) += vbe_abrec.o vbe_common.o\n obj-$(CONFIG_$(PHASE_)BOOTMETH_VBE_ABREC_FW) += vbe_abrec_fw.o\n obj-$(CONFIG_$(PHASE_)BOOTMETH_VBE_ABREC_OS) += vbe_abrec_os.o\ndiff --git a/boot/image-loader.c b/boot/image-loader.c\nnew file mode 100644\nindex 00000000000..77f5b8c69a1\n--- /dev/null\n+++ b/boot/image-loader.c\n@@ -0,0 +1,163 @@\n+// SPDX-License-Identifier: GPL-2.0+\n+/*\n+ * On-demand image loading from storage\n+ *\n+ * Copyright (C) 2026 Daniel Golle <daniel@makrotopia.org>\n+ */\n+\n+#include <image-loader.h>\n+#include <mapmem.h>\n+#include <asm/cache.h>\n+#include <linux/errno.h>\n+#include <linux/kernel.h>\n+#include <log.h>\n+\n+void *image_loader_lookup(struct image_loader *ldr, ulong img_offset,\n+\t\t\t ulong size)\n+{\n+\tint i;\n+\n+\tfor (i = 0; i < ldr->nr_regions; i++) {\n+\t\tstruct image_loader_region *r = &ldr->regions[i];\n+\n+\t\tif (img_offset >= r->img_offset &&\n+\t\t img_offset + size <= r->img_offset + r->size)\n+\t\t\treturn (char *)r->ram + (img_offset - r->img_offset);\n+\t}\n+\n+\treturn NULL;\n+}\n+\n+void image_loader_cleanup(struct image_loader *ldr)\n+{\n+\tif (ldr->cleanup)\n+\t\tldr->cleanup(ldr);\n+\n+\tldr->read = NULL;\n+\tldr->cleanup = NULL;\n+\tldr->priv = NULL;\n+\tldr->nr_regions = 0;\n+}\n+\n+/**\n+ * image_loader_record() - Record a region in the translation table\n+ *\n+ * If an entry with the same img_offset already exists and the new size\n+ * is larger, update the existing entry. Otherwise add a new entry.\n+ *\n+ * @ldr:\tThe image loader\n+ * @img_offset:\tByte offset within the source image\n+ * @size:\tRegion size\n+ * @ram:\tRAM pointer where the region was loaded\n+ * Return: pointer to the region entry, or NULL if the table is full\n+ */\n+static struct image_loader_region *\n+image_loader_record(struct image_loader *ldr, ulong img_offset, ulong size,\n+\t\t void *ram)\n+{\n+\tstruct image_loader_region *r;\n+\tint i;\n+\n+\t/* Check for an existing entry at the same base that we can extend */\n+\tfor (i = 0; i < ldr->nr_regions; i++) {\n+\t\tr = &ldr->regions[i];\n+\t\tif (r->img_offset == img_offset) {\n+\t\t\tr->size = size;\n+\t\t\tr->ram = ram;\n+\t\t\treturn r;\n+\t\t}\n+\t}\n+\n+\tif (ldr->nr_regions >= CONFIG_IMAGE_LOADER_MAX_REGIONS) {\n+\t\tlog_err(\"image_loader: translation table full (%d regions)\\n\",\n+\t\t\tldr->nr_regions);\n+\t\treturn NULL;\n+\t}\n+\n+\tr = &ldr->regions[ldr->nr_regions++];\n+\tr->img_offset = img_offset;\n+\tr->size = size;\n+\tr->ram = ram;\n+\n+\treturn r;\n+}\n+\n+void *image_loader_map(struct image_loader *ldr, ulong img_offset, ulong size)\n+{\n+\tstruct image_loader_region *r;\n+\tvoid *p;\n+\tint ret;\n+\n+\t/* Return existing mapping if the range is already covered */\n+\tp = image_loader_lookup(ldr, img_offset, size);\n+\tif (p)\n+\t\treturn p;\n+\n+\t/*\n+\t * Check if we have an entry at the same base offset but smaller.\n+\t * If so, re-read the full range to the same RAM address.\n+\t */\n+\tfor (int i = 0; i < ldr->nr_regions; i++) {\n+\t\tr = &ldr->regions[i];\n+\t\tif (r->img_offset == img_offset && r->size < size) {\n+\t\t\tulong region_end;\n+\n+\t\t\tret = ldr->read(ldr, img_offset, size, r->ram);\n+\t\t\tif (ret) {\n+\t\t\t\tlog_err(\"image_loader: read failed at offset 0x%lx (size 0x%lx): %d\\n\",\n+\t\t\t\t\timg_offset, size, ret);\n+\t\t\t\treturn NULL;\n+\t\t\t}\n+\t\t\tr->size = size;\n+\n+\t\t\t/* Keep alloc_ptr past the extended region */\n+\t\t\tregion_end = ALIGN(map_to_sysmem(r->ram) + size,\n+\t\t\t\t\t ARCH_DMA_MINALIGN);\n+\t\t\tif (region_end > ldr->alloc_ptr)\n+\t\t\t\tldr->alloc_ptr = region_end;\n+\n+\t\t\treturn r->ram;\n+\t\t}\n+\t}\n+\n+\t/* New region — allocate from scratch area */\n+\tp = map_sysmem(ldr->alloc_ptr, size);\n+\n+\tret = ldr->read(ldr, img_offset, size, p);\n+\tif (ret) {\n+\t\tlog_err(\"image_loader: read failed at offset 0x%lx (size 0x%lx): %d\\n\",\n+\t\t\timg_offset, size, ret);\n+\t\treturn NULL;\n+\t}\n+\n+\tif (!image_loader_record(ldr, img_offset, size, p))\n+\t\treturn NULL;\n+\n+\tldr->alloc_ptr = ALIGN(ldr->alloc_ptr + size, ARCH_DMA_MINALIGN);\n+\n+\treturn p;\n+}\n+\n+void *image_loader_map_to(struct image_loader *ldr, ulong img_offset,\n+\t\t\t ulong size, void *dst)\n+{\n+\tint ret;\n+\n+\t/* If already mapped to this exact destination, return it */\n+\tvoid *p = image_loader_lookup(ldr, img_offset, size);\n+\n+\tif (p && p == dst)\n+\t\treturn p;\n+\n+\tret = ldr->read(ldr, img_offset, size, dst);\n+\tif (ret) {\n+\t\tlog_err(\"image_loader: read failed at offset 0x%lx (size 0x%lx): %d\\n\",\n+\t\t\timg_offset, size, ret);\n+\t\treturn NULL;\n+\t}\n+\n+\tif (!image_loader_record(ldr, img_offset, size, dst))\n+\t\treturn NULL;\n+\n+\treturn dst;\n+}\ndiff --git a/include/image-loader.h b/include/image-loader.h\nnew file mode 100644\nindex 00000000000..e273b1ca50f\n--- /dev/null\n+++ b/include/image-loader.h\n@@ -0,0 +1,141 @@\n+/* SPDX-License-Identifier: GPL-2.0+ */\n+/*\n+ * On-demand image loading from storage\n+ *\n+ * Copyright (C) 2026 Daniel Golle <daniel@makrotopia.org>\n+ */\n+\n+#ifndef __IMAGE_LOADER_H\n+#define __IMAGE_LOADER_H\n+\n+#include <linux/types.h>\n+\n+/**\n+ * struct image_loader_region - One mapped region of the image\n+ *\n+ * Records the fact that image bytes [img_offset, img_offset + size)\n+ * have been loaded into RAM at address @ram.\n+ *\n+ * @img_offset:\tStart offset within the source image (bytes)\n+ * @size:\tRegion size (bytes)\n+ * @ram:\tRAM pointer where this region was loaded\n+ */\n+struct image_loader_region {\n+\tulong img_offset;\n+\tulong size;\n+\tvoid *ram;\n+};\n+\n+struct image_loader;\n+\n+/**\n+ * image_loader_read_fn - Read data from a storage device\n+ *\n+ * @ldr:\tThe image loader instance\n+ * @src:\tByte offset within the source image\n+ * @size:\tNumber of bytes to read\n+ * @dst:\tDestination buffer in RAM\n+ * Return: 0 on success, negative errno on failure\n+ */\n+typedef int (*image_loader_read_fn)(struct image_loader *ldr, ulong src,\n+\t\t\t\t ulong size, void *dst);\n+\n+/**\n+ * image_loader_cleanup_fn - Release backend resources\n+ *\n+ * Called by image_loader_cleanup() to free any backend-specific state\n+ * such as allocated priv structs or held device references.\n+ *\n+ * @ldr:\tThe image loader instance\n+ */\n+typedef void (*image_loader_cleanup_fn)(struct image_loader *ldr);\n+\n+/**\n+ * struct image_loader - On-demand image loading from storage\n+ *\n+ * Provides a generic abstraction for reading image data from a storage\n+ * device on demand. A translation table maps regions of the source\n+ * image that have already been loaded to their RAM addresses, avoiding\n+ * redundant reads.\n+ *\n+ * @read:\tBackend read callback\n+ * @cleanup:\tOptional backend cleanup callback\n+ * @priv:\tOpaque backend-specific context\n+ * @regions:\tTranslation table of loaded regions\n+ * @nr_regions:\tNumber of entries currently used in @regions\n+ * @alloc_ptr:\tNext free RAM address for scratch allocations\n+ */\n+struct image_loader {\n+\timage_loader_read_fn read;\n+\timage_loader_cleanup_fn cleanup;\n+\tvoid *priv;\n+\tstruct image_loader_region regions[CONFIG_IMAGE_LOADER_MAX_REGIONS];\n+\tint nr_regions;\n+\tulong alloc_ptr;\n+};\n+\n+/**\n+ * image_loader_lookup() - Look up an already-mapped region\n+ *\n+ * Checks the translation table to see if the requested range\n+ * [img_offset, img_offset + size) is fully contained within a\n+ * previously loaded region.\n+ *\n+ * @ldr:\tThe image loader\n+ * @img_offset:\tByte offset within the source image\n+ * @size:\tNumber of bytes needed\n+ * Return: RAM pointer on hit, NULL on miss (does not trigger a read)\n+ */\n+void *image_loader_lookup(struct image_loader *ldr, ulong img_offset,\n+\t\t\t ulong size);\n+\n+/**\n+ * image_loader_cleanup() - Release all backend resources\n+ *\n+ * Calls the backend cleanup callback (if set) and resets the loader\n+ * state so it can be safely re-initialised or discarded. Should be\n+ * called when the boot attempt is finished, whether it succeeded or\n+ * not.\n+ *\n+ * @ldr:\tThe image loader to clean up\n+ */\n+void image_loader_cleanup(struct image_loader *ldr);\n+\n+/**\n+ * image_loader_map() - Ensure an image region is accessible in RAM\n+ *\n+ * If the region is already in the translation table, returns the\n+ * existing RAM pointer. Otherwise allocates RAM at @ldr->alloc_ptr,\n+ * reads the data from storage, records the mapping, advances the\n+ * allocation pointer (aligned to ARCH_DMA_MINALIGN), and returns the\n+ * new pointer.\n+ *\n+ * If the requested range starts at the same offset as an existing\n+ * region but is larger, the existing region is extended in place\n+ * (re-read to the same RAM base, size updated).\n+ *\n+ * @ldr:\tThe image loader\n+ * @img_offset:\tByte offset within the source image\n+ * @size:\tNumber of bytes needed\n+ * Return: RAM pointer on success, NULL on failure\n+ */\n+void *image_loader_map(struct image_loader *ldr, ulong img_offset,\n+\t\t ulong size);\n+\n+/**\n+ * image_loader_map_to() - Load an image region to a specific RAM address\n+ *\n+ * Like image_loader_map() but reads into a caller-specified address\n+ * instead of allocating from the scratch area. Used when the sub-image\n+ * has a known load address for a zero-copy path.\n+ *\n+ * @ldr:\tThe image loader\n+ * @img_offset:\tByte offset within the source image\n+ * @size:\tNumber of bytes to load\n+ * @dst:\tDestination address in RAM\n+ * Return: @dst on success, NULL on failure\n+ */\n+void *image_loader_map_to(struct image_loader *ldr, ulong img_offset,\n+\t\t\t ulong size, void *dst);\n+\n+#endif /* __IMAGE_LOADER_H */\n", "prefixes": [ "RFC", "01/20" ] }