Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196991/?format=api
{ "id": 2196991, "url": "http://patchwork.ozlabs.org/api/patches/2196991/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260216203529.5744-1-jemarch@gnu.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216203529.5744-1-jemarch@gnu.org>", "list_archive_url": null, "date": "2026-02-16T20:35:29", "name": "[COMMITTED] a68: fix uninitialized memory in get_hole_symbol [PR algol68/124115]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "61e468af65413c64eadaa60d1978f541e672582d", "submitter": { "id": 53513, "url": "http://patchwork.ozlabs.org/api/people/53513/?format=api", "name": "Jose E. Marchesi", "email": "jemarch@gnu.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260216203529.5744-1-jemarch@gnu.org/mbox/", "series": [ { "id": 492348, "url": "http://patchwork.ozlabs.org/api/series/492348/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=492348", "date": "2026-02-16T20:35:29", "name": "[COMMITTED] a68: fix uninitialized memory in get_hole_symbol [PR algol68/124115]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492348/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196991/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196991/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256\n header.s=fencepost-gnu-org header.b=dyTwYi0B;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256\n header.s=fencepost-gnu-org header.b=dyTwYi0B", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gnu.org", "sourceware.org; spf=pass smtp.mailfrom=gnu.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=209.51.188.92" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFF1D23SLz1xwD\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 07:36:30 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id E64744B9DB49\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 20:36:28 +0000 (GMT)", "from eggs.gnu.org (eggs.gnu.org [209.51.188.92])\n by sourceware.org (Postfix) with ESMTPS id 087664BA23D0;\n Mon, 16 Feb 2026 20:36:01 +0000 (GMT)", "from fencepost.gnu.org ([2001:470:142:3::e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jemarch@gnu.org>)\n id 1vs5K4-0004iA-Gc; Mon, 16 Feb 2026 15:36:00 -0500" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org E64744B9DB49", "OpenDKIM Filter v2.11.0 sourceware.org 087664BA23D0" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 087664BA23D0", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 087664BA23D0", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771274161; cv=none;\n b=hEZiYA0L6Ib9xN5WGZKYoypVUQxKA50qINvdif0vK3vM0XETdQM1o6P/7qxTfqjusR9YpnfYdbfPB/oIZvA2hsUEjElgb0PDC5TUvMlbZVSQqGyTOcBB4nNyV1yMNqCi9n/T/L5sciI2hWVLT/3lz4sRaBkh0sfZaI2N1La+N/8=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1771274161; c=relaxed/simple;\n bh=ncRyRsQ3Fa1TkUY56OaRGizY73/0zO/ppS1hcOfldyc=;\n h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version;\n b=sQhjPFU3SQByLYGIsGQzF3ANVlnlScpB9DHG1BQb7pGLDPGHW/XiFazIJaaYMKPKAl86HhbXblFLOQ5UnVvBwPQnQtaKABez6Jz32D3C7YG3FUUP0CMb9u7LTCMRlrRkifKR7RjunsOmfKgAikZkZym6+U0oeXXoYrupshQKFHY=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;\n s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to:\n references; bh=PF7ktnssRJE1ig8oCKiM6UdPrOsVLHJ76NYSBDNcSw4=; b=dyTwYi0BpO9js7\n IFaqZ/zq9WAdcNh8r1o+xKEiY+mfK2StT5ggbPOGScSMF72h+leYouO/yiJhXP0GAHsc7scbMMSPR\n cF/rZ+iZ5CxYPEOzJJUbo4o/anHPf+VbZ9PEzf0sRXuVv2i+mUJ2ONIn4ZClb6aHSrokRnC1CZUv5\n 3TpFxuUwwABPJFsW/W0Jz3wDLYKSunkLU697rQQrNFM9OB92vO4qTC8EHiN4EPiYTQNKLST2y/12D\n Jh49XwtUShA9p1TfQxkNkJLNH72v2B2Gx8AhL/y0zuaOxgonzfKCByynbqYEw8AwafWwk+dhBy+7B\n tVv/1cJ7NXi0gTUzZMPA==;", "From": "\"Jose E. Marchesi\" <jemarch@gnu.org>", "To": "gcc-patches@gcc.gnu.org", "Cc": "algol68@gcc.gnu.org", "Subject": "[COMMITTED] a68: fix uninitialized memory in get_hole_symbol [PR\n algol68/124115]", "Date": "Mon, 16 Feb 2026 21:35:29 +0100", "Message-Id": "<20260216203529.5744-1-jemarch@gnu.org>", "X-Mailer": "git-send-email 2.39.5", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "The function get_hole_symbol is supposed to set *addrp to either true\nor false. However it was only setting it to false, causing\nuninitialized memory.\n\nThis patch also removes a gcc_asser tfrom a68_make_formal_hole_decl.\nIf the formal hole results in an empty symbol then it may result into\ninvalid assembly being generated, but that is akin to use an invalid\nasm template.\n\nSigned-off-by: Jose E. Marchesi <jemarch@gnu.org>\n\ngcc/algol68/ChangeLog\n\n\tPR algol68/124115\n\t* a68-low-holes.cc (get_hole_symbol): Always set *addrp to avoid\n\tuninitialized memory.\n\t* a68-low.cc (a68_make_formal_hole_decl): Remove assert.\n\ngcc/testsuite/ChangeLog\n\n\tPR algol68/124115\n\t* algol68/compile/formal-hole-2.a68: New test.\n---\n gcc/algol68/a68-low-holes.cc | 7 +++++--\n gcc/algol68/a68-low.cc | 3 +--\n gcc/testsuite/algol68/compile/formal-hole-2.a68 | 6 ++++++\n 3 files changed, 12 insertions(+), 4 deletions(-)\n create mode 100644 gcc/testsuite/algol68/compile/formal-hole-2.a68", "diff": "diff --git a/gcc/algol68/a68-low-holes.cc b/gcc/algol68/a68-low-holes.cc\nindex 3eca4e4e0b2..eaf4ddfecb3 100644\n--- a/gcc/algol68/a68-low-holes.cc\n+++ b/gcc/algol68/a68-low-holes.cc\n@@ -57,12 +57,15 @@ get_hole_symbol (NODE_T *p, bool *addrp)\n gcc_assert (IS (str, ROW_CHAR_DENOTATION));\n \n const char *cstr = NSYMBOL (str);\n- if (strlen (cstr) > 0 && cstr[0] == '&' && addrp != NULL)\n+ bool isaddr = false;\n+ if (strlen (cstr) > 0 && cstr[0] == '&')\n {\n- *addrp = true;\n+ isaddr = true;\n cstr = cstr + 1;\n }\n \n+ if (addrp != NULL)\n+ *addrp = isaddr;\n return a68_string_process_breaks (p, cstr);\n }\n \ndiff --git a/gcc/algol68/a68-low.cc b/gcc/algol68/a68-low.cc\nindex dcc974ad67d..7df38c801e6 100644\n--- a/gcc/algol68/a68-low.cc\n+++ b/gcc/algol68/a68-low.cc\n@@ -642,8 +642,7 @@ a68_make_formal_hole_decl (NODE_T *p, const char *extern_symbol)\n \t ? TREE_TYPE (CTYPE (MOID (p)))\n \t : CTYPE (MOID (p)));\n \n- gcc_assert (strlen (extern_symbol) > 0);\n- const char *sym = (extern_symbol[0] == '&'\n+ const char *sym = (strlen (extern_symbol) > 0 && extern_symbol[0] == '&'\n \t\t ? extern_symbol + 1\n \t\t : extern_symbol);\n \ndiff --git a/gcc/testsuite/algol68/compile/formal-hole-2.a68 b/gcc/testsuite/algol68/compile/formal-hole-2.a68\nnew file mode 100644\nindex 00000000000..9337a044f35\n--- /dev/null\n+++ b/gcc/testsuite/algol68/compile/formal-hole-2.a68\n@@ -0,0 +1,6 @@\n+{ Freestanding formal hole with &. }\n+\n+begin\n+ ref int foo = nest C \"&foo\";\n+ skip\n+end\n", "prefixes": [ "COMMITTED" ] }