Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196971/?format=api
{ "id": 2196971, "url": "http://patchwork.ozlabs.org/api/patches/2196971/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216191213.2556073-8-dmitry.osipenko@collabora.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216191213.2556073-8-dmitry.osipenko@collabora.com>", "list_archive_url": null, "date": "2026-02-16T19:12:02", "name": "[v17,07/18] ui/sdl2: Implement dpy dmabuf functions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8f82025a2eb5f3dc851932aa2bf0efd1b16a800a", "submitter": { "id": 83453, "url": "http://patchwork.ozlabs.org/api/people/83453/?format=api", "name": "Dmitry Osipenko", "email": "dmitry.osipenko@collabora.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216191213.2556073-8-dmitry.osipenko@collabora.com/mbox/", "series": [ { "id": 492344, "url": "http://patchwork.ozlabs.org/api/series/492344/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492344", "date": "2026-02-16T19:11:55", "name": "Support virtio-gpu DRM native context and MAP_FIXED API", "version": 17, "mbox": "http://patchwork.ozlabs.org/series/492344/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196971/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196971/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=RzRj33uK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFCBT0JNbz1xwF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 06:14:25 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vs42e-00081O-3x; Mon, 16 Feb 2026 14:13:56 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vs42X-00080L-Mp\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:50 -0500", "from sender4-pp-f112.zoho.com ([136.143.188.112])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vs42V-0003a3-No\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:49 -0500", "by mx.zohomail.com with SMTPS id 177126920956623.720257775977643;\n Mon, 16 Feb 2026 11:13:29 -0800 (PST)" ], "ARC-Seal": "i=1; a=rsa-sha256; t=1771269210; cv=none;\n d=zohomail.com; s=zohoarc;\n b=Z/KHoWFd3MjVQNXWctmhCmmoAuf2sug7Srl5EUxHUO/mSSZT2DKZ7ibNyl7v81A+aArZZc+7XBjMABH1G38C1Bv7vMi3hRT0jSaXY0/biFPQU3XnlRWNi124EkHDmBUPiXKFf5onaxaC3vG05kPN+DZjWl/zfTNabsHnoqrpP9Q=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1771269210;\n h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=bfcfKL4sgMkNZ4BkHX9zdAppRHZJEY/aKa9cz3LDUGc=;\n b=ZVryqGJ3ya6c68wgyFy4HF400dXTSsfGKAZ0oDEyo3EbRm++Pnp61c0iU5JfHOUbmpiPbioU/kjBwG30QiJ0bltM89TWprGeybfy6s2pJYylA0M4Ww8v/Q+cclpEI6OhkveLG09ow6EgciICT8dFAFJfJFSjva0UTILptMgeHtw=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n dkim=pass header.i=collabora.com;\n spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;\n dmarc=pass header.from=<dmitry.osipenko@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771269210;\n s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;\n h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n bh=bfcfKL4sgMkNZ4BkHX9zdAppRHZJEY/aKa9cz3LDUGc=;\n b=RzRj33uKKvKpU3smpKigPD8c1NdYR56QoDrj5FJsEIUz5ncmGZWPhcnUIWtgKl74\n ElrVpsy0kr5rh8O+uXEjkG5BXF1vmiW+M8rAHa9mvmaOdmQgtQ+070R+MKZM74flTFp\n +ltC5N2J7ak9l1VdoDc0HG+R29blOWl+WYuWHslw=", "From": "Dmitry Osipenko <dmitry.osipenko@collabora.com>", "To": "Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Huang Rui <ray.huang@amd.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Gerd Hoffmann <kraxel@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,\n \"Michael S . Tsirkin\" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Yiwei Zhang <zzyiwei@gmail.com>, Sergio Lopez Pascual <slp@redhat.com>", "Cc": "Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,\n Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,\n\t=?utf-8?q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>,\n Alex Deucher <alexander.deucher@amd.com>,\n Stefano Stabellini <stefano.stabellini@amd.com>, =?utf-8?q?Christian_K?=\n\t=?utf-8?q?=C3=B6nig?= <christian.koenig@amd.com>,\n Xenia Ragiadakou <xenia.ragiadakou@amd.com>,\n Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,\n Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,\n Robert Beckett <bob.beckett@collabora.com>", "Subject": "[PATCH v17 07/18] ui/sdl2: Implement dpy dmabuf functions", "Date": "Mon, 16 Feb 2026 22:12:02 +0300", "Message-ID": "<20260216191213.2556073-8-dmitry.osipenko@collabora.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260216191213.2556073-1-dmitry.osipenko@collabora.com>", "References": "<20260216191213.2556073-1-dmitry.osipenko@collabora.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ZohoMailClient": "External", "Received-SPF": "pass client-ip=136.143.188.112;\n envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>\n\nIf EGL is used, we can rely on dmabuf to import textures without\ndoing copies.\n\nTo get this working on X11, we use the existing SDL hint:\nSDL_HINT_VIDEO_X11_FORCE_EGL (because dmabuf can't be used with GLX).\n\nReviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>\nAcked-by: Michael S. Tsirkin <mst@redhat.com>\nTested-by: Alex Bennée <alex.bennee@linaro.org>\nSigned-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>\nReviewed-by: Yiwei Zhang <zzyiwei@gmail.com>\nSigned-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>\n---\n include/ui/sdl2.h | 7 +++++\n meson.build | 6 ++---\n ui/sdl2-gl.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++\n ui/sdl2.c | 42 ++++++++++++++++++++++++++++++\n 4 files changed, 117 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h\nindex dbe6e3d9739b..9daf5ecffae7 100644\n--- a/include/ui/sdl2.h\n+++ b/include/ui/sdl2.h\n@@ -45,6 +45,7 @@ struct sdl2_console {\n bool gui_keysym;\n SDL_GLContext winctx;\n QKbdState *kbd;\n+ bool has_dmabuf;\n #ifdef CONFIG_OPENGL\n QemuGLShader *gls;\n egl_fb guest_fb;\n@@ -96,5 +97,11 @@ void sdl2_gl_scanout_texture(DisplayChangeListener *dcl,\n void *d3d_tex2d);\n void sdl2_gl_scanout_flush(DisplayChangeListener *dcl,\n uint32_t x, uint32_t y, uint32_t w, uint32_t h);\n+void sdl2_gl_scanout_dmabuf(DisplayChangeListener *dcl,\n+ QemuDmaBuf *dmabuf);\n+void sdl2_gl_release_dmabuf(DisplayChangeListener *dcl,\n+ QemuDmaBuf *dmabuf);\n+bool sdl2_gl_has_dmabuf(DisplayChangeListener *dcl);\n+void sdl2_gl_console_init(struct sdl2_console *scon);\n \n #endif /* SDL2_H */\ndiff --git a/meson.build b/meson.build\nindex e8fd77aac00d..7b56a4b2775e 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1937,10 +1937,8 @@ if get_option('gtk') \\\n endif\n endif\n \n-x11 = not_found\n-if gtkx11.found()\n- x11 = dependency('x11', method: 'pkg-config', required: gtkx11.found())\n-endif\n+x11 = dependency('x11', method: 'pkg-config', required: gtkx11.found())\n+\n png = not_found\n if get_option('png').allowed() and have_system\n png = dependency('libpng', version: '>=1.6.34', required: get_option('png'),\ndiff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c\nindex 936b15f737d8..93f460cee9f6 100644\n--- a/ui/sdl2-gl.c\n+++ b/ui/sdl2-gl.c\n@@ -26,6 +26,8 @@\n */\n \n #include \"qemu/osdep.h\"\n+#include \"qemu/main-loop.h\"\n+#include \"qemu/error-report.h\"\n #include \"ui/console.h\"\n #include \"ui/input.h\"\n #include \"ui/sdl2.h\"\n@@ -255,3 +257,67 @@ void sdl2_gl_scanout_flush(DisplayChangeListener *dcl,\n \n SDL_GL_SwapWindow(scon->real_window);\n }\n+\n+void sdl2_gl_scanout_dmabuf(DisplayChangeListener *dcl,\n+ QemuDmaBuf *dmabuf)\n+{\n+ struct sdl2_console *scon = container_of(dcl, struct sdl2_console, dcl);\n+ const int *fds;\n+\n+ assert(scon->opengl);\n+ SDL_GL_MakeCurrent(scon->real_window, scon->winctx);\n+\n+ egl_dmabuf_import_texture(dmabuf);\n+ if (!qemu_dmabuf_get_texture(dmabuf)) {\n+ fds = qemu_dmabuf_get_fds(dmabuf, NULL);\n+ error_report(\"%s: failed fd=%d\", __func__, fds ? fds[0] : -1);\n+ return;\n+ }\n+\n+ sdl2_gl_scanout_texture(dcl, qemu_dmabuf_get_texture(dmabuf), false,\n+ qemu_dmabuf_get_width(dmabuf),\n+ qemu_dmabuf_get_height(dmabuf),\n+ 0, 0,\n+ qemu_dmabuf_get_width(dmabuf),\n+ qemu_dmabuf_get_height(dmabuf),\n+ NULL);\n+\n+ if (qemu_dmabuf_get_allow_fences(dmabuf)) {\n+ scon->guest_fb.dmabuf = dmabuf;\n+ }\n+}\n+\n+void sdl2_gl_release_dmabuf(DisplayChangeListener *dcl,\n+ QemuDmaBuf *dmabuf)\n+{\n+ egl_dmabuf_release_texture(dmabuf);\n+}\n+\n+bool sdl2_gl_has_dmabuf(DisplayChangeListener *dcl)\n+{\n+ struct sdl2_console *scon = container_of(dcl, struct sdl2_console, dcl);\n+\n+ return scon->has_dmabuf;\n+}\n+\n+void sdl2_gl_console_init(struct sdl2_console *scon)\n+{\n+ bool hidden = scon->hidden;\n+\n+ scon->hidden = true;\n+ scon->surface = qemu_create_displaysurface(1, 1);\n+ sdl2_window_create(scon);\n+\n+ /*\n+ * QEMU checks whether console supports dma-buf before switching\n+ * to the console. To break this chicken-egg problem we pre-check\n+ * dma-buf availability beforehand using a dummy SDL window.\n+ */\n+ scon->has_dmabuf = qemu_egl_has_dmabuf();\n+\n+ sdl2_window_destroy(scon);\n+ qemu_free_displaysurface(scon->surface);\n+\n+ scon->surface = NULL;\n+ scon->hidden = hidden;\n+}\ndiff --git a/ui/sdl2.c b/ui/sdl2.c\nindex 032dc14bc398..3bb2676f847b 100644\n--- a/ui/sdl2.c\n+++ b/ui/sdl2.c\n@@ -35,6 +35,10 @@\n #include \"qemu/log.h\"\n #include \"qemu-main.h\"\n \n+#ifdef CONFIG_X11\n+#include <X11/Xlib.h>\n+#endif\n+\n static int sdl2_num_outputs;\n static struct sdl2_console *sdl2_console;\n \n@@ -120,6 +124,9 @@ void sdl2_window_create(struct sdl2_console *scon)\n /* The SDL renderer is only used by sdl2-2D, when OpenGL is disabled */\n scon->real_renderer = SDL_CreateRenderer(scon->real_window, -1, 0);\n }\n+\n+ qemu_egl_display = eglGetCurrentDisplay();\n+\n sdl_update_caption(scon);\n }\n \n@@ -808,6 +815,10 @@ static const DisplayChangeListenerOps dcl_gl_ops = {\n .dpy_gl_scanout_disable = sdl2_gl_scanout_disable,\n .dpy_gl_scanout_texture = sdl2_gl_scanout_texture,\n .dpy_gl_update = sdl2_gl_scanout_flush,\n+\n+ .dpy_gl_scanout_dmabuf = sdl2_gl_scanout_dmabuf,\n+ .dpy_gl_release_dmabuf = sdl2_gl_release_dmabuf,\n+ .dpy_has_dmabuf = sdl2_gl_has_dmabuf,\n };\n \n static bool\n@@ -835,6 +846,35 @@ static void sdl2_display_early_init(DisplayOptions *o)\n }\n }\n \n+static void sdl2_set_hint_x11_force_egl(void)\n+{\n+#if defined(SDL_HINT_VIDEO_X11_FORCE_EGL) && defined(CONFIG_OPENGL) && \\\n+ defined(CONFIG_X11)\n+ Display *x_disp = XOpenDisplay(NULL);\n+ EGLDisplay egl_display;\n+\n+ if (!x_disp) {\n+ return;\n+ }\n+\n+ /* Prefer EGL over GLX to get dma-buf support. */\n+ egl_display = eglGetDisplay((EGLNativeDisplayType)x_disp);\n+\n+ if (egl_display != EGL_NO_DISPLAY) {\n+ /*\n+ * Setting X11_FORCE_EGL hint doesn't make SDL to prefer X11 over\n+ * Wayland. SDL will use Wayland driver even if XWayland presents.\n+ * It's always safe to set the hint even if X11 is not used by SDL.\n+ * SDL will work regardless of the hint.\n+ */\n+ SDL_SetHint(SDL_HINT_VIDEO_X11_FORCE_EGL, \"1\");\n+ eglTerminate(egl_display);\n+ }\n+\n+ XCloseDisplay(x_disp);\n+#endif\n+}\n+\n static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)\n {\n uint8_t data = 0;\n@@ -862,6 +902,7 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)\n SDL_SetHint(SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED, \"0\");\n #endif\n SDL_SetHint(SDL_HINT_WINDOWS_NO_CLOSE_ON_ALT_F4, \"1\");\n+ sdl2_set_hint_x11_force_egl();\n SDL_EnableScreenSaver();\n memset(&info, 0, sizeof(info));\n SDL_VERSION(&info.version);\n@@ -908,6 +949,7 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)\n sdl2_console[i].kbd = qkbd_state_init(con);\n if (display_opengl) {\n qemu_console_set_display_gl_ctx(con, &sdl2_console[i].dgc);\n+ sdl2_gl_console_init(&sdl2_console[i]);\n }\n register_displaychangelistener(&sdl2_console[i].dcl);\n \n", "prefixes": [ "v17", "07/18" ] }