Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196970/?format=api
{ "id": 2196970, "url": "http://patchwork.ozlabs.org/api/patches/2196970/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216191213.2556073-6-dmitry.osipenko@collabora.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216191213.2556073-6-dmitry.osipenko@collabora.com>", "list_archive_url": null, "date": "2026-02-16T19:12:00", "name": "[v17,05/18] ui/gtk-egl: Unset context after GL operations", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "79b8bdb6c5f64d4d55ced2dc9a8ae227d3a9f173", "submitter": { "id": 83453, "url": "http://patchwork.ozlabs.org/api/people/83453/?format=api", "name": "Dmitry Osipenko", "email": "dmitry.osipenko@collabora.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216191213.2556073-6-dmitry.osipenko@collabora.com/mbox/", "series": [ { "id": 492344, "url": "http://patchwork.ozlabs.org/api/series/492344/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492344", "date": "2026-02-16T19:11:55", "name": "Support virtio-gpu DRM native context and MAP_FIXED API", "version": 17, "mbox": "http://patchwork.ozlabs.org/series/492344/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196970/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=BH1fHtW2;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFCBT0hbyz1xxp\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 06:14:25 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vs42O-0007zC-WB; Mon, 16 Feb 2026 14:13:41 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vs42M-0007yv-Dr\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:38 -0500", "from sender4-pp-e105.zoho.com ([136.143.188.105])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vs42K-0003ZU-7C\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:38 -0500", "by mx.zohomail.com with SMTPS id 1771269198520731.0716908357117;\n Mon, 16 Feb 2026 11:13:18 -0800 (PST)" ], "ARC-Seal": "i=1; a=rsa-sha256; t=1771269200; cv=none;\n d=zohomail.com; s=zohoarc;\n b=L/9GQFWSBDuFEZAdDj6b7RpYjx1deLZhMdlG8IEGM/9RnUpK0o02/ZwuuWGTB2hYIZFDxhwsm2j0ZtpUG6aHUGPQqdrTIh1JeCEBL3UHItURYXwUzxAoI692vNCc+MIERc3r5LAZIsk5x99nzTDOzbs28L2GptxcmEJA45BNtsA=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1771269200;\n h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=tMuuSYDErcV8h4Nk0lnQAaM6c4X/fM/cFF7p8GocgcQ=;\n b=nGccA3QGxZqigA2Njh8EhBdsc8UgRTJQCARL8pdJEkYJWpSOP2FR2mOIdz1uZWEqzNSIzLTb38/vruPicRvsx5I1Lm0UkUYi8LIBIvR9r+vSCnjKy7wL9TZ3CLnI6G53A+Zn6jFiKTfkl09g+6w1fqBgH3Qki8ShlCyHDZDD3y4=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n dkim=pass header.i=collabora.com;\n spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;\n dmarc=pass header.from=<dmitry.osipenko@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771269200;\n s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;\n h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n bh=tMuuSYDErcV8h4Nk0lnQAaM6c4X/fM/cFF7p8GocgcQ=;\n b=BH1fHtW2+Fvf9e+k5w4LfGIpecZsA40RGbzPuLrItgZHUJk5540XjJWcICK6JtZO\n cJEtaKShGcQ4fUsXr8PGi+Th7wYwnUcEaQllR07U5iXnAq3aAa161sQ5YsROcKaF6Ar\n GuYUeE7UzUntXQfKLggQ7KLNs5K99yOJlknuu9YM=", "From": "Dmitry Osipenko <dmitry.osipenko@collabora.com>", "To": "Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Huang Rui <ray.huang@amd.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Gerd Hoffmann <kraxel@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,\n \"Michael S . Tsirkin\" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Yiwei Zhang <zzyiwei@gmail.com>, Sergio Lopez Pascual <slp@redhat.com>", "Cc": "Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,\n Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,\n\t=?utf-8?q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>,\n Alex Deucher <alexander.deucher@amd.com>,\n Stefano Stabellini <stefano.stabellini@amd.com>, =?utf-8?q?Christian_K?=\n\t=?utf-8?q?=C3=B6nig?= <christian.koenig@amd.com>,\n Xenia Ragiadakou <xenia.ragiadakou@amd.com>,\n Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,\n Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,\n Robert Beckett <bob.beckett@collabora.com>", "Subject": "[PATCH v17 05/18] ui/gtk-egl: Unset context after GL operations", "Date": "Mon, 16 Feb 2026 22:12:00 +0300", "Message-ID": "<20260216191213.2556073-6-dmitry.osipenko@collabora.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260216191213.2556073-1-dmitry.osipenko@collabora.com>", "References": "<20260216191213.2556073-1-dmitry.osipenko@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-ZohoMailClient": "External", "Received-SPF": "pass client-ip=136.143.188.105;\n envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-e105.zoho.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "VirtIO-GPU commands may be processed outside of main-loop, from a CPU\nthread. This results in GL context switch failure because context is held\nby main-loop thread when GL is invoked from CPU thread. Always release GL\ncontext after performing GL operations such that other threads could take\nover the context.\n\nSigned-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>\n---\n ui/gtk-egl.c | 16 ++++++++++++++++\n ui/gtk-gl-area.c | 7 ++++++-\n 2 files changed, 22 insertions(+), 1 deletion(-)", "diff": "diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c\nindex 0dbb429958e5..157b000f45fb 100644\n--- a/ui/gtk-egl.c\n+++ b/ui/gtk-egl.c\n@@ -39,6 +39,8 @@ static void gtk_egl_set_scanout_mode(VirtualConsole *vc, bool scanout)\n surface_gl_destroy_texture(vc->gfx.gls, vc->gfx.ds);\n surface_gl_create_texture(vc->gfx.gls, vc->gfx.ds);\n }\n+ eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+ EGL_NO_SURFACE, EGL_NO_CONTEXT);\n }\n }\n \n@@ -125,6 +127,9 @@ void gd_egl_draw(VirtualConsole *vc)\n surface_height(vc->gfx.ds));\n \n glFlush();\n+\n+ eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+ EGL_NO_SURFACE, EGL_NO_CONTEXT);\n }\n }\n \n@@ -261,6 +266,9 @@ void gd_egl_scanout_texture(DisplayChangeListener *dcl,\n gtk_egl_set_scanout_mode(vc, true);\n egl_fb_setup_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,\n backing_id, false);\n+\n+ eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+ EGL_NO_SURFACE, EGL_NO_CONTEXT);\n }\n \n void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,\n@@ -277,6 +285,8 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,\n egl_dmabuf_import_texture(dmabuf);\n texture = qemu_dmabuf_get_texture(dmabuf);\n if (!texture) {\n+ eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+ EGL_NO_SURFACE, EGL_NO_CONTEXT);\n return;\n }\n \n@@ -294,6 +304,9 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,\n if (qemu_dmabuf_get_allow_fences(dmabuf)) {\n vc->gfx.guest_fb.dmabuf = dmabuf;\n }\n+\n+ eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+ EGL_NO_SURFACE, EGL_NO_CONTEXT);\n #endif\n }\n \n@@ -397,6 +410,9 @@ void gd_egl_scanout_flush(DisplayChangeListener *dcl,\n #endif\n \n eglSwapBuffers(qemu_egl_display, vc->gfx.esurface);\n+\n+ eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+ EGL_NO_SURFACE, EGL_NO_CONTEXT);\n }\n \n void gd_egl_flush(DisplayChangeListener *dcl,\ndiff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c\nindex c709b2ce0f63..0036f1490740 100644\n--- a/ui/gtk-gl-area.c\n+++ b/ui/gtk-gl-area.c\n@@ -389,6 +389,11 @@ void gtk_gl_area_init(void)\n int gd_gl_area_make_current(DisplayGLCtx *dgc,\n QEMUGLContext ctx)\n {\n- gdk_gl_context_make_current(ctx);\n+ if (!ctx) {\n+ gdk_gl_context_clear_current();\n+ } else {\n+ gdk_gl_context_make_current(ctx);\n+ }\n+\n return 0;\n }\n", "prefixes": [ "v17", "05/18" ] }